Hi Radek,
Sebastian send some bug fixes for RAP that mainly concern the DB and =
RDQL modules.
Could you please check them and submit them to subversion when you =
finish the work on RAP-Pubby.
This would be great.
Cheers
Chris
--
Chris Bizer
Freie Universit=C3=A4t Berlin
+49 30 838 54057
ch...@bi...
www.bizer.de
----- Original Message -----=20
From: Sebastien Marinier=20
To: Chris Bizer=20
Sent: Friday, January 18, 2008 5:05 PM
Subject: Re: RAP Project
Chris Bizer a =C3=A9crit :=20
Hi Sebastian=20
We are a software company, and we've connect RAP as a=20
complementary ontology module to our product.=20
Interesting. Which product?=20
It's a product wich is collecting information on Intranets or =
Internet, for the company usage. We allow to build an ontology. The =
ontology might be built by any way by the client (RDF Model), and =
information might be interact (print and clic) accordingly to the store =
information. This is the main usage from rdf api, no ? ;)
We found some=20
little bugs/misfuntions in it, and as we are already used to=20
work with sourceforge projects, we propose you to send our=20
corrections to the product. If you're interested in, we could:=20
- send you a mail of detailed corrections=20
- send you a patch (like diff -Naur)=20
- become a developer from the sourceforge project with=20
subversion access.=20
What kind of corrections are this?=20
If it is only minor stuff and if you have tested the code against =
the test cases, I would prefer to give you subversion access to submit =
the changes directly.=20
Cheers=20
Chris=20
I'd rather to list you the corrections we've made in the code. I =
explain why we've done. If you consider these as acceptable, i can =
commit them, if you give me access to the project. But as the 4 and 5 =
might be involving modifications, i don't know how tou proceed.: is =
there a technical debate on the forum ? Or are you the ultimate deciding =
person ? ;)
=20
1) rdfapi/api/constants.php
Line 331:
// =
-------------------------------------------------------------------------=
---------
// RDQL, SPARQL and parser default namespace prefixes
// =
-------------------------------------------------------------------------=
---------global $default_prefixes;
$default_prefixes =3D array(=3D> when rdfapi in included from function =
call (wich is the case, as we don't really want to include always all =
the files), the globals need to be declared as globals.
2) rdfapi/api/model/DbModel.php
Line 501
function & getMemModel() {
$recordSet =3D $this->_getRecordSet($this);
// Modified by mgr for AMI Software, 2007/11/20
$model =3D $this->_convertRecordSetToMemModel($recordSet);
return $model;
}=3D> PHP Notice Error: Only variable references should be returned =
by reference
3) rdfapi/api/rdql/RdqlDbEngine.php
$queryResult =3D $this->filterQueryResult($recordSet);
if ($returnNodes)
$ret =3D $this->toNodes($queryResult);
else
$ret =3D $this->toString($queryResult);
return $ret;=3D> same
4) rdfapi/api/model/DbStore.php
Line 71:=20
// $r =3D $this->dbConn->connect($host, $user, $password, $dbName);
$r =3D $this->dbConn->NConnect($host, $user, $password, $dbName);
=3D> As we work already with ADODb, on our own base, the "connect" =
call always use the wrong base. A new connection is required.
5) rdfapi/api/rdql/RdqlParser.php
Line 510:
// $reg_ex =3D =
"/(\?[a-zA-Z0-9_]+)\s+([~!=3D]~)\s+(['|\"])?([^\s'\"]+)(['|\"])?/";
$reg_ex =3D =
"/(\?[a-zA-Z0-9_]+)\s+([~!=3D]~)\s+(['|\"])?([^\"]+)(['|\"])?/";
=3D> the regular expression removes spaces and quotes. Why not =
tolerating them ? If we want to search for "Jean d'Ormesson" by example =
?
=20
6) rdfapi/api/resModel/ResModel.php
Line 635:=20
function load($filename, $type =3D NULL, $stream=3Dfalse)
{
// $this->model->load($filename, $type =3D NULL, =
$stream=3Dfalse);
$this->model->load($filename, $type, $stream);
}
=3D> It looks like a "fast copy/paste" error ;)
Line 797:
function & rdqlQuery($queryString, $returnNodes =3D TRUE)=20
{
// Modified by mgr for AMI Software, 2007/11/19
$ret =3D $this->model->rdqlQuery($queryString, $returnNodes);
return $ret;
}
=3D> PHP Notice Error: Only variable references should be returned by =
reference
Yours
S=C3=A9bastien Marinier
|
