#211 Support for non-rectangulare window and screen mode
open
nobody
None
5
2012-11-29
2012-01-22
Anonymous
No
This patch add some features
- add options to hide login/logout screen ( -H )
- add support for non-rectangulare window
- add screen seamlessrdp mode like in VirtualBox
This is interesting, could you please split up the patch into 3 patches for each of the mention feature
and clean them up from old / commented code blocks and i'll make a review of them.
Kind Regards,
Henrik Andersson
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This is interesting, could you please split up the patch into 3 patches for each of the mention feature
and clean them up from old / commented code blocks and i'll make a review of them.
Kind Regards,
Henrik Andersson
Henrik Andersson
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hello Henrik
I wrote the patch a few years ago for the version 1.5.0, so I in the last 3 days prescribed for version 1.7.1, and since then I have a whole day spent on the extra code and delete their comments.
I do not speak English and I use Google for translation, and so I asked you to explain me that the old / commented code blocks.
I will be split patch into 3 patches:
1. patch to suport nonrectangulare window shape
2. patch to support screen seamless mode (like in VirtualBox) ( " semalessrdpshell.exe -f " options)
3. patch to hide login/logout screen ( -H options in rdesktop)
But some patch will depend on other patchs.
I will try to do all this as soon as possible, but would you ask for a little help if we need it, because it does not deal with programming and have no knowledge of English.
Best regards Srdjan Cvetic
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
There are some #if 0 / #endif code blocks that can be removed and
there is also a ENABLED_BUG_WINDOW code blocks which i do not
fully understand.
If the code within ENABLED_BUG_WINDOW doesn't work with
rdesktop version 1.7.1 and the patches works as expected i were
ENABLED_BUG_WINDOW is undefined I assume that related code
should be removed too.
Regards,
Henrik Andersson
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I split patch of rdesktop into 3 patches, and clean up the comments
I can split and patch for server sesmlessrdpshell.exe into 2 patchs if necesseri.
ENABLED_BUG_WINDOW is my solution to fix bug when using VirtualBox mode. In that mode the server side grab full screen region and send to client, but when move window rdesktop don't refresh screen and on screen stay black image. ENABLED_BUG_WINDOW show small window on 1x1 size always on top the main window and automatic refresh the screen. I think that is a prombel on x server system. not on rdesktop application. My second solution is to refresh the all screen on server side, that is work good, but is very bandwidth expenses.
Best regards Srdjan
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
View and moderate all "patches Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Patches"
Patch rdesktop 1.7.1 rev 1658
View and moderate all "patches Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Patches"
Patch seamlessrdpshell rev 1658
View and moderate all "patches Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Patches"
Compiled seamlessrdpshell.exe with MinGW
View and moderate all "patches Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Patches"
How to use?
rdesktop -u admin -p admin -A -s "c:\srdp\seamlessrdpshell.exe -f notepad.exe" -H 127.0.0.1 # For screen mode like VirtualBox
rdesktop -u admin -p admin -A -s "c:\srdp\seamlessrdpshell.exe notepad.exe" -H 127.0.0.1 # For seamless rdp mode
Hi, google accounts :)
This is interesting, could you please split up the patch into 3 patches for each of the mention feature
and clean them up from old / commented code blocks and i'll make a review of them.
Kind Regards,
Henrik Andersson
Hi, google accounts :)
This is interesting, could you please split up the patch into 3 patches for each of the mention feature
and clean them up from old / commented code blocks and i'll make a review of them.
Kind Regards,
Henrik Andersson
Henrik Andersson
View and moderate all "patches Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Patches"
Hello Henrik
I wrote the patch a few years ago for the version 1.5.0, so I in the last 3 days prescribed for version 1.7.1, and since then I have a whole day spent on the extra code and delete their comments.
I do not speak English and I use Google for translation, and so I asked you to explain me that the old / commented code blocks.
I will be split patch into 3 patches:
1. patch to suport nonrectangulare window shape
2. patch to support screen seamless mode (like in VirtualBox) ( " semalessrdpshell.exe -f " options)
3. patch to hide login/logout screen ( -H options in rdesktop)
But some patch will depend on other patchs.
I will try to do all this as soon as possible, but would you ask for a little help if we need it, because it does not deal with programming and have no knowledge of English.
Best regards Srdjan Cvetic
Hi Srdjan,
There are some #if 0 / #endif code blocks that can be removed and
there is also a ENABLED_BUG_WINDOW code blocks which i do not
fully understand.
If the code within ENABLED_BUG_WINDOW doesn't work with
rdesktop version 1.7.1 and the patches works as expected i were
ENABLED_BUG_WINDOW is undefined I assume that related code
should be removed too.
Regards,
Henrik Andersson
View and moderate all "patches Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Patches"
Patch rdesktop 1.7.1 rev 1658 to support non-rectangulare windows shape
View and moderate all "patches Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Patches"
Patch rdesktop 1.7.1 rev 1658 to support seamless mode like in VirtualBox
Last edit: Anonymous 2014-07-30
View and moderate all "patches Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Patches"
Patch rdesktop 1.7.1 rev 1658 to hide Login and Logout screen
View and moderate all "patches Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Patches"
Hello Henrik,
I split patch of rdesktop into 3 patches, and clean up the comments
I can split and patch for server sesmlessrdpshell.exe into 2 patchs if necesseri.
ENABLED_BUG_WINDOW is my solution to fix bug when using VirtualBox mode. In that mode the server side grab full screen region and send to client, but when move window rdesktop don't refresh screen and on screen stay black image. ENABLED_BUG_WINDOW show small window on 1x1 size always on top the main window and automatic refresh the screen. I think that is a prombel on x server system. not on rdesktop application. My second solution is to refresh the all screen on server side, that is work good, but is very bandwidth expenses.
Best regards Srdjan
View and moderate all "patches Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Patches"
Hello Henrik,
I forget to tell you, the patches is independed, if need I can build patch depended on each other.
Best regards Srdjan