#119 Installation fix for Cygwin

open
nobody
None
5
2012-11-29
2006-09-12
Ed Avis
No

Doing 'make install' fails on Cygwin when it tries to
strip the installed rdesktop binary - because on Cygwin
the filename is rdesktop.exe. To fix this, get
install(1) to do the stripping itself with the -s flag:

--- Makefile.in~ 2005-05-04 21:32:16.000000000 +0100
+++ Makefile.in 2006-09-12 08:24:01.050540900 +0100
@@ -55,8 +55,7 @@
.PHONY: installbin
installbin: rdesktop
mkdir -p $(DESTDIR)$(bindir)
- $(INSTALL) rdesktop $(DESTDIR)$(bindir)
- strip $(DESTDIR)$(bindir)/rdesktop
+ $(INSTALL) -s rdesktop $(DESTDIR)$(bindir)
chmod 755 $(DESTDIR)$(bindir)/rdesktop

.PHONY: installman

Discussion

  • Ilya Konstantinov

    Logged In: YES
    user_id=335423

    Looks legit. Could someone with CVS permissions check this in?

     
  • Adrian Davey

    Adrian Davey - 2006-09-12

    Logged In: YES
    user_id=152874

    can you test the current CVS version first as this is
    against 1.4.1 not CVS HEAD.

    'install -s' is not guaranteed to work with all cross
    compiled environments.

    perhaps a strip of an rdesktop binary variable would be
    better, allowing for if strip exists then use it against a
    variable such as:
    $(STRIP) $(DESTDIR)$(bindir)/$(RDESKTOP_BINARY)

    this will then use the strip found in autofoo and still work
    if no strip is found. also allows for a version'ed binary
    too rdesktop-1.5 etc.

     
  • Nobody/Anonymous

    MyutNE <a href="http://wljfmejdwhkj.com/">wljfmejdwhkj</a>, [url=http://wdenivvedugg.com/]wdenivvedugg[/url], [link=http://qpuzwuoezfma.com/]qpuzwuoezfma[/link], http://qihgcvyrpqnu.com/

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks