Menu

#118 change the handling of KEYMAP_PATH

open
keyboard (31)
5
2012-11-29
2006-09-04
Anonymous
No

Currently (1.4.1), KEYMAP_PATH and mapname are simply
merged (see xkeymap.c:xkeymap_read()).
This may lead to problems, if you set a different path
while passing (for what reason ever) another path to
make and you forgot a trailing slash. i.e.:
make KEYMAP_PATH=/foo/bar

This patch makes usage of snprintf() and puts an
explicit slash between KEYMAP_PATH and mapname. If you
add a trailing slash, you'll have 2. But, this doesn't
hurt someone, where a missing does.

greetings, Daniel

(Yes, the patch doesn't add any functionallity - just
some beautifing.)

Discussion

  • Nobody/Anonymous

    a patch to change the handling of KEYMAP_PATH

     
  • Ilya Konstantinov

    Logged In: YES
    user_id=335423

    Looks legit. Could someone merge this in?