From: Bob B. <bo...@zk...> - 2002-07-19 18:26:16
|
I run rdesktop with the two attached patches. They apply to rdesktop 1.1.0-pl19-9-0. The first is a patch to make the using of variable arguments to function-type macros consistent with the C99 standard. This should continue to work with gcc, and was required to work with Compaq C on Tru64 UNIX. The second patch consistents of touch-up to pointer casting that removed a lot of warning messages. If there's anything that I should do to get these patches officially accepted, please let me know. (I apply the va_args patch first, if that makes a difference) -- Bob Bell <bo...@zk...> ------------------------------------------------------------------------- "Duct tape is like The Force. It has a light side, a dark side and it holds the universe together." -- Carl Zwanzig |
From: <pe...@ce...> - 2002-07-29 08:26:55
|
Bob Bell wrote: > I run rdesktop with the two attached patches. They apply to rdesktop > 1.1.0-pl19-9-0. I've tried to apply these patches to the main CVS version. >The first is a patch to make the using of variable > arguments to function-type macros consistent with the C99 standard. > This should continue to work with gcc, and was required to work with > Compaq C on Tru64 UNIX. The main version is quite different from the 19-9-0 version. I've tried to fix all varargs I could find. Can you try the latest CVS version and check if it compiles on your platform? >The second patch consistents of touch-up to > pointer casting that removed a lot of warning messages. I've tried gcc -Wall, but as far as I can see, none of your changes applies to the main version. There are still other warnings though... Thanks, Peter |
From: Bob B. <bo...@zk...> - 2002-07-29 14:25:19
|
On Mon, Jul 29, 2002 at 10:26:47AM +0200, Peter strand <pe...@ce...> wrote: > The main version is quite different from the 19-9-0 version. I've tried > to fix all varargs I could find. Can you try the latest CVS version and > check if it compiles on your platform? Are the changes from 19-9-0 in the CVS version? If not, how do I get the most of both versions? -- Bob Bell <bo...@zk...> ------------------------------------------------------------------------- "MSN [the Microsoft Network] has a guy whose full time job is walking around rebooting NT Servers as they crash." -- Alex St. John, former Microsoft employee |
From: <pe...@ce...> - 2002-07-29 14:43:17
|
> On Mon, Jul 29, 2002 at 10:26:47AM +0200, Peter strand <pe...@ce...> wrote: > > The main version is quite different from the 19-9-0 version. I've tried > > to fix all varargs I could find. Can you try the latest CVS version and > > check if it compiles on your platform? > > Are the changes from 19-9-0 in the CVS version? Some are, some are not. >If not, how do > I get the most of both versions? Tell us about which features from 19-9-0 you are missing in the CVS version, and wait for us to merge :-) -- Peter Åstrand Telephone: +46-13-21 46 00 Cendio Systems E-mail: pe...@ce... Teknikringen 3 583 30 Linköping Sweden |
From: Bob B. <bo...@zk...> - 2002-07-29 15:48:21
|
On Mon, Jul 29, 2002 at 04:43:29PM +0200, Peter strand <pe...@ce...> wrote: > Tell us about which features from 19-9-0 you are missing in the CVS > version, and wait for us to merge :-) Since you mention it... :-) I've played with it for just a few minutes, and the only thing I've noticed so far is the '-K' option missing. This option keeps my window manager key bindings available. Since I like to run rdesktop full screen (making it look like I have a Windows box), I need my window manager key binding available to switch to another page, so that I don't have to close rdesktop just to use another window. -- Bob Bell <bo...@zk...> ------------------------------------------------------------------------- "Everything that can be invented has been invented." -- Commissioner, US Office of Patents, 1889 |
From: Bob B. <bo...@zk...> - 2002-07-29 17:49:24
Attachments:
rdesktop-rjb-3.patch
|
On Mon, Jul 29, 2002 at 11:48:05AM -0400, Bob Bell <bo...@zk...> wrote: > On Mon, Jul 29, 2002 at 04:43:29PM +0200, Peter strand <pe...@ce...> wrote: > > Tell us about which features from 19-9-0 you are missing in the CVS > > version, and wait for us to merge :-) > > Since you mention it... :-) I've played with it for just a few > minutes, and the only thing I've noticed so far is the '-K' option > missing. This option keeps my window manager key bindings available. > Since I like to run rdesktop full screen (making it look like I have > a Windows box), I need my window manager key binding available to switch > to another page, so that I don't have to close rdesktop just to use > another window. Here's a sample port of '-K' from 19-9-0 to CVS. This is what I'm going to use until a '-K' shows up in CVS. Note that I didn't conceptually come up with this code, but simply ported it from 19-9-0. As such, I can't explain all the ins and outs of it, though it's pretty short. -- Bob Bell <bo...@zk...> ------------------------------------------------------------------------- "There are two major products to have come out of Berkeley: LSD and UNIX" -- Author Unknown |
From: <pe...@ce...> - 2002-07-29 20:20:09
|
> > Since you mention it... :-) I've played with it for just a few > > minutes, and the only thing I've noticed so far is the '-K' option > > missing. This option keeps my window manager key bindings available. > Here's a sample port of '-K' from 19-9-0 to CVS. This is what I'm > going to use until a '-K' shows up in CVS. Note that I didn't > conceptually come up with this code, but simply ported it from 19-9-0. > As such, I can't explain all the ins and outs of it, though it's pretty > short. Patch applied. (Btw, fullscreen does not work perfectly for me: Even though I can change virtual desktop, rdesktop still is running fullscreen and obscures all other applications, on all virtual desktops. I'm using GNOME 1.4 and Sawfish.) -- Peter Åstrand Telephone: +46-13-21 46 00 Cendio Systems E-mail: pe...@ce... Teknikringen 3 583 30 Linköping Sweden |
From: Bob B. <bo...@zk...> - 2002-07-29 20:33:26
|
On Mon, Jul 29, 2002 at 10:20:26PM +0200, Peter strand <pe...@ce...> wrote: > Patch applied. > > (Btw, fullscreen does not work perfectly for me: Even though I can change > virtual desktop, rdesktop still is running fullscreen and obscures all > other applications, on all virtual desktops. I'm using GNOME 1.4 and > Sawfish.) This is both before and after my patch was applied, right? I fiddled with using fullscreen mode before, but didn't get the desired results. Instead, I used '-P 100' for 100% of the screen. Hmm, '-P' is not supported in CVS, but I would suppose -g should suffice. BTW, I noticed a cosmetic error with my patch. In rdesktop, move the double newline from '-t' to '-K' in usage(). -- Bob Bell <bo...@zk...> ------------------------------------------------------------------------- "So far we've managed to avoid turning Perl into APL. :-)" -- Larry Wall, creator of the Perl programming language |
From: <pe...@ce...> - 2002-07-29 20:36:10
|
> > (Btw, fullscreen does not work perfectly for me: Even though I can change > > virtual desktop, rdesktop still is running fullscreen and obscures all > > other applications, on all virtual desktops. I'm using GNOME 1.4 and > > Sawfish.) > > This is both before and after my patch was applied, right? Yes. > BTW, I noticed a cosmetic error with my patch. In rdesktop, move > the double newline from '-t' to '-K' in usage(). Fixed. -- Peter Åstrand Telephone: +46-13-21 46 00 Cendio Systems E-mail: pe...@ce... Teknikringen 3 583 30 Linköping Sweden |
From: Bob B. <bo...@zk...> - 2002-07-29 15:15:45
Attachments:
rdesktop-rjb-1.patch
rdesktop-rjb-2.patch
|
On Mon, Jul 29, 2002 at 10:26:47AM +0200, Peter strand <pe...@ce...> wrote: > >The first is a patch to make the using of variable > >arguments to function-type macros consistent with the C99 standard. > >This should continue to work with gcc, and was required to work with > >Compaq C on Tru64 UNIX. > > The main version is quite different from the 19-9-0 version. I've tried > to fix all varargs I could find. Can you try the latest CVS version and > check if it compiles on your platform? Yes, it compiles, though not cleanly. The varargs issue appears to be cleaned up. > >The second patch consistents of touch-up to > >pointer casting that removed a lot of warning messages. > > I've tried gcc -Wall, but as far as I can see, none of your changes > applies to the main version. There are still other warnings though... I get a couple of issues. Note that I am using 'cc', the Compaq C compiler, on Tru64 UNIX, which works much better on Alpha, and is in many ways a more sophisticated compiler. Note that I am not using the -Wall equivalent, but just a default compile. I've attached two patches. The first, rdesktop-rjb-1.patch, fixes behavior that I think is definitely in error. The affected lines of code have undefined behavior that may not be portable between C compilers. It should be checked to verify that it implements the desired behavior, since the original intent is not 100% certain to me. I believe even if I got this wrong, an equivalent change should be made to avoid this undefined behavior. The second patch, rdesktop-rjb-2.patch, simply clears up some remaining pointer issues. Not a big deal, but takes care of some warning messages on my platform. I'm one of those that believes code should compile without any such messages. To apply the patch cleanly, apply after applying rdesktop-rjb-1.patch (both touch xwin.c). Lastly, are you aware that SCANCODE_CHAR_BACKSPACE is defined twice in scancodes.h? I was going to fix this, but I wasn't sure what the desired fix would be. It's unconditionally defined twice, so it's always SCANCODE_KEY_291, never SCANCODE_KEY_15. Since it's SCANCODE_KEY_291 instead of SCANCODE_KEY_29, and SCANCODE_KEY_291 is used nowhere else, I'd have to say that something is definitely going on that I don't know about. I believe the end result is that SCANCODE_CHAR_BACKSPACE is not defined, though perhaps that matters little, since it doesn't seem to be in use at all. Care to enlighten me as to what's going on? -- Bob Bell <bo...@zk...> ------------------------------------------------------------------------- "MSN [the Microsoft Network] has a guy whose full time job is walking around rebooting NT Servers as they crash." -- Alex St. John, former Microsoft employee |
From: <pe...@ce...> - 2002-07-29 19:34:41
|
> > I've tried gcc -Wall, but as far as I can see, none of your changes > > applies to the main version. There are still other warnings though... > > I get a couple of issues. Note that I am using 'cc', the Compaq > C compiler, on Tru64 UNIX, which works much better on Alpha, and is in > many ways a more sophisticated compiler. Note that I am not using the > -Wall equivalent, but just a default compile. > > I've attached two patches. I've applied both patches. The first, rdesktop-rjb-1.patch, fixes > behavior that I think is definitely in error. > warning messages on my platform. I'm one of those that believes code > should compile without any such messages. Agree. > Lastly, are you aware that SCANCODE_CHAR_BACKSPACE is defined twice > in scancodes.h? I was going to fix this, but I wasn't sure what the > desired fix would be. It's unconditionally defined twice, so it's > always SCANCODE_KEY_291, never SCANCODE_KEY_15. Since it's > SCANCODE_KEY_291 instead of SCANCODE_KEY_29, and SCANCODE_KEY_291 is > used nowhere else, I'd have to say that something is definitely going on > that I don't know about. I believe the end result is that > SCANCODE_CHAR_BACKSPACE is not defined, though perhaps that matters > little, since it doesn't seem to be in use at all. Care to enlighten me > as to what's going on? I typed in scancodes.h by hand, so this is just a typo. Fixed now. -- Peter Åstrand Telephone: +46-13-21 46 00 Cendio Systems E-mail: pe...@ce... Teknikringen 3 583 30 Linköping Sweden |