From: SourceForge.net <no...@so...> - 2005-11-26 18:08:16
|
Patches item #1367109, was opened at 2005-11-27 03:08 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Jeon, ByeongSik (bsjeon) Assigned to: Nobody/Anonymous (nobody) Summary: At some keymap, strtol is overflowed. Initial Comment: At Korean keymap(keymaps/ko), "map 0xe0010412", "g_keylayout = strtol(...)" is overflowed. At Japanese keymap(keymaps/ja), "map 0xe0010411", same above .... "strtol" must to change "strtoul". ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 |
From: SourceForge.net <no...@so...> - 2005-12-30 16:57:24
|
Patches item #1367109, was opened at 2005-11-26 20:08 Message generated for change (Comment added) made by ikonst You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Byeong-Sik, Jeon (bsjeon) >Assigned to: Peter Åstrand (astrand) Summary: At some keymap, strtol is overflowed. Initial Comment: At Korean keymap(keymaps/ko), "map 0xe0010412", "g_keylayout = strtol(...)" is overflowed. At Japanese keymap(keymaps/ja), "map 0xe0010411", same above .... "strtol" must to change "strtoul". ---------------------------------------------------------------------- >Comment By: Ilya Konstantinov (ikonst) Date: 2005-12-30 18:57 Message: Logged In: YES user_id=335423 Peter, the change looks sensible (though admitedly I don't have a Japanese Windows installation to test it with). Will you check it in? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 |
From: SourceForge.net <no...@so...> - 2005-12-30 20:33:45
|
Patches item #1367109, was opened at 2005-11-26 10:08 Message generated for change (Comment added) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Byeong-Sik, Jeon (bsjeon) Assigned to: Peter Åstrand (astrand) Summary: At some keymap, strtol is overflowed. Initial Comment: At Korean keymap(keymaps/ko), "map 0xe0010412", "g_keylayout = strtol(...)" is overflowed. At Japanese keymap(keymaps/ja), "map 0xe0010411", same above .... "strtol" must to change "strtoul". ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2005-12-30 12:33 Message: Logged In: NO I've applied the changes to rdesktop.c, secure.c and xkeymap.c. However, I don't understand the motivation behind the changes to the "ko" and "ja" keymaps. Why are these necessary? ---------------------------------------------------------------------- Comment By: Ilya Konstantinov (ikonst) Date: 2005-12-30 08:57 Message: Logged In: YES user_id=335423 Peter, the change looks sensible (though admitedly I don't have a Japanese Windows installation to test it with). Will you check it in? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 |
From: SourceForge.net <no...@so...> - 2005-12-31 00:24:17
|
Patches item #1367109, was opened at 2005-11-27 03:08 Message generated for change (Comment added) made by bsjeon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Byeong-Sik, Jeon (bsjeon) Assigned to: Peter Åstrand (astrand) Summary: At some keymap, strtol is overflowed. Initial Comment: At Korean keymap(keymaps/ko), "map 0xe0010412", "g_keylayout = strtol(...)" is overflowed. At Japanese keymap(keymaps/ja), "map 0xe0010411", same above .... "strtol" must to change "strtoul". ---------------------------------------------------------------------- >Comment By: Byeong-Sik, Jeon (bsjeon) Date: 2005-12-31 09:24 Message: Logged In: YES user_id=1175121 the changes of the "ko" and "ja" keymaps is not always necessary. and "strtol -> strtoul" change is not depends to keymap changes. but, I think that the changes are more general for the latest Windows Version(XP, 2003, and abobe ...) . ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2005-12-31 05:33 Message: Logged In: NO I've applied the changes to rdesktop.c, secure.c and xkeymap.c. However, I don't understand the motivation behind the changes to the "ko" and "ja" keymaps. Why are these necessary? ---------------------------------------------------------------------- Comment By: Ilya Konstantinov (ikonst) Date: 2005-12-31 01:57 Message: Logged In: YES user_id=335423 Peter, the change looks sensible (though admitedly I don't have a Japanese Windows installation to test it with). Will you check it in? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 |
From: SourceForge.net <no...@so...> - 2005-12-31 00:36:45
|
Patches item #1367109, was opened at 2005-11-27 03:08 Message generated for change (Comment added) made by bsjeon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Byeong-Sik, Jeon (bsjeon) Assigned to: Peter Åstrand (astrand) Summary: At some keymap, strtol is overflowed. Initial Comment: At Korean keymap(keymaps/ko), "map 0xe0010412", "g_keylayout = strtol(...)" is overflowed. At Japanese keymap(keymaps/ja), "map 0xe0010411", same above .... "strtol" must to change "strtoul". ---------------------------------------------------------------------- >Comment By: Byeong-Sik, Jeon (bsjeon) Date: 2005-12-31 09:36 Message: Logged In: YES user_id=1175121 HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Control\Keyboard Layouts\E0010412 E0010412 is Korean Input System(IME 2000) E0010411 is Japanese Input System(MS-IME 2002) Chainese Input System(E0010404, E0010804, ....) ---------------------------------------------------------------------- Comment By: Byeong-Sik, Jeon (bsjeon) Date: 2005-12-31 09:24 Message: Logged In: YES user_id=1175121 the changes of the "ko" and "ja" keymaps is not always necessary. and "strtol -> strtoul" change is not depends to keymap changes. but, I think that the changes are more general for the latest Windows Version(XP, 2003, and abobe ...) . ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2005-12-31 05:33 Message: Logged In: NO I've applied the changes to rdesktop.c, secure.c and xkeymap.c. However, I don't understand the motivation behind the changes to the "ko" and "ja" keymaps. Why are these necessary? ---------------------------------------------------------------------- Comment By: Ilya Konstantinov (ikonst) Date: 2005-12-31 01:57 Message: Logged In: YES user_id=335423 Peter, the change looks sensible (though admitedly I don't have a Japanese Windows installation to test it with). Will you check it in? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 |
From: SourceForge.net <no...@so...> - 2005-12-31 08:30:40
|
Patches item #1367109, was opened at 2005-11-26 19:08 Message generated for change (Comment added) made by astrand You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Byeong-Sik, Jeon (bsjeon) Assigned to: Peter Åstrand (astrand) Summary: At some keymap, strtol is overflowed. Initial Comment: At Korean keymap(keymaps/ko), "map 0xe0010412", "g_keylayout = strtol(...)" is overflowed. At Japanese keymap(keymaps/ja), "map 0xe0010411", same above .... "strtol" must to change "strtoul". ---------------------------------------------------------------------- >Comment By: Peter Åstrand (astrand) Date: 2005-12-31 09:30 Message: Logged In: YES user_id=344921 >the changes of the "ko" and "ja" keymaps is not always >necessary. Please be more specific, why isn't the current layout code sufficient? ---------------------------------------------------------------------- Comment By: Byeong-Sik, Jeon (bsjeon) Date: 2005-12-31 01:36 Message: Logged In: YES user_id=1175121 HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Control\Keyboard Layouts\E0010412 E0010412 is Korean Input System(IME 2000) E0010411 is Japanese Input System(MS-IME 2002) Chainese Input System(E0010404, E0010804, ....) ---------------------------------------------------------------------- Comment By: Byeong-Sik, Jeon (bsjeon) Date: 2005-12-31 01:24 Message: Logged In: YES user_id=1175121 the changes of the "ko" and "ja" keymaps is not always necessary. and "strtol -> strtoul" change is not depends to keymap changes. but, I think that the changes are more general for the latest Windows Version(XP, 2003, and abobe ...) . ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2005-12-30 21:33 Message: Logged In: NO I've applied the changes to rdesktop.c, secure.c and xkeymap.c. However, I don't understand the motivation behind the changes to the "ko" and "ja" keymaps. Why are these necessary? ---------------------------------------------------------------------- Comment By: Ilya Konstantinov (ikonst) Date: 2005-12-30 17:57 Message: Logged In: YES user_id=335423 Peter, the change looks sensible (though admitedly I don't have a Japanese Windows installation to test it with). Will you check it in? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 |
From: SourceForge.net <no...@so...> - 2005-12-31 14:14:50
|
Patches item #1367109, was opened at 2005-11-27 03:08 Message generated for change (Comment added) made by bsjeon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Byeong-Sik, Jeon (bsjeon) Assigned to: Peter Åstrand (astrand) Summary: At some keymap, strtol is overflowed. Initial Comment: At Korean keymap(keymaps/ko), "map 0xe0010412", "g_keylayout = strtol(...)" is overflowed. At Japanese keymap(keymaps/ja), "map 0xe0010411", same above .... "strtol" must to change "strtoul". ---------------------------------------------------------------------- >Comment By: Byeong-Sik, Jeon (bsjeon) Date: 2005-12-31 23:14 Message: Logged In: YES user_id=1175121 When I set "ko" keymaps with "map 0x412", If I execute "rdesktop -k ko 192.168.10.3", then I can't use "Korean/English input mode toggle key) and I can't input Korean character. I should be change to "Microsoft IME 2003" through mouse click. But, when I set "ko" keymap with "map 0xe0010412", It's all good. I found Japanese case recently. http://tdiary.flowernet.gr.jp/jado/?date=20051007 It's all the same case. I attach image file. I don't know good 0x412 case. ---------------------------------------------------------------------- Comment By: Peter Åstrand (astrand) Date: 2005-12-31 17:30 Message: Logged In: YES user_id=344921 >the changes of the "ko" and "ja" keymaps is not always >necessary. Please be more specific, why isn't the current layout code sufficient? ---------------------------------------------------------------------- Comment By: Byeong-Sik, Jeon (bsjeon) Date: 2005-12-31 09:36 Message: Logged In: YES user_id=1175121 HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Control\Keyboard Layouts\E0010412 E0010412 is Korean Input System(IME 2000) E0010411 is Japanese Input System(MS-IME 2002) Chainese Input System(E0010404, E0010804, ....) ---------------------------------------------------------------------- Comment By: Byeong-Sik, Jeon (bsjeon) Date: 2005-12-31 09:24 Message: Logged In: YES user_id=1175121 the changes of the "ko" and "ja" keymaps is not always necessary. and "strtol -> strtoul" change is not depends to keymap changes. but, I think that the changes are more general for the latest Windows Version(XP, 2003, and abobe ...) . ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2005-12-31 05:33 Message: Logged In: NO I've applied the changes to rdesktop.c, secure.c and xkeymap.c. However, I don't understand the motivation behind the changes to the "ko" and "ja" keymaps. Why are these necessary? ---------------------------------------------------------------------- Comment By: Ilya Konstantinov (ikonst) Date: 2005-12-31 01:57 Message: Logged In: YES user_id=335423 Peter, the change looks sensible (though admitedly I don't have a Japanese Windows installation to test it with). Will you check it in? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 |
From: SourceForge.net <no...@so...> - 2006-01-01 18:33:03
|
Patches item #1367109, was opened at 2005-11-26 19:08 Message generated for change (Comment added) made by astrand You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Byeong-Sik, Jeon (bsjeon) Assigned to: Peter Åstrand (astrand) Summary: At some keymap, strtol is overflowed. Initial Comment: At Korean keymap(keymaps/ko), "map 0xe0010412", "g_keylayout = strtol(...)" is overflowed. At Japanese keymap(keymaps/ja), "map 0xe0010411", same above .... "strtol" must to change "strtoul". ---------------------------------------------------------------------- >Comment By: Peter Åstrand (astrand) Date: 2006-01-01 19:33 Message: Logged In: YES user_id=344921 Ok. I've applied this part of the patch as well. Thanks. Closing. ---------------------------------------------------------------------- Comment By: Byeong-Sik, Jeon (bsjeon) Date: 2005-12-31 15:14 Message: Logged In: YES user_id=1175121 When I set "ko" keymaps with "map 0x412", If I execute "rdesktop -k ko 192.168.10.3", then I can't use "Korean/English input mode toggle key) and I can't input Korean character. I should be change to "Microsoft IME 2003" through mouse click. But, when I set "ko" keymap with "map 0xe0010412", It's all good. I found Japanese case recently. http://tdiary.flowernet.gr.jp/jado/?date=20051007 It's all the same case. I attach image file. I don't know good 0x412 case. ---------------------------------------------------------------------- Comment By: Peter Åstrand (astrand) Date: 2005-12-31 09:30 Message: Logged In: YES user_id=344921 >the changes of the "ko" and "ja" keymaps is not always >necessary. Please be more specific, why isn't the current layout code sufficient? ---------------------------------------------------------------------- Comment By: Byeong-Sik, Jeon (bsjeon) Date: 2005-12-31 01:36 Message: Logged In: YES user_id=1175121 HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Control\Keyboard Layouts\E0010412 E0010412 is Korean Input System(IME 2000) E0010411 is Japanese Input System(MS-IME 2002) Chainese Input System(E0010404, E0010804, ....) ---------------------------------------------------------------------- Comment By: Byeong-Sik, Jeon (bsjeon) Date: 2005-12-31 01:24 Message: Logged In: YES user_id=1175121 the changes of the "ko" and "ja" keymaps is not always necessary. and "strtol -> strtoul" change is not depends to keymap changes. but, I think that the changes are more general for the latest Windows Version(XP, 2003, and abobe ...) . ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2005-12-30 21:33 Message: Logged In: NO I've applied the changes to rdesktop.c, secure.c and xkeymap.c. However, I don't understand the motivation behind the changes to the "ko" and "ja" keymaps. Why are these necessary? ---------------------------------------------------------------------- Comment By: Ilya Konstantinov (ikonst) Date: 2005-12-30 17:57 Message: Logged In: YES user_id=335423 Peter, the change looks sensible (though admitedly I don't have a Japanese Windows installation to test it with). Will you check it in? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1367109&group_id=24366 |