> I have added a (very) small patch that enables RDP compression as it is
> currently implemented. I have used the (de)compression code, which is now
> implemented nicely in mppc_expand, for a while and on w2k it works great!
Yep, I think we should enable the decompression so people can use it.
> Interesting though is a potential memory leak in the code. I discovered
> that PC's with barely enough memory crashed using rdesktop after a while. Using memprof I found that the memory allocated by the call ui_create_glyph is not freed. It looks like the call is not directly executed by rdesktop but I haven't discovered where the leak really is.
> Because ui_create_glyph typically allocates 32 bytes per call, the leak is
> hardly noticable on systems with more than 10MB of free ram....
> Anyone an idea?
I looked and I can't find this leak. It looks like they don't get freed when
rdesktop closes. This is a one time leak.
I'll check this more.