From: Huang Y. <hu...@xy...> - 2004-08-24 09:54:53
|
MS4gY29tcGlsZSBvbiBGcmVlQlNEDQoNCiAgIDEuMSBPbiBGcmVlQlNELCBpdCBzZWVtcyB3ZSBu ZWVkIHRoZSBIQVZFX0RJUkZEIGJlIGRlZmluZWQuIGJ1dCBJICANCmNhbid0IGZpbmQgYW55IGRl ZmluZSBpbiBzcmMuIHNvIEkgYWRkIGl0IGluIGNvbmZpZ3VyZS5hYy4NCg0KICAgMS4yIFdlIG5l ZWQgPHN5cy9zZWxlY3QuaD4gaW4gcmRlc2t0b3AuaC4gaWYgbm90ICwgY2FuJ3QgZmluZCAgDQpm ZF9zZXQuDQoNCjIuIHNlcmlhbCByZWRpcmVjdCBwcm9ibGVtDQoNCiAgIEl0IHNlZW1zIGlmIHdl IHVzZSBzZWxlY3QoKSBhbmQgVk1JTiBWVElNRSB0b2d0aGVyLCB0aGUgcmVhZCgpIHdpbGwgIA0K bmV2ZXIgcmV0dXJuIDAsIGl0IGFsd2F5cyBiZSBibG9ja2VkIHV0aWwgaXQgcmVjZWl2ZSBzb21l dGhpbmcsICANCndoYXRldmVyIHRoZSBWTUlOIFZUSU1FIHZhbHVlLg0KDQogICBTbyBJIGNoYW5n ZSB0aGUgcmRwZHJfc2VuZF9jb21wbGV0aW9uKCkgc2VuZCBydWxlLCBpZiB3ZSBhcmUgaW4gYSAg DQpzZXJpYWwgcmVkaXJlY3QsIHdlIHdpbGwgbm90IHRvIHdhaXQgaXQgcmV0dXJuIDAobmV2ZXIg aGFwcGVubmVkIG9uICANClZUSU1FIFZNSU4gdGltZW91dCkgLCBvciBnZXQgYWxsIGRhdGEgaW4g QUlPKGl0IHdpbGwgc2hvdyA2NCBieXRlIGluICANCkh5cGVyVGVybSBvbmUgdGltZSkuDQoNCiAg IEkgYXR0YWNoIHRoZSBjdnMgZGlmZiwgYW5kIHRoZSBwcm9ncmFtIGZvciB0ZXN0IHNlbGVjdCgp IGFuZCBWTUlOICANClZUSU1FLkl0J3Mgbm90IGEgcGVyZmVjdCBzb2x1dGlvbiwganVzdCBmb3Ig ZGlzY3Vzc3Rpb24uIEknbSBub3QgcXVpdGUgIA0Kc3VyZSBkb2VzIHRoZSBwcm9ibGVtIG9ubHkg aGFwcGVuIG9uIG15IHN5c3RlbShGcmVlQlNEIDUuMi4xKSBvciBub3QuDQoNCiAgIEJUVy4gTWF5 YmUgd2Ugc2hvdWxkIGNsZWFyIHRoZSB0ZXJtaW9zJ3MgbWVtb3J5LCBhbmQgcHV0IHR0eSBpbiBy YXcgIA0KbW9kZS4gT24gc29tZSBsaW51eCwgaXQgc2VlbXMgdHR5IHdhcyBpbiBDYW5vbmljYWwg TW9kZSBhZnRlciB3ZSBkbyAgDQppbml0Lg0KDQozLiBjdnMgZGlmZg0KDQpjdnMgZGlmZjogRGlm ZmluZyAuDQpJbmRleDogY29uZmlndXJlLmFjDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2c3Jv b3QvcmRlc2t0b3AvcmRlc2t0b3AvY29uZmlndXJlLmFjLHYNCnJldHJpZXZpbmcgcmV2aXNpb24g MS40DQpkaWZmIC1yMS40IGNvbmZpZ3VyZS5hYw0KM2E0DQo+IEFNX01BSU5UQUlORVJfTU9ERQ0K MjM5YTI0MSwyNDINCj4gICAgIGVsc2UNCj4gICAgICAgICBDRkxBR1M9IiRDRkxBR1MgLURIQVZF X0RJUkZEIg0KSW5kZXg6IHJkZXNrdG9wLmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3Zzcm9v dC9yZGVza3RvcC9yZGVza3RvcC9yZGVza3RvcC5oLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4y Mg0KZGlmZiAtcjEuMjIgcmRlc2t0b3AuaA0KMjRhMjUNCj4gI2luY2x1ZGUgPHN5cy9zZWxlY3Qu aD4NCkluZGV4OiByZHBkci5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2c3Jvb3QvcmRlc2t0 b3AvcmRlc2t0b3AvcmRwZHIuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMzUNCmRpZmYgLXIx LjM1IHJkcGRyLmMNCjk0M2M5NDMsOTQ0DQo8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKHJlc3VsdCA9PSAwKSkNCi0tLQ0KPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChyZXN1bHQgPT0gMCkgfHwNCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZ19yZHBk cl9kZXZpY2UgDQo+IFtpb3JxLT5kZXZpY2VdLmRldmljZV90eXBlID09IERFVklDRV9UWVBFX1NF UklBTCkpDQpJbmRleDogc2VyaWFsLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3Zzcm9vdC9y ZGVza3RvcC9yZGVza3RvcC9zZXJpYWwuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTUNCmRp ZmYgLXIxLjE1IHNlcmlhbC5jDQozNzZhMzc3DQo+ICAgICAgICAgICAgICAgYnplcm8ocHNlcl9p bmYtPnB0ZXJtaW9zLHNpemVvZihzdHJ1Y3QgdGVybWlvcykpOw0KMzc3YTM3OQ0KPiAgICAgICAg ICAgICAgIGJ6ZXJvKHBzZXJfaW5mLT5wb2xkX3Rlcm1pb3Msc2l6ZW9mKHN0cnVjdCB0ZXJtaW9z KSk7DQo0NDBhNDQzDQo+ICAgICAgIGNmbWFrZXJhdyhwc2VyX2luZi0+cHRlcm1pb3MpOw0KNjUx YzY1NA0KPCAgICAgICAgICAgICAgICAgICAgICAgdW5pbXBsKCJTRVJJQUwgSU9DVEwgJWRcbiIs IHJlcXVlc3QpOw0KLS0tDQo+ICAgICAgICAgICAgICAgLy8gICAgICB1bmltcGwoIlNFUklBTCBJ T0NUTCAlZFxuIiwgcmVxdWVzdCk7DQoNCjQuIHRlc3QgcHJvZ3JhbQ0KDQojaW5jbHVkZSA8ZmNu dGwuaD4NCiNpbmNsdWRlIDx0ZXJtaW9zLmg+DQojaW5jbHVkZSA8c3RkaW8uaD4NCiNpbmNsdWRl IDxzeXMvc2VsZWN0Lmg+DQoNCnZvaWQgbWFpbih2b2lkKSB7DQogICAgaW50CSAgIGZkOw0KICAg IHN0cnVjdCB0ZXJtaW9zIHQ7DQogICAgaW50CSAgIHJlc3VsdDsNCiAgICBjaGFyICAgYnVmWzEw XTsNCg0KICAgIGZkID0gb3BlbigiL2Rldi9jdWFhMCIsT19SRFdSKTsNCiAgICBiemVybygmdCxz aXplb2Yoc3RydWN0IHRlcm1pb3MpKTsNCg0KICAgIHQuY19jZmxhZyA9IEhVUENMIHwgQ1M4IHwg Q1JFQUQgfCBDUlRTQ1RTOw0KICAgIHQuY19jZmxhZyA9IDA7DQogICAgdC5jX2xmbGFnID0gMDsN CiAgICB0LmNfaWZsYWcgPSAwOw0KICAgIHQuY19jY1tWVElNRV0gPSAzMDsgLy90aW1lb3V0IDNz DQogICAgdC5jX2NjW1ZNSU5dID0gMDsNCg0KICAgIGNmc2V0aXNwZWVkKCZ0LCBCOTYwMCk7DQog ICAgY2ZzZXRvc3BlZWQoJnQsIEI5NjAwKTsNCg0KICAgIHRjc2V0YXR0cihmZCwgVENTQU5PVywg JnQpOw0KDQovLyAgICByZXN1bHQgPSByZWFkKGZkLGJ1ZiwxMCk7DQovLyAgICBwcmludGYoInJl c3VsdDEgJWRcbiIscmVzdWx0KTsNCg0KICAgIGludCBtYXhmZDsNCiAgICBtYXhmZCA9IGZkKzE7 DQogICAgc3RydWN0IHRpbWV2YWwgdHY7DQogICAgdHYudHZfc2VjID0gMTU7IC8vdGltZW91dCAx NXMNCiAgICB0di50dl91c2VjID0gMDsNCiAgICBmZF9zZXQgcmVhZGZzOw0KDQogICAgcmVzdWx0 ID0gc2VsZWN0KG1heGZkLCAmcmVhZGZzLCBOVUxMLCBOVUxMLCAmdHYpOw0KICAgIHByaW50Zigi YWZ0ZXIgc2VsZWN0ICVkXG4iLHJlc3VsdCk7DQoNCiAgICBpZiAoRkRfSVNTRVQoZmQsJnJlYWRm cykpIHsNCglyZXN1bHQgPSByZWFkKGZkLGJ1ZiwxMCk7DQoJcHJpbnRmKCJyZXN1bHQyICVkXG4i LHJlc3VsdCk7DQogICAgfTsNCn07DQo= |
From: Michael G. <mi...@ge...> - 2004-08-24 15:29:59
|
Hi, On Tue, Aug 24, 2004 at 03:27:23PM +0800, Huang Yushuo wrote: > 1.1 On FreeBSD, it seems we need the HAVE_DIRFD be defined. but I > can't find any define in src. so I add it in configure.ac. Hmm, this should not be needed. Please send me your config.log from an unmodified configure as PM. > 1.2 We need <sys/select.h> in rdesktop.h. if not , can't find > fd_set. Ok, this seems to be POSIX now, so I'll commit it if noone complains about it ;-) > 2. serial redirect problem Thanks for your troubleshooting. I'm currently not shure if serial redirection works anywhere, but as I need to get it working in the near future, I'll look at it soon. > I attach the cvs diff, and the program for test select() and VMIN > VTIME. I've modified your program a bit, and it seems to work for me. Please test it on your machine. Try if adding |O_NONBLOCK to line 409 of serial.c solves your problem. Regards, Michael |
From: Michael G. <mi...@ge...> - 2004-08-24 15:31:39
Attachments:
serial-test.c
|
On Tue, Aug 24, 2004 at 05:29:51PM +0200, Michael Gernoth wrote: > I've modified your program a bit, and it seems to work for me. And then forgot to attach it... It's attached to this mail. Regards, Michael |
From: Michael G. <mi...@ge...> - 2004-08-24 21:42:42
|
Hi, On Tue, Aug 24, 2004 at 03:27:23PM +0800, Huang Yushuo wrote: > 2. serial redirect problem > > So I change the rdpdr_send_completion() send rule, if we are in a > serial redirect, we will not to wait it return 0(never happenned on > VTIME VMIN timeout) , or get all data in AIO(it will show 64 byte in > HyperTerm one time). This seems to be a solution. > I attach the cvs diff, and the program for test select() and VMIN > VTIME.It's not a perfect solution, just for discusstion. I'm not quite > sure does the problem only happen on my system(FreeBSD 5.2.1) or not. I could reproduce the problems on my Linux-system here. > BTW. Maybe we should clear the termios's memory, Yes, we certainly should. > and put tty in raw mode. On some linux, it seems tty was in Canonical > Mode after we do init. Yes, too. I applied the serial-part of your diff. Regards, Michael |