Menu
▾
▴
rdesktop-devel
|
From: Arend v. B. jr. <ar...@au...> - 2004-03-07 21:43:37
|
Hi! I'm doing some work with rdesktop and I'm adding XEmbed support. This way the usage would become something like this: rdesktop [options] server[:port] [window id] Where the window id is an optional X window id into which rdesktop will embed itself if given. I'll be using this functionality so I can embed rdesktop into the KDE Remote Desktop Client, but of course other frontends can use this as well. If I provide patches for this, would they be allowed to go into the main tree of rdesktop? That would allow me (and other frontend builders) to use vanilla rdesktop releases and nicely integrate it into my app, thereby saving lots of hassles of porting rdesktop or requiring patches versions. Thanks, Arend jr. -- Arend van Beelen jr. http://www.liacs.nl/~dvbeelen I have become comfortably numb. -- Pink Floyd |
|
From: Arend v. B. jr. <ar...@au...> - 2004-03-07 23:06:25
Attachments:
xembed.patch
|
Attached you can find the patch (I think this should be it, but it might need a little refinement). Arend jr. On Sunday 07 March 2004 22:42, Arend van Beelen jr. wrote: > Hi! > > I'm doing some work with rdesktop and I'm adding XEmbed support. This way > the usage would become something like this: > > rdesktop [options] server[:port] [window id] > > Where the window id is an optional X window id into which rdesktop will > embed itself if given. > I'll be using this functionality so I can embed rdesktop into the KDE > Remote Desktop Client, but of course other frontends can use this as well. > If I provide patches for this, would they be allowed to go into the main > tree of rdesktop? That would allow me (and other frontend builders) to use > vanilla rdesktop releases and nicely integrate it into my app, thereby > saving lots of hassles of porting rdesktop or requiring patches versions. > > Thanks, > > Arend jr. -- Arend van Beelen jr. http://www.liacs.nl/~dvbeelen I have become comfortably numb. -- Pink Floyd |
|
From: Bob B. <bb...@us...> - 2004-03-08 15:48:53
|
On Sun, Mar 07, 2004 at 10:42:24PM +0100, Arend van Beelen jr. <ar...@au...> wrote: > I'm doing some work with rdesktop and I'm adding XEmbed support. This way the > usage would become something like this: > > rdesktop [options] server[:port] [window id] It personally would make more sense to me to see [window id] as an options, not a bare argument. But I'm not a core rdesktop developer, so my vote doesn't really count. :-) -- Bob Bell <bb...@us...> |
|
From: Arend v. B. jr. <ar...@au...> - 2004-03-08 17:20:48
Attachments:
xembed.patch
|
On Monday 08 March 2004 16:31, Bob Bell wrote: > On Sun, Mar 07, 2004 at 10:42:24PM +0100, Arend van Beelen jr. <ar...@au...> wrote: > > I'm doing some work with rdesktop and I'm adding XEmbed support. This way > > the usage would become something like this: > > > > rdesktop [options] server[:port] [window id] > > It personally would make more sense to me to see [window id] as an > options, not a bare argument. But I'm not a core rdesktop developer, so > my vote doesn't really count. :-) Actually, I agree with you ;) I cleaned up the patch a bit and made the window id an option (-x). -- Arend van Beelen jr. http://www.liacs.nl/~dvbeelen Coming for you, we're the Cowboys from Hell! -- Pantera |
|
From: Matt C. <mat...@cs...> - 2004-03-09 01:08:11
|
On Mon, Mar 08, 2004 at 06:19:17PM +0100, Arend van Beelen jr. wrote: > On Monday 08 March 2004 16:31, Bob Bell wrote: > > On Sun, Mar 07, 2004 at 10:42:24PM +0100, Arend van Beelen jr. > <ar...@au...> wrote: > > > I'm doing some work with rdesktop and I'm adding XEmbed support. This way > > > the usage would become something like this: > > > > > > rdesktop [options] server[:port] [window id] > > > > It personally would make more sense to me to see [window id] as an > > options, not a bare argument. But I'm not a core rdesktop developer, so > > my vote doesn't really count. :-) > Actually, I agree with you ;) I cleaned up the patch a bit and made the window > id an option (-x). I agree, although I'd prefer -X since currently most of the X-specific options have capital letters. > + xembed = XInternAtom(g_display, "_XEMBED", False); Can you explain what this is for? xembed doesn't seem to be used anywhere in your patch. Otherwise it looks okay. Matt |
|
From: Arend v. B. jr. <ar...@au...> - 2004-03-09 16:14:36
Attachments:
xembed.patch
|
On Tuesday 09 March 2004 01:51, Matt Chapman wrote: > I agree, although I'd prefer -X since currently most of the X-specific > options have capital letters. Okay, I fixed this in the patch and as such I put it right under the other X options. > > + xembed = XInternAtom(g_display, "_XEMBED", False); > > Can you explain what this is for? xembed doesn't seem to be used anywhere > in your patch. I assumed it was a requirement for the XEmbed specification as it was used by the KDE implementation, but apparently they use it later on for different purposes. It gave no obvious trouble when I removed it, so I left it out now. > Otherwise it looks okay. Thanks, attached you can find the (hopefully last ;) version. Btw, is there any new release of rdesktop planned in the near future? If you decide to include this patch, the next rdesktop version would obviously be a minimal requirement for the RDP support in KDE 3.3 (planned for August). -- Arend van Beelen jr. http://www.liacs.nl/~dvbeelen |
|
From: Arend v. B. jr. <ar...@au...> - 2004-03-12 17:46:36
Attachments:
xembed.patch
|
Hi I've made a slight modification to the patch. I moved the XReparentWindow() call down so the size of the window is known when the window is embedded. Otherwise it could sometimes happen the parent would check the size right before it was known giving obvious sizing trouble. Greets, Arend jr. On Sunday 07 March 2004 22:42, Arend van Beelen jr. wrote: > Hi! > > I'm doing some work with rdesktop and I'm adding XEmbed support. This way > the usage would become something like this: > > rdesktop [options] server[:port] [window id] > > Where the window id is an optional X window id into which rdesktop will > embed itself if given. > I'll be using this functionality so I can embed rdesktop into the KDE > Remote Desktop Client, but of course other frontends can use this as well. > If I provide patches for this, would they be allowed to go into the main > tree of rdesktop? That would allow me (and other frontend builders) to use > vanilla rdesktop releases and nicely integrate it into my app, thereby > saving lots of hassles of porting rdesktop or requiring patches versions. > > Thanks, > > Arend jr. -- Arend van Beelen jr. http://www.liacs.nl/~dvbeelen Thus saith the Lord, the King of Israel and his redeemer, the Lord of hosts, I am the first, and I am the last, and beside Me there is no god. -- Isaiah 44:6 |
|
From: Martin B. <ma...@gr...> - 2004-03-12 20:11:30
Attachments:
fr-ca
|
I had a lot of trouble with the fr-ca keyboard, most of us in Quebec use the french canada keyboard, not the canada multilingual one nor the french canada legacy one. So here it is... One little problem need to be resolve though. the map 1009 gives the right keyboard but the wrong local. If someone finds out how to fix the local the french canada instead of english canada, please e-mail me, it might help me fixing another problem I have in the windows OPK. I allready ask dr. International from M$, but no response yet! Keep up the good work Martin ----- Original Message ----- From: "Arend van Beelen jr." <ar...@au...> To: <rde...@li...> Sent: Friday, March 12, 2004 12:38 PM Subject: Re: [rdesktop-devel] XEmbed support > Hi > > I've made a slight modification to the patch. I moved the XReparentWindow() > call down so the size of the window is known when the window is embedded. > Otherwise it could sometimes happen the parent would check the size right > before it was known giving obvious sizing trouble. > > Greets, > Arend jr. > > On Sunday 07 March 2004 22:42, Arend van Beelen jr. wrote: > > Hi! > > > > I'm doing some work with rdesktop and I'm adding XEmbed support. This way > > the usage would become something like this: > > > > rdesktop [options] server[:port] [window id] > > > > Where the window id is an optional X window id into which rdesktop will > > embed itself if given. > > I'll be using this functionality so I can embed rdesktop into the KDE > > Remote Desktop Client, but of course other frontends can use this as well. > > If I provide patches for this, would they be allowed to go into the main > > tree of rdesktop? That would allow me (and other frontend builders) to use > > vanilla rdesktop releases and nicely integrate it into my app, thereby > > saving lots of hassles of porting rdesktop or requiring patches versions. > > > > Thanks, > > > > Arend jr. > > -- > Arend van Beelen jr. > http://www.liacs.nl/~dvbeelen > > Thus saith the Lord, the King of Israel and his redeemer, the Lord of hosts, I > am the first, and I am the last, and beside Me there is no god. > -- Isaiah 44:6 > |
|
From: Michael G. <mi...@ge...> - 2004-03-13 12:17:17
|
Hi, On Fri, Mar 12, 2004 at 06:38:35PM +0100, Arend van Beelen jr. wrote: > I've made a slight modification to the patch. I moved the XReparentWindow() > call down so the size of the window is known when the window is embedded. > Otherwise it could sometimes happen the parent would check the size right > before it was known giving obvious sizing trouble. I have applied a slightly modified version of your patch to the cvs. rdesktop.c does not include Xlib.h in my version. Regards, Michael |
Thanks for helping keep SourceForge clean.
X