[SourceForge.net <noreply@so...>]

Patches item #1193178, was opened at 2005-04-30 19:09
Message generated for change (Comment added) made by dschuff
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1193178&group_id=24366

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Yuiga (yuiga)
Assigned to: Michael Gernoth (stargo)
Summary: Patch to support ALSA

Initial Comment:
This patch adds a support for ALSA(Advanced Linux Sound
System) to rdesktop.

----------------------------------------------------------------------

Comment By: Derek Schuff (dschuff)
Date: 2006-03-23 23:09

Message:
Logged In: YES 
user_id=1475109

I tried out this patch, and it doesnt quite work for me, 
the sample rate isn't right, or at least that's what it 
sounds like... it sets the rate for 22050 but it plays too 
low. if i instead set the rate for say 24000 its too high, 
but 23950 is too low, and it sounds as though there's a 
larger gap than the sample rates would indicate (just dead 
reckoning based on hearing)... but i know little about 
sound programming and less about the ALSA API so i could be 
reading the sample rate wrong or there could be some other 
effect altogether. the documentation on the ALSA PCM 
formats is a little confusing.
I'm connecting to windows XP, and i have  Via VT8233  
onboard sound. 

i will say (not that you should value my opinion on this... 
you probably shouldnt) that i dont have a problem with the 
threaded model, it seems simpler than what's used in rdpsnd_
oss... especially since the frequent calls  to ioctl(g_dsp_
fd, SNDCTL_DSP_GETOSPACE, &info) seems to be what causes 
the CPU usage problem that everyone (including me) seems to 
have with OSS... (the sound pops without that though)

so just my 2 cents.
any insight anyone can give would be helpful, ALSA support 
in rdesktop would be great.


----------------------------------------------------------------------

Comment By: Pierre Ossman (ossman_)
Date: 2006-03-06 10:50

Message:
Logged In: YES 
user_id=1469081

I've done a review of this patch and I am concerned over the
quality. I've found a number of issues:

 * It is threaded when it doesn't have to be. An access
pattern like that in rdpsnd_oss.c would work for alsa aswell
(g_dsp_fd would need to be expanded to an array though).

 * The error handling when snd_pcm_writei() fails is broken.
It only checks one specific error code, causing havoc if any
other is returned.

 * The wait gains nothing by having a timeout. It could also
be possible to get caught in this loop forever (because of
the above point).

 * The format check does no verification towards ALSA that
the format is actually supported.

 * No error handling when setting format.


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2006-02-28 16:41

Message:
Logged In: NO 

Hi,

I tested this patch and it looks like it works.  Is there 
anything else that's missing in it that needs work?

I tested using the latest CVS and a debian sarge box 
running a 2.4.27 kernel and a standard ALSA install.  Sound 
worked along with the standard audio control within the 
rdesktop session.  The latency is still there (but 
expected).

Rgds,
-- Adam

----------------------------------------------------------------------

Comment By: Adam Bil (ab17182)
Date: 2006-02-28 16:38

Message:
Logged In: YES 
user_id=1464137

Hi,

I tested this patch and it looks like it works.  Is there 
anything else that's missing in it that needs work?

I tested using the latest CVS and a debian sarge box 
running a 2.4.27 kernel and a standard ALSA install.  Sound 
worked along with the standard audio control within the 
rdesktop session.  The latency is still there (but 
expected).

Rgds,
-- Adam

----------------------------------------------------------------------

Comment By: Ilya Konstantinov (ikonst)
Date: 2005-10-28 06:21

Message:
Logged In: YES 
user_id=335423

stargo, how is this rework going on? :)

----------------------------------------------------------------------

Comment By: Michael Gernoth (stargo)
Date: 2005-05-08 12:28

Message:
Logged In: YES 
user_id=471365

Thanks, I will include this when I rework the
sound-interface of rdesktop in a short while

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1193178&group_id=24366