You can subscribe to this list here.
2009 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
(4) |
Sep
(3) |
Oct
(9) |
Nov
|
Dec
(1) |
---|---|---|---|---|---|---|---|---|---|---|---|---|
2010 |
Jan
(41) |
Feb
(1) |
Mar
(24) |
Apr
(5) |
May
|
Jun
(6) |
Jul
|
Aug
(1) |
Sep
|
Oct
|
Nov
|
Dec
|
2011 |
Jan
|
Feb
|
Mar
|
Apr
(20) |
May
(1) |
Jun
|
Jul
|
Aug
(2) |
Sep
(5) |
Oct
(1) |
Nov
(2) |
Dec
(5) |
2012 |
Jan
(5) |
Feb
|
Mar
|
Apr
|
May
|
Jun
(5) |
Jul
(4) |
Aug
|
Sep
(2) |
Oct
(3) |
Nov
(14) |
Dec
(2) |
2013 |
Jan
(6) |
Feb
(3) |
Mar
(10) |
Apr
(4) |
May
|
Jun
(12) |
Jul
(2) |
Aug
(10) |
Sep
(14) |
Oct
|
Nov
(21) |
Dec
(9) |
2014 |
Jan
|
Feb
(11) |
Mar
(3) |
Apr
(3) |
May
(14) |
Jun
(8) |
Jul
(5) |
Aug
(4) |
Sep
(10) |
Oct
(2) |
Nov
(4) |
Dec
|
2015 |
Jan
|
Feb
(4) |
Mar
(1) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
From: <as...@us...> - 2013-09-19 14:45:25
|
Revision: 1747 http://sourceforge.net/p/rdesktop/code/1747 Author: astrand Date: 2013-09-19 14:45:22 +0000 (Thu, 19 Sep 2013) Log Message: ----------- When using SeamlessRDP with broken window managers, we hade a timeout of 1 second for ConfigureNotify. Lower this to 0.5 seconds. Modified Paths: -------------- rdesktop/trunk/xwin.c Modified: rdesktop/trunk/xwin.c =================================================================== --- rdesktop/trunk/xwin.c 2013-09-19 14:39:08 UTC (rev 1746) +++ rdesktop/trunk/xwin.c 2013-09-19 14:45:22 UTC (rev 1747) @@ -574,14 +574,14 @@ XEvent xevent; sw_configurenotify_context context; struct timeval now; - struct timeval nextsecond; + struct timeval future; RD_BOOL got = False; context.window = wnd; context.serial = serial; - gettimeofday(&nextsecond, NULL); - nextsecond.tv_sec += 1; + gettimeofday(&future, NULL); + future.tv_usec += 500000; do { @@ -593,7 +593,7 @@ usleep(100000); gettimeofday(&now, NULL); } - while (timercmp(&now, &nextsecond, <)); + while (timercmp(&now, &future, <)); if (!got) { This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <as...@us...> - 2013-09-19 14:39:11
|
Revision: 1746 http://sourceforge.net/p/rdesktop/code/1746 Author: astrand Date: 2013-09-19 14:39:08 +0000 (Thu, 19 Sep 2013) Log Message: ----------- Similar to SeamlessRDPshell commit 1745. Avoid issues with topmost ("_NET_WM_STATE_ABOVE") windows relating to non-topmost windows. Modified Paths: -------------- rdesktop/trunk/ewmhints.c rdesktop/trunk/xproto.h rdesktop/trunk/xwin.c Modified: rdesktop/trunk/ewmhints.c =================================================================== --- rdesktop/trunk/ewmhints.c 2013-09-19 14:36:40 UTC (rev 1745) +++ rdesktop/trunk/ewmhints.c 2013-09-19 14:39:08 UTC (rev 1746) @@ -543,6 +543,33 @@ return 0; } +RD_BOOL +ewmh_is_window_above(Window w) +{ + unsigned long nitems_return; + unsigned char *prop_return; + unsigned long *return_words; + unsigned long item; + RD_BOOL above; + + above = False; + + if (get_property_value(w, "_NET_WM_STATE", 64, &nitems_return, &prop_return, 0) < 0) + return False; + + return_words = (unsigned long *) prop_return; + + for (item = 0; item < nitems_return; item++) + { + if (return_words[item] == g_net_wm_state_above_atom) + above = True; + } + + XFree(prop_return); + + return above; +} + #endif /* MAKE_PROTO */ Modified: rdesktop/trunk/xproto.h =================================================================== --- rdesktop/trunk/xproto.h 2013-09-19 14:36:40 UTC (rev 1745) +++ rdesktop/trunk/xproto.h 2013-09-19 14:39:08 UTC (rev 1746) @@ -12,5 +12,6 @@ void ewmh_set_icon(Window wnd, int width, int height, const char *rgba_data); void ewmh_del_icon(Window wnd, int width, int height); int ewmh_set_window_above(Window wnd); +RD_BOOL ewmh_is_window_above(Window w); void set_keypress_keysym(unsigned int keycode, KeySym keysym); KeySym reset_keypress_keysym(unsigned int keycode, KeySym keysym); Modified: rdesktop/trunk/xwin.c =================================================================== --- rdesktop/trunk/xwin.c 2013-09-19 14:36:40 UTC (rev 1745) +++ rdesktop/trunk/xwin.c 2013-09-19 14:39:08 UTC (rev 1746) @@ -4207,6 +4207,7 @@ seamless_window *sw; XWindowChanges values; unsigned long restack_serial; + unsigned int value_mask; if (!g_seamless_active) return; @@ -4229,25 +4230,43 @@ return; } - if (!g_seamless_broken_restack) + values.stack_mode = Below; + value_mask = CWStackMode | CWSibling; + values.sibling = sw_behind->wnd; + + /* Avoid that topmost windows references non-topmost + windows, and vice versa. */ + if (ewmh_is_window_above(sw->wnd)) { - values.stack_mode = Below; - values.sibling = sw_behind->wnd; - restack_serial = XNextRequest(g_display); - XReconfigureWMWindow(g_display, sw->wnd, DefaultScreen(g_display), - CWStackMode | CWSibling, &values); - sw_wait_configurenotify(sw->wnd, restack_serial); + if (!ewmh_is_window_above(sw_behind->wnd)) + { + /* Disallow, move to bottom of the + topmost stack. */ + values.stack_mode = Below; + value_mask = CWStackMode; /* Not sibling */ + } } + else + { + if (ewmh_is_window_above(sw_behind->wnd)) + { + /* Move to top of non-topmost + stack. */ + values.stack_mode = Above; + value_mask = CWStackMode; /* Not sibling */ + } + } } else { values.stack_mode = Above; - restack_serial = XNextRequest(g_display); - XReconfigureWMWindow(g_display, sw->wnd, DefaultScreen(g_display), CWStackMode, - &values); - sw_wait_configurenotify(sw->wnd, restack_serial); + value_mask = CWStackMode; } + restack_serial = XNextRequest(g_display); + XReconfigureWMWindow(g_display, sw->wnd, DefaultScreen(g_display), value_mask, &values); + sw_wait_configurenotify(sw->wnd, restack_serial); + sw_restack_window(sw, behind); if (flags & SEAMLESSRDP_CREATE_TOPMOST) This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <as...@us...> - 2013-09-19 14:36:44
|
Revision: 1745 http://sourceforge.net/p/rdesktop/code/1745 Author: astrand Date: 2013-09-19 14:36:40 +0000 (Thu, 19 Sep 2013) Log Message: ----------- Avoid that normal windows gets promoted to topmost windows, if a ZCHANGE message references both topmost and non-topmost windows. Modified Paths: -------------- seamlessrdp/trunk/ServerExe/hookdll.c Modified: seamlessrdp/trunk/ServerExe/hookdll.c =================================================================== --- seamlessrdp/trunk/ServerExe/hookdll.c 2013-09-19 12:02:40 UTC (rev 1744) +++ seamlessrdp/trunk/ServerExe/hookdll.c 2013-09-19 14:36:40 UTC (rev 1745) @@ -760,7 +760,7 @@ ReleaseMutex(g_mutex); SetWindowPos(hwnd, NULL, x, y, width, height, - SWP_NOACTIVATE | SWP_NOZORDER); + SWP_NOACTIVATE | SWP_NOOWNERZORDER | SWP_NOZORDER); vchannel_write("ACK", "%u", serial); @@ -788,8 +788,28 @@ g_shdata->blocked_zchange[1] = hwnd_to_long(behind); ReleaseMutex(g_mutex); - if (behind == NULL) + LONG exstyle = GetWindowLong(hwnd, GWL_EXSTYLE); + if (behind) { + LONG bhstyle = GetWindowLong(behind, GWL_EXSTYLE); + /* Avoid that topmost windows references non-topmost + windows, and vice versa. */ + if (exstyle & WS_EX_TOPMOST) { + if (!(bhstyle & WS_EX_TOPMOST)) { + /* Disallow, move to bottom of the topmost + stack. */ + /* FIXME: Remains to be implemented */ + behind = HWND_TOP; + } + } else { + if (bhstyle & WS_EX_TOPMOST) { + /* Move to top of non-topmost + stack. */ + behind = HWND_TOP; + } + } + } else { behind = HWND_TOP; + } SetWindowPos(hwnd, behind, 0, 0, 0, 0, SWP_NOACTIVATE | SWP_NOMOVE | SWP_NOSIZE); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <as...@us...> - 2013-09-19 12:02:44
|
Revision: 1744 http://sourceforge.net/p/rdesktop/code/1744 Author: astrand Date: 2013-09-19 12:02:40 +0000 (Thu, 19 Sep 2013) Log Message: ----------- Fixed indent Modified Paths: -------------- seamlessrdp/trunk/ServerExe/hookdll.c seamlessrdp/trunk/ServerExe/vchannel.c Modified: seamlessrdp/trunk/ServerExe/hookdll.c =================================================================== --- seamlessrdp/trunk/ServerExe/hookdll.c 2013-09-19 08:38:07 UTC (rev 1743) +++ seamlessrdp/trunk/ServerExe/hookdll.c 2013-09-19 12:02:40 UTC (rev 1744) @@ -95,11 +95,10 @@ /* checks instance connection serial against shared. */ static void -check_conn_serial() +check_conn_serial() { WaitForSingleObject(g_mutex, INFINITE); - if (g_conn_serial != g_shdata->conn_serial) - { + if (g_conn_serial != g_shdata->conn_serial) { vchannel_reopen(); g_conn_serial = g_shdata->conn_serial; } @@ -708,7 +707,7 @@ WaitForSingleObject(g_mutex, INFINITE); g_shdata->conn_serial++; ReleaseMutex(g_mutex); - + } EXTERN void Modified: seamlessrdp/trunk/ServerExe/vchannel.c =================================================================== --- seamlessrdp/trunk/ServerExe/vchannel.c 2013-09-19 08:38:07 UTC (rev 1743) +++ seamlessrdp/trunk/ServerExe/vchannel.c 2013-09-19 12:02:40 UTC (rev 1744) @@ -155,7 +155,7 @@ WTSVirtualChannelClose(g_vchannel); g_vchannel = WTSVirtualChannelOpen(WTS_CURRENT_SERVER_HANDLE, - WTS_CURRENT_SESSION, CHANNELNAME); + WTS_CURRENT_SESSION, CHANNELNAME); vchannel_unblock(); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <he...@us...> - 2013-09-19 08:38:09
|
Revision: 1743 http://sourceforge.net/p/rdesktop/code/1743 Author: hean01 Date: 2013-09-19 08:38:07 +0000 (Thu, 19 Sep 2013) Log Message: ----------- Added the 4 new exit codes to the man page. Modified Paths: -------------- rdesktop/trunk/doc/rdesktop.1 Modified: rdesktop/trunk/doc/rdesktop.1 =================================================================== --- rdesktop/trunk/doc/rdesktop.1 2013-09-17 14:48:56 UTC (rev 1742) +++ rdesktop/trunk/doc/rdesktop.1 2013-09-19 08:38:07 UTC (rev 1743) @@ -282,6 +282,16 @@ The server denied the connection .IP "\fB8\fP" The server denied the connection for security reason +.IP "\fB9\fP" +The user cannot connect to the server due to insufficient access +privileges +.IP "\fB10\fP" +The server does not accept saved user credentials and requires that +the user enter their credentials for each connection +.IP "\fB11\fP" +Disconnect initiated by administration tool +.IP "\fB12\fP" +Disconnect initiated by user .IP "\fB16\fP" Internal licensing error .IP "\fB17\fP" This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <he...@us...> - 2013-09-17 14:49:09
|
Revision: 1742 http://sourceforge.net/p/rdesktop/code/1742 Author: hean01 Date: 2013-09-17 14:48:56 +0000 (Tue, 17 Sep 2013) Log Message: ----------- Added 4 new disconnect reasons with corresponding return code. Modified Paths: -------------- rdesktop/trunk/constants.h rdesktop/trunk/rdesktop.c rdesktop/trunk/rdesktop.h Modified: rdesktop/trunk/constants.h =================================================================== --- rdesktop/trunk/constants.h 2013-09-17 13:32:16 UTC (rev 1741) +++ rdesktop/trunk/constants.h 2013-09-17 14:48:56 UTC (rev 1742) @@ -454,7 +454,10 @@ #define exDiscReasonOutOfMemory 0x0006 #define exDiscReasonServerDeniedConnection 0x0007 #define exDiscReasonServerDeniedConnectionFips 0x0008 -#define exDiscReasonWindows7Disconnect 0x000b /* unofficial */ +#define exDiscReasonServerInsufficientPrivileges 0x0009 +#define exDiscReasonServerFreshCredentialsRequired 0x000a +#define exDiscReasonRPCInitiatedDisconnectByUser 0x000b +#define exDiscReasonByUser 0x000c #define exDiscReasonLicenseInternal 0x0100 #define exDiscReasonLicenseNoLicenseServer 0x0101 #define exDiscReasonLicenseNoLicense 0x0102 Modified: rdesktop/trunk/rdesktop.c =================================================================== --- rdesktop/trunk/rdesktop.c 2013-09-17 13:32:16 UTC (rev 1741) +++ rdesktop/trunk/rdesktop.c 2013-09-17 14:48:56 UTC (rev 1742) @@ -281,7 +281,6 @@ break; case exDiscReasonAPIInitiatedDisconnect: - case exDiscReasonWindows7Disconnect: text = "Server initiated disconnect"; retval = EXRD_API_DISCONNECT; break; @@ -321,6 +320,26 @@ retval = EXRD_DENIED_FIPS; break; + case exDiscReasonServerInsufficientPrivileges: + text = "The user cannot connect to the server due to insufficient access privileges."; + retval = EXRD_INSUFFICIENT_PRIVILEGES; + break; + + case exDiscReasonServerFreshCredentialsRequired: + text = "The server does not accept saved user credentials and requires that the user enter their credentials for each connection."; + retval = EXRD_FRESH_CREDENTIALS_REQUIRED; + break; + + case exDiscReasonRPCInitiatedDisconnectByUser: + text = "Disconnect initiated by administration tool"; + retval = EXRD_RPC_DISCONNECT_BY_USER; + break; + + case exDiscReasonByUser: + text = "Disconnect initiated by user"; + retval = EXRD_DISCONNECT_BY_USER; + break; + case exDiscReasonLicenseInternal: text = "Internal licensing error"; retval = EXRD_LIC_INTERNAL; Modified: rdesktop/trunk/rdesktop.h =================================================================== --- rdesktop/trunk/rdesktop.h 2013-09-17 13:32:16 UTC (rev 1741) +++ rdesktop/trunk/rdesktop.h 2013-09-17 14:48:56 UTC (rev 1742) @@ -100,6 +100,10 @@ #define EXRD_OUT_OF_MEM 6 #define EXRD_DENIED 7 #define EXRD_DENIED_FIPS 8 +#define EXRD_INSUFFICIENT_PRIVILEGES 9 +#define EXRD_FRESH_CREDENTIALS_REQUIRED 10 +#define EXRD_RPC_DISCONNECT_BY_USER 11 +#define EXRD_DISCONNECT_BY_USER 12 #define EXRD_LIC_INTERNAL 16 #define EXRD_LIC_NOSERVER 17 #define EXRD_LIC_NOLICENSE 18 This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <as...@us...> - 2013-09-17 13:32:18
|
Revision: 1741 http://sourceforge.net/p/rdesktop/code/1741 Author: astrand Date: 2013-09-17 13:32:16 +0000 (Tue, 17 Sep 2013) Log Message: ----------- Correct build warning caused by commit 1732. Modified Paths: -------------- rdesktop/trunk/rdesktop.c Modified: rdesktop/trunk/rdesktop.c =================================================================== --- rdesktop/trunk/rdesktop.c 2013-09-17 13:27:31 UTC (rev 1740) +++ rdesktop/trunk/rdesktop.c 2013-09-17 13:32:16 UTC (rev 1741) @@ -1733,7 +1733,7 @@ if (!ui_have_window()) { if (!ui_create_window()) - return EX_OSERR; + exit(EX_OSERR); } } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <as...@us...> - 2013-09-17 13:27:34
|
Revision: 1740 http://sourceforge.net/p/rdesktop/code/1740 Author: astrand Date: 2013-09-17 13:27:31 +0000 (Tue, 17 Sep 2013) Log Message: ----------- Removed unused variable. Modified Paths: -------------- rdesktop/trunk/rdesktop.c Modified: rdesktop/trunk/rdesktop.c =================================================================== --- rdesktop/trunk/rdesktop.c 2013-09-17 13:11:22 UTC (rev 1739) +++ rdesktop/trunk/rdesktop.c 2013-09-17 13:27:31 UTC (rev 1740) @@ -510,7 +510,6 @@ #ifdef WITH_RDPSND char *rdpsnd_optarg = NULL; #endif - int longidx; #ifdef HAVE_LOCALE_H /* Set locale according to environment */ This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <as...@us...> - 2013-09-17 13:11:25
|
Revision: 1739 http://sourceforge.net/p/rdesktop/code/1739 Author: astrand Date: 2013-09-17 13:11:22 +0000 (Tue, 17 Sep 2013) Log Message: ----------- Fix SeamlessRDP bugs related to maximized Windows: * Fix ewmhints.c:ewmh_get_window_state was not working on 64 bit platforms. * In EWMH, HIDDEN overrides MAXIMIZED_VERT/MAXIMIZED_HORZ. * Finally, if we receive a POSITION when window is maximized or minimized, it's wrong to simply ignore the POSITION and simply set the local values to what the server gave us. Instead, we are sending back a new POSITION. Modified Paths: -------------- rdesktop/trunk/ewmhints.c rdesktop/trunk/xwin.c Modified: rdesktop/trunk/ewmhints.c =================================================================== --- rdesktop/trunk/ewmhints.c 2013-09-16 12:45:47 UTC (rev 1738) +++ rdesktop/trunk/ewmhints.c 2013-09-17 13:11:22 UTC (rev 1739) @@ -203,7 +203,7 @@ { unsigned long nitems_return; unsigned char *prop_return; - uint32 *return_words; + unsigned long *return_words; unsigned long item; RD_BOOL maximized_vert, maximized_horz, hidden; @@ -212,7 +212,7 @@ if (get_property_value(w, "_NET_WM_STATE", 64, &nitems_return, &prop_return, 0) < 0) return SEAMLESSRDP_NORMAL; - return_words = (uint32 *) prop_return; + return_words = (unsigned long *) prop_return; for (item = 0; item < nitems_return; item++) { @@ -226,10 +226,11 @@ XFree(prop_return); - if (maximized_vert && maximized_horz) + /* In EWMH, HIDDEN overrides MAXIMIZED_VERT/MAXIMIZED_HORZ */ + if (hidden) + return SEAMLESSRDP_MINIMIZED; + else if (maximized_vert && maximized_horz) return SEAMLESSRDP_MAXIMIZED; - else if (hidden) - return SEAMLESSRDP_MINIMIZED; else return SEAMLESSRDP_NORMAL; } Modified: rdesktop/trunk/xwin.c =================================================================== --- rdesktop/trunk/xwin.c 2013-09-16 12:45:47 UTC (rev 1738) +++ rdesktop/trunk/xwin.c 2013-09-17 13:11:22 UTC (rev 1739) @@ -4181,20 +4181,21 @@ /* X11 windows must be at least 1x1 */ return; - sw->xoffset = x; - sw->yoffset = y; - sw->width = width; - sw->height = height; - /* If we move the window in a maximized state, then KDE won't accept restoration */ switch (sw->state) { case SEAMLESSRDP_MINIMIZED: case SEAMLESSRDP_MAXIMIZED: + sw_update_position(sw); return; } + sw->xoffset = x; + sw->yoffset = y; + sw->width = width; + sw->height = height; + /* FIXME: Perhaps use ewmh_net_moveresize_window instead */ XMoveResizeWindow(g_display, sw->wnd, sw->xoffset, sw->yoffset, sw->width, sw->height); } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <as...@us...> - 2013-09-16 12:45:50
|
Revision: 1738 http://sourceforge.net/p/rdesktop/code/1738 Author: astrand Date: 2013-09-16 12:45:47 +0000 (Mon, 16 Sep 2013) Log Message: ----------- Ran indent-all Modified Paths: -------------- rdesktop/trunk/scard.c Modified: rdesktop/trunk/scard.c =================================================================== --- rdesktop/trunk/scard.c 2013-09-16 12:45:24 UTC (rev 1737) +++ rdesktop/trunk/scard.c 2013-09-16 12:45:47 UTC (rev 1738) @@ -1135,7 +1135,7 @@ for (i = 0, cur = rsArray; i < dwCount; i++, cur++) { in_uint32_le(in, dwPointerId); - cur->szReader = (char *)(intptr_t)dwPointerId; + cur->szReader = (char *) (intptr_t) dwPointerId; in_uint32_le(in, cur->dwCurrentState); in_uint32_le(in, cur->dwEventState); in_uint32_le(in, cur->cbAtr); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <as...@us...> - 2013-09-16 12:45:27
|
Revision: 1737 http://sourceforge.net/p/rdesktop/code/1737 Author: astrand Date: 2013-09-16 12:45:24 +0000 (Mon, 16 Sep 2013) Log Message: ----------- Minor warning message fix. Modified Paths: -------------- rdesktop/trunk/rdpsnd_dsp.c Modified: rdesktop/trunk/rdpsnd_dsp.c =================================================================== --- rdesktop/trunk/rdpsnd_dsp.c 2013-09-16 12:44:37 UTC (rev 1736) +++ rdesktop/trunk/rdpsnd_dsp.c 2013-09-16 12:45:24 UTC (rev 1737) @@ -255,7 +255,7 @@ #ifdef HAVE_LIBSAMPLERATE if (src_converter == NULL) { - warning("no samplerate converter available!!\n"); + warning("no samplerate converter available!\n"); return 0; } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <as...@us...> - 2013-09-16 12:44:40
|
Revision: 1736 http://sourceforge.net/p/rdesktop/code/1736 Author: astrand Date: 2013-09-16 12:44:37 +0000 (Mon, 16 Sep 2013) Log Message: ----------- Make sure that the style is the same with both indent 2.2.10 and 2.2.11, wrt !!. Modified Paths: -------------- rdesktop/trunk/indent-all.sh Modified: rdesktop/trunk/indent-all.sh =================================================================== --- rdesktop/trunk/indent-all.sh 2013-09-16 12:21:44 UTC (rev 1735) +++ rdesktop/trunk/indent-all.sh 2013-09-16 12:44:37 UTC (rev 1736) @@ -1,3 +1,5 @@ #!/bin/sh indent -bli0 -i8 -cli8 -npcs -l100 *.h *.c vnc/*.h vnc/*.c +# Tweak in order to support both indent 2.2.10 and 2.2.11 +perl -pi -e 's|!!|! !|g' *.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <as...@us...> - 2013-09-16 12:21:46
|
Revision: 1735 http://sourceforge.net/p/rdesktop/code/1735 Author: astrand Date: 2013-09-16 12:21:44 +0000 (Mon, 16 Sep 2013) Log Message: ----------- Corrected DEBUG_SEAMLESS statement; use same style for both "got" and "sending" messages. Modified Paths: -------------- rdesktop/trunk/seamless.c Modified: rdesktop/trunk/seamless.c =================================================================== --- rdesktop/trunk/seamless.c 2013-08-29 14:27:25 UTC (rev 1734) +++ rdesktop/trunk/seamless.c 2013-09-16 12:21:44 UTC (rev 1735) @@ -437,7 +437,7 @@ s = channel_init(seamless_channel, len); out_uint8p(s, buf, len) s_mark_end(s); - DEBUG_SEAMLESS(("SeamlessRDP sending:%s", buf)); + DEBUG_SEAMLESS(("seamlessrdp sending:%s", buf)); #if 0 printf("seamless send:\n"); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <he...@us...> - 2013-08-29 14:27:29
|
Revision: 1734 http://sourceforge.net/p/rdesktop/code/1734 Author: hean01 Date: 2013-08-29 14:27:25 +0000 (Thu, 29 Aug 2013) Log Message: ----------- Test if SSL_OP_NO_COMPRESSION is defined before use. OpenSSL < 0.9.9 does not support this option, see upstream commit 566dda07ba16f9d3b9774fd5c8d526d7cc93f179 for reference. Modified Paths: -------------- rdesktop/trunk/tcp.c Modified: rdesktop/trunk/tcp.c =================================================================== --- rdesktop/trunk/tcp.c 2013-08-29 13:27:35 UTC (rev 1733) +++ rdesktop/trunk/tcp.c 2013-08-29 14:27:25 UTC (rev 1734) @@ -318,7 +318,9 @@ } options = 0; +#ifdef SSL_OP_NO_COMPRESSION options |= SSL_OP_NO_COMPRESSION; +#endif // __SSL_OP_NO_COMPRESSION options |= SSL_OP_DONT_INSERT_EMPTY_FRAGMENTS; SSL_CTX_set_options(g_ssl_ctx, options); } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <he...@us...> - 2013-08-29 13:27:38
|
Revision: 1733 http://sourceforge.net/p/rdesktop/code/1733 Author: hean01 Date: 2013-08-29 13:27:35 +0000 (Thu, 29 Aug 2013) Log Message: ----------- Remove undocumented fallback codeblock which existence is not motivated. Modified Paths: -------------- rdesktop/trunk/scard.c Modified: rdesktop/trunk/scard.c =================================================================== --- rdesktop/trunk/scard.c 2013-08-14 13:49:45 UTC (rev 1732) +++ rdesktop/trunk/scard.c 2013-08-29 13:27:35 UTC (rev 1733) @@ -1991,26 +1991,6 @@ rv = SCardGetAttrib(myHCard, (MYPCSC_DWORD) dwAttrId, pbAttr, &attrLen); dwAttrLen = attrLen; - if (dwAttrId == SCARD_ATTR_VENDOR_NAME && rv != SCARD_S_SUCCESS) - { - DEBUG_SCARD(("SCARD: Faking attribute ATTR_VENDOR_NAME\n")); - pthread_mutex_lock(&hcardAccess); - PSCHCardRec hcard = hcardFirst; - while (hcard) - { - if (hcard->hCard == hCard) - { - dwAttrLen = strlen(hcard->vendor); - memcpy(pbAttr, hcard->vendor, dwAttrLen); - rv = SCARD_S_SUCCESS; - break; - } - hcard = hcard->next; - } - pthread_mutex_unlock(&hcardAccess); - DEBUG_SCARD(("[0x%.8x]\n", (unsigned int) rv)); - } - if (rv != SCARD_S_SUCCESS) { DEBUG_SCARD(("SCARD: -> Failure: %s (0x%08x)\n", This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <he...@us...> - 2013-08-14 13:49:48
|
Revision: 1732 http://sourceforge.net/p/rdesktop/code/1732 Author: hean01 Date: 2013-08-14 13:49:45 +0000 (Wed, 14 Aug 2013) Log Message: ----------- - Added rd_create_ui() helper function - Make sure that ui is created if processing demand active PDU - Make sure we use precached bitmap cache again This fixes bugs #367 and #368 Modified Paths: -------------- rdesktop/trunk/proto.h rdesktop/trunk/rdesktop.c rdesktop/trunk/rdp.c Modified: rdesktop/trunk/proto.h =================================================================== --- rdesktop/trunk/proto.h 2013-08-14 13:23:01 UTC (rev 1731) +++ rdesktop/trunk/proto.h 2013-08-14 13:49:45 UTC (rev 1732) @@ -144,6 +144,7 @@ char *l_to_a(long N, int base); int load_licence(unsigned char **data); void save_licence(unsigned char *data, int length); +void rd_create_ui(void); RD_BOOL rd_pstcache_mkdir(void); int rd_open_file(char *filename); void rd_close_file(int fd); Modified: rdesktop/trunk/rdesktop.c =================================================================== --- rdesktop/trunk/rdesktop.c 2013-08-14 13:23:01 UTC (rev 1731) +++ rdesktop/trunk/rdesktop.c 2013-08-14 13:49:45 UTC (rev 1732) @@ -87,7 +87,7 @@ RD_BOOL g_sendmotion = True; RD_BOOL g_bitmap_cache = True; RD_BOOL g_bitmap_cache_persist_enable = False; -RD_BOOL g_bitmap_cache_precache = False; +RD_BOOL g_bitmap_cache_precache = True; RD_BOOL g_use_ctrl = True; RD_BOOL g_encryption = True; RD_BOOL g_encryption_initial = True; @@ -1132,13 +1132,7 @@ DEBUG(("Connection successful.\n")); memset(password, 0, sizeof(password)); - /* only create a window if we dont have one intialized */ - if (!ui_have_window()) - { - if (!ui_create_window()) - return EX_OSERR; - } - + rd_create_ui(); tcp_run_ui(True); g_redirect = False; @@ -1732,6 +1726,18 @@ close(fd); } +/* create rdesktop ui */ +void +rd_create_ui() +{ + /* only create a window if we dont have one intialized */ + if (!ui_have_window()) + { + if (!ui_create_window()) + return EX_OSERR; + } +} + /* Create the bitmap cache directory */ RD_BOOL rd_pstcache_mkdir(void) Modified: rdesktop/trunk/rdp.c =================================================================== --- rdesktop/trunk/rdp.c 2013-08-14 13:23:01 UTC (rev 1731) +++ rdesktop/trunk/rdp.c 2013-08-14 13:49:45 UTC (rev 1732) @@ -1044,6 +1044,9 @@ uint8 type; uint16 len_src_descriptor, len_combined_caps; + /* at this point we need to ensure that we have ui created */ + rd_create_ui(); + in_uint32_le(s, g_rdp_shareid); in_uint16_le(s, len_src_descriptor); in_uint16_le(s, len_combined_caps); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <he...@us...> - 2013-08-14 13:23:05
|
Revision: 1731 http://sourceforge.net/p/rdesktop/code/1731 Author: hean01 Date: 2013-08-14 13:23:01 +0000 (Wed, 14 Aug 2013) Log Message: ----------- Bitmap cache precaching is broken, tries to create bitmaps without window which results in a sigsegv. Workaround for bug #367 Modified Paths: -------------- rdesktop/trunk/rdesktop.c Modified: rdesktop/trunk/rdesktop.c =================================================================== --- rdesktop/trunk/rdesktop.c 2013-08-14 12:56:52 UTC (rev 1730) +++ rdesktop/trunk/rdesktop.c 2013-08-14 13:23:01 UTC (rev 1731) @@ -87,7 +87,7 @@ RD_BOOL g_sendmotion = True; RD_BOOL g_bitmap_cache = True; RD_BOOL g_bitmap_cache_persist_enable = False; -RD_BOOL g_bitmap_cache_precache = True; +RD_BOOL g_bitmap_cache_precache = False; RD_BOOL g_use_ctrl = True; RD_BOOL g_encryption = True; RD_BOOL g_encryption_initial = True; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <he...@us...> - 2013-08-14 12:56:55
|
Revision: 1730 http://sourceforge.net/p/rdesktop/code/1730 Author: hean01 Date: 2013-08-14 12:56:52 +0000 (Wed, 14 Aug 2013) Log Message: ----------- Zero memory of format struct to prevent sigsegv. Modified Paths: -------------- rdesktop/trunk/rdpsnd_libao.c Modified: rdesktop/trunk/rdpsnd_libao.c =================================================================== --- rdesktop/trunk/rdpsnd_libao.c 2013-08-12 09:52:08 UTC (rev 1729) +++ rdesktop/trunk/rdpsnd_libao.c 2013-08-14 12:56:52 UTC (rev 1730) @@ -111,6 +111,7 @@ { ao_sample_format format; + memset(&format, 0, sizeof(format)); format.bits = pwfx->wBitsPerSample; format.channels = pwfx->nChannels; format.rate = 44100; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <he...@us...> - 2013-08-12 09:52:10
|
Revision: 1729 http://sourceforge.net/p/rdesktop/code/1729 Author: hean01 Date: 2013-08-12 09:52:08 +0000 (Mon, 12 Aug 2013) Log Message: ----------- Fixes a issue with 64bit portability. Fix for bug #366 Modified Paths: -------------- rdesktop/trunk/scard.c Modified: rdesktop/trunk/scard.c =================================================================== --- rdesktop/trunk/scard.c 2013-08-10 16:16:55 UTC (rev 1728) +++ rdesktop/trunk/scard.c 2013-08-12 09:52:08 UTC (rev 1729) @@ -2,8 +2,8 @@ rdesktop: A Remote Desktop Protocol client. Smart Card support Copyright (C) Alexi Volkov <al...@my...> 2006 - Copyright 2010 Pierre Ossman <os...@ce...> for Cendio AB - Copyright 2011 Henrik Andersson <he...@ce...> for Cendio AB + Copyright 2010-2013 Pierre Ossman <os...@ce...> for Cendio AB + Copyright 2011-2013 Henrik Andersson <he...@ce...> for Cendio AB This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -1109,6 +1109,7 @@ MYPCSC_SCARDCONTEXT myHContext; SERVER_DWORD dwTimeout; SERVER_DWORD dwCount; + SERVER_DWORD dwPointerId; SERVER_LPSCARD_READERSTATE_A rsArray, cur; MYPCSC_LPSCARD_READERSTATE_A myRsArray; long i; @@ -1133,7 +1134,8 @@ memset(rsArray, 0, dwCount * sizeof(SERVER_SCARD_READERSTATE_A)); for (i = 0, cur = rsArray; i < dwCount; i++, cur++) { - in_uint32_le(in, cur->szReader); + in_uint32_le(in, dwPointerId); + cur->szReader = (char *)(intptr_t)dwPointerId; in_uint32_le(in, cur->dwCurrentState); in_uint32_le(in, cur->dwEventState); in_uint32_le(in, cur->cbAtr); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <he...@us...> - 2013-08-10 16:16:58
|
Revision: 1728 http://sourceforge.net/p/rdesktop/code/1728 Author: hean01 Date: 2013-08-10 16:16:55 +0000 (Sat, 10 Aug 2013) Log Message: ----------- Return a NULL value as expected. Partly fix for bug #366 Modified Paths: -------------- rdesktop/trunk/tcp.c Modified: rdesktop/trunk/tcp.c =================================================================== --- rdesktop/trunk/tcp.c 2013-08-09 08:55:09 UTC (rev 1727) +++ rdesktop/trunk/tcp.c 2013-08-10 16:16:55 UTC (rev 1728) @@ -193,7 +193,7 @@ int rcvd = 0, ssl_err; if (g_network_error == True) - return; + return NULL; if (s == NULL) { This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <he...@us...> - 2013-08-09 08:55:13
|
Revision: 1727 http://sourceforge.net/p/rdesktop/code/1727 Author: hean01 Date: 2013-08-09 08:55:09 +0000 (Fri, 09 Aug 2013) Log Message: ----------- Bump trunk version to 1.8.0post Modified Paths: -------------- rdesktop/trunk/configure.ac rdesktop/trunk/rdesktop.spec Modified: rdesktop/trunk/configure.ac =================================================================== --- rdesktop/trunk/configure.ac 2013-08-09 08:19:44 UTC (rev 1726) +++ rdesktop/trunk/configure.ac 2013-08-09 08:55:09 UTC (rev 1727) @@ -1,4 +1,4 @@ -AC_INIT(rdesktop, 1.8.0) +AC_INIT(rdesktop, 1.8.0post) AC_CONFIG_SRCDIR([rdesktop.c]) Modified: rdesktop/trunk/rdesktop.spec =================================================================== --- rdesktop/trunk/rdesktop.spec 2013-08-09 08:19:44 UTC (rev 1726) +++ rdesktop/trunk/rdesktop.spec 2013-08-09 08:55:09 UTC (rev 1727) @@ -1,6 +1,6 @@ Summary: Remote Desktop Protocol client Name: rdesktop -Version: 1.8.0 +Version: 1.8.0post Release: 1 License: GPL; see COPYING Group: Applications/Communications This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <he...@us...> - 2013-08-09 08:19:47
|
Revision: 1726 http://sourceforge.net/p/rdesktop/code/1726 Author: hean01 Date: 2013-08-09 08:19:44 +0000 (Fri, 09 Aug 2013) Log Message: ----------- rdesktop 1.8.0 release. Added Paths: ----------- rdesktop/tags/rdesktop-1.8.0/ This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <he...@us...> - 2013-08-09 08:13:47
|
Revision: 1725 http://sourceforge.net/p/rdesktop/code/1725 Author: hean01 Date: 2013-08-09 08:13:46 +0000 (Fri, 09 Aug 2013) Log Message: ----------- Bump version to 1.8.0 Modified Paths: -------------- rdesktop/trunk/configure.ac rdesktop/trunk/doc/ChangeLog rdesktop/trunk/rdesktop.spec Modified: rdesktop/trunk/configure.ac =================================================================== --- rdesktop/trunk/configure.ac 2013-07-05 14:32:43 UTC (rev 1724) +++ rdesktop/trunk/configure.ac 2013-08-09 08:13:46 UTC (rev 1725) @@ -1,4 +1,4 @@ -AC_INIT(rdesktop, 1.7.1post) +AC_INIT(rdesktop, 1.8.0) AC_CONFIG_SRCDIR([rdesktop.c]) Modified: rdesktop/trunk/doc/ChangeLog =================================================================== --- rdesktop/trunk/doc/ChangeLog 2013-07-05 14:32:43 UTC (rev 1724) +++ rdesktop/trunk/doc/ChangeLog 2013-08-09 08:13:46 UTC (rev 1725) @@ -1,3 +1,18 @@ +rdesktop (1.8.0) + * Support for protocol negotiation eg. SSL/TLSv1 and CredSSP + * Support for CredSSP + Kerberos authentication (NLA) + * Support for smart card single-sign-on + * Support passing smart card pin as password as argument + * Added IPC for controlling a master rdesktop process + * Support for connection sharing when using SeamlessRDP + * Improved handling of network connection failures + * Autoreconnect using the connection cookie at network failure + * Fix a few smart card issues + * Fix bug with mouse scroll handling + * Fix for left/right braces in Italian keymap + * Fix crash and memory leak in local drive redirection + * Fixes issues with license files loading/saving + rdesktop (1.7.1) * Fix clipboard issue when not building with unicode support * Fix compilation against newer PCSC lite versions Modified: rdesktop/trunk/rdesktop.spec =================================================================== --- rdesktop/trunk/rdesktop.spec 2013-07-05 14:32:43 UTC (rev 1724) +++ rdesktop/trunk/rdesktop.spec 2013-08-09 08:13:46 UTC (rev 1725) @@ -1,6 +1,6 @@ Summary: Remote Desktop Protocol client Name: rdesktop -Version: 1.7.1post +Version: 1.8.0 Release: 1 License: GPL; see COPYING Group: Applications/Communications This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <os...@us...> - 2013-07-05 14:32:47
|
Revision: 1724 http://sourceforge.net/p/rdesktop/code/1724 Author: ossman_ Date: 2013-07-05 14:32:43 +0000 (Fri, 05 Jul 2013) Log Message: ----------- Don't screw up the attribute ID for SCardGetAttr(). It worked by pure luck in some cases, and failed in the rest. Modified Paths: -------------- rdesktop/trunk/scard.c Modified: rdesktop/trunk/scard.c =================================================================== --- rdesktop/trunk/scard.c 2013-07-05 11:44:03 UTC (rev 1723) +++ rdesktop/trunk/scard.c 2013-07-05 14:32:43 UTC (rev 1724) @@ -1962,7 +1962,6 @@ in->p += 0x0C; in_uint32_le(in, hCard); myHCard = _scard_handle_list_get_pcsc_handle(hCard); - dwAttrId = dwAttrId & 0x0000FFFF; DEBUG_SCARD(("SCARD: SCardGetAttrib(hcard: 0x%08x [0x%08lx], attrib: 0x%08x (%d bytes))\n", (unsigned) hCard, (unsigned long) myHCard, @@ -1990,7 +1989,7 @@ rv = SCardGetAttrib(myHCard, (MYPCSC_DWORD) dwAttrId, pbAttr, &attrLen); dwAttrLen = attrLen; - if (dwAttrId == 0x00000100 && rv != SCARD_S_SUCCESS) + if (dwAttrId == SCARD_ATTR_VENDOR_NAME && rv != SCARD_S_SUCCESS) { DEBUG_SCARD(("SCARD: Faking attribute ATTR_VENDOR_NAME\n")); pthread_mutex_lock(&hcardAccess); @@ -2059,8 +2058,6 @@ in_uint32_le(in, hCard); myHCard = scHandleToMyPCSC(hCard); - dwAttrId = dwAttrId & 0x0000FFFF; - DEBUG_SCARD(("SCARD: SCardSetAttrib(hcard: 0x%08x [0x%08lx], attrib: 0x%08x (%d bytes))\n", (unsigned) hCard, (unsigned long) myHCard, (unsigned) dwAttrId, (int) dwAttrLen)); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <os...@us...> - 2013-07-05 11:44:05
|
Revision: 1723 http://sourceforge.net/p/rdesktop/code/1723 Author: ossman_ Date: 2013-07-05 11:44:03 +0000 (Fri, 05 Jul 2013) Log Message: ----------- Do a proper parsing of the ReaderState structure. We did not handle NULL szReader properly previously. Modified Paths: -------------- rdesktop/trunk/scard.c rdesktop/trunk/scard.h Modified: rdesktop/trunk/scard.c =================================================================== --- rdesktop/trunk/scard.c 2013-06-27 10:43:34 UTC (rev 1722) +++ rdesktop/trunk/scard.c 2013-07-05 11:44:03 UTC (rev 1723) @@ -1131,32 +1131,31 @@ if (!rsArray) return SC_returnNoMemoryError(&lcHandle, in, out); memset(rsArray, 0, dwCount * sizeof(SERVER_SCARD_READERSTATE_A)); - /* skip two pointers at beginning of struct */ - for (i = 0, cur = (SERVER_LPSCARD_READERSTATE_A) ((unsigned char **) rsArray + 2); - i < dwCount; i++, cur++) + for (i = 0, cur = rsArray; i < dwCount; i++, cur++) { - in->p += 0x04; - in_uint8a(in, cur, SERVER_SCARDSTATESIZE); + in_uint32_le(in, cur->szReader); + in_uint32_le(in, cur->dwCurrentState); + in_uint32_le(in, cur->dwEventState); + in_uint32_le(in, cur->cbAtr); + in_uint8a(in, cur->rgbAtr, sizeof(cur->rgbAtr)); } for (i = 0, cur = rsArray; i < dwCount; i++, cur++) { - SERVER_DWORD dataLength; + if (cur->szReader != NULL) + { + SERVER_DWORD dataLength; - /* Do endian swaps... */ - cur->dwCurrentState = swap32(cur->dwCurrentState); - cur->dwEventState = swap32(cur->dwEventState); - cur->cbAtr = swap32(cur->cbAtr); + in->p += 0x08; + in_uint32_le(in, dataLength); + inRepos(in, + inString(&lcHandle, in, (char **) &(cur->szReader), + dataLength, wide)); - in->p += 0x08; - in_uint32_le(in, dataLength); - inRepos(in, - inString(&lcHandle, in, (char **) &(cur->szReader), dataLength, - wide)); + if (strcmp(cur->szReader, "\\\\?PnP?\\Notification") == 0) + cur->dwCurrentState |= SCARD_STATE_IGNORE; + } - if (strcmp(cur->szReader, "\\\\?PnP?\\Notification") == 0) - cur->dwCurrentState |= SCARD_STATE_IGNORE; - DEBUG_SCARD(("SCARD: \"%s\"\n", cur->szReader ? cur->szReader : "NULL")); DEBUG_SCARD(("SCARD: user: %p, state: 0x%08x, event: 0x%08x\n", cur->pvUserData, (unsigned) cur->dwCurrentState, Modified: rdesktop/trunk/scard.h =================================================================== --- rdesktop/trunk/scard.h 2013-06-27 10:43:34 UTC (rev 1722) +++ rdesktop/trunk/scard.h 2013-07-05 11:44:03 UTC (rev 1723) @@ -59,7 +59,7 @@ SERVER_DWORD dwCurrentState; SERVER_DWORD dwEventState; SERVER_DWORD cbAtr; - unsigned char rgbAtr[MAX_ATR_SIZE]; + unsigned char rgbAtr[36]; } SERVER_SCARD_READERSTATE_A; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |