[rdesktop-devel] [ rdesktop-Patches-1339819 ] Clipboard: Unicode, XFixes, Obsolete PRIMARY

[SourceForge.net <no...@so...>]

Patches item #1339819, was opened at 2005-10-27 20:46
Message generated for change (Comment added) made by ikonst
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1339819&group_id=24366

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Ilya Konstantinov (ikonst)
Assigned to: Nobody/Anonymous (nobody)
Summary: Clipboard: Unicode, XFixes, Obsolete PRIMARY

Initial Comment:
This patch takes care of the following:
- Adds Unicode support, for both incoming and outgoing
clipboard data, as long as iconv is available.
- Adds XFixes support on new xorg servers, which allows
us to be notified about clipboard changes and provide
cleaner RDP support (RDP expects those notifications).
Of course, where it's not available, there's an
alternative code path.
- Stops using PRIMARY selection (the one that is
updated when you select text) in favor of CLIPBOARD
selection (the one you use explicitly with copy-paste
commands). Currently rdesktop is using both PRIMARY and
CLIPBOARD, which is confusing, non-standard (both GTK+
and Qt have clear separation between CLIPBOARD and
PRIMARY) and uncomfortable (you select a text you want
replaced with something in the clipboard, and the text
you selected replaces the clipboard text!). See
http://standards.freedesktop.org/clipboards-spec/clipboards-0.1.txt
for more info.
- No longer offer TEXT clipboard format, since we don't
support it properlty (according to the standard) so
better not try at all.

This patch adds the necessary autoconf magic to detect
and use Xfixes when available.

----------------------------------------------------------------------

>Comment By: Ilya Konstantinov (ikonst)
Date: 2005-11-03 11:45

Message:
Logged In: YES 
user_id=335423

When rdesktop acquires clipboard ownership, it can take
ownership of both.
When rdesktop requests clipboard data from somebody else,
should it check PRIMARY first or CLIPBOARD first? Logics say
it should check CLIPBOARD first, since all modern (=
non-xterm) X11 apps follow the FreeDesktop.org model of
clipboard behavior, as described here:
http://www.freedesktop.org/wiki/Standards_2fClipboardsWiki

----------------------------------------------------------------------

Comment By: Matt Chapman (matthewc)
Date: 2005-11-03 11:38

Message:
Logged In: YES 
user_id=60189

The one thing I'm not comfortable with is dropping PRIMARY
support.  X users are familiar with using middle-click to
paste.  A lot of X applications don't have easy or obvious
facilities to paste from CLIPBOARD - e.g. xterm, how does
one paste CLIPBOARD and not PRIMARY into xterm?  I didn't
even know about the CLIPBOARD selection before I started
writing X apps.

The fact is that most applications do end up using both
PRIMARY and CLIPBOARD, because even if you're going to use
explicit copy and paste, you have to select first. 
Unfortunately rdesktop doesn't know when the user selects
something in Windows, but at the time that the user does the
explicit copy, it can update both.

----------------------------------------------------------------------

Comment By: Ilya Konstantinov (ikonst)
Date: 2005-10-28 17:07

Message:
Logged In: YES 
user_id=335423

In its XFixes variant, the patch isn't all correct. A new
patch will follow soon.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1339819&group_id=24366