From: Beaumont, K. <Kev...@pr...> - 2005-04-15 19:29:42
|
Woah. Can anybody else verify this? I will patch and try here... If we can get compression working it'd be a HUGE plus some some (eg me). Ta Kevin -----Original Message----- From: rde...@li... [mailto:rde...@li...] On Behalf Of Vahur Sinij=E4rv Sent: 15 April 2005 20:19 To: rde...@li... Subject: [rdesktop-devel] 16 bpp compression Hi ! I've found a way how to reliably enable compression for 16bpp mode: Look at the code below from rdp.c: static void rdp_out_bmpcache2_caps(STREAM s) { =09out_uint16_le(s, RDP_CAPSET_BMPCACHE2); =09out_uint16_le(s, RDP_CAPLEN_BMPCACHE2); =09out_uint16_le(s, g_bitmap_cache_persist_enable ? 2 : 0); /* version */ =09out_uint16_le(s, 0x0200); /* flags? number of caches? */ =09out_uint32_le(s, BMPCACHE2_C0_CELLS); =09out_uint32_le(s, BMPCACHE2_C1_CELLS); =09if (pstcache_init(2)) =09{ =09 out_uint32_le(s, BMPCACHE2_NUM_PSTCELLS | BMPCACHE2_FLAG_PERSIST); =09} =09else =09{ =09 out_uint32_le(s, BMPCACHE2_C2_CELLS); =09} =09out_uint8s(s, 20); /* other bitmap caches not used */ } The line , which reads=20 =09out_uint16_le(s, 0x0200); /* flags? number of caches? */ The upper byte actually specifies maximum size of the bitmap cell to send= . 01=20 =3D 16x16, 02 =3D 32x32, 03 =3D 64x64, etc. log2(cell size) - 3. You can set it to maximum 32x32 for 16bpp and MPPC compression, because bigger=20 cells will overflow the MPPC history buffer. Performance suffers somewhat= =20 with smaller cells, you have to play with cache settings a bit. Also I've noticed that when you enable persistent bitmap cache, the bitma= ps=20 are not cached the first time, but instead on second. Try opening a start= =20 menu for example: first and second time it is slow, third time it's fast.= =20I=20 do not yet know what is causing this client or server ... Regards, Vahur ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=3D6595&alloc_id=3D14396&op=3Dclick _______________________________________________ rdesktop-devel mailing list rde...@li... https://lists.sourceforge.net/lists/listinfo/rdesktop-devel *************************************************************************= ************* The information contained in this e-mail is private and confidential, may= be legally privileged and/or protected by law and it is intended only for= the use of the addressee. Any liability (in negligence or otherwise) arising from any third party taking any action or refraining from taking any action on any of the information contained in this e-mail is hereby excluded. If you are not the intended recipient please notify the sender immediately. Do not disclose the contents to any other person store or copy the information in any medium or use it for any purpose whatsoever. Copyright in this e-mail and any attachment created by us belongs to this= company and we assert the right to be identified as such and object to an= y=20 misuse. Any contract concluded by means of e-mail communications is expressly concluded subject to Princes Limited's current standard terms and conditi= ons. A copy of these is available on request. *************************************************************************= ************* |