Re: [rdesktop-devel] Re: The "shortcuts don't work with caps lock on" bug, how much to fix?

[Santos <sa...@ca...>]

Michael Gernoth wrote:
> Hi,
> 
> On Thu, Jan 20, 2005 at 12:07:51PM +0000, cas wrote:
> 
>>I'm talking about the bugs:
>>http://sourceforge.net/tracker/index.php?func=detail&aid=1069927&group_id=24366&atid=381347
>>http://sourceforge.net/tracker/index.php?func=detail&aid=858618&group_id=24366&atid=381347
> 
> 
> please try the attached patch and see if it fixes your bug.
> I'll commit it to the cvs version, if it's working for you.
> 
> Regards,
>   Michael
> 
> 
> ------------------------------------------------------------------------
> 
> Index: xkeymap.c
> ===================================================================
> RCS file: /cvsroot/rdesktop/rdesktop/xkeymap.c,v
> retrieving revision 1.65
> diff -u -r1.65 xkeymap.c
> --- xkeymap.c	15 Jun 2004 22:17:08 -0000	1.65
> +++ xkeymap.c	20 Jan 2005 20:58:43 -0000
> @@ -408,6 +408,13 @@
>  		}
>  	}
>  
> +	if (((remote_modifier_state & MapLeftCtrlMask)
> +	     || (remote_modifier_state & MapRightCtrlMask)) && get_key_state(state, XK_Caps_Lock))
> +	{
> +		DEBUG_KBD(("CapsLock + CTRL pressed, releasing LeftShift\n"));
> +		tr.modifiers ^= MapLeftShiftMask;
> +	}
> +
>  	if (tr.scancode != 0)
>  	{
>  		DEBUG_KBD(("Found key translation, scancode=0x%x, modifiers=0x%x\n",


Yup, this fixes it, I tested shortcuts on explorer, IE, and firefox.
Many thanks for the fix. Nice to see quick responsiveness like this.


Regards,

Santos