[rdesktop-users] Class 2/3 smart card reader features not working with rdesktop & pcsclite ccid driver

[Elfi H. <EH...@in...>]

The changes from revisions 1595, 1597, 1598 don't work with the ccid driver from the pcsc-lite project. This driver uses control codes that overlap with the 49 << 16 used in Windows codes. In the output of GET_FEATURE_REQUEST these codes are translated to the Windows format. Then when using one of those codes, translation in the other direction is not done because the condition "(dwControlCode & 0xffff0000) == (49 << 16)" always results to false.

This might be fixed be adjusting the mask, but my opinion is that control codes returned by the reader driver should always be left alone, because only this way we can be sure that the driver will understand the codes sent back to it. Translating makes assumptions about the used bits that might not be valid.