[rdesktop-devel] Patch to improve smartcard handling on smartcard logon

[Rostislav K. <r.k...@ww...>]

Hello,
When using rdesktop with smartcard logon there are two issues.

1. When connecting to existing session server does not end the 
transaction taken for smartcard logon, sending Server Announce instead. 
Protocol specification directs client to drop all existing device 
references, witch should include releasing all smartcard contexts, 
effectively releasing all current transactions. Current version however 
does not release these contexts, blocking smartcard from any use for the 
rest of the session.

2. When calling SCardGetStatus change caller may ask for special reader 
"\\\\?PnP?\\Notification" that will effectively signal when new 
smartcard reader will appear. Support for this feature appeared in 
pcsc-lite v1.6.0 quite a while ago. Current version of rdesktop filters 
out this special reader name for compatibility with older versions of 
pcsc-lite and Apple fork of it. As a result if a reader was not plugged 
in at application startup, windows logon screen will not detect 
insertion of a new reader during logon screen and options for smartcard 
logon won't appear.

I have prepared a patch addressing these two issues. See attachment.

Rostislav Kondratenko.