#10 virtual transport, vacation.pl, css, behaviour, translation

[ichier]

Hi
i did some fixes to roundcube-vacation 1.9.9 and vacation.pl 4.0 a couple of days ago.
so in order not to do em again, on next update, i post em here.

what i did to vacation.pl is
- adding the possibility to optionally define a client, so mails sent by vacation.pl will pass the helo checks on my mailsetup - i used a whitelist for that. (you shouldnt whitelist localhost.localdomain :)

what i did to virtual.class.php is
- using the correct syntax for the virtual transport so that vacation.pl and postfix work correctly. the old syntax user@mail.tld@vacation.blah resulted in a lot of mails being sent, the "new" syntax with user#domain.tld@vacation.blah works fine.
- little template-change to fit with new roundcube css (functional only...)
- some fixes on the frontendbehaviour regarding the redirect-option - it now does, what its supposed to do (i dont remember what went wrong, several things on differently combined actions...)
- missing german phrases ;)

las but not least:
i highly prefer updating the 'goto' entry in the the transport-table rather than deleting the row and writing a new one, that way all the additional info in the table will be kept. also i wanted the entries of vacation_notification to be removed on update. so i did the following in my config.ini:
[CODE]
select_query = "SELECT goto FROM %m.alias WHERE address='%e' AND goto='%g'"

delete_query = "DELETE FROM %m.vacation_notification WHERE on_vacation='%e'"

insert_query = "UPDATE %m.alias SET goto='%g' WHERE domain='%d' AND address='%e'"
[/CODE]
in order of that i needed an additional check in the update-function, so that there is still teh original address left, when unsetting the vacation and having 'keep copy of message' deactivated ;)

the deletion of notification status should be optional maybe, but well, its ok sop far...

cheers, nïkö

ps: the vacation patch removes some lines that i didnt had in my version of vacation.pl 4.0 ... since i didnt see such time-functionality, i think that way its more correct

[ichier]

vacation.pl.diff

[ichier]

german translation

[ichier]

template-to fit roundcube 0.5

[ichier]

btw: sorry that i "ignored" the previous patches for the transport and template, but i just saw them today when submitting my patches, not when i did em... my fault ;)

keep up the good work!

[ichier]

virtual.class patch - working

[ichier]

hi, its me again. i stumbled across a dumb bug today in the original patch file when applying to another server... i didnt had the final version of the modified virtual-class on my local desktop. well now it's correct.