Menu ▾ ▴

#8 EPSILON definitions are inconsistent

open
nobody
graph, barchart, stripchart (1)
1
2009-10-19
2009-10-19
Bob Techentin
No

Several modules use FLT_EPSILON or DBL_EPSILON for comparisons, but the definitions are inconsistent. ActiveState suggested a patch to rbcGrMisc.c to re-define __FLT_EPSILON__ for certain platforms, including __sun, __hpux, _AIX, and WIN32. But FLT_EPSILON is used elsewhere, and DBL_EPSILON is just hardcoded in rbcMath.h. These definitions should be rationalized in a cross platform way.

Discussion

  • Bob Techentin

    Bob Techentin - 2009-10-19

    Fixed the definitions in rbcGrMisc.c by replacing __FLT_EPSILON__ with FLT_EPSILON, as was done in the original BLT code. This is portable. There still may be some inconsistent usage of FLT_EPSILON and DBL_EPSILON, but nothing requiring a portability hack.

     

  • Bob Techentin

    Bob Techentin - 2009-10-19
    • priority: 5 --> 1