Menu
▾
▴
razorbacktm-devel — Project Razorback Development
You can subscribe to this list here.
| 2010 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
(3) |
Aug
(70) |
Sep
(24) |
Oct
(6) |
Nov
(4) |
Dec
(6) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2011 |
Jan
(4) |
Feb
(19) |
Mar
(505) |
Apr
(407) |
May
(214) |
Jun
(307) |
Jul
(479) |
Aug
(209) |
Sep
(94) |
Oct
(454) |
Nov
(165) |
Dec
(36) |
| 2012 |
Jan
(384) |
Feb
(345) |
Mar
(14) |
Apr
(266) |
May
(11) |
Jun
(5) |
Jul
(2) |
Aug
|
Sep
(1) |
Oct
|
Nov
|
Dec
|
| 2013 |
Jan
|
Feb
(20) |
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: <tom...@us...> - 2013-02-08 04:05:50
|
Revision: 4017
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4017&view=rev
Author: tomjudge
Date: 2013-02-08 04:05:43 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Dont leak the message in the error case
Modified Paths:
--------------
api/trunk/src/messages/cnc/config_update.c
Modified: api/trunk/src/messages/cnc/config_update.c
===================================================================
--- api/trunk/src/messages/cnc/config_update.c 2013-02-08 04:03:15 UTC (rev 4016)
+++ api/trunk/src/messages/cnc/config_update.c 2013-02-08 04:05:43 UTC (rev 4017)
@@ -49,24 +49,23 @@
if ((msg = Message_Create_Directed(MESSAGE_TYPE_CONFIG_UPDATE, MESSAGE_VERSION_1, sizeof(struct MessageConfigurationUpdate), p_uuidSourceNugget, p_uuidDestNugget)) == NULL)
return NULL;
message = msg->message;
-
- if ((list = UUID_Get_List(UUID_TYPE_NTLV_TYPE)) == NULL)
- return false;
- if ((message->ntlvTypes= List_Clone(list)) == NULL)
- return false;
- if ((list = UUID_Get_List(UUID_TYPE_NTLV_NAME)) == NULL)
- return false;
- if ((message->ntlvNames= List_Clone(list)) == NULL)
- return false;
- if ((list = UUID_Get_List(UUID_TYPE_DATA_TYPE)) == NULL)
- return false;
- if ((message->dataTypes= List_Clone(list)) == NULL)
- return false;
-
-
msg->destroy = ConfigUpdate_Destroy;
msg->deserialize = ConfigUpdate_Deserialize;
msg->serialize = ConfigUpdate_Serialize;
+
+ if (
+ ((list = UUID_Get_List(UUID_TYPE_NTLV_TYPE)) == NULL) ||
+ ((message->ntlvTypes= List_Clone(list)) == NULL) ||
+ ((list = UUID_Get_List(UUID_TYPE_NTLV_NAME)) == NULL) ||
+ ((message->ntlvNames= List_Clone(list)) == NULL) ||
+ ((list = UUID_Get_List(UUID_TYPE_DATA_TYPE)) == NULL) ||
+ ((message->dataTypes= List_Clone(list)) == NULL) )
+ {
+ msg->destroy(msg);
+ return NULL;
+ }
+
+
return msg;
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 04:03:22
|
Revision: 4016
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4016&view=rev
Author: tomjudge
Date: 2013-02-08 04:03:15 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Don't leak the message in the error case
Modified Paths:
--------------
api/trunk/src/messages/cnc/error.c
Modified: api/trunk/src/messages/cnc/error.c
===================================================================
--- api/trunk/src/messages/cnc/error.c 2013-02-08 04:00:46 UTC (rev 4015)
+++ api/trunk/src/messages/cnc/error.c 2013-02-08 04:03:15 UTC (rev 4016)
@@ -53,6 +53,9 @@
if ((msg = Message_Create_Directed(p_iCode, MESSAGE_VERSION_1, sizeof(struct MessageError), p_uuidSourceNugget, p_uuidDestNugget)) == NULL)
return NULL;
message = msg->message;
+ msg->destroy = Error_Destroy;
+ msg->deserialize = Error_Deserialize;
+ msg->serialize = Error_Serialize;
if ((message->sMessage =
malloc (strlen ((const char *) p_sMessage) + 1)) == NULL)
@@ -60,13 +63,11 @@
Error_Destroy(msg);
rzb_log (LOG_ERR,
"%s: failed due to lack of memory", __func__);
+ msg->destroy(msg);
return NULL;
}
strcpy ((char *) message->sMessage,
(const char *) p_sMessage);
- msg->destroy = Error_Destroy;
- msg->deserialize = Error_Deserialize;
- msg->serialize = Error_Serialize;
return msg;
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 04:00:52
|
Revision: 4015
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4015&view=rev
Author: tomjudge
Date: 2013-02-08 04:00:46 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Fix memory leak in error case
Modified Paths:
--------------
api/trunk/src/messages/core.c
Modified: api/trunk/src/messages/core.c
===================================================================
--- api/trunk/src/messages/core.c 2013-02-08 03:59:49 UTC (rev 4014)
+++ api/trunk/src/messages/core.c 2013-02-08 04:00:46 UTC (rev 4015)
@@ -32,7 +32,10 @@
if (msgSize > 0)
{
if ((message->message = calloc(1,msgSize)) == NULL)
+ {
+ free(message);
return NULL;
+ }
}
message->headers = Message_Header_List_Create();
return message;
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:59:56
|
Revision: 4014
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4014&view=rev
Author: tomjudge
Date: 2013-02-08 03:59:49 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Don't leak the message if we fail to get the time
Modified Paths:
--------------
api/trunk/src/messages/output_inspection.c
Modified: api/trunk/src/messages/output_inspection.c
===================================================================
--- api/trunk/src/messages/output_inspection.c 2013-02-08 03:56:30 UTC (rev 4013)
+++ api/trunk/src/messages/output_inspection.c 2013-02-08 03:59:49 UTC (rev 4014)
@@ -56,19 +56,20 @@
message->status = reason;
message->final = final;
+ msg->destroy = OutputInspection_Destroy;
+ msg->deserialize=OutputInspection_Deserialize;
+ msg->serialize=OutputInspection_Serialize;
+
memset(&l_tsTime, 0, sizeof(struct timespec));
if (clock_gettime(CLOCK_REALTIME, &l_tsTime) == -1)
{
rzb_log(LOG_ERR, "%s: Failed to get time stamp", __func__);
+ Message_Destroy(msg);
return NULL;
}
message->seconds = l_tsTime.tv_sec;
message->nanosecs = l_tsTime.tv_nsec;
- msg->destroy = OutputInspection_Destroy;
- msg->deserialize=OutputInspection_Deserialize;
- msg->serialize=OutputInspection_Serialize;
-
return msg;
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:56:37
|
Revision: 4013
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4013&view=rev
Author: tomjudge
Date: 2013-02-08 03:56:30 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Fix memory leaks in error conditions
Modified Paths:
--------------
api/trunk/src/socket.c
Modified: api/trunk/src/socket.c
===================================================================
--- api/trunk/src/socket.c 2013-02-08 03:54:00 UTC (rev 4012)
+++ api/trunk/src/socket.c 2013-02-08 03:56:30 UTC (rev 4013)
@@ -210,11 +210,14 @@
if ((sock = (struct Socket *)calloc (1, sizeof (struct Socket))) == NULL)
{
rzb_log(LOG_ERR, "%s: Failed to allocate new socket", __func__);
+ free(server);
return NULL;
}
if ((sock->pAddressInfo = (struct addrinfo *)calloc(1,sizeof(struct addrinfo))) == NULL)
{
rzb_log(LOG_ERR, "%s: Failed to allocate new address info", __func__);
+ free(server);
+ free(sock);
return false;
}
@@ -331,6 +334,7 @@
{
rzb_log (LOG_ERR,
"%s: failed due to failure of SocketAddress_Initialize", __func__);
+ free(sock);
return NULL;
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:54:08
|
Revision: 4012
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4012&view=rev
Author: tomjudge
Date: 2013-02-08 03:54:00 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Fix memory leaks in error cases
Modified Paths:
--------------
api/trunk/src/queue.c
Modified: api/trunk/src/queue.c
===================================================================
--- api/trunk/src/queue.c 2013-02-08 03:51:29 UTC (rev 4011)
+++ api/trunk/src/queue.c 2013-02-08 03:54:00 UTC (rev 4012)
@@ -55,7 +55,6 @@
if ((message = (struct StompMessage *)calloc (1, sizeof (struct StompMessage))) == NULL)
{
rzb_log(LOG_ERR, "%s: Failed to allocate message struct", __func__);
- free(buffer);
return NULL;
}
message->headers= Message_Header_List_Create();
@@ -364,6 +363,7 @@
{
rzb_log (LOG_ERR,
"%s: failed due to failure of strncasecmp ( CONNECTED )", __func__);
+ Queue_Destroy_Stomp_Message(message);
return NULL;
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:51:35
|
Revision: 4011
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4011&view=rev
Author: tomjudge
Date: 2013-02-08 03:51:29 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Fix varargs cleanup in error cases
Modified Paths:
--------------
api/trunk/src/log.c
Modified: api/trunk/src/log.c
===================================================================
--- api/trunk/src/log.c 2013-02-08 03:48:37 UTC (rev 4010)
+++ api/trunk/src/log.c 2013-02-08 03:51:29 UTC (rev 4011)
@@ -72,7 +72,10 @@
if (log_dest != RZB_LOG_DEST_SYSLOG)
{
if (vasprintf (&msg, fmt, argp) == -1)
+ {
+ va_end (argp);
return;
+ }
}
switch (log_dest)
@@ -112,7 +115,10 @@
va_start (argp, fmt);
if (vasprintf (&msg, fmt, argp) == -1)
+ {
+ va_end (argp);
return;
+ }
va_end (argp);
l_pContext = Thread_GetCurrentContext ();
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:48:43
|
Revision: 4010
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4010&view=rev
Author: tomjudge
Date: 2013-02-08 03:48:37 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
* Protect List_Push with mode assertions.
* Don't leak the node when assertions are compiled out and and invalid list is passed in.
Modified Paths:
--------------
api/trunk/src/list.c
Modified: api/trunk/src/list.c
===================================================================
--- api/trunk/src/list.c 2013-02-08 03:43:24 UTC (rev 4009)
+++ api/trunk/src/list.c 2013-02-08 03:48:37 UTC (rev 4010)
@@ -82,6 +82,11 @@
{
struct ListNode *node;
ASSERT(list != NULL);
+ ASSERT(
+ (list->mode == LIST_MODE_GENERIC) ||
+ (list->mode == LIST_MODE_QUEUE) ||
+ (list->mode == LIST_MODE_STACK)
+ );
if (list == NULL)
return false;
if ((node = calloc(1, sizeof(struct ListNode))) == NULL)
@@ -97,7 +102,11 @@
case LIST_MODE_STACK:
List_Stack_Push(list, node);
break;
- }
+ default:
+ free(node);
+ Mutex_Unlock(list->lock);
+ return false;
+ }
list->length++;
Mutex_Unlock(list->lock);
if (list->sem != NULL)
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:43:30
|
Revision: 4009
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4009&view=rev
Author: tomjudge
Date: 2013-02-08 03:43:24 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Fix null pointer de-reference
Modified Paths:
--------------
api/trunk/src/json_buffer.c
Modified: api/trunk/src/json_buffer.c
===================================================================
--- api/trunk/src/json_buffer.c 2013-02-08 03:34:24 UTC (rev 4008)
+++ api/trunk/src/json_buffer.c 2013-02-08 03:43:24 UTC (rev 4009)
@@ -382,8 +382,15 @@
UUID_Get_UUID(NTLV_TYPE_STRING, UUID_TYPE_NTLV_TYPE, uuid);
if (uuid_compare(type, uuid) == 0)
+ {
+ if (str == NULL)
+ {
+ if (byteData != NULL)
+ free(byteData);
+ return false;
+ }
NTLVList_Add(list, name, type, strlen(str)+1, (uint8_t*)str);
-
+ }
UUID_Get_UUID(NTLV_TYPE_PORT, UUID_TYPE_NTLV_TYPE, uuid);
if (uuid_compare(type, uuid) == 0)
{
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:34:31
|
Revision: 4008
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4008&view=rev
Author: tomjudge
Date: 2013-02-08 03:34:24 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
* Fix hash string allocation size
* Fix memory leaks in error conditions.
Modified Paths:
--------------
api/trunk/src/hash.c
Modified: api/trunk/src/hash.c
===================================================================
--- api/trunk/src/hash.c 2013-02-08 03:31:54 UTC (rev 4007)
+++ api/trunk/src/hash.c 2013-02-08 03:34:24 UTC (rev 4008)
@@ -42,7 +42,7 @@
ASSERT (p_pHash != NULL);
ASSERT (p_pHash->iFlags & HASH_FLAG_FINAL);
- if ((l_sString = (char *)calloc((p_pHash->iSize * 2) + 1, sizeof(char *))) == NULL)
+ if ((l_sString = (char *)calloc((p_pHash->iSize * 2) + 1, sizeof(char))) == NULL)
{
rzb_log(LOG_ERR, "%s: Failed to allocate new string", __func__);
return NULL;
@@ -204,6 +204,7 @@
if ((p_pSource->iFlags & HASH_FLAG_FINAL) != HASH_FLAG_FINAL)
{
rzb_log(LOG_ERR, "%s: Can not copy a non finalized hash", __func__);
+ free(l_pDestination);
return NULL;
}
l_pDestination->iType = p_pSource->iType;
@@ -213,6 +214,7 @@
if ((l_pDestination->pData = (uint8_t *)malloc(p_pSource->iSize)) == NULL)
{
rzb_log(LOG_ERR, "%s: Failed to allocation new data: %i bytes", __func__, p_pSource->iSize);
+ free(l_pDestination);
return NULL;
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:32:01
|
Revision: 4007
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4007&view=rev
Author: tomjudge
Date: 2013-02-08 03:31:54 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Remove dead code
Modified Paths:
--------------
api/trunk/src/connected_entity.c
Modified: api/trunk/src/connected_entity.c
===================================================================
--- api/trunk/src/connected_entity.c 2013-02-08 03:28:34 UTC (rev 4006)
+++ api/trunk/src/connected_entity.c 2013-02-08 03:31:54 UTC (rev 4007)
@@ -512,8 +512,6 @@
if (uuid_compare(entity->uuidNuggetId, key->nuggetId) == 0)
ret = 0;
- else if (ret == 0)
- ret = -1;
}
if ((key->searchKeys & SEARCH_KEY_APP_TYPE) != 0)
{
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:28:40
|
Revision: 4006
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4006&view=rev
Author: tomjudge
Date: 2013-02-08 03:28:34 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Fix memory leaks in error cases
Modified Paths:
--------------
api/trunk/src/config_file.c
Modified: api/trunk/src/config_file.c
===================================================================
--- api/trunk/src/config_file.c 2013-02-08 03:27:41 UTC (rev 4005)
+++ api/trunk/src/config_file.c 2013-02-08 03:28:34 UTC (rev 4006)
@@ -224,6 +224,7 @@
if (!testFile (configfile))
{
free (configfile);
+ free(file);
return false;
}
if (config_read_file (&file->config, configfile) != CONFIG_TRUE)
@@ -518,8 +519,11 @@
for (conf_int_t i = 0; i < size; i++)
{
tmp = config_setting_get_string_elem(config, i);
- if (!(arrayConf->parseString (tmp, ints++)))
+ if (!(arrayConf->parseString (tmp, ints++)))
+ {
+ free(data);
return false;
+ }
}
}
@@ -554,6 +558,7 @@
else
{
rzb_log (LOG_ERR, "%s: Failed to parse bool: %s", __func__, tmp);
+ free(data);
return false;
}
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:27:47
|
Revision: 4005
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4005&view=rev
Author: tomjudge
Date: 2013-02-08 03:27:41 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Fix copy and paste error
Modified Paths:
--------------
api/trunk/src/block_id.c
Modified: api/trunk/src/block_id.c
===================================================================
--- api/trunk/src/block_id.c 2013-02-08 03:27:04 UTC (rev 4004)
+++ api/trunk/src/block_id.c 2013-02-08 03:27:41 UTC (rev 4005)
@@ -96,7 +96,7 @@
if ((dest->pHash = Hash_Clone (p_pSource->pHash)) == NULL)
{
rzb_log (LOG_ERR, "%s: failed due to failure of Hash_Clone", __func__);
- BlockId_Destroy(id);
+ BlockId_Destroy(dest);
return NULL;
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:27:11
|
Revision: 4004
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4004&view=rev
Author: tomjudge
Date: 2013-02-08 03:27:04 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Fix missing ;
Modified Paths:
--------------
api/trunk/src/block_pool.c
Modified: api/trunk/src/block_pool.c
===================================================================
--- api/trunk/src/block_pool.c 2013-02-08 03:23:07 UTC (rev 4003)
+++ api/trunk/src/block_pool.c 2013-02-08 03:27:04 UTC (rev 4004)
@@ -161,7 +161,7 @@
rzb_log(LOG_ERR, "%s: Block pool global size limit exceeded", __func__);
Mutex_Unlock(sg_sizeMutex);
free(dataBlock->data.fileName);
- free(dataBlock)
+ free(dataBlock);
return false;
}
sg_size +=sb.st_size;
@@ -177,7 +177,7 @@
sg_size -=sb.st_size;
Mutex_Unlock(sg_sizeMutex);
free(dataBlock->data.fileName);
- free(dataBlock)
+ free(dataBlock);
return false;
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:23:14
|
Revision: 4003
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4003&view=rev
Author: tomjudge
Date: 2013-02-08 03:23:07 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
* Don't leak data block or file name in error cases
* Don't leak the pool size lock in error case
Modified Paths:
--------------
api/trunk/src/block_pool.c
Modified: api/trunk/src/block_pool.c
===================================================================
--- api/trunk/src/block_pool.c 2013-02-08 03:18:55 UTC (rev 4002)
+++ api/trunk/src/block_pool.c 2013-02-08 03:23:07 UTC (rev 4003)
@@ -160,6 +160,8 @@
{
rzb_log(LOG_ERR, "%s: Block pool global size limit exceeded", __func__);
Mutex_Unlock(sg_sizeMutex);
+ free(dataBlock->data.fileName);
+ free(dataBlock)
return false;
}
sg_size +=sb.st_size;
@@ -174,6 +176,8 @@
Mutex_Lock(sg_sizeMutex);
sg_size -=sb.st_size;
Mutex_Unlock(sg_sizeMutex);
+ free(dataBlock->data.fileName);
+ free(dataBlock)
return false;
}
@@ -235,6 +239,7 @@
Config_getBlockPoolMaxSize()))
{
rzb_log(LOG_ERR, "%s: Block pool global size limit exceeded", __func__);
+ Mutex_Unlock(sg_sizeMutex);
List_Unlock(sg_bpList);
return false;
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:19:02
|
Revision: 4002
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4002&view=rev
Author: tomjudge
Date: 2013-02-08 03:18:55 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Fix memory leak, free block id upon hash creation faliure
Modified Paths:
--------------
api/trunk/src/block_id.c
Modified: api/trunk/src/block_id.c
===================================================================
--- api/trunk/src/block_id.c 2013-02-08 03:16:58 UTC (rev 4001)
+++ api/trunk/src/block_id.c 2013-02-08 03:18:55 UTC (rev 4002)
@@ -63,6 +63,7 @@
if ((id->pHash = Hash_Create()) == NULL)
{
rzb_log (LOG_ERR, "%s: failed due to lack of memory: Hash_Create", __func__);
+ BlockId_Destroy(id);
return NULL;
}
return id;
@@ -95,6 +96,7 @@
if ((dest->pHash = Hash_Clone (p_pSource->pHash)) == NULL)
{
rzb_log (LOG_ERR, "%s: failed due to failure of Hash_Clone", __func__);
+ BlockId_Destroy(id);
return NULL;
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:17:04
|
Revision: 4001
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4001&view=rev
Author: tomjudge
Date: 2013-02-08 03:16:58 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Fixes:
* Don't free NULL pointer
* Check return of UUID lookups rather than using invalid logic of checking array against NULL.
Modified Paths:
--------------
api/trunk/src/block.c
Modified: api/trunk/src/block.c
===================================================================
--- api/trunk/src/block.c 2013-02-08 03:12:50 UTC (rev 4000)
+++ api/trunk/src/block.c 2013-02-08 03:16:58 UTC (rev 4001)
@@ -63,7 +63,6 @@
if ((l_pDestination = calloc(1, sizeof (struct Block))) == NULL)
{
rzb_log(LOG_ERR, "%s: Failed to allocate new block", __func__);
- Block_Destroy (l_pDestination);
return NULL;
}
if ((l_pDestination->pId = BlockId_Clone (p_pSource->pId)) == NULL)
@@ -122,9 +121,8 @@
{
uuid_t uuidName;
uuid_t uuidType;
- UUID_Get_UUID(NTLV_NAME_FILENAME, UUID_TYPE_NTLV_NAME, uuidName);
- UUID_Get_UUID(NTLV_TYPE_STRING, UUID_TYPE_NTLV_TYPE, uuidType);
- if (uuidName == NULL || uuidType == NULL)
+ if ( (!UUID_Get_UUID(NTLV_NAME_FILENAME, UUID_TYPE_NTLV_NAME, uuidName)) ||
+ (!UUID_Get_UUID(NTLV_TYPE_STRING, UUID_TYPE_NTLV_TYPE, uuidType)))
{
rzb_log(LOG_ERR, "%s: Failed to lookup uuids", __func__);
return false;
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:12:58
|
Revision: 4000
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=4000&view=rev
Author: tomjudge
Date: 2013-02-08 03:12:50 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Fix more memory leaks
Modified Paths:
--------------
api/trunk/src/binary_buffer.c
Modified: api/trunk/src/binary_buffer.c
===================================================================
--- api/trunk/src/binary_buffer.c 2013-02-08 03:08:08 UTC (rev 3999)
+++ api/trunk/src/binary_buffer.c 2013-02-08 03:12:50 UTC (rev 4000)
@@ -1,6 +1,7 @@
#include "config.h"
#include <razorback/api.h>
#include <razorback/block.h>
+#include <razorback/block_id.h>
#include <razorback/debug.h>
#include <razorback/log.h>
#include <razorback/hash.h>
@@ -730,12 +731,14 @@
{
rzb_log (LOG_ERR,
"%s: failed due failure of BinaryBuffer_Get_UUID", __func__);
+ BlockId_Destroy(l_pId);
return false;
}
if (!BinaryBuffer_Get_uint64_t (p_pBuffer, &l_pId->iLength))
{
rzb_log (LOG_ERR,
"%s: failed due failure of BinaryBuffer_Get_uint64_t", __func__);
+ BlockId_Destroy(l_pId);
return false;
}
if (!BinaryBuffer_Get_Hash (p_pBuffer, &l_pId->pHash))
@@ -743,6 +746,7 @@
free (l_pId->pHash);
rzb_log (LOG_ERR,
"%s: failed due failure of BinaryBuffer_Get_Hash", __func__);
+ BlockId_Destroy(l_pId);
return false;
}
*p_pId = l_pId;
@@ -899,17 +903,20 @@
if (!BinaryBuffer_Get_UUID (p_pBuffer, eventId->uuidNuggetId))
{
rzb_log(LOG_ERR, "%s: Failed to get nugget id", __func__);
+ EventId_Destroy(eventId);
return false;
}
if (!BinaryBuffer_Get_uint64_t (p_pBuffer, &eventId->iSeconds))
{
rzb_log(LOG_ERR, "%s: Failed to get seconds", __func__);
+ EventId_Destroy(eventId);
return false;
}
if (!BinaryBuffer_Get_uint64_t (p_pBuffer, &eventId->iNanoSecs))
{
rzb_log(LOG_ERR, "%s: Failed to get nano seconds", __func__);
+ EventId_Destroy(eventId);
return false;
}
*p_pEventId = eventId;
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:08:14
|
Revision: 3999
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=3999&view=rev
Author: tomjudge
Date: 2013-02-08 03:08:08 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Fix memory leak CID:10098
Modified Paths:
--------------
api/trunk/src/binary_buffer.c
Modified: api/trunk/src/binary_buffer.c
===================================================================
--- api/trunk/src/binary_buffer.c 2013-02-08 03:01:14 UTC (rev 3998)
+++ api/trunk/src/binary_buffer.c 2013-02-08 03:08:08 UTC (rev 3999)
@@ -56,8 +56,11 @@
}
- if (p_iSize > (uint32_t) Config_getMaxBlockSize ())
+ if (p_iSize > (uint32_t) Config_getMaxBlockSize ())
+ {
+ free(l_pBuffer);
return NULL;
+ }
l_pBuffer->iLength = p_iSize;
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <tom...@us...> - 2013-02-08 03:01:22
|
Revision: 3998
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=3998&view=rev
Author: tomjudge
Date: 2013-02-08 03:01:14 +0000 (Fri, 08 Feb 2013)
Log Message:
-----------
Fix leak of error message structure CID:10133
Modified Paths:
--------------
api/trunk/src/messages/cnc/error.c
Modified: api/trunk/src/messages/cnc/error.c
===================================================================
--- api/trunk/src/messages/cnc/error.c 2012-06-21 15:14:03 UTC (rev 3997)
+++ api/trunk/src/messages/cnc/error.c 2013-02-08 03:01:14 UTC (rev 3998)
@@ -84,6 +84,7 @@
free(message->sMessage);
free(message);
+ Message_Destroy(msg);
}
bool
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: Tom J. <tj...@so...> - 2012-09-20 15:02:16
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Due to some changes that are happening at sourceforge.net we are migrating our bug tracking system to Bugzilla. All bugs that are currently in TRAC will be replicated into the Bugzilla instance at http://buzilla.clamav.net/. Once a bug in TRAC has been migrated it will be closed as invalid with a link to the new bug in Bugzilla. Thanks Tom Judge PS. The aforementioned changes are the discontinuing of hosted apps. - -- Senior Research Engineer Sourcefire Vulnerability Research Team -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (Darwin) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBAgAGBQJQWy/qAAoJEEJSM9yB4iIW/eEIAJWUsZ3Yx6oFvj0oDESBD8k+ KejmRb7siCPtd1/OlQ/2h+7YVoVOGGdU0SOng0IXi2UXyUMeYg52+v8Wh4X5y5w5 bjEawpAl4JIyDhhhhxgSK+X9lb7OHFsGda0LkBoaq5JJrTfQj1zEuwa7mgRlmppH g8rrNlvk0XFA6uLVHYDPrI9sftIpxe0FI3zBDMcWB3ihwSv1FaLPZQZlrFwoG4ma e4ZpGiUYDRL5HwrXrIgUMJaqAOP/x7h1NjgoDCtm+dHme05zxe+yeuYLtT3v/VrA stV4bAGZL0/8oL9Fztg1FHXz3zNvdwLS5L7DENDQCQ2zmweTzhTG7NWtNpwU7fQ= =+Nmj -----END PGP SIGNATURE----- |
|
From: Tom J. <to...@to...> - 2012-07-31 20:34:16
|
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
Unfortunately the razorback development team does not maintain the
razorback code in the official snort releases. As such an official
snort release is not usable with razorback, you need to use the
version we ship from sourceforge. We are working to address this
issue in future snort releases.
Thanks for letting us know about this issue.
Tom
On 17/07/2012 12:20, William Parker wrote:
> Hi Guys,
>
> I was reviewing the code for malloc and calloc issues, and found a
> potentially serious problem in directory
> 'src/dynamic-preprocessors/rzb_saac', file 'rzb_http-client.c',
> function 'ProcessFromClient' at lines 195-200 where variable
> 'fileinfo' is assigned a function call to calloc(), but in the
> current 2.9.3 RC code (to be sure, I unpacked the currently
> available tarball), there is NO check done for it being equal to
> NULL, which means the allocation of memory failed.
>
> Here is the code in the patch file (which i'm attaching to this
> email):
>
> bill@odie:~> cat rzb_http-client.c.patch --- rzb_http-client.c.orig
> 2012-07-16 15:51:39.323972430 -0700 +++ rzb_http-client.c
> 2012-07-16 21:53:43.965742968 -0700 @@ -174,7 +174,7 @@
> if(!ruledata) { DEBUGOUT((D_CLIENT | D_DEBUG),
> printf("ProcessFromClient: adding new rule data\n")); ruledata =
> calloc(1, sizeof(RULEDATA)); - if(!ruledata) { +
> if(ruledata == NULL) { DEBUGOUT(D_CRITICAL,
> printf("ProcessFromClient: ruledata malloc failed\n"));
> return(-1); } @@ -194,6 +194,11 @@
>
> fileinfo = calloc(1, sizeof(FILEINFO));
>
> + if (fileinfo == NULL) { /* calloc() failed */ +
> DEBUGOUT(D_CRITICAL, printf("ProcessFromClient: fileinfo malloc
> failed\n"); + return(-1); + } + // Set all counts and sizes
> to 0, all strings to empty, and pointers to NULL //
> memset(fileinfo, '\0', sizeof(FILEINFO)); Let me know if this fixes
> the potential bug/issue in 'rzb_http-client.c' (since it appears to
> be the only calloc() call I found without a check against NULL).
>
> Bill Parker
>
>
>
> ------------------------------------------------------------------------------
>
>
Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond.
> Discussions will include endpoint security, mobile security and the
> latest in malware threats.
> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>
>
>
> _______________________________________________ Razorbacktm-devel
> mailing list Raz...@li...
> https://lists.sourceforge.net/lists/listinfo/razorbacktm-devel
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJQGDpZAAoJEEJSM9yB4iIWacQH+QHVq3wFZfsa1itgQYP3DI7p
ghxPqVCWSWR4I4Srknrnr1b0JI2BRG6uphKLK+MuWNin9QY93Odyji8dVumsuLUl
Cn13Kc1UYKKJ9WY9je5DlqzotYW6bJXEAc7sr8fstD6QyReIxXiEUrnI7rSyOxtQ
Yd2CyxBtcgt/S8FtjiLUV1LHZzcrl/7iaj4oPu6TllZ6c4QsGQuYxVpxX9bjS0sT
vyB32HttqmvUuTWrytdGZFhEKkEPNsp+5BKH/V1TvxshHiJk97OEMhfI5RFnJBRi
6QQBtbpwPwrAZFEBaZip07Vj45mAjZGtAPqF1t9KHDTG6RpuKKGwEfcWvvrHdaI=
=hH/x
-----END PGP SIGNATURE-----
|
|
From: William P. <wp...@gm...> - 2012-07-17 16:20:45
|
Hi Guys,
I was reviewing the code for malloc and calloc issues, and
found a potentially serious problem in directory
'src/dynamic-preprocessors/rzb_saac', file 'rzb_http-client.c',
function 'ProcessFromClient' at lines 195-200 where variable
'fileinfo' is assigned a function call to calloc(), but in the
current 2.9.3 RC code (to be sure, I unpacked the currently
available tarball), there is NO check done for it being equal
to NULL, which means the allocation of memory failed.
Here is the code in the patch file (which i'm attaching to
this email):
bill@odie:~> cat rzb_http-client.c.patch
--- rzb_http-client.c.orig 2012-07-16 15:51:39.323972430 -0700
+++ rzb_http-client.c 2012-07-16 21:53:43.965742968 -0700
@@ -174,7 +174,7 @@
if(!ruledata) {
DEBUGOUT((D_CLIENT | D_DEBUG), printf("ProcessFromClient: adding new
rule data\n"));
ruledata = calloc(1, sizeof(RULEDATA));
- if(!ruledata) {
+ if(ruledata == NULL) {
DEBUGOUT(D_CRITICAL, printf("ProcessFromClient: ruledata malloc
failed\n"));
return(-1);
}
@@ -194,6 +194,11 @@
fileinfo = calloc(1, sizeof(FILEINFO));
+ if (fileinfo == NULL) { /* calloc() failed */
+ DEBUGOUT(D_CRITICAL, printf("ProcessFromClient: fileinfo malloc
failed\n");
+ return(-1);
+ }
+
// Set all counts and sizes to 0, all strings to empty, and pointers to
NULL
// memset(fileinfo, '\0', sizeof(FILEINFO));
Let me know if this fixes the potential bug/issue in 'rzb_http-client.c'
(since it appears to be the only calloc() call I found without a check
against NULL).
Bill Parker
|
|
From: <kp...@us...> - 2012-06-21 15:14:09
|
Revision: 3997
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=3997&view=rev
Author: kpyke
Date: 2012-06-21 15:14:03 +0000 (Thu, 21 Jun 2012)
Log Message:
-----------
Fix double free.
Modified Paths:
--------------
nuggets/clamavNugget/trunk/src/ClamAVNugget.c
Modified: nuggets/clamavNugget/trunk/src/ClamAVNugget.c
===================================================================
--- nuggets/clamavNugget/trunk/src/ClamAVNugget.c 2012-06-20 21:08:57 UTC (rev 3996)
+++ nuggets/clamavNugget/trunk/src/ClamAVNugget.c 2012-06-21 15:14:03 UTC (rev 3997)
@@ -210,7 +210,6 @@
Mutex_Destroy(con->mutex);
Socket_Close(con->socket);
free(con);
- free(con);
return false;
}
*threadData = con;
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
|
From: <the...@us...> - 2012-06-20 21:09:03
|
Revision: 3996
http://razorbacktm.svn.sourceforge.net/razorbacktm/?rev=3996&view=rev
Author: thekappa
Date: 2012-06-20 21:08:57 +0000 (Wed, 20 Jun 2012)
Log Message:
-----------
Various bug fixes
Modified Paths:
--------------
nuggets/pdfFox/trunk/src/foxdecode.c
nuggets/pdfFox/trunk/src/foxdetect.c
nuggets/pdfFox/trunk/src/foxjsutil.c
nuggets/pdfFox/trunk/src/foxparse.c
Modified: nuggets/pdfFox/trunk/src/foxdecode.c
===================================================================
--- nuggets/pdfFox/trunk/src/foxdecode.c 2012-06-20 20:18:25 UTC (rev 3995)
+++ nuggets/pdfFox/trunk/src/foxdecode.c 2012-06-20 21:08:57 UTC (rev 3996)
@@ -136,6 +136,7 @@
//ret = Z_DATA_ERROR;
(void)inflateEnd(&strm);
foxLog(NONFATAL, "%s: Z_NEED_DICT ERROR\n", __func__);
+ return;
case Z_DATA_ERROR:
(void)inflateEnd(&strm);
/*FILE *file;
Modified: nuggets/pdfFox/trunk/src/foxdetect.c
===================================================================
--- nuggets/pdfFox/trunk/src/foxdetect.c 2012-06-20 20:18:25 UTC (rev 3995)
+++ nuggets/pdfFox/trunk/src/foxdetect.c 2012-06-20 21:08:57 UTC (rev 3996)
@@ -380,7 +380,7 @@
if (DParams->predictor <= 1)
return;
- result = (uint64_t)(DParams->columns * DParams->bitspercomp);
+ result = (uint64_t)DParams->columns * DParams->bitspercomp;
if (result > 0xffffffff) {
foxReport("Adobe Acrobat and Adobe Reader FlateDecode Integer Overflow", "CVE-2009-1856", 12, 2, 0, 2);
Modified: nuggets/pdfFox/trunk/src/foxjsutil.c
===================================================================
--- nuggets/pdfFox/trunk/src/foxjsutil.c 2012-06-20 20:18:25 UTC (rev 3995)
+++ nuggets/pdfFox/trunk/src/foxjsutil.c 2012-06-20 21:08:57 UTC (rev 3996)
@@ -32,7 +32,7 @@
list->count = 0;
- if ((list->vector = (char **)calloc(JSARG_VECTOR_INIT_SIZE, sizeof(char **))) == NULL) {
+ if ((list->vector = (char **)calloc(JSARG_VECTOR_INIT_SIZE, sizeof(char *))) == NULL) {
foxLog(FATAL, "%s: Calloc failure.\n", __func__);
free(list);
return NULL;
@@ -47,6 +47,10 @@
*/
void destroyJSArgList (JSArgList *list) {
int i;
+
+ if (list == NULL)
+ return;
+
for (i = 0; i < list->count; i++) {
if (list->vector[i] != NULL)
free(list->vector[i]);
Modified: nuggets/pdfFox/trunk/src/foxparse.c
===================================================================
--- nuggets/pdfFox/trunk/src/foxparse.c 2012-06-20 20:18:25 UTC (rev 3995)
+++ nuggets/pdfFox/trunk/src/foxparse.c 2012-06-20 21:08:57 UTC (rev 3996)
@@ -66,6 +66,8 @@
ObjTableEntry *entry;
node = getNewNode();
+ if (node == NULL)
+ return NULL;
temp = node;
while ((entry = getNextUnresolved())) {
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
2 messages has been excluded from this view by a project administrator.
