From: Martin R. <ma...@MP...> - 2004-10-12 12:21:24
|
Hi! >>In any case, we could replace the >>#ifdef _MSC_VER >>lines in config.h with something like >>#ifdef WIN32 >>and the problem should go away. > > > I wouldn't do that. MSC++7.1 can cope with the new templates to select > the right types. That's good news! > With the endianess tester we could use the standard > mechanism > for Windows as well and just have some other specialities (min, max etc). > Moreover, I'm not sure what will happen on 64bit Windows, probably the > defines are wrong there. > Compile time checks are better... Certainly. > >>Completely apart from that: I have written binary stream classes which > > take > >>the endianness as a constructor argument, not as template parameter. >>I'll check them in later today. > > > Nice. So I can leave my endianess test class? Yes. > Something different: How do you create patches? I did a test yesterday and > I was not able to apply the patch. What I did was > >>cvs diff -u config\config.h programs\teapot.cxx utils\twister.h > > in the raypp directory. > Then I wanted to apply the patch (on my laptop) using > patch -u -i mypatch.txt > but that didn't work. First it did not find the files (although when typing > them > manually they were found) and then all changes were rejected. > I did all that on the Windows platform, so it could be wrong/non-working/ > incompatible versions of diff/patch but I want to make sure I do not have > a general problem there. > Any ideas? What you did sounds correct. I don't use diff and patch very often, because I can access CVS from all my machines, so I don't have much experience. If you can send me the patch, I can try to find out what's wrong. Cheers, Martin |