From: Martin R. <ma...@MP...> - 2004-10-11 11:45:27
|
Hi Andreas, I just noticed your checkins from last night. It seems that the triangle mesh is progressing, that's good to know! I tried to compile the code on Linux, and have a few comments: - I would love to remove the configure test for endianness and replace it with a class like you did, but unfortunately this breaks the binary stream classes (kernel/bstream.h) in the respect that you can no longer write bistream<file_is_lsb> inputfile("foo.bin"); This only works if "file_is_lsb" is a compile-time constant, and this can only be done as long as we use a configure mechanism. If we could do it via expression templates (like we do with the datatypes) that would work, but I don't know how to do that. - In trianglemesh.cxx a function filelength() is called, which does not exist on Linux. We will have to find something more portable. - TRIANGLE_MESH::All_Intersections() appears to return only the first intersection with the mesh. TRIANGLE_MESH::Load3DS() might be a good candidate for using the bistream class. (I expect that the 3DS files are always little-endian, so they have to be swapped on a big-endian machine). Cheers, Martin |