Thread: RE: [Rainbowportal-devel] help
Brought to you by:
danijel_kecman,
manudea
From: Hongwei S. <hs...@oc...> - 2005-06-24 18:39:51
|
Hello, Rainbow management, I just developed a new functionality for HtmlDocument module to allow editor or approver to compare the staging content with the production content while working in workflow mode. If you think this functionality is useful, please give me check-in permission to submit the code. For you to evaluate it, I enclosed all the necessary files needed to test the functionality. Among them: 1. Rainbow.MergeEngine.dll, inside this class library, I first parse the html strings into English words collection with html tags retained but not compared, and then implement the algorithm proposed by Eugene W. Myers (http://www.si.xmailserver.org/diff2.pdf it is also the algorithm of Unix Diff) to compare the two words collections word-wisely (not character wise). I plan to put the class library project under the Extension repository. For testing, just save the enclosed dll file to Rainbow/bin directory. Since I need a little bit more time to do clean-up, the source code is not enclosed at this time. 2. PortalModuleControl.cs. Implementing the compare functionality doesn't need to modify this file; however, there are two bugs in the file that are triggered by my code. I fixed them and please read the comment inside the code for details. For your convenience, the modified locations are: a) Started from line 680 inside OnLoad=20 b) Started from line 2933 inside protected void RevertToProductionContent (object sender, EventArgs e) 3. HtmlModule.ascx.cs the functionality is implemented here. Modification is inside the region "support for version comparison" and at line 268 to turn on ViewState 4. Put the icon files in the themes/icon directory. Note: All the files and test are based on Rainbow 15 Release, not on the development version on CVS or SVN! If you have any question, I can be reached by Hon...@gm... during the weekend. My sincere thanks to Matt Cowan, he pushed this work and did lots of testing. Hongwei |
From: Hongwei S. <hs...@oc...> - 2005-06-27 13:01:53
|
The bug I mentioned in my previous email (the bug started from line 2933 inside protected void RevertToProductionContent(object sender, EventArgs e) ) can be shown up on Rainbow 15 Release as follow: 1. Add a new Html Document module into a page 2. Change the setting of the module into support workflow 3. Edit the content by clicking edit button and apply the changes 4. Click revert button to roll back 5. Until now everything looks just fine, but if you click the buttons of the module again, an error shows up. When the error happens, the address is like the following one: http://localhost/rainbow/DesktopDefault.aspx?tabid=3D489wversion3001%3dSt= a ging&wversion3001=3DStaging The "tabid=3D489wversion3001%3dStaging" is caused by the bug I = mentioned. In other words, when constructing the address, '&' between each key-value pairs is forgotten. Hongwei |
From: Emmanuele De A. <ma...@gm...> - 2005-06-28 11:42:56
|
Do you have submitted a fix for this? Manu On 6/27/05, Hongwei Shen <hs...@oc...> wrote: > The bug I mentioned in my previous email (the bug started from line 2933 > inside protected void RevertToProductionContent(object sender, EventArgs > e) ) can be shown up on Rainbow 15 Release as follow: >=20 > 1. Add a new Html Document module into a page > 2. Change the setting of the module into support workflow > 3. Edit the content by clicking edit button and apply the changes > 4. Click revert button to roll back > 5. Until now everything looks just fine, but if you click the buttons of > the module again, an error shows up. When the error happens, the address > is like the following one: > http://localhost/rainbow/DesktopDefault.aspx?tabid=3D489wversion3001%3dSt= a > ging&wversion3001=3DStaging >=20 > The "tabid=3D489wversion3001%3dStaging" is caused by the bug I mentioned. > In other words, when constructing the address, '&' between each > key-value pairs is forgotten. >=20 > Hongwei >=20 >=20 >=20 > ------------------------------------------------------- > SF.Net email is sponsored by: Discover Easy Linux Migration Strategies > from IBM. Find simple to follow Roadmaps, straightforward articles, > informative Webcasts and more! Get everything you need to get up to > speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id=16492&opclick > _______________________________________________ > Rainbowportal-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rainbowportal-devel > |
From: Emmanuele De A. <ma...@gm...> - 2005-06-28 11:46:38
|
I have reported here: http://support.rainbowportal.net/jira/browse/RBP-709 On 6/28/05, Emmanuele De Andreis <ma...@gm...> wrote: > Do you have submitted a fix for this? > Manu >=20 > On 6/27/05, Hongwei Shen <hs...@oc...> wrote: > > The bug I mentioned in my previous email (the bug started from line 293= 3 > > inside protected void RevertToProductionContent(object sender, EventArg= s > > e) ) can be shown up on Rainbow 15 |
From: Hongwei S. <hs...@oc...> - 2005-06-28 12:35:20
|
Yes, in my email of last Friday, I fixed the bug in the file of PortalModuleCOntrol.cs. I did not realize that you have reported the bug. Sorry for that.=20 Hongwei -----Original Message----- From: Emmanuele De Andreis [mailto:ma...@gm...]=20 Sent: Tuesday, June 28, 2005 7:43 AM To: rai...@li... Subject: Re: [Rainbowportal-devel] help Do you have submitted a fix for this? Manu On 6/27/05, Hongwei Shen <hs...@oc...> wrote: > The bug I mentioned in my previous email (the bug started from line 2933 > inside protected void RevertToProductionContent(object sender, EventArgs > e) ) can be shown up on Rainbow 15 Release as follow: >=20 > 1. Add a new Html Document module into a page > 2. Change the setting of the module into support workflow > 3. Edit the content by clicking edit button and apply the changes > 4. Click revert button to roll back > 5. Until now everything looks just fine, but if you click the buttons of > the module again, an error shows up. When the error happens, the address > is like the following one: > http://localhost/rainbow/DesktopDefault.aspx?tabid=3D489wversion3001%3dSt= a > ging&wversion3001=3DStaging >=20 > The "tabid=3D489wversion3001%3dStaging" is caused by the bug I mentioned. > In other words, when constructing the address, '&' between each > key-value pairs is forgotten. >=20 > Hongwei >=20 >=20 >=20 > ------------------------------------------------------- > SF.Net email is sponsored by: Discover Easy Linux Migration Strategies > from IBM. Find simple to follow Roadmaps, straightforward articles, > informative Webcasts and more! Get everything you need to get up to > speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id=16492&opclick > _______________________________________________ > Rainbowportal-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rainbowportal-devel > ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id=16492&op=3Dick _______________________________________________ Rainbowportal-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rainbowportal-devel |
From: Hongwei S. <hs...@oc...> - 2005-06-28 18:00:42
|
It seems that Jira is not working today. Hongwei -----Original Message----- From: Emmanuele De Andreis [mailto:ma...@gm...]=20 Sent: Tuesday, June 28, 2005 7:47 AM To: rai...@li... Subject: Re: [Rainbowportal-devel] help I have reported here: http://support.rainbowportal.net/jira/browse/RBP-709 On 6/28/05, Emmanuele De Andreis <ma...@gm...> wrote: > Do you have submitted a fix for this? > Manu >=20 > On 6/27/05, Hongwei Shen <hs...@oc...> wrote: > > The bug I mentioned in my previous email (the bug started from line 2933 > > inside protected void RevertToProductionContent(object sender, EventArgs > > e) ) can be shown up on Rainbow 15 ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id=16492&op=3Dick _______________________________________________ Rainbowportal-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rainbowportal-devel |
From: Emmanuele De A. <ma...@gm...> - 2005-06-29 09:26:58
|
support is up now.... anyway i do not see your changes and i do not see any evidence on history..= . where did you fixed it? Manu On 6/28/05, Hongwei Shen <hs...@oc...> wrote: > It seems that Jira is not working today. >=20 > Hongwei > -----Original Message----- > From: Emmanuele De Andreis [mailto:ma...@gm...] > Sent: Tuesday, June 28, 2005 7:47 AM > To: rai...@li... > Subject: Re: [Rainbowportal-devel] help >=20 > I have reported here: > http://support.rainbowportal.net/jira/browse/RBP-709 >=20 > On 6/28/05, Emmanuele De Andreis <ma...@gm...> wrote: > > Do you have submitted a fix for this? > > Manu > > > > On 6/27/05, Hongwei Shen <hs...@oc...> wrote: > > > The bug I mentioned in my previous email (the bug started from line > 2933 > > > inside protected void RevertToProductionContent(object sender, > EventArgs > > > e) ) can be shown up on Rainbow 15 >=20 >=20 > ------------------------------------------------------- > SF.Net email is sponsored by: Discover Easy Linux Migration Strategies > from IBM. Find simple to follow Roadmaps, straightforward articles, > informative Webcasts and more! Get everything you need to get up to > speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id=16492&op=3Dick > _______________________________________________ > Rainbowportal-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rainbowportal-devel >=20 >=20 >=20 > ------------------------------------------------------- > SF.Net email is sponsored by: Discover Easy Linux Migration Strategies > from IBM. Find simple to follow Roadmaps, straightforward articles, > informative Webcasts and more! Get everything you need to get up to > speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id=16492&opclick > _______________________________________________ > Rainbowportal-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rainbowportal-devel > |
From: Hongwei S. <hs...@oc...> - 2005-06-29 12:42:57
|
I don't have commit permission right now, so I attached the files with the email of last Friday. I hope that I can be given commit permission so that I can commit the changes to PortalModuleControl.cs as well as the the Version Compare functionality. =20 Hongwei -----Original Message----- From: Emmanuele De Andreis [mailto:ma...@gm...]=20 Sent: Wednesday, June 29, 2005 5:27 AM To: rai...@li... Subject: Re: [Rainbowportal-devel] help support is up now.... anyway i do not see your changes and i do not see any evidence on history... where did you fixed it? Manu On 6/28/05, Hongwei Shen <hs...@oc...> wrote: > It seems that Jira is not working today. >=20 > Hongwei > -----Original Message----- > From: Emmanuele De Andreis [mailto:ma...@gm...] > Sent: Tuesday, June 28, 2005 7:47 AM > To: rai...@li... > Subject: Re: [Rainbowportal-devel] help >=20 > I have reported here: > http://support.rainbowportal.net/jira/browse/RBP-709 >=20 > On 6/28/05, Emmanuele De Andreis <ma...@gm...> wrote: > > Do you have submitted a fix for this? > > Manu > > > > On 6/27/05, Hongwei Shen <hs...@oc...> wrote: > > > The bug I mentioned in my previous email (the bug started from line > 2933 > > > inside protected void RevertToProductionContent(object sender, > EventArgs > > > e) ) can be shown up on Rainbow 15 >=20 >=20 > ------------------------------------------------------- > SF.Net email is sponsored by: Discover Easy Linux Migration Strategies > from IBM. Find simple to follow Roadmaps, straightforward articles, > informative Webcasts and more! Get everything you need to get up to > speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id=16492&op=3Dick > _______________________________________________ > Rainbowportal-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rainbowportal-devel >=20 >=20 >=20 > ------------------------------------------------------- > SF.Net email is sponsored by: Discover Easy Linux Migration Strategies > from IBM. Find simple to follow Roadmaps, straightforward articles, > informative Webcasts and more! Get everything you need to get up to > speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id=16492&opclick > _______________________________________________ > Rainbowportal-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rainbowportal-devel > ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id=16492&op=3Dick _______________________________________________ Rainbowportal-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rainbowportal-devel |