rails-devel

[Rails-devel] 1856 in Rails 1.0.7-rc4

[Aliza P. <ali...@gm...>]

Twice today I've gone through the private auction (6-player ) and then
not been able to buy into companies.  I never saw this on rc2 or rc3;
what might I be doing wrong? Saving and reloading did not help.

Windows XP, Java 1.6.0_15

Re: [Rails-devel] 1856 in Rails 1.0.7-rc4

[Erik V. <eri...@xs...>]

Thanks for the report. 
I have never tested 6 players, but indeed this seems to go wrong.
I'll check it out later.
Erik.

> -----Original Message-----
> From: Aliza Panitz [mailto:ali...@gm...] 
> Sent: Monday 07 December 2009 01:06
> To: rai...@li...
> Subject: [Rails-devel] 1856 in Rails 1.0.7-rc4
> 
> Twice today I've gone through the private auction (6-player ) and then
> not been able to buy into companies.  I never saw this on rc2 or rc3;
> what might I be doing wrong? Saving and reloading did not help.
> 
> Windows XP, Java 1.6.0_15
> 
> --------------------------------------------------------------
> ----------------
> Join us December 9, 2009 for the Red Hat Virtual Experience,
> a free event focused on virtualization and cloud computing. 
> Attend in-depth sessions from your desk. Your couch. Anywhere.
> http://p.sf.net/sfu/redhat-sfdev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] 1856 in Rails 1.0.7-rc4

[Erik V. <eri...@xs...>]

> > Twice today I've gone through the private auction (6-player 
> ) and then
> > not been able to buy into companies.  I never saw this on 
> rc2 or rc3;
> > what might I be doing wrong? Saving and reloading did not help.

This problem is not related to the number of players, 
but occurs if only one bid has been placed on the
final private company, and no further player action
is needed to complete buying that private.

I recently removed a case of duplicate execution of 
some code in that area, but that removal has had this
adverse effect. The whole private auction process 
turned out to be insufficiently adapted to a code 
restructuring quite a long time ago.

I have fixed it, and the structure now looks better too.

More changes of today:

- Fixed 18Kaas, which would not load because the private
company specifications missed a mandatory attribute,
added in the past.

- Implemented Feature request #2906917: Display hex coordinates
The maps now show grid coordinates at all sides of the map.
It was implemented a bit quick and dirty, it's not perfect
and not entirely scalable yet, but I hope it will do for now.

- Implemented Feature Request #2904703: Display cost of trains
A line has been added below the available trains in GameStatus,
specifying the cost of all trains. This display is fixed and 
will not shorten during the game.

In a game like 1835 the cost string grows pretty long, 
considerably widening the whole window. We should probably split 
the string over two lines in such cases.

- FR #2904695: Add merger tokens in 18EU to Report Window
This had in fact already been done in one of yesterday's fixes.

Erik.

Re: [Rails-devel] 1856 in Rails 1.0.7-rc4

[brett l. <wak...@gm...>]

Erik -

Do you want more testing, or should we just call this release "done"
and ship 1.0.7?

I'm thinking we're probably at a "good enough" state, and ready to
move any further fixes to 1.0.8.  What do you think?

---Brett.



On Tue, Dec 8, 2009 at 11:52 AM, Erik Vos <eri...@xs...> wrote:
>> > Twice today I've gone through the private auction (6-player
>> ) and then
>> > not been able to buy into companies.  I never saw this on
>> rc2 or rc3;
>> > what might I be doing wrong? Saving and reloading did not help.
>
> This problem is not related to the number of players,
> but occurs if only one bid has been placed on the
> final private company, and no further player action
> is needed to complete buying that private.
>
> I recently removed a case of duplicate execution of
> some code in that area, but that removal has had this
> adverse effect. The whole private auction process
> turned out to be insufficiently adapted to a code
> restructuring quite a long time ago.
>
> I have fixed it, and the structure now looks better too.
>
> More changes of today:
>
> - Fixed 18Kaas, which would not load because the private
> company specifications missed a mandatory attribute,
> added in the past.
>
> - Implemented Feature request #2906917: Display hex coordinates
> The maps now show grid coordinates at all sides of the map.
> It was implemented a bit quick and dirty, it's not perfect
> and not entirely scalable yet, but I hope it will do for now.
>
> - Implemented Feature Request #2904703: Display cost of trains
> A line has been added below the available trains in GameStatus,
> specifying the cost of all trains. This display is fixed and
> will not shorten during the game.
>
> In a game like 1835 the cost string grows pretty long,
> considerably widening the whole window. We should probably split
> the string over two lines in such cases.
>
> - FR #2904695: Add merger tokens in 18EU to Report Window
> This had in fact already been done in one of yesterday's fixes.
>
> Erik.
>
>
>
> ------------------------------------------------------------------------------
> Return on Information:
> Google Enterprise Search pays you back
> Get the facts.
> http://p.sf.net/sfu/google-dev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] 1856 in Rails 1.0.7-rc4

[Erik V. <eri...@xs...>]

Brett,

I'm fine. The bug reports have flown fairly steadily 
in the past few weeks (thanks again to all contributors)
and we should expect some more to come, but I suspect
we have had the big ones.

I'm thinking whether or not it becomes time to step up
a minor version number and call this or the next release 1.1.0,
now that we have added 1856 and done so many fixes and minor 
improvements?

Erik.


> -----Original Message-----
> From: brett lentz [mailto:wak...@gm...] 
> Sent: Tuesday 08 December 2009 21:09
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] 1856 in Rails 1.0.7-rc4
> 
> Erik -
> 
> Do you want more testing, or should we just call this release "done"
> and ship 1.0.7?
> 
> I'm thinking we're probably at a "good enough" state, and ready to
> move any further fixes to 1.0.8.  What do you think?
> 
> ---Brett.
> 
> 
> 
> On Tue, Dec 8, 2009 at 11:52 AM, Erik Vos <eri...@xs...> wrote:
> >> > Twice today I've gone through the private auction (6-player
> >> ) and then
> >> > not been able to buy into companies.  I never saw this on
> >> rc2 or rc3;
> >> > what might I be doing wrong? Saving and reloading did not help.
> >
> > This problem is not related to the number of players,
> > but occurs if only one bid has been placed on the
> > final private company, and no further player action
> > is needed to complete buying that private.
> >
> > I recently removed a case of duplicate execution of
> > some code in that area, but that removal has had this
> > adverse effect. The whole private auction process
> > turned out to be insufficiently adapted to a code
> > restructuring quite a long time ago.
> >
> > I have fixed it, and the structure now looks better too.
> >
> > More changes of today:
> >
> > - Fixed 18Kaas, which would not load because the private
> > company specifications missed a mandatory attribute,
> > added in the past.
> >
> > - Implemented Feature request #2906917: Display hex coordinates
> > The maps now show grid coordinates at all sides of the map.
> > It was implemented a bit quick and dirty, it's not perfect
> > and not entirely scalable yet, but I hope it will do for now.
> >
> > - Implemented Feature Request #2904703: Display cost of trains
> > A line has been added below the available trains in GameStatus,
> > specifying the cost of all trains. This display is fixed and
> > will not shorten during the game.
> >
> > In a game like 1835 the cost string grows pretty long,
> > considerably widening the whole window. We should probably split
> > the string over two lines in such cases.
> >
> > - FR #2904695: Add merger tokens in 18EU to Report Window
> > This had in fact already been done in one of yesterday's fixes.
> >
> > Erik.
> >
> >
> >
> > 
> --------------------------------------------------------------
> ----------------
> > Return on Information:
> > Google Enterprise Search pays you back
> > Get the facts.
> > http://p.sf.net/sfu/google-dev2dev
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
> 
> --------------------------------------------------------------
> ----------------
> Return on Information:
> Google Enterprise Search pays you back
> Get the facts.
> http://p.sf.net/sfu/google-dev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 

Re: [Rails-devel] 1856 in Rails 1.0.7-rc4

[brett l. <wak...@gm...>]

That's fine by me. So... 1.0.7 will now be 1.1.0!

---Brett.



On Tue, Dec 8, 2009 at 2:22 PM, Erik Vos <eri...@xs...> wrote:
> Brett,
>
> I'm fine. The bug reports have flown fairly steadily
> in the past few weeks (thanks again to all contributors)
> and we should expect some more to come, but I suspect
> we have had the big ones.
>
> I'm thinking whether or not it becomes time to step up
> a minor version number and call this or the next release 1.1.0,
> now that we have added 1856 and done so many fixes and minor
> improvements?
>
> Erik.
>
>
>> -----Original Message-----
>> From: brett lentz [mailto:wak...@gm...]
>> Sent: Tuesday 08 December 2009 21:09
>> To: Development list for Rails: an 18xx game
>> Subject: Re: [Rails-devel] 1856 in Rails 1.0.7-rc4
>>
>> Erik -
>>
>> Do you want more testing, or should we just call this release "done"
>> and ship 1.0.7?
>>
>> I'm thinking we're probably at a "good enough" state, and ready to
>> move any further fixes to 1.0.8.  What do you think?
>>
>> ---Brett.
>>
>>
>>
>> On Tue, Dec 8, 2009 at 11:52 AM, Erik Vos <eri...@xs...> wrote:
>> >> > Twice today I've gone through the private auction (6-player
>> >> ) and then
>> >> > not been able to buy into companies.  I never saw this on
>> >> rc2 or rc3;
>> >> > what might I be doing wrong? Saving and reloading did not help.
>> >
>> > This problem is not related to the number of players,
>> > but occurs if only one bid has been placed on the
>> > final private company, and no further player action
>> > is needed to complete buying that private.
>> >
>> > I recently removed a case of duplicate execution of
>> > some code in that area, but that removal has had this
>> > adverse effect. The whole private auction process
>> > turned out to be insufficiently adapted to a code
>> > restructuring quite a long time ago.
>> >
>> > I have fixed it, and the structure now looks better too.
>> >
>> > More changes of today:
>> >
>> > - Fixed 18Kaas, which would not load because the private
>> > company specifications missed a mandatory attribute,
>> > added in the past.
>> >
>> > - Implemented Feature request #2906917: Display hex coordinates
>> > The maps now show grid coordinates at all sides of the map.
>> > It was implemented a bit quick and dirty, it's not perfect
>> > and not entirely scalable yet, but I hope it will do for now.
>> >
>> > - Implemented Feature Request #2904703: Display cost of trains
>> > A line has been added below the available trains in GameStatus,
>> > specifying the cost of all trains. This display is fixed and
>> > will not shorten during the game.
>> >
>> > In a game like 1835 the cost string grows pretty long,
>> > considerably widening the whole window. We should probably split
>> > the string over two lines in such cases.
>> >
>> > - FR #2904695: Add merger tokens in 18EU to Report Window
>> > This had in fact already been done in one of yesterday's fixes.
>> >
>> > Erik.
>> >
>> >
>> >
>> >
>> --------------------------------------------------------------
>> ----------------
>> > Return on Information:
>> > Google Enterprise Search pays you back
>> > Get the facts.
>> > http://p.sf.net/sfu/google-dev2dev
>> > _______________________________________________
>> > Rails-devel mailing list
>> > Rai...@li...
>> > https://lists.sourceforge.net/lists/listinfo/rails-devel
>> >
>>
>> --------------------------------------------------------------
>> ----------------
>> Return on Information:
>> Google Enterprise Search pays you back
>> Get the facts.
>> http://p.sf.net/sfu/google-dev2dev
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>
>
> ------------------------------------------------------------------------------
> Return on Information:
> Google Enterprise Search pays you back
> Get the facts.
> http://p.sf.net/sfu/google-dev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] 1856 in Rails 1.0.7-rc4

[Jim B. <jim...@ya...>]

< .. 10 digits, clapping and cheering away... >



On Dec 8, 2009, at 2:57 PM, brett lentz wrote:

> That's fine by me. So... 1.0.7 will now be 1.1.0!
>
> ---Brett.
>
>
>
> On Tue, Dec 8, 2009 at 2:22 PM, Erik Vos <eri...@xs...> wrote:
>> Brett,
>>
>> I'm fine. The bug reports have flown fairly steadily
>> in the past few weeks (thanks again to all contributors)
>> and we should expect some more to come, but I suspect
>> we have had the big ones.
>>
>> I'm thinking whether or not it becomes time to step up
>> a minor version number and call this or the next release 1.1.0,
>> now that we have added 1856 and done so many fixes and minor
>> improvements?
>>
>> Erik.
>>
>>
>>> -----Original Message-----
>>> From: brett lentz [mailto:wak...@gm...]
>>> Sent: Tuesday 08 December 2009 21:09
>>> To: Development list for Rails: an 18xx game
>>> Subject: Re: [Rails-devel] 1856 in Rails 1.0.7-rc4
>>>
>>> Erik -
>>>
>>> Do you want more testing, or should we just call this release "done"
>>> and ship 1.0.7?
>>>
>>> I'm thinking we're probably at a "good enough" state, and ready to
>>> move any further fixes to 1.0.8.  What do you think?
>>>
>>> ---Brett.
>>>
>>>
>>>
>>> On Tue, Dec 8, 2009 at 11:52 AM, Erik Vos <eri...@xs...>  
>>> wrote:
>>>>>> Twice today I've gone through the private auction (6-player
>>>>> ) and then
>>>>>> not been able to buy into companies.  I never saw this on
>>>>> rc2 or rc3;
>>>>>> what might I be doing wrong? Saving and reloading did not help.
>>>>
>>>> This problem is not related to the number of players,
>>>> but occurs if only one bid has been placed on the
>>>> final private company, and no further player action
>>>> is needed to complete buying that private.
>>>>
>>>> I recently removed a case of duplicate execution of
>>>> some code in that area, but that removal has had this
>>>> adverse effect. The whole private auction process
>>>> turned out to be insufficiently adapted to a code
>>>> restructuring quite a long time ago.
>>>>
>>>> I have fixed it, and the structure now looks better too.
>>>>
>>>> More changes of today:
>>>>
>>>> - Fixed 18Kaas, which would not load because the private
>>>> company specifications missed a mandatory attribute,
>>>> added in the past.
>>>>
>>>> - Implemented Feature request #2906917: Display hex coordinates
>>>> The maps now show grid coordinates at all sides of the map.
>>>> It was implemented a bit quick and dirty, it's not perfect
>>>> and not entirely scalable yet, but I hope it will do for now.
>>>>
>>>> - Implemented Feature Request #2904703: Display cost of trains
>>>> A line has been added below the available trains in GameStatus,
>>>> specifying the cost of all trains. This display is fixed and
>>>> will not shorten during the game.
>>>>
>>>> In a game like 1835 the cost string grows pretty long,
>>>> considerably widening the whole window. We should probably split
>>>> the string over two lines in such cases.
>>>>
>>>> - FR #2904695: Add merger tokens in 18EU to Report Window
>>>> This had in fact already been done in one of yesterday's fixes.
>>>>
>>>> Erik.
>>>>
>>>>
>>>>
>>>>
>>> --------------------------------------------------------------
>>> ----------------
>>>> Return on Information:
>>>> Google Enterprise Search pays you back
>>>> Get the facts.
>>>> http://p.sf.net/sfu/google-dev2dev
>>>> _______________________________________________
>>>> Rails-devel mailing list
>>>> Rai...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>>>
>>>
>>> --------------------------------------------------------------
>>> ----------------
>>> Return on Information:
>>> Google Enterprise Search pays you back
>>> Get the facts.
>>> http://p.sf.net/sfu/google-dev2dev
>>> _______________________________________________
>>> Rails-devel mailing list
>>> Rai...@li...
>>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>>
>>
>>
>> ------------------------------------------------------------------------------
>> Return on Information:
>> Google Enterprise Search pays you back
>> Get the facts.
>> http://p.sf.net/sfu/google-dev2dev
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>
> ------------------------------------------------------------------------------
> Return on Information:
> Google Enterprise Search pays you back
> Get the facts.
> http://p.sf.net/sfu/google-dev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] 1856 in Rails 1.0.7-rc4

[Aliza P. <ali...@gm...>]

Rules error:

The rules for 1856 clearly state:

----------------
A certificate cannot be sold during the stock turn it was purchased.
----------------

This is not enforced by Rails.

(While there are certainly things in the 1856 rules which are unclear,
this isn't one of them.)

 - Aliza

Re: [Rails-devel] 1856 in Rails 1.0.7-rc4

[Erik V. <eri...@xs...>]

Yes, it is true that this rule is not (yet) enforced.
Erik. 

> -----Original Message-----
> From: Aliza Panitz [mailto:ali...@gm...] 
> Sent: Wednesday 09 December 2009 08:44
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] 1856 in Rails 1.0.7-rc4
> 
> Rules error:
> 
> The rules for 1856 clearly state:
> 
> ----------------
> A certificate cannot be sold during the stock turn it was purchased.
> ----------------
> 
> This is not enforced by Rails.
> 
> (While there are certainly things in the 1856 rules which are unclear,
> this isn't one of them.)
> 
>  - Aliza
> 
> --------------------------------------------------------------
> ----------------
> Return on Information:
> Google Enterprise Search pays you back
> Get the facts.
> http://p.sf.net/sfu/google-dev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] 1856 in Rails 1.0.7-rc4

[Aliza P. <ali...@gm...>]

On Tue, Dec 8, 2009 at 11:52 AM, Erik Vos <eri...@xs...> wrote:
>> > Twice today I've gone through the private auction (6-player
>> ) and then
>> > not been able to buy into companies.  I never saw this on
>> rc2 or rc3;
>> > what might I be doing wrong? Saving and reloading did not help.
>
> This problem is not related to the number of players,
> but occurs if only one bid has been placed on the
> final private company, and no further player action
> is needed to complete buying that private.
>
[...]

Thanks for fixing that so quickly based on a poorly-specified bug report.

 - Aliza