rails-devel

Re: [Rails-devel] [Rails-commits] 18xx/rails/game TileI.java, 1.11, 1.12 Tile.java, 1.20, 1.21

[brett l. <wak...@gm...>]

I know that, historically, we've commented out many changes. Let's
dispose of that practice.

If it's your intention to change behavior and not just temporarily
disable something then just go ahead and remove the methods.

---Brett.

On Sat, Nov 15, 2008 at 5:41 AM, Erik Vos <ev...@us...> wrote:
> Update of /cvsroot/rails/18xx/rails/game
> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv7515/rails/game
>
> Modified Files:
>        TileI.java Tile.java
> Log Message:
> Removed isLayableNow()
>
> Index: TileI.java
> ===================================================================
> RCS file: /cvsroot/rails/18xx/rails/game/TileI.java,v
> retrieving revision 1.11
> retrieving revision 1.12
> diff -C2 -d -r1.11 -r1.12
> *** TileI.java  4 Jun 2008 19:00:32 -0000       1.11
> --- TileI.java  15 Nov 2008 13:41:11 -0000      1.12
> ***************
> *** 39,43 ****
>      public boolean isUpgradeable();
>
> !     public boolean isLayableNow();
>
>      public List<TileI> getUpgrades(MapHex hex);
> --- 39,43 ----
>      public boolean isUpgradeable();
>
> !     //public boolean isLayableNow();
>
>      public List<TileI> getUpgrades(MapHex hex);
>
> Index: Tile.java
> ===================================================================
> RCS file: /cvsroot/rails/18xx/rails/game/Tile.java,v
> retrieving revision 1.20
> retrieving revision 1.21
> diff -C2 -d -r1.20 -r1.21
> *** Tile.java   30 Jun 2008 20:35:29 -0000      1.20
> --- Tile.java   15 Nov 2008 13:41:11 -0000      1.21
> ***************
> *** 328,334 ****
>       * @return
>       */
> !     public boolean isLayableNow() {
> !         return GameManager.getInstance().getCurrentPhase().isTileColourAllowed(colourName);
> !     }
>
>      /**
> --- 328,334 ----
>       * @return
>       */
> !     // public boolean isLayableNow() {
> !     //    return GameManager.getInstance().getCurrentPhase().isTileColourAllowed(colourName);
> !     //}
>
>      /**
>
>

Re: [Rails-devel] [Rails-commits] 18xx/rails/game TileI.java, 1.11, 1.12 Tile.java, 1.20, 1.21

[Mark S. <mar...@gm...>]

In this I agree with Brett completely. Given the CVS System, if
something fails and you need to revert, you can go back to an older
revision easy enough. It makes the code a lot cleaner to remove "dead
code" before it is checked in.

Mark

Re: [Rails-devel] [Rails-commits] 18xx/rails/game TileI.java, 1.11, 1.12 Tile.java, 1.20, 1.21

[Erik V. <eri...@hc...>]

Yes, I know I'm the culprit.
The point is, though, that many of my changes start somewhat experimentally,
and I need to be able to *see* what I have removed until it's final. And,
yes, I then often overlook to remove much of that.
My current work on 1856 capitalization again causes pretty much refactoring
and removal of redundant code, so I hope I will do better this time.
Feel free to remove dead code when you see it. And whether you see it or
not, trust me, it's harmless.
Erik.

> -----Original Message-----
> From: Mark Smith [mailto:mar...@gm...] 
> Sent: Saturday 15 November 2008 19:43
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] [Rails-commits] 18xx/rails/game 
> TileI.java, 1.11,1.12 Tile.java, 1.20, 1.21
> 
> In this I agree with Brett completely. Given the CVS System, if
> something fails and you need to revert, you can go back to an older
> revision easy enough. It makes the code a lot cleaner to remove "dead
> code" before it is checked in.
> 
> Mark
> 
> --------------------------------------------------------------
> -----------
> This SF.Net email is sponsored by the Moblin Your Move 
> Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & 
> win great prizes
> Grand prize is a trip for two to an Open Source event 
> anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>