I'm sorry to report that RC3 is worthless, at least for loading saved files.
The story is a bit long.
The change to allow trainless companies to skip buying a train
made it necessary to add an attribute to the BuyTrain action (to trigger
adding an appropriate help text). This necessitated writing custom
deserialization code for this class (to preserve saved file compatibility).
Here I erred by overlooking a few attributes, including the paid price.
That in turn caused all train cost to become $0, hence the huge treasuries
that were reported in some bug reports.
Brett, I'm afraid that we need yet another RC...
I have taken the opportunity to strengthen move checking in the
following ways:
- If a paid train price is unequal to a fixed price (if bought from
the Bank), this is considered an error from now on.
This check would have catched the above error in stead of letting is pass.
- So far, load errors like this one (and I have seen several other cases
in the recent past) were not catched, causing strange results to
be displayed (such as these huge treasuries). From now on, if the
game engine detects an invalid move being loaded from a saved file,
loading stops, some sensible messages are displayed in a popup,
and play can be continued normally *from that point on*.
As you might remember, we recently had such a case, where
it turned out that the previous version had incorrectly swapped
the operating order of companies.
Please note that 'invalid move' may be version-dependent.
Unfortunately, this change has already proven several of my nice
1856 test save files being incorrect :-(
Erik.
> -----Original Message-----
> From: Chris Shaffer [mailto:chr...@gm...]
> Sent: Tuesday 24 November 2009 13:48
> To: rai...@li...
> Subject: Re: [Rails-devel] 18EU bug
>
> One of the players in our game did some testing and reports:
>
> ***
> I did a little playing around. I went back to 5's turn in OR1b and
> re-entered all the moves from there through 3's turn in OR2a. (I
> remembered to run 8 for the extra $10.) Just before 5's turn in OR2a,
> the windows correctly reported $56 for 5 and $59 for 8. I saved the
> game. I loaded the save. The windows incorrectly reported $55 for 5
> and $60 for 8.
>
> So it seems like the problem is with the saving and loading, somehow.
> ***
>
|
