rails-devel

[Rails-devel] Patch to fix private company revenue

[Michael A. <out...@gm...>]

Here is my patch to fix private company revenue in the 1880_specific
branch.  (Does this work better in the future as an attachment?)

diff --git a/data/1880/CompanyManager.xml b/data/1880/CompanyManager.xml
index ff26af7..5934325 100644
--- a/data/1880/CompanyManager.xml
+++ b/data/1880/CompanyManager.xml
@@ -91,7 +91,7 @@
         </SpecialProperties>
     </Company>
     <Company name="JO" longname="Jeme Tien Yow Engineer Office"
type="Private"
-        basePrice="70" revenue="20">
+        basePrice="70" revenue="25">
         <!-- SpecialProperties-->
         <!-- SpecialProperty condition="ifOwnedByPlayer"
when="tileLayingStep"
             class="rails.game.specific._1880.BuildingPermit"-->
@@ -99,7 +99,7 @@
         <!--  -->/SpecialProperties-->
     </Company>
     <Company name="IG" longname="Imperial Qing Government" type="Private"
-        basePrice="160" revenue="20">
+        basePrice="160" revenue="0">
         <Info key="ComesWithPresidency" parm="BCR,20"/>
     </Company>
     <Company name="RC" longname="Rocket Company" type="Private"
basePrice="70"

Thanks,  Mike

Re: [Rails-devel] Patch to fix private company revenue

[brett l. <bre...@gm...>]

Patches like this work just fine. :)

I'll get this applied later today.

In general, we have two styles of contributions. We'll take patches like
this and one of the committers will merge them, if approved. Second, if
you'd like to do more substantial development, we're happy to grant commit
access once we've seen a few patches from you.

---Brett.


On Sat, Aug 24, 2013 at 5:56 AM, Michael Alexander
<out...@gm...>wrote:

> Here is my patch to fix private company revenue in the 1880_specific
> branch.  (Does this work better in the future as an attachment?)
>
> diff --git a/data/1880/CompanyManager.xml b/data/1880/CompanyManager.xml
> index ff26af7..5934325 100644
> --- a/data/1880/CompanyManager.xml
> +++ b/data/1880/CompanyManager.xml
> @@ -91,7 +91,7 @@
>          </SpecialProperties>
>      </Company>
>      <Company name="JO" longname="Jeme Tien Yow Engineer Office"
> type="Private"
> -        basePrice="70" revenue="20">
> +        basePrice="70" revenue="25">
>          <!-- SpecialProperties-->
>          <!-- SpecialProperty condition="ifOwnedByPlayer"
> when="tileLayingStep"
>              class="rails.game.specific._1880.BuildingPermit"-->
> @@ -99,7 +99,7 @@
>          <!--  -->/SpecialProperties-->
>      </Company>
>      <Company name="IG" longname="Imperial Qing Government" type="Private"
> -        basePrice="160" revenue="20">
> +        basePrice="160" revenue="0">
>          <Info key="ComesWithPresidency" parm="BCR,20"/>
>      </Company>
>      <Company name="RC" longname="Rocket Company" type="Private"
> basePrice="70"
>
> Thanks,  Mike
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance Management.
> Visit us today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>

Re: [Rails-devel] Patch to fix private company revenue

[Martin B. <dr....@t-...>]

Am 24.08.2013 17:29, schrieb brett lentz:

Hi Brett & Alexander,

patch applied and committed to specific_1880.

Thanks Alexander.
> Patches like this work just fine. :)
>
> I'll get this applied later today.
>
> In general, we have two styles of contributions. We'll take patches
> like this and one of the committers will merge them, if approved.
> Second, if you'd like to do more substantial development, we're happy
> to grant commit access once we've seen a few patches from you.
>
> ---Brett.
>
>
> On Sat, Aug 24, 2013 at 5:56 AM, Michael Alexander
> <out...@gm... <mailto:out...@gm...>> wrote:
>
>     Here is my patch to fix private company revenue in the
>     1880_specific branch.  (Does this work better in the future as an
>     attachment?)
>
>     diff --git a/data/1880/CompanyManager.xml
>     b/data/1880/CompanyManager.xml
>     index ff26af7..5934325 100644
>     --- a/data/1880/CompanyManager.xml
>     +++ b/data/1880/CompanyManager.xml
>     @@ -91,7 +91,7 @@
>              </SpecialProperties>
>          </Company>
>          <Company name="JO" longname="Jeme Tien Yow Engineer Office"
>     type="Private"
>     -        basePrice="70" revenue="20">
>     +        basePrice="70" revenue="25">
>              <!-- SpecialProperties-->
>              <!-- SpecialProperty condition="ifOwnedByPlayer"
>     when="tileLayingStep"
>                  class="rails.game.specific._1880.BuildingPermit"-->
>     @@ -99,7 +99,7 @@
>              <!--  -->/SpecialProperties-->
>          </Company>
>          <Company name="IG" longname="Imperial Qing Government"
>     type="Private"
>     -        basePrice="160" revenue="20">
>     +        basePrice="160" revenue="0">
>              <Info key="ComesWithPresidency" parm="BCR,20"/>
>          </Company>
>          <Company name="RC" longname="Rocket Company" type="Private"
>     basePrice="70"
>
>     Thanks,  Mike
>

Re: [Rails-devel] Patch to fix private company revenue

[Michael A. <out...@gm...>]

Sounds good.  Thank you for the quick response.  I'll have a few more
shortly. :)

Mike


On Sat, Aug 24, 2013 at 11:29 AM, brett lentz <bre...@gm...> wrote:

> Patches like this work just fine. :)
>
> I'll get this applied later today.
>
> In general, we have two styles of contributions. We'll take patches like
> this and one of the committers will merge them, if approved. Second, if
> you'd like to do more substantial development, we're happy to grant commit
> access once we've seen a few patches from you.
>
> ---Brett.
>
>
> On Sat, Aug 24, 2013 at 5:56 AM, Michael Alexander <
> out...@gm...> wrote:
>
>> Here is my patch to fix private company revenue in the 1880_specific
>> branch.  (Does this work better in the future as an attachment?)
>>
>> diff --git a/data/1880/CompanyManager.xml b/data/1880/CompanyManager.xml
>> index ff26af7..5934325 100644
>> --- a/data/1880/CompanyManager.xml
>> +++ b/data/1880/CompanyManager.xml
>> @@ -91,7 +91,7 @@
>>          </SpecialProperties>
>>      </Company>
>>      <Company name="JO" longname="Jeme Tien Yow Engineer Office"
>> type="Private"
>> -        basePrice="70" revenue="20">
>> +        basePrice="70" revenue="25">
>>          <!-- SpecialProperties-->
>>          <!-- SpecialProperty condition="ifOwnedByPlayer"
>> when="tileLayingStep"
>>              class="rails.game.specific._1880.BuildingPermit"-->
>> @@ -99,7 +99,7 @@
>>          <!--  -->/SpecialProperties-->
>>      </Company>
>>      <Company name="IG" longname="Imperial Qing Government" type="Private"
>> -        basePrice="160" revenue="20">
>> +        basePrice="160" revenue="0">
>>          <Info key="ComesWithPresidency" parm="BCR,20"/>
>>      </Company>
>>      <Company name="RC" longname="Rocket Company" type="Private"
>> basePrice="70"
>>
>> Thanks,  Mike
>>
>>
>> ------------------------------------------------------------------------------
>> Introducing Performance Central, a new site from SourceForge and
>> AppDynamics. Performance Central is your source for news, insights,
>> analysis and resources for efficient Application Performance Management.
>> Visit us today!
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>>
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance Management.
> Visit us today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>

Re: [Rails-devel] Patch to fix private company revenue

[Michael A. <out...@gm...>]

diff --git a/rails/game/specific/_1880/StartRound_1880.java b/rails/game/specific/_1880/StartRound_1880.java
index 69d5fd5..a615c76 100644
--- a/rails/game/specific/_1880/StartRound_1880.java
+++ b/rails/game/specific/_1880/StartRound_1880.java
@@ -4,6 +4,8 @@
 package rails.game.specific._1880;
 
 import java.util.BitSet;
+import java.util.List;
+import java.util.Vector;
 
 import rails.common.DisplayBuffer;
 import rails.common.LocalText;
@@ -41,6 +43,8 @@
     
     /** A company in need for a par price. */
     PublicCompanyI companyNeedingPrice = null;
+    
+    private final List<Player> playersPassed = new Vector<Player>();
     
     
     /**
@@ -83,6 +87,7 @@
             if (currentItem == null || currentItem.get() != item ) { // we haven't seen this item before
                 numPasses.set(0); // new round so cancel all previous passes !
                 playersActed.set(0);
+                playersPassed.clear();
                 currentItem.set(item);
                 item.setStatus(StartItem.BIDDABLE);
                 item.setStatus(StartItem.BUYABLE);
@@ -138,6 +143,7 @@
                     // Can't bid: Autopass
                     numPasses.add(1);
                     playersActed.add(1);
+                    playersPassed.add(currentPlayer);
                     return false;
                 }
         } else { // Item is not a private ! should be a major or minor in 1880 special rules apply.
@@ -262,6 +268,7 @@
             auctionItemState.set(null);
             numPasses.set(0);
             playersActed.set(0);
+            playersPassed.clear();
            setNextStartingPlayer();
            return true;
         } else {
@@ -303,6 +310,7 @@
 
         numPasses.add(1);
         playersActed.add(1);
+        playersPassed.add(player);
         
         if (numPasses.intValue() >= numPlayers) {
             // All players have passed.
@@ -318,6 +326,7 @@
                                 Bank.format(startPacket.getFirstItem().getBasePrice()) ));
                 numPasses.set(0);
                 playersActed.set(0);
+                playersPassed.clear();
                 if (auctionItem.getBasePrice() == 0) {
                     assignItem((Player)startingPlayer.get(),
                             auctionItem, 0, 0);
@@ -327,6 +336,7 @@
             } else {
                 numPasses.set(0);
                 playersActed.set(0);
+                playersPassed.clear();
                 finishRound();
 
             }
@@ -346,6 +356,7 @@
             auctionItemState.set(null);
             numPasses.set(0);
             playersActed.set(0);
+            playersPassed.clear();
            setNextStartingPlayer();
            return true;
         } else {
@@ -371,26 +382,11 @@
     }
     
     private void setNextBiddingPlayer(StartItem item, int currentIndex) {
-        boolean bidState = false;
         for (int i = currentIndex + 1; i < currentIndex
                                            + gameManager.getNumberOfPlayers(); i++) {
-            /*
-             * Ok we need to make sure that every one has at least the chance to bid once.
-             * We need to make sure that everyone that has passed cant bid again.
-             * Unfortunately getBid() or hasBid() return 0 so they cant be of use here until the second bidding round !
-             * Now we only need a status indicator how many people have acted already....
-             */
-            if (playersActed.intValue() == numPlayers) {
-                bidState = item.hasBid(gameManager.getPlayerByIndex(i));
-                if (bidState == true) {
-                    setCurrentPlayerIndex(i);
-                    break;
-                } else {
-                    continue;
-                }
-            } else {
-                    setCurrentPlayerIndex(i);
-                    break;
+            if (playersPassed.contains(gameManager.getPlayerByIndex(i)) == false) {
+                setCurrentPlayerIndex(i);
+                break;
             }
         }
     }
@@ -543,7 +539,15 @@
             if (lastBid == 0) {
                 gameManager.setPriorityPlayer();
             }
-            setNextPlayer();
+
+            // If this item is the "IG" (BCR), then we are still in the "auction" portion
+            // of the stock round, and the next player is based on the current player
+            // (not the current player).
+            if (item == StartItem.getByName("IG")) {
+                setCurrentPlayerIndex(((Player) startingPlayer.get()).getIndex());
+            } else {
+                setNextPlayer();
+            }
 
             auctionItemState.set(null);
             numPasses.set(0);

Re: [Rails-devel] Patch to fix private company revenue

[Martin B. <dr....@t-...>]

Hi Michael,

thanks again, i applied the patch to 1880_specific, though  i thought i
had fixed the behaviour in the code already pushed.

The second fix for StartCompany_1880 needs to be classified into the
category : "Ouch :)".

Thanks for catching it.

Regards,
Martin
Am 24.08.2013 19:55, schrieb Michael Alexander:
> Two more patches for 1880_specific.  These patches fix the following
> problems:
>
> - During "long" auctions in the initial stock round, the player whose
> turn it is to bid next or pass can get messed up.  For example: 
>
> Player A bids $5
> Player B bids $10
> Player C bids $15
> Player D passes
> Player A passes
> Player B bids $20
> Player C bids $25
> Player D will now be incorrectly given a chance to bid again, and if
> he passes, the company will be awarded to Player C.
>
> - After the IG is purchased (giving ownership to the BCR), the player
> who should start the auction on the RC is calculated incorrectly.
>
> - If a player does not have $200, the game crashes if they try to open
> a company.
>
>
>
>
> On Sat, Aug 24, 2013 at 11:59 AM, Michael Alexander
> <out...@gm... <mailto:out...@gm...>> wrote:
>
>     Sounds good.  Thank you for the quick response.  I'll have a few
>     more shortly. :)
>
>     Mike
>
>
>     On Sat, Aug 24, 2013 at 11:29 AM, brett lentz
>     <bre...@gm... <mailto:bre...@gm...>> wrote:
>
>         Patches like this work just fine. :)
>
>         I'll get this applied later today.
>
>         In general, we have two styles of contributions. We'll take
>         patches like this and one of the committers will merge them,
>         if approved. Second, if you'd like to do more substantial
>         development, we're happy to grant commit access once we've
>         seen a few patches from you.
>
>         ---Brett.
>
>
>         On Sat, Aug 24, 2013 at 5:56 AM, Michael Alexander
>         <out...@gm... <mailto:out...@gm...>> wrote:
>
>             Here is my patch to fix private company revenue in the
>             1880_specific branch.  (Does this work better in the
>             future as an attachment?)
>
>             diff --git a/data/1880/CompanyManager.xml
>             b/data/1880/CompanyManager.xml
>             index ff26af7..5934325 100644
>             --- a/data/1880/CompanyManager.xml
>             +++ b/data/1880/CompanyManager.xml
>             @@ -91,7 +91,7 @@
>                      </SpecialProperties>
>                  </Company>
>                  <Company name="JO" longname="Jeme Tien Yow Engineer
>             Office" type="Private"
>             -        basePrice="70" revenue="20">
>             +        basePrice="70" revenue="25">
>                      <!-- SpecialProperties-->
>                      <!-- SpecialProperty condition="ifOwnedByPlayer"
>             when="tileLayingStep"
>                         
>             class="rails.game.specific._1880.BuildingPermit"-->
>             @@ -99,7 +99,7 @@
>                      <!--  -->/SpecialProperties-->
>                  </Company>
>                  <Company name="IG" longname="Imperial Qing
>             Government" type="Private"
>             -        basePrice="160" revenue="20">
>             +        basePrice="160" revenue="0">
>                      <Info key="ComesWithPresidency" parm="BCR,20"/>
>                  </Company>
>                  <Company name="RC" longname="Rocket Company"
>             type="Private" basePrice="70"
>
>             Thanks,  Mike
>
>             ------------------------------------------------------------------------------
>             Introducing Performance Central, a new site from
>             SourceForge and
>             AppDynamics. Performance Central is your source for news,
>             insights,
>             analysis and resources for efficient Application
>             Performance Management.
>             Visit us today!
>             http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>             _______________________________________________
>             Rails-devel mailing list
>             Rai...@li...
>             <mailto:Rai...@li...>
>             https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
>         ------------------------------------------------------------------------------
>         Introducing Performance Central, a new site from SourceForge and
>         AppDynamics. Performance Central is your source for news,
>         insights,
>         analysis and resources for efficient Application Performance
>         Management.
>         Visit us today!
>         http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>         _______________________________________________
>         Rails-devel mailing list
>         Rai...@li...
>         <mailto:Rai...@li...>
>         https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and 
> AppDynamics. Performance Central is your source for news, insights, 
> analysis and resources for efficient Application Performance Management. 
> Visit us today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Patch to fix private company revenue

[Michael A. <out...@gm...>]

Martin,

    Are you working on the price slots?  I was thinking about taking a look
at them, but I wouldn't want to step on stuff you've already written.

Mike


On Sat, Aug 24, 2013 at 3:36 PM, Martin Brumm
<dr....@t-...>wrote:

>  Hi Michael,
>
> thanks again, i applied the patch to 1880_specific, though  i thought i
> had fixed the behaviour in the code already pushed.
>
> The second fix for StartCompany_1880 needs to be classified into the
> category : "Ouch :)".
>
> Thanks for catching it.
>
> Regards,
> Martin
> Am 24.08.2013 19:55, schrieb Michael Alexander:
>
>      Two more patches for 1880_specific.  These patches fix the following
> problems:
>
>  - During "long" auctions in the initial stock round, the player whose
> turn it is to bid next or pass can get messed up.  For example:
>
>  Player A bids $5
>  Player B bids $10
>  Player C bids $15
>  Player D passes
> Player A passes
>  Player B bids $20
>  Player C bids $25
>  Player D will now be incorrectly given a chance to bid again, and if he
> passes, the company will be awarded to Player C.
>
>  - After the IG is purchased (giving ownership to the BCR), the player who
> should start the auction on the RC is calculated incorrectly.
>
>  - If a player does not have $200, the game crashes if they try to open a
> company.
>
>
>
>
> On Sat, Aug 24, 2013 at 11:59 AM, Michael Alexander <
> out...@gm...> wrote:
>
>>  Sounds good.  Thank you for the quick response.  I'll have a few more
>> shortly. :)
>>
>>  Mike
>>
>>
>> On Sat, Aug 24, 2013 at 11:29 AM, brett lentz <bre...@gm...>wrote:
>>
>>> Patches like this work just fine. :)
>>>
>>>  I'll get this applied later today.
>>>
>>>  In general, we have two styles of contributions. We'll take patches
>>> like this and one of the committers will merge them, if approved. Second,
>>> if you'd like to do more substantial development, we're happy to grant
>>> commit access once we've seen a few patches from you.
>>>
>>>  ---Brett.
>>>
>>>
>>>  On Sat, Aug 24, 2013 at 5:56 AM, Michael Alexander <
>>> out...@gm...> wrote:
>>>
>>>>   Here is my patch to fix private company revenue in the 1880_specific
>>>> branch.  (Does this work better in the future as an attachment?)
>>>>
>>>> diff --git a/data/1880/CompanyManager.xml b/data/1880/CompanyManager.xml
>>>> index ff26af7..5934325 100644
>>>> --- a/data/1880/CompanyManager.xml
>>>> +++ b/data/1880/CompanyManager.xml
>>>> @@ -91,7 +91,7 @@
>>>>          </SpecialProperties>
>>>>      </Company>
>>>>      <Company name="JO" longname="Jeme Tien Yow Engineer Office"
>>>> type="Private"
>>>> -        basePrice="70" revenue="20">
>>>> +        basePrice="70" revenue="25">
>>>>          <!-- SpecialProperties-->
>>>>          <!-- SpecialProperty condition="ifOwnedByPlayer"
>>>> when="tileLayingStep"
>>>>              class="rails.game.specific._1880.BuildingPermit"-->
>>>> @@ -99,7 +99,7 @@
>>>>          <!--  -->/SpecialProperties-->
>>>>      </Company>
>>>>      <Company name="IG" longname="Imperial Qing Government"
>>>> type="Private"
>>>> -        basePrice="160" revenue="20">
>>>> +        basePrice="160" revenue="0">
>>>>          <Info key="ComesWithPresidency" parm="BCR,20"/>
>>>>      </Company>
>>>>      <Company name="RC" longname="Rocket Company" type="Private"
>>>> basePrice="70"
>>>>
>>>>  Thanks,  Mike
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Introducing Performance Central, a new site from SourceForge and
>>>> AppDynamics. Performance Central is your source for news, insights,
>>>> analysis and resources for efficient Application Performance Management.
>>>> Visit us today!
>>>>
>>>> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>>>> _______________________________________________
>>>> Rails-devel mailing list
>>>> Rai...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>>>
>>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Introducing Performance Central, a new site from SourceForge and
>>> AppDynamics. Performance Central is your source for news, insights,
>>> analysis and resources for efficient Application Performance Management.
>>> Visit us today!
>>>
>>> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>>> _______________________________________________
>>> Rails-devel mailing list
>>> Rai...@li...
>>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>>
>>>
>>
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance Management.
> Visit us today!http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>
>
>
> _______________________________________________
> Rails-devel mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance Management.
> Visit us today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>

Re: [Rails-devel] Patch to fix private company revenue

[Martin B. <dr....@t-...>]

Am 24.08.2013 23:19, schrieb Michael Alexander:

Hi Mike,

i have a preliminary version in the latest 1880_specific committed.

But it still has its flaws.
Startround uses a different numeration, this is not yet carried over to
the main StartCompany procedure.
The StartCompany_procedure for the priceslot still needs adjustments
also. If you want to give it a shot, great.

I have prepared a build for the BGG-Guys to use with those caveats...
Can be found at
https://dl.dropboxusercontent.com/u/29072620/rails-1.7.12_1880.zip
As i dont have access to the release build mechanismn on sourceforge
myself :)

Regards,
Martin

P.s. in the archive of rails-devel theres a lot of nice information
regarding the intended architecture by Brett, Stefan and Erik.
> Martin,
>
>     Are you working on the price slots?  I was thinking about taking a
> look at them, but I wouldn't want to step on stuff you've already written.
>
> Mike
>
>
> On Sat, Aug 24, 2013 at 3:36 PM, Martin Brumm
> <dr....@t-... <mailto:dr....@t-...>> wrote:
>
>     Hi Michael,
>
>     thanks again, i applied the patch to 1880_specific, though  i
>     thought i had fixed the behaviour in the code already pushed.
>
>     The second fix for StartCompany_1880 needs to be classified into
>     the category : "Ouch :)".
>
>     Thanks for catching it.
>
>     Regards,
>     Martin
>

Re: [Rails-devel] Patch to fix private company revenue

[Michael A. <out...@gm...>]

diff --git a/rails/game/specific/_1880/BuyStartItem_1880.java b/rails/game/specific/_1880/BuyStartItem_1880.java
index b97d733..5036509 100644
--- a/rails/game/specific/_1880/BuyStartItem_1880.java
+++ b/rails/game/specific/_1880/BuyStartItem_1880.java
@@ -21,6 +21,8 @@
     private BitSet buildingRights;
     
     private BitSet associatedBuildingRight;
+    
+    private int parSlotIndex = 0;
     /**
      * @param startItem
      * @param price
@@ -167,5 +169,14 @@
         }
         return "None";
     }
+
+
+    public void setParSlotIndex(int index) {
+        parSlotIndex = index;        
+    }
+    
+    public int getParSlotIndex() {
+        return parSlotIndex;
+    }
      
 }
\ No newline at end of file
diff --git a/rails/game/specific/_1880/GameManager_1880.java b/rails/game/specific/_1880/GameManager_1880.java
index a8c5f37..c3ed260 100644
--- a/rails/game/specific/_1880/GameManager_1880.java
+++ b/rails/game/specific/_1880/GameManager_1880.java
@@ -31,6 +31,7 @@
     public IntegerState numOfORs = new IntegerState("numOfORs");
     //Keeps track of the company that purchased the last train
     private PublicCompany_1880 lastTrainBuyingCompany;
+    private ParSlots_1880 parSlots = new ParSlots_1880();
     /**
      * 
      */
@@ -142,5 +143,9 @@
         
         super.finishShareSellingRound();
     }
+    
+    public ParSlots_1880 getParSlots() {
+        return parSlots;
+    }
 
 }
diff --git a/rails/game/specific/_1880/OperatingRound_1880.java b/rails/game/specific/_1880/OperatingRound_1880.java
index f573a95..df1cb8f 100644
--- a/rails/game/specific/_1880/OperatingRound_1880.java
+++ b/rails/game/specific/_1880/OperatingRound_1880.java
@@ -509,30 +509,25 @@
     @Override
     public List<PublicCompanyI> setOperatingCompanies() {
         Map<Integer, PublicCompanyI> operatingCompanies = new TreeMap<Integer, PublicCompanyI>();
-      int space = 100;
-      int key;
-      int minorNo = 0;
+      int key = 1;
+      
+      // Put in Foreign Investors first      
       for (PublicCompanyI company : companyManager.getAllPublicCompanies()) {
           if (!canCompanyOperateThisRound(company)) continue; 
-          if (! company.hasFloated()) continue;
-          // Key must put companies in reverse operating order, because sort
-          // is ascending.
-          if (company.hasStockPrice()) {
-          space = company.getStartSpace().getPrice();
-          //Corps operate in descending Startprice
-          //Corps with the same Start price operate in the order they were floated
-          //Start price will inherently be in the right order
-          //subtracting the formation order index will put it at the right point to operate
-          //This wouldn't work if there are lots of corps at the same price
-          //there are not too many corps in each banding for this to be an issue in 1825 even with all 3 units
-          key = 1000000 - (space - ((PublicCompany_1880) company).getOperationSlotIndex());
-          operatingCompanies.put(new Integer(key), company);
-          }
-          else {
-              key = 50 + ++minorNo;
-              operatingCompanies.put(new Integer(key), company);
+          if (!company.hasFloated()) continue;
+          if (!company.hasStockPrice()) {
+              operatingCompanies.put(new Integer(key++), company);
           }
       }
+      
+      // Now the share companies in par slot order
+      List<PublicCompanyI> companies = ((GameManager_1880) gameManager).getParSlots().getCompaniesInOperatingOrder();
+      for (PublicCompanyI company : companies) {
+          if (!canCompanyOperateThisRound(company)) continue; 
+          if (!company.hasFloated()) continue;
+          operatingCompanies.put(new Integer(key++), company);
+      }
+      
       return new ArrayList<PublicCompanyI>(operatingCompanies.values());
     }
 
diff --git a/rails/game/specific/_1880/ParSlot_1880.java b/rails/game/specific/_1880/ParSlot_1880.java
new file mode 100644
index 0000000..6678235
--- /dev/null
+++ b/rails/game/specific/_1880/ParSlot_1880.java
@@ -0,0 +1,35 @@
+package rails.game.specific._1880;
+
+/**
+ * @author Michael Alexander
+ * 
+ */
+import rails.game.PublicCompanyI;
+
+public class ParSlot_1880 {
+    private int index = -1;
+    private int price = -1;
+    private PublicCompanyI company = null;
+    
+    public ParSlot_1880(int index, int price) {
+        this.index = index;
+        this.price = price;
+    }
+    
+    public void setCompany(PublicCompanyI company) {
+        this.company = company;
+    }
+    
+    public int getIndex() {
+        return index;
+    }
+    
+    public int getPrice() {
+        return price;
+    }
+    
+    public PublicCompanyI getCompany() {
+        return company;
+    }
+
+}
diff --git a/rails/game/specific/_1880/ParSlots_1880.java b/rails/game/specific/_1880/ParSlots_1880.java
new file mode 100644
index 0000000..a7d54b4
--- /dev/null
+++ b/rails/game/specific/_1880/ParSlots_1880.java
@@ -0,0 +1,62 @@
+package rails.game.specific._1880;
+
+/**
+ * @author Michael Alexander
+ * 
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+import rails.game.PublicCompanyI;
+
+public class ParSlots_1880 {
+
+    private List<ParSlot_1880> parSlots = new ArrayList<ParSlot_1880>();
+        
+    public ParSlots_1880() {
+        for (int i = 0; i < 4; i++) {
+            for (int j = 0; j < 4; j++) {
+                parSlots.add(new ParSlot_1880(i*4+j, 100-(10*i)));
+            }
+        }
+    }
+    
+    public List<ParSlot_1880> getEmptyParSlotsAtPrice(int price) {
+        List<ParSlot_1880> emptySlots = new ArrayList<ParSlot_1880>();
+        for (ParSlot_1880 slot : parSlots) {
+            if ((slot.getCompany() == null) && (slot.getPrice() == price)) {
+                emptySlots.add(slot);
+            }
+        }
+        return emptySlots;
+    }
+        
+    public boolean freeSlotAtPrice(int price) {
+        for (ParSlot_1880 slot : parSlots) {
+            if ((slot.getCompany() == null) && (slot.getPrice() == price)) {
+                return true;
+            }
+        }
+        return false;
+    }
+
+    public void setCompanyAtSlot(PublicCompanyI company, int index) {
+        for (ParSlot_1880 slot : parSlots) {
+            if (slot.getIndex() == index) {
+                slot.setCompany(company);
+                break;
+            }
+        }
+    }
+    
+    public List<PublicCompanyI> getCompaniesInOperatingOrder() {
+        List<PublicCompanyI> companies = new ArrayList<PublicCompanyI>();
+        for (ParSlot_1880 slot : parSlots) {
+            if (slot.getCompany() != null) {
+                companies.add(slot.getCompany());
+            }
+        }
+        return companies;
+    }    
+}
diff --git a/rails/game/specific/_1880/PublicCompany_1880.java b/rails/game/specific/_1880/PublicCompany_1880.java
index 0a85c62..da09f38 100644
--- a/rails/game/specific/_1880/PublicCompany_1880.java
+++ b/rails/game/specific/_1880/PublicCompany_1880.java
@@ -65,7 +65,6 @@
     
     protected IntegerState operationSlotIndex = new IntegerState ("OperatingSlot, 0");
   
-
     /**
      * 
      */
@@ -378,18 +377,5 @@
         }
     }
 */
-    /**
-     * @return the operationSlotIndex
-     */
-    public int getOperationSlotIndex() {
-        return operationSlotIndex.intValue();
-    }
-
-    /**
-     * @param operationSlotIndex the operationSlotIndex to set
-     */
-    public void setOperationSlotIndex(int operationSlotIndex) {
-        this.operationSlotIndex.add(operationSlotIndex);
-    }
     
 }
diff --git a/rails/game/specific/_1880/StartCompany_1880.java b/rails/game/specific/_1880/StartCompany_1880.java
index 7e02cc6..073d399 100644
--- a/rails/game/specific/_1880/StartCompany_1880.java
+++ b/rails/game/specific/_1880/StartCompany_1880.java
@@ -6,12 +6,12 @@
 import java.io.IOException;
 import java.io.ObjectInputStream;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.BitSet;
+import java.util.Collections;
 import java.util.List;
 
-import rails.game.CompanyManagerI;
 import rails.game.PublicCompanyI;
-import rails.game.StockSpace;
 import rails.game.StockSpaceI;
 import rails.game.action.StartCompany;
 
@@ -121,9 +121,9 @@
         // TODO Auto-generated method stub
         // make sure that all exhausted price Slots will not be returned as valid prices anymore...
         startPrices2 = super.getStartPrices();
-        for (int e =0 ; e< 4 ; e++)
-        {
-            if (  ((StockMarket_1880) gameManager.getStockMarket()).getParSlot(startPrices2[e])== true) //free slot found
+        for (int e = 0 ; e < startPrices2.length ; e++)
+        {   
+            if (((GameManager_1880) gameManager).getParSlots().freeSlotAtPrice(startPrices2[e])) //free slot found
             {
                 startPrices_new.add(startPrices2[e]);
             }
@@ -133,6 +133,26 @@
             startPrices2_new[i] = startPrices_new.get(i).intValue();
         return startPrices2_new;
     }
+    
+    public List<ParSlot_1880> getStartParSlots() {
+        List<ParSlot_1880> startParSlots = new ArrayList<ParSlot_1880>();
+        int []startPrices = super.getStartPrices();
+        Integer []startPrices2 = new Integer[startPrices.length];
+        ParSlots_1880 parSlots = ((GameManager_1880) gameManager).getParSlots();
+             
+        for (int i = 0; i < startPrices.length ; i++) {
+            startPrices2[i] = startPrices[i];
+        }
+        Arrays.sort(startPrices2, Collections.reverseOrder());
+        
+        for (int i = 0; i < startPrices2.length ; i++) {
+            List<ParSlot_1880> emptySlotsAtThisPrice = parSlots.getEmptyParSlotsAtPrice(startPrices2[i]);
+            for (ParSlot_1880 slot : emptySlotsAtThisPrice) {
+                startParSlots.add(slot);
+            }
+        }
+        return startParSlots;
+    }
 
     /* (non-Javadoc)
      * @see rails.game.action.StartCompany#setStartPrice(int)
@@ -140,7 +160,6 @@
     public void setStartPrice(int startPrice, int index) {
         StockSpaceI parPrice=gameManager.getStockMarket().getStartSpace(startPrice);
         this.getCompany().setParSpace(parPrice);
-        ((StockMarket_1880) gameManager.getStockMarket()).setParSlot(index);
     }
     
     /** Deserialize */
@@ -191,8 +210,7 @@
          return "None";
     }
 
-    public void setOperatingSlot(int index) {
-        ((PublicCompany_1880) this.getCompany()).setOperationSlotIndex(index);
-        
+    public void setParSlotIndex(int index) {
+        ((GameManager_1880) gameManager).getParSlots().setCompanyAtSlot(this.getCompany(), index);        
     }
 }
diff --git a/rails/game/specific/_1880/StartRound_1880.java b/rails/game/specific/_1880/StartRound_1880.java
index 69d5fd5..39055e9 100644
--- a/rails/game/specific/_1880/StartRound_1880.java
+++ b/rails/game/specific/_1880/StartRound_1880.java
@@ -4,6 +4,8 @@
 package rails.game.specific._1880;
 
 import java.util.BitSet;
+import java.util.List;
+import java.util.Vector;
 
 import rails.common.DisplayBuffer;
 import rails.common.LocalText;
@@ -41,6 +43,8 @@
     
     /** A company in need for a par price. */
     PublicCompanyI companyNeedingPrice = null;
+    
+    private final List<Player> playersPassed = new Vector<Player>();
     
     
     /**
@@ -83,6 +87,7 @@
             if (currentItem == null || currentItem.get() != item ) { // we haven't seen this item before
                 numPasses.set(0); // new round so cancel all previous passes !
                 playersActed.set(0);
+                playersPassed.clear();
                 currentItem.set(item);
                 item.setStatus(StartItem.BIDDABLE);
                 item.setStatus(StartItem.BUYABLE);
@@ -138,6 +143,7 @@
                     // Can't bid: Autopass
                     numPasses.add(1);
                     playersActed.add(1);
+                    playersPassed.add(currentPlayer);
                     return false;
                 }
         } else { // Item is not a private ! should be a major or minor in 1880 special rules apply.
@@ -262,6 +268,7 @@
             auctionItemState.set(null);
             numPasses.set(0);
             playersActed.set(0);
+            playersPassed.clear();
            setNextStartingPlayer();
            return true;
         } else {
@@ -303,6 +310,7 @@
 
         numPasses.add(1);
         playersActed.add(1);
+        playersPassed.add(player);
         
         if (numPasses.intValue() >= numPlayers) {
             // All players have passed.
@@ -318,6 +326,7 @@
                                 Bank.format(startPacket.getFirstItem().getBasePrice()) ));
                 numPasses.set(0);
                 playersActed.set(0);
+                playersPassed.clear();
                 if (auctionItem.getBasePrice() == 0) {
                     assignItem((Player)startingPlayer.get(),
                             auctionItem, 0, 0);
@@ -327,6 +336,7 @@
             } else {
                 numPasses.set(0);
                 playersActed.set(0);
+                playersPassed.clear();
                 finishRound();
 
             }
@@ -346,6 +356,7 @@
             auctionItemState.set(null);
             numPasses.set(0);
             playersActed.set(0);
+            playersPassed.clear();
            setNextStartingPlayer();
            return true;
         } else {
@@ -371,26 +382,11 @@
     }
     
     private void setNextBiddingPlayer(StartItem item, int currentIndex) {
-        boolean bidState = false;
         for (int i = currentIndex + 1; i < currentIndex
                                            + gameManager.getNumberOfPlayers(); i++) {
-            /*
-             * Ok we need to make sure that every one has at least the chance to bid once.
-             * We need to make sure that everyone that has passed cant bid again.
-             * Unfortunately getBid() or hasBid() return 0 so they cant be of use here until the second bidding round !
-             * Now we only need a status indicator how many people have acted already....
-             */
-            if (playersActed.intValue() == numPlayers) {
-                bidState = item.hasBid(gameManager.getPlayerByIndex(i));
-                if (bidState == true) {
-                    setCurrentPlayerIndex(i);
-                    break;
-                } else {
-                    continue;
-                }
-            } else {
-                    setCurrentPlayerIndex(i);
-                    break;
+            if (playersPassed.contains(gameManager.getPlayerByIndex(i)) == false) {
+                setCurrentPlayerIndex(i);
+                break;
             }
         }
     }
@@ -479,6 +475,7 @@
             int sharePrice = 0;
             String shareCompName = "";
             BitSet buildingRights = new BitSet(5);
+            int parSlotIndex = 0;
             BuyStartItem_1880 boughtItem_1880 = (BuyStartItem_1880) boughtItem;
 
             while (true) {
@@ -503,6 +500,7 @@
                     shareCompName = boughtItem_1880.getCompanyToSetPriceFor();
                     sharePrice = boughtItem_1880.getAssociatedSharePrice();
                     buildingRights = boughtItem_1880.getAssociatedBuildingRight();
+                    parSlotIndex = boughtItem_1880.getParSlotIndex();
                     
                     if (sharePrice == 0) {
                         errMsg =
@@ -522,6 +520,7 @@
                                         shareCompName );
                         break;
                     }
+                    // TODO: Add check for ParSlot validity
                 }
                 break;
             }
@@ -536,14 +535,22 @@
 
             moveStack.start(false);
 
-            assignItem(player, item, price, sharePrice, buildingRights);
+            assignItem(player, item, price, sharePrice, buildingRights, parSlotIndex);
 
             // Set priority (only if the item was not auctioned)
             // ASSUMPTION: getting an item in auction mode never changes priority
             if (lastBid == 0) {
                 gameManager.setPriorityPlayer();
             }
-            setNextPlayer();
+
+            // If this item is the "IG" (BCR), then we are still in the "auction" portion
+            // of the stock round, and the next player is based on the current player
+            // (not the current player).
+            if (item == StartItem.getByName("IG")) {
+                setCurrentPlayerIndex(((Player) startingPlayer.get()).getIndex());
+            } else {
+                setNextPlayer();
+            }
 
             auctionItemState.set(null);
             numPasses.set(0);
@@ -559,7 +566,7 @@
      * @param buildingRights
      */
     private void assignItem(Player player, StartItem item, int price,
-            int sharePrice, BitSet buildingRights) {
+            int sharePrice, BitSet buildingRights, int parSlotIndex) {
         Certificate primary = item.getPrimary();
         ReportBuffer.add(LocalText.getText("BuysItemFor",
                 player.getName(),
@@ -567,14 +574,14 @@
                 Bank.format(price) ));
         pay (player, bank, price);
         transferCertificate (primary, player.getPortfolio());
-        checksOnBuying(primary, sharePrice, buildingRights);
+        checksOnBuying(primary, sharePrice, buildingRights, parSlotIndex);
         if (item.hasSecondary()) {
             Certificate extra = item.getSecondary();
             ReportBuffer.add(LocalText.getText("ALSO_GETS",
                     player.getName(),
                     extra.getName() ));
             transferCertificate (extra, player.getPortfolio());
-            checksOnBuying(extra, sharePrice, buildingRights);
+            checksOnBuying(extra, sharePrice, buildingRights, parSlotIndex);
         }
         item.setSold(player, price);
         
@@ -585,7 +592,7 @@
      * @param buildingRights
      */
     private void checksOnBuying(Certificate cert, int sharePrice,
-            BitSet buildingRights) {
+            BitSet buildingRights, int parSlot) {
         if (cert instanceof PublicCertificateI) {
             PublicCertificateI pubCert = (PublicCertificateI) cert;
             PublicCompany_1880 comp = (PublicCompany_1880) pubCert.getCompany();
@@ -600,6 +607,7 @@
                         comp.start(sharePrice);
                         //Building Rights are also set..
                         comp.setBuildingRights(buildingRights);
+                        ((GameManager_1880) gameManager).getParSlots().setCompanyAtSlot(comp, parSlot);
                         comp.setRight("BuildingRight",buildingRightToString(buildingRights));
                     } else {
                         log.error("No start price for " + comp.getName());
diff --git a/rails/game/specific/_1880/StockMarket_1880.java b/rails/game/specific/_1880/StockMarket_1880.java
index 91a2304..5a311c1 100644
--- a/rails/game/specific/_1880/StockMarket_1880.java
+++ b/rails/game/specific/_1880/StockMarket_1880.java
@@ -29,11 +29,7 @@
     public IntegerState parPlace_80;
 
     public IntegerState parPlace_70;
-
-    protected int parSlots[]= new int [16];
-
-    private int freeParSlots [] = new int [16];
-
+    
     GameManagerI gameManager;
 
     /**
@@ -171,115 +167,5 @@
                 comp.getStartSpace().addFixedStartPrice(comp);
             }
         }
-    }
-
-    /**
-     * @return all free parSlots
-     */
-    public int[] getParSlots() {
-       
-        int i = 0;
-        for (int e: parSlots )
-        {
-         if (parSlots[e] == 0)
-                 {
-                 freeParSlots[i] = e+1;
-                 i++;
-                 }
-        }
-        return freeParSlots;
-    }
-
-    public int [] getParSlots(int price){
-        int [] freeParSlotsPerPrice= new int [4];
-        int i =0;
-        switch (price) {
-        case 70:
-            for (int e=0 ; e< 4; e++ )
-            {
-                if ( parSlots[e] == 0)
-                   freeParSlotsPerPrice[e] =e+1;
-            }
-                   
-            break;
-        case 80:
-            for (int e=4 ; e< 8; e++ )
-            {
-                if ( parSlots[e] == 0) {
-                   i = e % 4; 
-                   freeParSlotsPerPrice[i] =e+1;
-                }
-            }
-            break;
-        case 90:
-            for (int e=8 ; e< 12; e++ )
-            {
-                if ( parSlots[e] == 0)
-                {
-                    i = e % 4; 
-                freeParSlotsPerPrice[i] =e+1;
-                }
-            }
-            break;
-        case 100:
-            for (int e=12 ; e< 16; e++ )
-            {
-                if ( parSlots[e] == 0){
-                    i = e % 4; 
-                freeParSlotsPerPrice[i] =e+1;
-                }
-            }
-        default:
-            return freeParSlotsPerPrice;
-        }
-        return freeParSlotsPerPrice;
-    }
-    /**
-     * @param parSlots the parSlots to set
-     */
-    public void setParSlots(int[] parSlots) {
-        this.parSlots = parSlots;
-    }
-
-    public boolean setParSlot(int position) {
-        
-        if (this.parSlots[position] > 0) {
-            return false;
-        } else {
-            this.parSlots[position] = 1;
-            return true;
-        }
-    }
-
-    public boolean getParSlot(int price) {
-        switch (price) {
-        case 70:
-            for (int e=0 ; e< 4; e++ )
-               if ( parSlots[e] == 0)
-                   return true;
-            break;
-        case 80:
-            for (int e=4 ; e< 8; e++ )
-                if ( parSlots[e] == 0)
-                    return true;
-            break;
-        case 90:
-            for (int e=8 ; e< 12; e++ )
-                if ( parSlots[e] == 0)
-                    return true;
-            break;
-        case 100:
-            for (int e=12 ; e< 16; e++ )
-                if ( parSlots[e] == 0)
-                    return true;
-            break;
-        default:
-            return false;
-        }
-        return false;
-    }
-
-    public boolean getParSlot(int price, int position) {
-        return true;
     }
 }
diff --git a/rails/game/specific/_1880/StockRound_1880.java b/rails/game/specific/_1880/StockRound_1880.java
index 8ed6669..be75bd4 100644
--- a/rails/game/specific/_1880/StockRound_1880.java
+++ b/rails/game/specific/_1880/StockRound_1880.java
@@ -274,7 +274,7 @@
                 } else if (!comp.hasStarted()) {
                     List<Integer> startPrices = new ArrayList<Integer>();
                         for (int startPrice : stockMarket.getStartPrices()) {
-                            if ((startPrice * shares <= playerCash) && (((StockMarket_1880) gameManager.getStockMarket()).getParSlot(startPrice))) {
+                            if ((startPrice * shares <= playerCash) && (((GameManager_1880) gameManager).getParSlots().freeSlotAtPrice(startPrice))) {
                                 startPrices.add(startPrice);
                             }
                         }

Re: [Rails-devel] Patch to fix private company revenue

[<Dr....@t-...>]

Hi Michael, 

	thanks, i'll incorporate the patches later today. 

	Regarding the takeover in the initial round, tht should not be
possible, as a player will found/start a company with at least 20
percent, the FI of the player gets another 10, that just leaves 20
percent in the open stock (till the first 3 has been bought). So
theres no take over possible in the initial round. Ergo we have a bug
in there somewhere. I'll have look later tonight at the save file. 

	Regards, 

	Martin  

	Von: Michael Alexander <out...@gm...> 

	An: "Development list for Rails: an 18xx game"
<rai...@li...> 

	Betreff: Re: [Rails-devel] Patch to fix private company revenue 

	Datum: Mon, 26 Aug 2013 05:33:47 +0200 

	     Martin, 

I think these patches fix the problems I saw with price slots.  I saw
a few things (BCR didn't get a slot, for example, and I had trouble
getting companies to open at the right prices).  I ended up pulling
out the ParSlot into it's own class(es).  It didn't seem appropriate
for it to be part of the stock market.  If you could take a look at
these changes and let me know what you think, I'd appreciate it.

 I also included the save game that represents as far as I can get
with this version in the online game I'm in before I hit another
problem.  In the initial stock round, one of the players took the
presidency of a company from another player.  The game (we believe
incorrectly) then puts a share of that company in the FI.  We think
because the second player didn't form the company (he just took it
over) that it shouldn't do that.

Mike  

 On Sat, Aug 24, 2013 at 5:27 PM, Martin Brumm
<dr....@t-... [1]> wrote:
   Am 24.08.2013 23:19, schrieb Michael Alexander:

 Hi Mike,

 i have a preliminary version in the latest 1880_specific committed.

 But it still has its flaws. 
 Startround uses a different numeration, this is not yet carried over
to the main StartCompany procedure.
 The StartCompany_procedure for the priceslot still needs adjustments
also. If you want to give it a shot, great.

 I have prepared a build for the BGG-Guys to use with those caveats...
 Can be found at
https://dl.dropboxusercontent.com/u/29072620/rails-1.7.12_1880.zip [2]
 As i dont have access to the release build mechanismn on sourceforge
myself :)

 Regards,
 Martin

 P.s. in the archive of rails-devel theres a lot of nice information
regarding the intended architecture by Brett, Stefan and Erik.   
Martin,

     Are you working on the price slots?  I was thinking about taking
a look at them, but I wouldn't want to step on stuff you've already
written.

 Mike 

 On Sat, Aug 24, 2013 at 3:36 PM, Martin Brumm
<dr....@t-... [3]> wrote:
   Hi Michael,

 thanks again, i applied the patch to 1880_specific, though  i thought
i had fixed the behaviour in the code already pushed.

 The second fix for StartCompany_1880 needs to be classified into the
category : "Ouch :)".

 Thanks for catching it.

 Regards,
 Martin        
------------------------------------------------------------------------------
 Introducing Performance Central, a new site from SourceForge and
 AppDynamics. Performance Central is your source for news, insights,
 analysis and resources for efficient Application Performance
Management.
 Visit us today!
 http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
[4]
_______________________________________________
 Rails-devel mailing list
 Rai...@li... [5]
 https://lists.sourceforge.net/lists/listinfo/rails-devel [6]

Links:
------
[1] mailto:dr....@t-...
[2] https://dl.dropboxusercontent.com/u/29072620/rails-1.7.12_1880.zip
[3] mailto:dr....@t-...
[4]
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&amp;iu=/4140/ostg.clktrk
[5] mailto:Rai...@li...
[6] https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Patch to fix private company revenue

[Michael A. <out...@gm...>]

The scenario was this:

Player A bought the IG (getting the BCR).  His foreign investor took a BCR
share.  He then opened the HKR at 20%.  Player B (who had not yet opened a
company) bought the remaining 30% of HKR that was available and took over
the company.  The code assumed that Player B has opened it, and gave player
B's investor a share of HKR.

My approach to fixing it (which I have coded, but isn't in the files I sent
because I just did it) was to have the public company keep track of the
"founder" - which was the player who bought the president's share, and to
put another check on the Investor to only allow it to take a share if the
current player was also the founder.

Mike


On Mon, Aug 26, 2013 at 2:45 AM, Dr....@t-... <
Dr....@t-...> wrote:

> Hi Michael,
>
>
>
> thanks, i'll incorporate the patches later today.
>
>
>
> Regarding the takeover in the initial round, tht should not be possible,
> as a player will found/start a company with at least 20 percent, the FI of
> the player gets another 10, that just leaves 20 percent in the open stock
> (till the first 3 has been bought). So theres no take over possible in the
> initial round. Ergo we have a bug in there somewhere. I'll have look later
> tonight at the save file.
>
>
>
> Regards,
>
> Martin
>
>
>
> *Von:* Michael Alexander <out...@gm...>
>
> *An:* "Development list for Rails: an 18xx game" <
> rai...@li...>
>
> *Betreff:* Re: [Rails-devel] Patch to fix private company revenue
>
> *Datum:* Mon, 26 Aug 2013 05:33:47 +0200
>
>
>
>
>   Martin,
>
> I think these patches fix the problems I saw with price slots.  I saw a
> few things (BCR didn't get a slot, for example, and I had trouble getting
> companies to open at the right prices).  I ended up pulling out the ParSlot
> into it's own class(es).  It didn't seem appropriate for it to be part of
> the stock market.  If you could take a look at these changes and let me
> know what you think, I'd appreciate it.
>
> I also included the save game that represents as far as I can get with
> this version in the online game I'm in before I hit another problem.  In
> the initial stock round, one of the players took the presidency of a
> company from another player.  The game (we believe incorrectly) then puts a
> share of that company in the FI.  We think because the second player didn't
> form the company (he just took it over) that it shouldn't do that.
>
> Mike
>
>
> On Sat, Aug 24, 2013 at 5:27 PM, Martin Brumm <dr....@t-...
> > wrote:
>
>  Am 24.08.2013 23:19, schrieb Michael Alexander:
>
> Hi Mike,
>
> i have a preliminary version in the latest 1880_specific committed.
>
> But it still has its flaws.
> Startround uses a different numeration, this is not yet carried over to
> the main StartCompany procedure.
> The StartCompany_procedure for the priceslot still needs adjustments also.
> If you want to give it a shot, great.
>
> I have prepared a build for the BGG-Guys to use with those caveats...
> Can be found at
> https://dl.dropboxusercontent.com/u/29072620/rails-1.7.12_1880.zip
> As i dont have access to the release build mechanismn on sourceforge
> myself :)
>
> Regards,
> Martin
>
> P.s. in the archive of rails-devel theres a lot of nice information
> regarding the intended architecture by Brett, Stefan and Erik.
>
>  Martin,
>
>     Are you working on the price slots?  I was thinking about taking a
> look at them, but I wouldn't want to step on stuff you've already written.
>
> Mike
>
>
> On Sat, Aug 24, 2013 at 3:36 PM, Martin Brumm <dr....@t-...
> > wrote:
>
>  Hi Michael,
>
> thanks again, i applied the patch to 1880_specific, though  i thought i
> had fixed the behaviour in the code already pushed.
>
> The second fix for StartCompany_1880 needs to be classified into the
> category : "Ouch :)".
>
> Thanks for catching it.
>
> Regards,
> Martin
>
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance Management.
> Visit us today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance Management.
> Visit us today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>

Re: [Rails-devel] Patch to fix private company revenue

[<Dr....@t-...>]

Hi Michael, 

	the behaviour of the code as currently observed is wrong. According
to the rules neither Investor should have a share of the HKR. The
Investor of Player A holds a BCR share, Player B buys 30% to become
director (thus no shares are available until the Phase 3). 

	And the rules state : 

	"As soon as the owner of the FI founds his first company (buys the
directors certificate), one share of this company is placed on the
charter of the foreigen investor." 

	So the current implementation by myself is flawed :(. 

	Your approach to fixing that sounds good, but dont forget to check
the fact that each FI gets only one share .) 

	Regards, 

	Martin 

	P.s. your changes are already committed so please fetch them first
and apply them to your local branch, otherwise i get to many patch
mismatches :) 

	P.P.s. Thanks again ! :)

	Von: Michael Alexander <out...@gm...> 

	An: "Dr....@t-..." <Dr....@t-...>, 
"Development list for Rails: an 18xx game"
<rai...@li...> 

	Betreff: Re: [Rails-devel] Patch to fix private company revenue 

	Datum: Mon, 26 Aug 2013 08:52:30 +0200 

	       The scenario was this:

 Player A bought the IG (getting the BCR).  His foreign investor took
a BCR share.  He then opened the HKR at 20%.  Player B (who had not
yet opened a company) bought the remaining 30% of HKR that was
available and took over the company.  The code assumed that Player B
has opened it, and gave player B's investor a share of HKR.

 My approach to fixing it (which I have coded, but isn't in the files
I sent because I just did it) was to have the public company keep
track of the "founder" - which was the player who bought the
president's share, and to put another check on the Investor to only
allow it to take a share if the current player was also the founder.

 Mike 

 On Mon, Aug 26, 2013 at 2:45 AM, Dr....@t-... [1]
<Dr....@t-... [2]> wrote:

	Hi Michael, 

	thanks, i'll incorporate the patches later today. 

	Regarding the takeover in the initial round, tht should not be
possible, as a player will found/start a company with at least 20
percent, the FI of the player gets another 10, that just leaves 20
percent in the open stock (till the first 3 has been bought). So
theres no take over possible in the initial round. Ergo we have a bug
in there somewhere. I'll have look later tonight at the save file. 

	Regards, 

	Martin  

	Von: Michael Alexander <out...@gm... [3]> 

	An: "Development list for Rails: an 18xx game"
<rai...@li... [4]> 

	Betreff: Re: [Rails-devel] Patch to fix private company revenue 

	Datum: Mon, 26 Aug 2013 05:33:47 +0200 

	       Martin, 

I think these patches fix the problems I saw with price slots.  I saw
a few things (BCR didn't get a slot, for example, and I had trouble
getting companies to open at the right prices).  I ended up pulling
out the ParSlot into it's own class(es).  It didn't seem appropriate
for it to be part of the stock market.  If you could take a look at
these changes and let me know what you think, I'd appreciate it.

 I also included the save game that represents as far as I can get
with this version in the online game I'm in before I hit another
problem.  In the initial stock round, one of the players took the
presidency of a company from another player.  The game (we believe
incorrectly) then puts a share of that company in the FI.  We think
because the second player didn't form the company (he just took it
over) that it shouldn't do that.

Mike  

 On Sat, Aug 24, 2013 at 5:27 PM, Martin Brumm
<dr....@t-... [5]> wrote:
   Am 24.08.2013 23:19, schrieb Michael Alexander:

 Hi Mike,

 i have a preliminary version in the latest 1880_specific committed.

 But it still has its flaws. 
 Startround uses a different numeration, this is not yet carried over
to the main StartCompany procedure.
 The StartCompany_procedure for the priceslot still needs adjustments
also. If you want to give it a shot, great.

 I have prepared a build for the BGG-Guys to use with those caveats...
 Can be found at
https://dl.dropboxusercontent.com/u/29072620/rails-1.7.12_1880.zip [6]
 As i dont have access to the release build mechanismn on sourceforge
myself :)

 Regards,
 Martin

 P.s. in the archive of rails-devel theres a lot of nice information
regarding the intended architecture by Brett, Stefan and Erik.   
Martin,

     Are you working on the price slots?  I was thinking about taking
a look at them, but I wouldn't want to step on stuff you've already
written.

 Mike 

 On Sat, Aug 24, 2013 at 3:36 PM, Martin Brumm
<dr....@t-... [7]> wrote:
   Hi Michael,

 thanks again, i applied the patch to 1880_specific, though  i thought
i had fixed the behaviour in the code already pushed.

 The second fix for StartCompany_1880 needs to be classified into the
category : "Ouch :)".

 Thanks for catching it.

 Regards,
 Martin        
------------------------------------------------------------------------------
 Introducing Performance Central, a new site from SourceForge and
 AppDynamics. Performance Central is your source for news, insights,
 analysis and resources for efficient Application Performance
Management.
 Visit us today!
 http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
[8]
 _______________________________________________
 Rails-devel mailing list
 Rai...@li... [9]
 https://lists.sourceforge.net/lists/listinfo/rails-devel [10]

------------------------------------------------------------------------------
 Introducing Performance Central, a new site from SourceForge and
 AppDynamics. Performance Central is your source for news, insights,
 analysis and resources for efficient Application Performance
Management.
 Visit us today!
 http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
[11]
_______________________________________________
 Rails-devel mailing list
 Rai...@li... [12]
 https://lists.sourceforge.net/lists/listinfo/rails-devel [13]

Links:
------
[1] mailto:Dr....@t-...
[2] mailto:Dr....@t-...
[3] mailto:out...@gm...
[4] mailto:rai...@li...
[5] mailto:dr....@t-...
[6] https://dl.dropboxusercontent.com/u/29072620/rails-1.7.12_1880.zip
[7] mailto:dr....@t-...
[8]
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&amp;iu=/4140/ostg.clktrk
[9] mailto:Rai...@li...
[10] https://lists.sourceforge.net/lists/listinfo/rails-devel
[11]
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&amp;iu=/4140/ostg.clktrk
[12] mailto:Rai...@li...
[13] https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Patch to fix private company revenue

[Chris S. <chr...@gm...>]

I've seen players open a second company several times, and seen it
taken over once. Even if a share was available, it should not be
assigned to a foreign investor, since the person taking over the
company did not found it. Here's a scenario where that might happen:

Player 1 launches HKR, FI takes HKR share
Player 1 launches JHA, no FI share taken
Player 2 buys JHA
Player 2 buys JHA
Player 1 seeing the takeover coming sells 2 JHA; player 2 becomes
president and still no FI takes a share even though one is available.

--
Chris

Please consider the environment before printing this e-mail.


On Mon, Aug 26, 2013 at 2:10 AM, Dr....@t-...
<Dr....@t-...> wrote:
> Hi Michael,
>
>
>
> the behaviour of the code as currently observed is wrong. According to the
> rules neither Investor should have a share of the HKR. The Investor of
> Player A holds a BCR share, Player B buys 30% to become director (thus no
> shares are available until the Phase 3).
>
>
>
> And the rules state :
>
> "As soon as the owner of the FI founds his first company (buys the directors
> certificate), one share of this company is placed on the charter of the
> foreigen investor."
>
>
>
> So the current implementation by myself is flawed :(.
>
>
>
> Your approach to fixing that sounds good, but dont forget to check the fact
> that each FI gets only one share .)
>
>
>
> Regards,
>
> Martin
>
>
>
> P.s. your changes are already committed so please fetch them first and apply
> them to your local branch, otherwise i get to many patch mismatches :)
>
> P.P.s. Thanks again ! :)
>
>
>
>
>
>
> Von: Michael Alexander <out...@gm...>
>
> An: "Dr....@t-..." <Dr....@t-...>,
> "Development list for Rails: an 18xx game"
> <rai...@li...>
>
> Betreff: Re: [Rails-devel] Patch to fix private company revenue
>
> Datum: Mon, 26 Aug 2013 08:52:30 +0200
>
>
>
>
>
> The scenario was this:
>
> Player A bought the IG (getting the BCR).  His foreign investor took a BCR
> share.  He then opened the HKR at 20%.  Player B (who had not yet opened a
> company) bought the remaining 30% of HKR that was available and took over
> the company.  The code assumed that Player B has opened it, and gave player
> B's investor a share of HKR.
>
> My approach to fixing it (which I have coded, but isn't in the files I sent
> because I just did it) was to have the public company keep track of the
> "founder" - which was the player who bought the president's share, and to
> put another check on the Investor to only allow it to take a share if the
> current player was also the founder.
>
> Mike
>
>
> On Mon, Aug 26, 2013 at 2:45 AM, Dr....@t-...
> <Dr....@t-...> wrote:
>
> Hi Michael,
>
>
>
> thanks, i'll incorporate the patches later today.
>
>
>
> Regarding the takeover in the initial round, tht should not be possible, as
> a player will found/start a company with at least 20 percent, the FI of the
> player gets another 10, that just leaves 20 percent in the open stock (till
> the first 3 has been bought). So theres no take over possible in the initial
> round. Ergo we have a bug in there somewhere. I'll have look later tonight
> at the save file.
>
>
>
> Regards,
>
> Martin
>
>
>
> Von: Michael Alexander <out...@gm...>
>
> An: "Development list for Rails: an 18xx game"
> <rai...@li...>
>
> Betreff: Re: [Rails-devel] Patch to fix private company revenue
>
> Datum: Mon, 26 Aug 2013 05:33:47 +0200
>
>
>
>
>
> Martin,
>
> I think these patches fix the problems I saw with price slots.  I saw a few
> things (BCR didn't get a slot, for example, and I had trouble getting
> companies to open at the right prices).  I ended up pulling out the ParSlot
> into it's own class(es).  It didn't seem appropriate for it to be part of
> the stock market.  If you could take a look at these changes and let me know
> what you think, I'd appreciate it.
>
> I also included the save game that represents as far as I can get with this
> version in the online game I'm in before I hit another problem.  In the
> initial stock round, one of the players took the presidency of a company
> from another player.  The game (we believe incorrectly) then puts a share of
> that company in the FI.  We think because the second player didn't form the
> company (he just took it over) that it shouldn't do that.
>
> Mike
>
>
> On Sat, Aug 24, 2013 at 5:27 PM, Martin Brumm <dr....@t-...>
> wrote:
>
> Am 24.08.2013 23:19, schrieb Michael Alexander:
>
> Hi Mike,
>
> i have a preliminary version in the latest 1880_specific committed.
>
> But it still has its flaws.
> Startround uses a different numeration, this is not yet carried over to the
> main StartCompany procedure.
> The StartCompany_procedure for the priceslot still needs adjustments also.
> If you want to give it a shot, great.
>
> I have prepared a build for the BGG-Guys to use with those caveats...
> Can be found at
> https://dl.dropboxusercontent.com/u/29072620/rails-1.7.12_1880.zip
> As i dont have access to the release build mechanismn on sourceforge myself
> :)
>
> Regards,
> Martin
>
> P.s. in the archive of rails-devel theres a lot of nice information
> regarding the intended architecture by Brett, Stefan and Erik.
>
> Martin,
>
>     Are you working on the price slots?  I was thinking about taking a look
> at them, but I wouldn't want to step on stuff you've already written.
>
> Mike
>
>
> On Sat, Aug 24, 2013 at 3:36 PM, Martin Brumm <dr....@t-...>
> wrote:
>
> Hi Michael,
>
> thanks again, i applied the patch to 1880_specific, though  i thought i had
> fixed the behaviour in the code already pushed.
>
> The second fix for StartCompany_1880 needs to be classified into the
> category : "Ouch :)".
>
> Thanks for catching it.
>
> Regards,
> Martin
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance Management.
> Visit us today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance Management.
> Visit us today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance Management.
> Visit us today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Patch to fix private company revenue

[Chris S. <chr...@gm...>]

Also note that a player can decline to open a company in SR1. I once
saw a game where a player's first company was founded after the first
T4 was purchased.

--
Chris

Please consider the environment before printing this e-mail.


On Mon, Aug 26, 2013 at 6:24 AM, Chris Shaffer <chr...@gm...> wrote:
> I've seen players open a second company several times, and seen it
> taken over once. Even if a share was available, it should not be
> assigned to a foreign investor, since the person taking over the
> company did not found it. Here's a scenario where that might happen:
>
> Player 1 launches HKR, FI takes HKR share
> Player 1 launches JHA, no FI share taken
> Player 2 buys JHA
> Player 2 buys JHA
> Player 1 seeing the takeover coming sells 2 JHA; player 2 becomes
> president and still no FI takes a share even though one is available.
>
> --
> Chris
>
> Please consider the environment before printing this e-mail.
>
>
> On Mon, Aug 26, 2013 at 2:10 AM, Dr....@t-...
> <Dr....@t-...> wrote:
>> Hi Michael,
>>
>>
>>
>> the behaviour of the code as currently observed is wrong. According to the
>> rules neither Investor should have a share of the HKR. The Investor of
>> Player A holds a BCR share, Player B buys 30% to become director (thus no
>> shares are available until the Phase 3).
>>
>>
>>
>> And the rules state :
>>
>> "As soon as the owner of the FI founds his first company (buys the directors
>> certificate), one share of this company is placed on the charter of the
>> foreigen investor."
>>
>>
>>
>> So the current implementation by myself is flawed :(.
>>
>>
>>
>> Your approach to fixing that sounds good, but dont forget to check the fact
>> that each FI gets only one share .)
>>
>>
>>
>> Regards,
>>
>> Martin
>>
>>
>>
>> P.s. your changes are already committed so please fetch them first and apply
>> them to your local branch, otherwise i get to many patch mismatches :)
>>
>> P.P.s. Thanks again ! :)
>>
>>
>>
>>
>>
>>
>> Von: Michael Alexander <out...@gm...>
>>
>> An: "Dr....@t-..." <Dr....@t-...>,
>> "Development list for Rails: an 18xx game"
>> <rai...@li...>
>>
>> Betreff: Re: [Rails-devel] Patch to fix private company revenue
>>
>> Datum: Mon, 26 Aug 2013 08:52:30 +0200
>>
>>
>>
>>
>>
>> The scenario was this:
>>
>> Player A bought the IG (getting the BCR).  His foreign investor took a BCR
>> share.  He then opened the HKR at 20%.  Player B (who had not yet opened a
>> company) bought the remaining 30% of HKR that was available and took over
>> the company.  The code assumed that Player B has opened it, and gave player
>> B's investor a share of HKR.
>>
>> My approach to fixing it (which I have coded, but isn't in the files I sent
>> because I just did it) was to have the public company keep track of the
>> "founder" - which was the player who bought the president's share, and to
>> put another check on the Investor to only allow it to take a share if the
>> current player was also the founder.
>>
>> Mike
>>
>>
>> On Mon, Aug 26, 2013 at 2:45 AM, Dr....@t-...
>> <Dr....@t-...> wrote:
>>
>> Hi Michael,
>>
>>
>>
>> thanks, i'll incorporate the patches later today.
>>
>>
>>
>> Regarding the takeover in the initial round, tht should not be possible, as
>> a player will found/start a company with at least 20 percent, the FI of the
>> player gets another 10, that just leaves 20 percent in the open stock (till
>> the first 3 has been bought). So theres no take over possible in the initial
>> round. Ergo we have a bug in there somewhere. I'll have look later tonight
>> at the save file.
>>
>>
>>
>> Regards,
>>
>> Martin
>>
>>
>>
>> Von: Michael Alexander <out...@gm...>
>>
>> An: "Development list for Rails: an 18xx game"
>> <rai...@li...>
>>
>> Betreff: Re: [Rails-devel] Patch to fix private company revenue
>>
>> Datum: Mon, 26 Aug 2013 05:33:47 +0200
>>
>>
>>
>>
>>
>> Martin,
>>
>> I think these patches fix the problems I saw with price slots.  I saw a few
>> things (BCR didn't get a slot, for example, and I had trouble getting
>> companies to open at the right prices).  I ended up pulling out the ParSlot
>> into it's own class(es).  It didn't seem appropriate for it to be part of
>> the stock market.  If you could take a look at these changes and let me know
>> what you think, I'd appreciate it.
>>
>> I also included the save game that represents as far as I can get with this
>> version in the online game I'm in before I hit another problem.  In the
>> initial stock round, one of the players took the presidency of a company
>> from another player.  The game (we believe incorrectly) then puts a share of
>> that company in the FI.  We think because the second player didn't form the
>> company (he just took it over) that it shouldn't do that.
>>
>> Mike
>>
>>
>> On Sat, Aug 24, 2013 at 5:27 PM, Martin Brumm <dr....@t-...>
>> wrote:
>>
>> Am 24.08.2013 23:19, schrieb Michael Alexander:
>>
>> Hi Mike,
>>
>> i have a preliminary version in the latest 1880_specific committed.
>>
>> But it still has its flaws.
>> Startround uses a different numeration, this is not yet carried over to the
>> main StartCompany procedure.
>> The StartCompany_procedure for the priceslot still needs adjustments also.
>> If you want to give it a shot, great.
>>
>> I have prepared a build for the BGG-Guys to use with those caveats...
>> Can be found at
>> https://dl.dropboxusercontent.com/u/29072620/rails-1.7.12_1880.zip
>> As i dont have access to the release build mechanismn on sourceforge myself
>> :)
>>
>> Regards,
>> Martin
>>
>> P.s. in the archive of rails-devel theres a lot of nice information
>> regarding the intended architecture by Brett, Stefan and Erik.
>>
>> Martin,
>>
>>     Are you working on the price slots?  I was thinking about taking a look
>> at them, but I wouldn't want to step on stuff you've already written.
>>
>> Mike
>>
>>
>> On Sat, Aug 24, 2013 at 3:36 PM, Martin Brumm <dr....@t-...>
>> wrote:
>>
>> Hi Michael,
>>
>> thanks again, i applied the patch to 1880_specific, though  i thought i had
>> fixed the behaviour in the code already pushed.
>>
>> The second fix for StartCompany_1880 needs to be classified into the
>> category : "Ouch :)".
>>
>> Thanks for catching it.
>>
>> Regards,
>> Martin
>>
>>
>> ------------------------------------------------------------------------------
>> Introducing Performance Central, a new site from SourceForge and
>> AppDynamics. Performance Central is your source for news, insights,
>> analysis and resources for efficient Application Performance Management.
>> Visit us today!
>> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Introducing Performance Central, a new site from SourceForge and
>> AppDynamics. Performance Central is your source for news, insights,
>> analysis and resources for efficient Application Performance Management.
>> Visit us today!
>> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Introducing Performance Central, a new site from SourceForge and
>> AppDynamics. Performance Central is your source for news, insights,
>> analysis and resources for efficient Application Performance Management.
>> Visit us today!
>> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>

Re: [Rails-devel] Patch to fix private company revenue

[Michael A. <out...@gm...>]

Martin had almost all of the logic in place for this - I just had to add in
one additional check.


On Mon, Aug 26, 2013 at 9:24 AM, Chris Shaffer <chr...@gm...>wrote:

> I've seen players open a second company several times, and seen it
> taken over once. Even if a share was available, it should not be
> assigned to a foreign investor, since the person taking over the
> company did not found it. Here's a scenario where that might happen:
>
> Player 1 launches HKR, FI takes HKR share
> Player 1 launches JHA, no FI share taken
> Player 2 buys JHA
> Player 2 buys JHA
> Player 1 seeing the takeover coming sells 2 JHA; player 2 becomes
> president and still no FI takes a share even though one is available.
>
> --
> Chris
>
> Please consider the environment before printing this e-mail.
>
>
> On Mon, Aug 26, 2013 at 2:10 AM, Dr....@t-...
> <Dr....@t-...> wrote:
> > Hi Michael,
> >
> >
> >
> > the behaviour of the code as currently observed is wrong. According to
> the
> > rules neither Investor should have a share of the HKR. The Investor of
> > Player A holds a BCR share, Player B buys 30% to become director (thus no
> > shares are available until the Phase 3).
> >
> >
> >
> > And the rules state :
> >
> > "As soon as the owner of the FI founds his first company (buys the
> directors
> > certificate), one share of this company is placed on the charter of the
> > foreigen investor."
> >
> >
> >
> > So the current implementation by myself is flawed :(.
> >
> >
> >
> > Your approach to fixing that sounds good, but dont forget to check the
> fact
> > that each FI gets only one share .)
> >
> >
> >
> > Regards,
> >
> > Martin
> >
> >
> >
> > P.s. your changes are already committed so please fetch them first and
> apply
> > them to your local branch, otherwise i get to many patch mismatches :)
> >
> > P.P.s. Thanks again ! :)
> >
> >
> >
> >
> >
> >
> > Von: Michael Alexander <out...@gm...>
> >
> > An: "Dr....@t-..." <Dr....@t-...>,
> > "Development list for Rails: an 18xx game"
> > <rai...@li...>
> >
> > Betreff: Re: [Rails-devel] Patch to fix private company revenue
> >
> > Datum: Mon, 26 Aug 2013 08:52:30 +0200
> >
> >
> >
> >
> >
> > The scenario was this:
> >
> > Player A bought the IG (getting the BCR).  His foreign investor took a
> BCR
> > share.  He then opened the HKR at 20%.  Player B (who had not yet opened
> a
> > company) bought the remaining 30% of HKR that was available and took over
> > the company.  The code assumed that Player B has opened it, and gave
> player
> > B's investor a share of HKR.
> >
> > My approach to fixing it (which I have coded, but isn't in the files I
> sent
> > because I just did it) was to have the public company keep track of the
> > "founder" - which was the player who bought the president's share, and to
> > put another check on the Investor to only allow it to take a share if the
> > current player was also the founder.
> >
> > Mike
> >
> >
> > On Mon, Aug 26, 2013 at 2:45 AM, Dr....@t-...
> > <Dr....@t-...> wrote:
> >
> > Hi Michael,
> >
> >
> >
> > thanks, i'll incorporate the patches later today.
> >
> >
> >
> > Regarding the takeover in the initial round, tht should not be possible,
> as
> > a player will found/start a company with at least 20 percent, the FI of
> the
> > player gets another 10, that just leaves 20 percent in the open stock
> (till
> > the first 3 has been bought). So theres no take over possible in the
> initial
> > round. Ergo we have a bug in there somewhere. I'll have look later
> tonight
> > at the save file.
> >
> >
> >
> > Regards,
> >
> > Martin
> >
> >
> >
> > Von: Michael Alexander <out...@gm...>
> >
> > An: "Development list for Rails: an 18xx game"
> > <rai...@li...>
> >
> > Betreff: Re: [Rails-devel] Patch to fix private company revenue
> >
> > Datum: Mon, 26 Aug 2013 05:33:47 +0200
> >
> >
> >
> >
> >
> > Martin,
> >
> > I think these patches fix the problems I saw with price slots.  I saw a
> few
> > things (BCR didn't get a slot, for example, and I had trouble getting
> > companies to open at the right prices).  I ended up pulling out the
> ParSlot
> > into it's own class(es).  It didn't seem appropriate for it to be part of
> > the stock market.  If you could take a look at these changes and let me
> know
> > what you think, I'd appreciate it.
> >
> > I also included the save game that represents as far as I can get with
> this
> > version in the online game I'm in before I hit another problem.  In the
> > initial stock round, one of the players took the presidency of a company
> > from another player.  The game (we believe incorrectly) then puts a
> share of
> > that company in the FI.  We think because the second player didn't form
> the
> > company (he just took it over) that it shouldn't do that.
> >
> > Mike
> >
> >
> > On Sat, Aug 24, 2013 at 5:27 PM, Martin Brumm <
> dr....@t-...>
> > wrote:
> >
> > Am 24.08.2013 23:19, schrieb Michael Alexander:
> >
> > Hi Mike,
> >
> > i have a preliminary version in the latest 1880_specific committed.
> >
> > But it still has its flaws.
> > Startround uses a different numeration, this is not yet carried over to
> the
> > main StartCompany procedure.
> > The StartCompany_procedure for the priceslot still needs adjustments
> also.
> > If you want to give it a shot, great.
> >
> > I have prepared a build for the BGG-Guys to use with those caveats...
> > Can be found at
> > https://dl.dropboxusercontent.com/u/29072620/rails-1.7.12_1880.zip
> > As i dont have access to the release build mechanismn on sourceforge
> myself
> > :)
> >
> > Regards,
> > Martin
> >
> > P.s. in the archive of rails-devel theres a lot of nice information
> > regarding the intended architecture by Brett, Stefan and Erik.
> >
> > Martin,
> >
> >     Are you working on the price slots?  I was thinking about taking a
> look
> > at them, but I wouldn't want to step on stuff you've already written.
> >
> > Mike
> >
> >
> > On Sat, Aug 24, 2013 at 3:36 PM, Martin Brumm <
> dr....@t-...>
> > wrote:
> >
> > Hi Michael,
> >
> > thanks again, i applied the patch to 1880_specific, though  i thought i
> had
> > fixed the behaviour in the code already pushed.
> >
> > The second fix for StartCompany_1880 needs to be classified into the
> > category : "Ouch :)".
> >
> > Thanks for catching it.
> >
> > Regards,
> > Martin
> >
> >
> >
> ------------------------------------------------------------------------------
> > Introducing Performance Central, a new site from SourceForge and
> > AppDynamics. Performance Central is your source for news, insights,
> > analysis and resources for efficient Application Performance Management.
> > Visit us today!
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
> >
> >
> >
> >
> ------------------------------------------------------------------------------
> > Introducing Performance Central, a new site from SourceForge and
> > AppDynamics. Performance Central is your source for news, insights,
> > analysis and resources for efficient Application Performance Management.
> > Visit us today!
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
> >
> >
> >
> >
> ------------------------------------------------------------------------------
> > Introducing Performance Central, a new site from SourceForge and
> > AppDynamics. Performance Central is your source for news, insights,
> > analysis and resources for efficient Application Performance Management.
> > Visit us today!
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
>