From: Phil D. <de...@gm...> - 2011-02-24 11:07:01
Attachments:
1856.patch
|
Hey all, Discovered a 'bug' (ish) in 1856 whilst playing a game recently. Currently rails checks to see whether the CGR is running a borrowed train and if it is then rails forces the CGR to withhold. The situation that occurred in this game was that the CGR was able to run a 4T inherited from it's merger corporations, I believe from the rules that it must withhold revenues from a 4T until it can buy a permanent train (I'm FAR from an expert on '56 though so if someone could clarify that would be nice). Admittedly this is one of those areas where the players should know the rules but it's nice to enforce these anyway, I believe the attached patch should fix the issue (simply changing the 'check for a borrowed train' into a 'check if CGR has a permanent train') but would appreciate someone more skilled just double checking the impact! There was a further issue in that I think it was allowed to buy a 4T from another corp, something it should not be allowed to do, but I haven't looked into that in detail yet Phil |
From: Stefan F. <jk...@gm...> - 2011-02-24 12:26:03
|
Hello Phil, -------- Original-Nachricht -------- > Datum: Thu, 24 Feb 2011 11:06:41 +0000 > Von: Phil Davies <de...@gm...> > An: "Development list for Rails: an 18xx game" <rai...@li...> > Betreff: [Rails-devel] 1856 Issue > Discovered a 'bug' (ish) in 1856 whilst playing a game recently. > Currently rails checks to see whether the CGR is running a borrowed > train and if it is then rails forces the CGR to withhold. The > situation that occurred in this game was that the CGR was able to run > a 4T inherited from it's merger corporations, I believe from the rules > that it must withhold revenues from a 4T until it can buy a permanent > train (I'm FAR from an expert on '56 though so if someone could > clarify that would be nice). You are right, the information is "hidden" in the section about Dividends within the CGR-Chapter: "When the CGR has a permanent train, it may, at the discretion of the current president, pay dividends." or http:/www.18xx.net/1856/1856f.htm > There was a further issue in that I think it was allowed to buy a 4T > from another corp, something it should not be allowed to do, but I > haven't looked into that in detail yet. Could you check if the Share Value token does move too? (It shouldn't) ciao stefan |
From: Phil D. <de...@gm...> - 2011-02-24 14:01:37
|
On 24 February 2011 12:25, Stefan Filonardi <jk...@gm...> wrote: >> There was a further issue in that I think it was allowed to buy a 4T >> from another corp, something it should not be allowed to do, but I >> haven't looked into that in detail yet. > > Could you check if the Share Value token does move too? (It shouldn't) > Short answer: no Longer answer: no, the share price does not move for sales or withholding. It moves up if the CGR pays out with a 4 train, which of course it isn't allowed to do. So if this fixes the forced withholding bug then the token movement becomes a non-issue. Phil |
From: Erik V. <eri...@xs...> - 2011-02-24 21:42:40
|
I clearly have misinterpreted the rules on this aspect. Thanks for the fix, I have applied it. Erik. > -----Oorspronkelijk bericht----- > Van: Phil Davies [mailto:de...@gm...] > Verzonden: donderdag 24 februari 2011 12:07 > Aan: Development list for Rails: an 18xx game > Onderwerp: [Rails-devel] 1856 Issue > > Hey all, > > Discovered a 'bug' (ish) in 1856 whilst playing a game recently. > Currently rails checks to see whether the CGR is running a borrowed train > and if it is then rails forces the CGR to withhold. The situation that occurred > in this game was that the CGR was able to run a 4T inherited from it's merger > corporations, I believe from the rules that it must withhold revenues from a > 4T until it can buy a permanent train (I'm FAR from an expert on '56 though so > if someone could clarify that would be nice). > > Admittedly this is one of those areas where the players should know the > rules but it's nice to enforce these anyway, I believe the attached patch > should fix the issue (simply changing the 'check for a borrowed train' into a > 'check if CGR has a permanent train') but would appreciate someone more > skilled just double checking the impact! > > There was a further issue in that I think it was allowed to buy a 4T from > another corp, something it should not be allowed to do, but I haven't looked > into that in detail yet > > Phil |
From: Aliza P. <ali...@gm...> - 2011-02-25 01:00:37
|
To be more precise: "Until the CGR has a permanent train (a type 5, type 6 or Diesel), its token on the stock market is not adjusted from its starting position for any reason, including sales of shares. Once the CGR acquires its first permanent train, it may no longer borrow a Diesel." So if (for example) the CGR forms with a 5-train and sells it to another company for face value, it cannot borrow a Diesel, and moves backwards normally if it has no train. On Thu, Feb 24, 2011 at 4:25 AM, Stefan Filonardi <jk...@gm...> wrote: > Hello Phil, > > -------- Original-Nachricht -------- >> Datum: Thu, 24 Feb 2011 11:06:41 +0000 >> Von: Phil Davies <de...@gm...> >> An: "Development list for Rails: an 18xx game" <rai...@li...> >> Betreff: [Rails-devel] 1856 Issue > >> Discovered a 'bug' (ish) in 1856 whilst playing a game recently. >> Currently rails checks to see whether the CGR is running a borrowed >> train and if it is then rails forces the CGR to withhold. The >> situation that occurred in this game was that the CGR was able to run >> a 4T inherited from it's merger corporations, I believe from the rules >> that it must withhold revenues from a 4T until it can buy a permanent >> train (I'm FAR from an expert on '56 though so if someone could >> clarify that would be nice). > > You are right, the information is "hidden" in the section about Dividends within the CGR-Chapter: > "When the CGR has a permanent train, it may, at the discretion of the current president, pay dividends." or > > http:/www.18xx.net/1856/1856f.htm > >> There was a further issue in that I think it was allowed to buy a 4T >> from another corp, something it should not be allowed to do, but I >> haven't looked into that in detail yet. > > Could you check if the Share Value token does move too? (It shouldn't) > > ciao stefan > > |
From: Phil D. <de...@gm...> - 2011-02-25 09:34:31
|
I'm pretty sure that all works fine although I'll run up a test case to check it. The whole process around 'has CGR acquired a permanent train or not' seems fairly solid, the bit that was missing was the behaviour if it inherits a 4 that hangs around long enough for the CGR to run it. On 25 February 2011 01:00, Aliza Panitz <ali...@gm...> wrote: > To be more precise: > > "Until the CGR has a permanent train (a type 5, type 6 or Diesel), its > token on the stock market is not adjusted from its starting position > for any reason, including sales of shares. Once the CGR acquires its > first permanent train, it may no longer borrow a Diesel." > > So if (for example) the CGR forms with a 5-train and sells it to > another company for face value, it cannot borrow a Diesel, and moves > backwards normally if it has no train. > > On Thu, Feb 24, 2011 at 4:25 AM, Stefan Filonardi <jk...@gm...> wrote: >> Hello Phil, >> >> -------- Original-Nachricht -------- >>> Datum: Thu, 24 Feb 2011 11:06:41 +0000 >>> Von: Phil Davies <de...@gm...> >>> An: "Development list for Rails: an 18xx game" <rai...@li...> >>> Betreff: [Rails-devel] 1856 Issue >> >>> Discovered a 'bug' (ish) in 1856 whilst playing a game recently. >>> Currently rails checks to see whether the CGR is running a borrowed >>> train and if it is then rails forces the CGR to withhold. The >>> situation that occurred in this game was that the CGR was able to run >>> a 4T inherited from it's merger corporations, I believe from the rules >>> that it must withhold revenues from a 4T until it can buy a permanent >>> train (I'm FAR from an expert on '56 though so if someone could >>> clarify that would be nice). >> >> You are right, the information is "hidden" in the section about Dividends within the CGR-Chapter: >> "When the CGR has a permanent train, it may, at the discretion of the current president, pay dividends." or >> >> http:/www.18xx.net/1856/1856f.htm >> >>> There was a further issue in that I think it was allowed to buy a 4T >>> from another corp, something it should not be allowed to do, but I >>> haven't looked into that in detail yet. >> >> Could you check if the Share Value token does move too? (It shouldn't) >> >> ciao stefan >> >> > > ------------------------------------------------------------------------------ > Free Software Download: Index, Search & Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
From: Phil D. <de...@gm...> - 2011-02-25 11:57:36
|
Just to confirm that Aliza's mentioned scenario works fine, the logic for noting that the CGR has or has not acquired a permanent train works even if it disposes of it later. Phil On 25 February 2011 09:34, Phil Davies <de...@gm...> wrote: > I'm pretty sure that all works fine although I'll run up a test case > to check it. The whole process around 'has CGR acquired a permanent > train or not' seems fairly solid, the bit that was missing was the > behaviour if it inherits a 4 that hangs around long enough for the CGR > to run it. > > On 25 February 2011 01:00, Aliza Panitz <ali...@gm...> wrote: >> To be more precise: >> >> "Until the CGR has a permanent train (a type 5, type 6 or Diesel), its >> token on the stock market is not adjusted from its starting position >> for any reason, including sales of shares. Once the CGR acquires its >> first permanent train, it may no longer borrow a Diesel." >> >> So if (for example) the CGR forms with a 5-train and sells it to >> another company for face value, it cannot borrow a Diesel, and moves >> backwards normally if it has no train. >> >> On Thu, Feb 24, 2011 at 4:25 AM, Stefan Filonardi <jk...@gm...> wrote: >>> Hello Phil, >>> >>> -------- Original-Nachricht -------- >>>> Datum: Thu, 24 Feb 2011 11:06:41 +0000 >>>> Von: Phil Davies <de...@gm...> >>>> An: "Development list for Rails: an 18xx game" <rai...@li...> >>>> Betreff: [Rails-devel] 1856 Issue >>> >>>> Discovered a 'bug' (ish) in 1856 whilst playing a game recently. >>>> Currently rails checks to see whether the CGR is running a borrowed >>>> train and if it is then rails forces the CGR to withhold. The >>>> situation that occurred in this game was that the CGR was able to run >>>> a 4T inherited from it's merger corporations, I believe from the rules >>>> that it must withhold revenues from a 4T until it can buy a permanent >>>> train (I'm FAR from an expert on '56 though so if someone could >>>> clarify that would be nice). >>> >>> You are right, the information is "hidden" in the section about Dividends within the CGR-Chapter: >>> "When the CGR has a permanent train, it may, at the discretion of the current president, pay dividends." or >>> >>> http:/www.18xx.net/1856/1856f.htm >>> >>>> There was a further issue in that I think it was allowed to buy a 4T >>>> from another corp, something it should not be allowed to do, but I >>>> haven't looked into that in detail yet. >>> >>> Could you check if the Share Value token does move too? (It shouldn't) >>> >>> ciao stefan >>> >>> >> >> ------------------------------------------------------------------------------ >> Free Software Download: Index, Search & Analyze Logs and other IT data in >> Real-Time with Splunk. Collect, index and harness all the fast moving IT data >> generated by your applications, servers and devices whether physical, virtual >> or in the cloud. Deliver compliance at lower cost and gain new business >> insights. http://p.sf.net/sfu/splunk-dev2dev >> _______________________________________________ >> Rails-devel mailing list >> Rai...@li... >> https://lists.sourceforge.net/lists/listinfo/rails-devel >> > |