Menu
▾
▴
rails-devel
|
From: Michael A. <out...@gm...> - 2014-08-24 04:05:50
|
The current implementation of StartItem doesn't allow a bid of 0. I made a StartItem_1862 which does allow it - but there's no mechanism to specify the class of a start item in the XML. So I could go a couple ways with this: a) Put the differences from StartItem_1862 into StartItem. I can then run the tests to make sure I didn't break other games, but I worry a bit because there are mentions of 18EU in StartItem, but no tests for 18EU. b) Add the ability to specify the class for each StartItem in the XML. Is there a preference for which way I should go with this? Mike |
|
From: Stefan F. <ste...@we...> - 2014-08-24 16:40:07
|
Why does it now allow a bid of zero? Excuse my ignorance. It is easy to add a test case for the 18EU again, at least for the initial auction, so I recommend to go ahead with a). Please be not too afraid to change core classes. There are only a few cases to be really careful, as they are complex, easy to break and/or there no automated tests: A) Algorithm package (complex, easy to break, no automated tests) B) UI classes (easy to break, no automated tests) C) Action classes (easy to break) On 08/24/2014 06:05 AM, Michael Alexander wrote: > The current implementation of StartItem doesn't allow a bid of 0. I > made a StartItem_1862 which does allow it - but there's no mechanism to > specify the class of a start item in the XML. So I could go a couple > ways with this: > > a) Put the differences from StartItem_1862 into StartItem. I can then > run the tests to make sure I didn't break other games, but I worry a bit > because there are mentions of 18EU in StartItem, but no tests for 18EU. > > b) Add the ability to specify the class for each StartItem in the XML. > > Is there a preference for which way I should go with this? > > Mike > > > ------------------------------------------------------------------------------ > Slashdot TV. > Video for Nerds. Stuff that matters. > http://tv.slashdot.org/ > > > > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
|
From: Michael A. <out...@gm...> - 2014-08-24 16:49:13
|
It assumes that a bid of zero means that the player has not made a bid on that item, and are therefore not "active" in an auction. So it allows it, but the player is then left out. On Sun, Aug 24, 2014 at 12:39 PM, Stefan Frey <ste...@we...> wrote: > Why does it now allow a bid of zero? Excuse my ignorance. > > It is easy to add a test case for the 18EU again, at least for the > initial auction, so I recommend to go ahead with a). > > Please be not too afraid to change core classes. There are only a few > cases to be really careful, as they are complex, easy to break and/or > there no automated tests: > > A) Algorithm package (complex, easy to break, no automated tests) > B) UI classes (easy to break, no automated tests) > C) Action classes (easy to break) > > > On 08/24/2014 06:05 AM, Michael Alexander wrote: > > The current implementation of StartItem doesn't allow a bid of 0. I > > made a StartItem_1862 which does allow it - but there's no mechanism to > > specify the class of a start item in the XML. So I could go a couple > > ways with this: > > > > a) Put the differences from StartItem_1862 into StartItem. I can then > > run the tests to make sure I didn't break other games, but I worry a bit > > because there are mentions of 18EU in StartItem, but no tests for 18EU. > > > > b) Add the ability to specify the class for each StartItem in the XML. > > > > Is there a preference for which way I should go with this? > > > > Mike > > > > > > > ------------------------------------------------------------------------------ > > Slashdot TV. > > Video for Nerds. Stuff that matters. > > http://tv.slashdot.org/ > > > > > > > > _______________________________________________ > > Rails-devel mailing list > > Rai...@li... > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > > ------------------------------------------------------------------------------ > Slashdot TV. > Video for Nerds. Stuff that matters. > http://tv.slashdot.org/ > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
|
From: Stefan F. <ste...@we...> - 2014-08-24 17:16:42
|
OK, is it possible to separate that indication "active" into a boolean (state?) variable, that would my preferred way to go. On 08/24/2014 06:49 PM, Michael Alexander wrote: > It assumes that a bid of zero means that the player has not made a bid > on that item, and are therefore not "active" in an auction. So it > allows it, but the player is then left out. > > > On Sun, Aug 24, 2014 at 12:39 PM, Stefan Frey <ste...@we... > <mailto:ste...@we...>> wrote: > > Why does it now allow a bid of zero? Excuse my ignorance. > > It is easy to add a test case for the 18EU again, at least for the > initial auction, so I recommend to go ahead with a). > > Please be not too afraid to change core classes. There are only a few > cases to be really careful, as they are complex, easy to break and/or > there no automated tests: > > A) Algorithm package (complex, easy to break, no automated tests) > B) UI classes (easy to break, no automated tests) > C) Action classes (easy to break) > > > On 08/24/2014 06:05 AM, Michael Alexander wrote: > > The current implementation of StartItem doesn't allow a bid of 0. I > > made a StartItem_1862 which does allow it - but there's no > mechanism to > > specify the class of a start item in the XML. So I could go a couple > > ways with this: > > > > a) Put the differences from StartItem_1862 into StartItem. I > can then > > run the tests to make sure I didn't break other games, but I > worry a bit > > because there are mentions of 18EU in StartItem, but no tests for > 18EU. > > > > b) Add the ability to specify the class for each StartItem in > the XML. > > > > Is there a preference for which way I should go with this? > > > > Mike > > > > > > > ------------------------------------------------------------------------------ > > Slashdot TV. > > Video for Nerds. Stuff that matters. > > http://tv.slashdot.org/ > > > > > > > > _______________________________________________ > > Rails-devel mailing list > > Rai...@li... > <mailto:Rai...@li...> > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > ------------------------------------------------------------------------------ > Slashdot TV. > Video for Nerds. Stuff that matters. > http://tv.slashdot.org/ > _______________________________________________ > Rails-devel mailing list > Rai...@li... > <mailto:Rai...@li...> > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > > ------------------------------------------------------------------------------ > Slashdot TV. > Video for Nerds. Stuff that matters. > http://tv.slashdot.org/ > > > > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
|
From: Michael A. <out...@gm...> - 2014-08-24 17:23:08
|
That's exactly what I was thinking, and it's already implemented. :) On Sun, Aug 24, 2014 at 1:16 PM, Stefan Frey <ste...@we...> wrote: > OK, is it possible to separate that indication "active" into a boolean > (state?) variable, that would my preferred way to go. > > On 08/24/2014 06:49 PM, Michael Alexander wrote: > > It assumes that a bid of zero means that the player has not made a bid > > on that item, and are therefore not "active" in an auction. So it > > allows it, but the player is then left out. > > > > > > On Sun, Aug 24, 2014 at 12:39 PM, Stefan Frey <ste...@we... > > <mailto:ste...@we...>> wrote: > > > > Why does it now allow a bid of zero? Excuse my ignorance. > > > > It is easy to add a test case for the 18EU again, at least for the > > initial auction, so I recommend to go ahead with a). > > > > Please be not too afraid to change core classes. There are only a few > > cases to be really careful, as they are complex, easy to break and/or > > there no automated tests: > > > > A) Algorithm package (complex, easy to break, no automated tests) > > B) UI classes (easy to break, no automated tests) > > C) Action classes (easy to break) > > > > > > On 08/24/2014 06:05 AM, Michael Alexander wrote: > > > The current implementation of StartItem doesn't allow a bid of > 0. I > > > made a StartItem_1862 which does allow it - but there's no > > mechanism to > > > specify the class of a start item in the XML. So I could go a > couple > > > ways with this: > > > > > > a) Put the differences from StartItem_1862 into StartItem. I > > can then > > > run the tests to make sure I didn't break other games, but I > > worry a bit > > > because there are mentions of 18EU in StartItem, but no tests for > > 18EU. > > > > > > b) Add the ability to specify the class for each StartItem in > > the XML. > > > > > > Is there a preference for which way I should go with this? > > > > > > Mike > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > Slashdot TV. > > > Video for Nerds. Stuff that matters. > > > http://tv.slashdot.org/ > > > > > > > > > > > > _______________________________________________ > > > Rails-devel mailing list > > > Rai...@li... > > <mailto:Rai...@li...> > > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > > > > > ------------------------------------------------------------------------------ > > Slashdot TV. > > Video for Nerds. Stuff that matters. > > http://tv.slashdot.org/ > > _______________________________________________ > > Rails-devel mailing list > > Rai...@li... > > <mailto:Rai...@li...> > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > > > > > > > > ------------------------------------------------------------------------------ > > Slashdot TV. > > Video for Nerds. Stuff that matters. > > http://tv.slashdot.org/ > > > > > > > > _______________________________________________ > > Rails-devel mailing list > > Rai...@li... > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > > ------------------------------------------------------------------------------ > Slashdot TV. > Video for Nerds. Stuff that matters. > http://tv.slashdot.org/ > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X