From: Martin B. <dr....@t-...> - 2014-07-22 20:29:00
Attachments:
signature.asc
|
Hi, upon trying to implement 1837 i stumbled on the "problem" that somehow from the second defined Startpaket in the companymanager.xml only the first two attributes of subsequent items are parsed. Anybody jas got any insight what is going wrong there ? 1880 has the lucky setup that the investors in the second Startpaket have a nominal value of 0 which is the predefined value in case the game doesnt find a baseprice, which however is defined. If i changed the basePrice attribute in the 1880 config for an investor this gets ignored :(). Regards, Martin |
From: Stefan F. <ste...@we...> - 2014-07-23 10:20:29
|
Hi Martin, could you please tell which branch you are looking at here? If I remember correctly I did some changes during rails 2 development there and so I wonder if you tried that on a branch that extended from rails 1.x or rails 2.x? Thanks, Stefan On 07/22/2014 10:28 PM, Martin Brumm wrote: > Hi, > > upon trying to implement 1837 i stumbled on the "problem" that somehow > from the second defined Startpaket in the companymanager.xml only the > first two attributes of subsequent items are parsed. > > Anybody jas got any insight what is going wrong there ? > > 1880 has the lucky setup that the investors in the second Startpaket > have a nominal value of 0 which is the predefined value in case the game > doesnt find a baseprice, which however is defined. If i changed the > basePrice attribute in the 1880 config for an investor this gets ignored > :(). > > Regards, > Martin > |
From: Martin B. <dr....@t-...> - 2014-07-23 17:24:09
Attachments:
signature.asc
|
Am 23.07.2014 12:20, schrieb Stefan Frey: > Hi Martin, > could you please tell which branch you are looking at here? > > If I remember correctly I did some changes during rails 2 development > there and so I wonder if you tried that on a branch that extended from > rails 1.x or rails 2.x? > > Thanks, > Stefan > > > Hi Stefan, it was in mbr_2_develop_1837 and thats a branch of rails_2_develop and actualised/rebased regularly from 2.0 develop. In rails.1.8.x the baseprices values of the second startpaket are read correctly. Regards, Martin |
From: Stefan F. <ste...@we...> - 2014-07-24 09:10:43
|
Martin: On first glance it seems that it is sufficient to change the wrong typing "baseprice" to "basePrice" for the item tags of the Hungarian startpacket. I pushed a commit that fixes that. Please be aware that the xml-files are case sensitive, which might be suprising for Windows users ;-) Both tag and attribute names use camelCase. Tag names start with an upper case, attribute names with a lower case. Hope that it works as expected now, maybe there are other issues, I did not look further. Stefan On 07/23/2014 07:23 PM, Martin Brumm wrote: > Am 23.07.2014 12:20, schrieb Stefan Frey: >> Hi Martin, >> could you please tell which branch you are looking at here? >> >> If I remember correctly I did some changes during rails 2 development >> there and so I wonder if you tried that on a branch that extended from >> rails 1.x or rails 2.x? >> >> Thanks, >> Stefan >> >> >> > > Hi Stefan, > > it was in mbr_2_develop_1837 and thats a branch of rails_2_develop and > actualised/rebased regularly from 2.0 develop. > > In rails.1.8.x the baseprices values of the second startpaket are read > correctly. > > > Regards, > Martin > > > > ------------------------------------------------------------------------------ > Want fast and easy access to all the code in your enterprise? Index and > search up to 200,000 lines of code with a free copy of Black Duck > Code Sight - the same software that powers the world's largest code > search on Ohloh, the Black Duck Open Hub! Try it now. > http://p.sf.net/sfu/bds > > > > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
From: John D. G. <jd...@di...> - 2014-07-24 06:08:23
|
On 2014-07-22 13:28, Martin Brumm wrote: > upon trying to implement 1837 i stumbled on the "problem" that somehow > from the second defined Startpaket in the companymanager.xml only the > first two attributes of subsequent items are parsed. You've gotten farther with it than I did, which suggests I should look at your development branch. By the way: I've been informed, off list, that someone plans to publish a new version of 1837 which ditches the existing start-packets for the "auction items by groups" start-arrangement that Steve Thomas already uses in his PBEM 1837 games. I want Rails to support both, because I believe Steve's version breaks the game. |