From: Dr. M. B. <dr....@t-...> - 2014-03-15 12:22:00
|
StartComany_1880 is never used. The Use in save Files is an Artefact from old versions. Von Samsung-Tablet gesendet -------- Ursprüngliche Nachricht -------- Von: Stefan Frey <ste...@we...> Datum:15.03.2014 11:37 (GMT+01:00) An: "Development list for Rails: an 18xx game" <rai...@li...> Betreff: [Rails-devel] Progress of 1880 integration to Rails 2.0 and question on StartCompany_1880 Martin & Mike: I have done further steps to integrate 1880 into the rails 2.0 branch. The current state is in branch sfy_1880, which was updated today. I will write more details what have been changed later this weekend. However I realized something strange: How do you use StartCompany_1880: There is no call to one of the constructors of that action. And actions are never created dynamically, as far as I know. And in fact the game engine only creates StartCompany actions. However in Martins save file examples there are StartCompany_1880 actions included. This does not work in Rails 2.0, as the check if the players only execute allowed actions is active. And it checks that the actions are of the same class. Could shed some light on this? I had a quick glance on your rails1.8.x branch and it seems that there is neither a call to the constructors. However in Rails 1.x the test if actions are allowed was never active. Thanks for your help, Stefan ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Rails-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rails-devel |
From: Stefan F. <ste...@we...> - 2014-03-15 13:27:34
|
<html> <head> </head> <body>Follow up question: How was the functionality of StartCompany_1880 replaced in the current version? Are your save files still loadable in 1.8.7?<br> Thanks, <br> Stefan<br> <br><br><div class="gmail_quote">"Dr. Martin Brumm" <dr....@t-...> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div> StartComany_1880 is never used. The Use in save Files is an Artefact from old versions. </div> <div> <br/> </div> <div> <br/> </div> <div> <br/> </div> <div> <br/> </div> <div> <div style="font-size: 100.0%;"> Von Samsung-Tablet gesendet </div> </div> <br/> <br/> -------- Ursprüngliche Nachricht --------<br/> Von: Stefan Frey<br/> Datum:15.03.2014 11:37 (GMT+01:00)<br/> An: "Development list for Rails: an 18xx game"<br/> Betreff: [Rails-devel] Progress of 1880 integration to Rails 2.0 and question on StartCompany_1880<br/> <br/> Martin & Mike:<br/> I have done further steps to integrate 1880 into the rails 2.0 branch.<br/> The current state is in branch sfy_1880, which was updated today.<br/> I will write more details what have been changed later this weekend.<br/> <br/> However I realized something strange:<br/> <br/> How do you use StartCompany_1880: There is no call to one of the<br/> constructors of that action. And actions are never created dynamically,<br/> as far as I know.<br/> <br/> And in fact the game engine only creates StartCompany actions. However<br/> in Martins save file examples there are StartCompany_1880 actions<br/> included. This does not work in Rails 2.0, as the check if the players<br/> only execute allowed actions is active. And it checks that the actions<br/> are of the same class.<br/> <br/> Could shed some light on this? I had a quick glance on your rails1.8.x<br/> branch and it seems that there is neither a call to the constructors.<br/> However in Rails 1.x the test if actions are allowed was never active.<br/> <br/> Thanks for your help,<br/> Stefan<br/> <br/> ------------------------------------------------------------------------------<br/> Learn Graph Databases - Download FREE O'Reilly Book<br/> "Graph Databases" is the definitive new guide to graph databases and their<br/> applications. Written by three acclaimed leaders in the field,<br/> this first edition is now available. Download your free book today!<br/> http://p.sf.net/sfu/13534_NeoTech<br/> _______________________________________________<br/> Rails-devel mailing list<br/> Rai...@li...<br/> https://lists.sourceforge.net/lists/listinfo/rails-devel<br/> ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech_______________________________________________ Rails-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rails-devel </blockquote></div></body> </html> |
From: Dr. M. B. <dr....@t-...> - 2014-03-15 13:49:25
|
The function was replaced by Startround_sequential and Startround_investor_1880 startround_privates_1880 by Mike Von Samsung Mobile gesendet -------- Ursprüngliche Nachricht -------- Von: Stefan Frey <ste...@we...> Datum:15.03.2014 14:27 (GMT+01:00) An: "Development list for Rails: an 18xx game" <rai...@li...> Betreff: Re: [Rails-devel] Progress of 1880 integration to Rails 2.0 and question on StartCompany_1880 Follow up question: How was the functionality of StartCompany_1880 replaced in the current version? Are your save files still loadable in 1.8.7? Thanks, Stefan "Dr. Martin Brumm" <dr....@t-...> wrote: StartComany_1880 is never used. The Use in save Files is an Artefact from old versions. Von Samsung-Tablet gesendet -------- Ursprüngliche Nachricht -------- Von: Stefan Frey Datum:15.03.2014 11:37 (GMT+01:00) An: "Development list for Rails: an 18xx game" Betreff: [Rails-devel] Progress of 1880 integration to Rails 2.0 and question on StartCompany_1880 Martin & Mike: I have done further steps to integrate 1880 into the rails 2.0 branch. The current state is in branch sfy_1880, which was updated today. I will write more details what have been changed later this weekend. However I realized something strange: How do you use StartCompany_1880: There is no call to one of the constructors of that action. And actions are never created dynamically, as far as I know. And in fact the game engine only creates StartCompany actions. However in Martins save file examples there are StartCompany_1880 actions included. This does not work in Rails 2.0, as the check if the players only execute allowed actions is active. And it checks that the actions are of the same class. Could shed some light on this? I had a quick glance on your rails1.8.x branch and it seems that there is neither a call to the constructors. However in Rails 1.x the test if actions are allowed was never active. Thanks for your help, Stefan ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Rails-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rails-devel ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech_______________________________________________ Rails-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rails-devel |
From: Stefan F. <ste...@we...> - 2014-03-15 19:11:02
|
<html> <head> </head> <body>Ok I believe I understand now, however I wonder how the new classes are backwards compatible with the old actions. Maybe Mike can give me a hint? <br> <br><br><div class="gmail_quote">"Dr. Martin Brumm" <dr....@t-...> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div> The function was replaced by Startround_sequential and Startround_investor_1880 startround_privates_1880 by Mike </div> <div> <br/> </div> <div> <br/> </div> <div> <div style="font-size: 9.0px;color: rgb(87,87,87);"> Von Samsung Mobile gesendet </div> </div> <br/> <br/> -------- Ursprüngliche Nachricht --------<br/> Von: Stefan Frey<br/> Datum:15.03.2014 14:27 (GMT+01:00)<br/> An: "Development list for Rails: an 18xx game"<br/> Betreff: Re: [Rails-devel] Progress of 1880 integration to Rails 2.0 and question on StartCompany_1880<br/> <br/> Follow up question: How was the functionality of StartCompany_1880 replaced in the current version? Are your save files still loadable in 1.8.7?<br/> Thanks,<br/> Stefan<br/> <br/> <br/> <div class="gmail_quote"> "Dr. Martin Brumm" <dr....@t-...> wrote: <blockquote class="gmail_quote" style="margin: 0.0pt 0.0pt 0.0pt 0.8ex;border-left: 1.0px solid rgb(204,204,204);padding-left: 1.0ex;"> <div> StartComany_1880 is never used. The Use in save Files is an Artefact from old versions. </div> <div> <br/> </div> <div> <br/> </div> <div> <br/> </div> <div> <br/> </div> <div> <div style="font-size: 100.0%;"> Von Samsung-Tablet gesendet </div> </div> <br/> <br/> -------- Ursprüngliche Nachricht --------<br/> Von: Stefan Frey<br/> Datum:15.03.2014 11:37 (GMT+01:00)<br/> An: "Development list for Rails: an 18xx game"<br/> Betreff: [Rails-devel] Progress of 1880 integration to Rails 2.0 and question on StartCompany_1880<br/> <br/> Martin & Mike:<br/> I have done further steps to integrate 1880 into the rails 2.0 branch.<br/> The current state is in branch sfy_1880, which was updated today.<br/> I will write more details what have been changed later this weekend.<br/> <br/> However I realized something strange:<br/> <br/> How do you use StartCompany_1880: There is no call to one of the<br/> constructors of that action. And actions are never created dynamically,<br/> as far as I know.<br/> <br/> And in fact the game engine only creates StartCompany actions. However<br/> in Martins save file examples there are StartCompany_1880 actions<br/> included. This does not work in Rails 2.0, as the check if the players<br/> only execute allowed actions is active. And it checks that the actions<br/> are of the same class.<br/> <br/> Could shed some light on this? I had a quick glance on your rails1.8.x<br/> branch and it seems that there is neither a call to the constructors.<br/> However in Rails 1.x the test if actions are allowed was never active.<br/> <br/> Thanks for your help,<br/> Stefan<br/> <br/> ------------------------------------------------------------------------------<br/> Learn Graph Databases - Download FREE O'Reilly Book<br/> "Graph Databases" is the definitive new guide to graph databases and their<br/> applications. Written by three acclaimed leaders in the field,<br/> this first edition is now available. Download your free book today!<br/> http://p.sf.net/sfu/13534_NeoTech<br/> _______________________________________________<br/> Rails-devel mailing list<br/> Rai...@li...<br/> https://lists.sourceforge.net/lists/listinfo/rails-devel<br/> ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech_______________________________________________ Rails-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rails-devel </blockquote> </div> ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech_______________________________________________ Rails-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rails-devel </blockquote></div></body> </html> |
From: Michael A. <out...@gm...> - 2014-03-15 19:18:10
|
StartRound or StartCompany? You asked about StartCompany_1880, which I believe is used in StockRound_1880... and I don't recall writing that myself - you are sure that wasn't you Martin? :) Mike On Sat, Mar 15, 2014 at 3:10 PM, Stefan Frey <ste...@we...> wrote: > Ok I believe I understand now, however I wonder how the new classes are > backwards compatible with the old actions. Maybe Mike can give me a hint? > > > "Dr. Martin Brumm" <dr....@t-...> wrote: >> >> The function was replaced by Startround_sequential and >> Startround_investor_1880 startround_privates_1880 by Mike >> >> >> Von Samsung Mobile gesendet >> >> >> -------- Ursprüngliche Nachricht -------- >> Von: Stefan Frey >> Datum:15.03.2014 14:27 (GMT+01:00) >> An: "Development list for Rails: an 18xx game" >> Betreff: Re: [Rails-devel] Progress of 1880 integration to Rails 2.0 and >> question on StartCompany_1880 >> >> Follow up question: How was the functionality of StartCompany_1880 >> replaced in the current version? Are your save files still loadable in >> 1.8.7? >> Thanks, >> Stefan >> >> >> "Dr. Martin Brumm" <dr....@t-...> wrote: >>> >>> StartComany_1880 is never used. The Use in save Files is an Artefact >>> from old versions. >>> >>> >>> >>> >>> Von Samsung-Tablet gesendet >>> >>> >>> -------- Ursprüngliche Nachricht -------- >>> Von: Stefan Frey >>> Datum:15.03.2014 11:37 (GMT+01:00) >>> An: "Development list for Rails: an 18xx game" >>> Betreff: [Rails-devel] Progress of 1880 integration to Rails 2.0 and >>> question on StartCompany_1880 >>> >>> Martin & Mike: >>> I have done further steps to integrate 1880 into the rails 2.0 branch. >>> The current state is in branch sfy_1880, which was updated today. >>> I will write more details what have been changed later this weekend. >>> >>> However I realized something strange: >>> >>> How do you use StartCompany_1880: There is no call to one of the >>> constructors of that action. And actions are never created dynamically, >>> as far as I know. >>> >>> And in fact the game engine only creates StartCompany actions. However >>> in Martins save file examples there are StartCompany_1880 actions >>> included. This does not work in Rails 2.0, as the check if the players >>> only execute allowed actions is active. And it checks that the actions >>> are of the same class. >>> >>> Could shed some light on this? I had a quick glance on your rails1.8.x >>> branch and it seems that there is neither a call to the constructors. >>> However in Rails 1.x the test if actions are allowed was never active. >>> >>> Thanks for your help, >>> Stefan >>> >>> >>> ------------------------------------------------------------------------------ >>> Learn Graph Databases - Download FREE O'Reilly Book >>> "Graph Databases" is the definitive new guide to graph databases and >>> their >>> applications. Written by three acclaimed leaders in the field, >>> this first edition is now available. Download your free book today! >>> http://p.sf.net/sfu/13534_NeoTech >>> _______________________________________________ >>> Rails-devel mailing list >>> Rai...@li... >>> https://lists.sourceforge.net/lists/listinfo/rails-devel >>> ------------------------------------------------------------------------------ >>> Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is >>> the definitive new guide to graph databases and their applications. Written >>> by three acclaimed leaders in the field, this first edition is now >>> available. Download your free book today! >>> http://p.sf.net/sfu/13534_NeoTech_______________________________________________Rails-devel mailing list >>> Rai...@li... >>> https://lists.sourceforge.net/lists/listinfo/rails-devel >> >> ------------------------------------------------------------------------------ >> Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is >> the definitive new guide to graph databases and their applications. Written >> by three acclaimed leaders in the field, this first edition is now >> available. Download your free book today! >> http://p.sf.net/sfu/13534_NeoTech_______________________________________________Rails-devel mailing list >> Rai...@li... >> https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/13534_NeoTech > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > > |
From: Stefan F. <ste...@we...> - 2014-03-15 19:38:58
|
<html> <head> </head> <body>I referred to StartCompany_1880, the action subclass of StartCompany. I thought that Martin meant that StartCompany_1880 was only used by StartRound_1880 which was later replaced by your new classes. But may be I am wrong...<br> <br><br><div class="gmail_quote">Michael Alexander <out...@gm...> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div> StartRound or StartCompany? You asked about StartCompany_1880, which I believe is used in StockRound_1880... and I don't recall writing that myself - you are sure that wasn't you Martin? :) <div> <br/> </div> <div> Mike </div> </div> <div class="gmail_extra"> <br/> <br/> <div class="gmail_quote"> On Sat, Mar 15, 2014 at 3:10 PM, Stefan Frey<span> <<a href="mailto:ste...@we..." target="_blank">ste...@we...</a>></span> wrote:<br/> <blockquote class="gmail_quote" style="margin: 0 0 0 0.8ex;border-left: 1.0px rgb(204,204,204) solid;padding-left: 1.0ex;"> <div> Ok I believe I understand now, however I wonder how the new classes are backwards compatible with the old actions. Maybe Mike can give me a hint?<br/> <div> <div class="h5"> <br/> <br/> <div class="gmail_quote"> "Dr. Martin Brumm" <<a href="mailto:dr....@t-..." target="_blank">dr....@t-...</a>> wrote: <blockquote class="gmail_quote" style="margin: 0.0pt 0.0pt 0.0pt 0.8ex;border-left: 1.0px solid rgb(204,204,204);padding-left: 1.0ex;"> <div> The function was replaced by Startround_sequential and Startround_investor_1880 startround_privates_1880 by Mike </div> <div> <br/> </div> <div> <br/> </div> <div> <div style="font-size: 9.0px;color: rgb(87,87,87);"> Von Samsung Mobile gesendet </div> </div> <br/> <br/> -------- Ursprüngliche Nachricht --------<br/> Von: Stefan Frey<br/> Datum:15.03.2014 14:27 (GMT+01:00)<br/> An: "Development list for Rails: an 18xx game"<br/> Betreff: Re: [Rails-devel] Progress of 1880 integration to Rails 2.0 and question on StartCompany_1880<br/> <br/> Follow up question: How was the functionality of StartCompany_1880 replaced in the current version? Are your save files still loadable in 1.8.7?<br/> Thanks,<br/> Stefan<br/> <br/> <br/> <div class="gmail_quote"> "Dr. Martin Brumm" <<a href="mailto:dr....@t-..." target="_blank">dr....@t-...</a>> wrote: <blockquote class="gmail_quote" style="margin: 0.0pt 0.0pt 0.0pt 0.8ex;border-left: 1.0px solid rgb(204,204,204);padding-left: 1.0ex;"> <div> StartComany_1880 is never used. The Use in save Files is an Artefact from old versions. </div> <div> <br/> </div> <div> <br/> </div> <div> <br/> </div> <div> <br/> </div> <div> <div style="font-size: 100.0%;"> Von Samsung-Tablet gesendet </div> </div> <br/> <br/> -------- Ursprüngliche Nachricht --------<br/> Von: Stefan Frey<br/> Datum:15.03.2014 11:37 (GMT+01:00)<br/> An: "Development list for Rails: an 18xx game"<br/> Betreff: [Rails-devel] Progress of 1880 integration to Rails 2.0 and question on StartCompany_1880<br/> <br/> Martin & Mike:<br/> I have done further steps to integrate 1880 into the rails 2.0 branch.<br/> The current state is in branch sfy_1880, which was updated today.<br/> I will write more details what have been changed later this weekend.<br/> <br/> However I realized something strange:<br/> <br/> How do you use StartCompany_1880: There is no call to one of the<br/> constructors of that action. And actions are never created dynamically,<br/> as far as I know.<br/> <br/> And in fact the game engine only creates StartCompany actions. However<br/> in Martins save file examples there are StartCompany_1880 actions<br/> included. This does not work in Rails 2.0, as the check if the players<br/> only execute allowed actions is active. And it checks that the actions<br/> are of the same class.<br/> <br/> Could shed some light on this? I had a quick glance on your rails1.8.x<br/> branch and it seems that there is neither a call to the constructors.<br/> However in Rails 1.x the test if actions are allowed was never active.<br/> <br/> Thanks for your help,<br/> Stefan<br/> <br/> ------------------------------------------------------------------------------<br/> Learn Graph Databases - Download FREE O'Reilly Book<br/> "Graph Databases" is the definitive new guide to graph databases and their<br/> applications. Written by three acclaimed leaders in the field,<br/> this first edition is now available. Download your free book today!<br/> <a href="http://p.sf.net/sfu/13534_NeoTech" target="_blank">http://p.sf.net/sfu/13534_NeoTech</a><br/> _______________________________________________<br/> Rails-devel mailing list<br/> <a href="mailto:Rai...@li..." target="_blank">Rai...@li...</a><br/> <a href="https://lists.sourceforge.net/lists/listinfo/rails-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/rails-devel</a><br/> ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today!<a href="http://p.sf.net/sfu/13534_NeoTech_______________________________________________" target="_blank"> http://p.sf.net/sfu/13534_NeoTech_______________________________________________</a> Rails-devel mailing list<a href="mailto:Rai...@li..." target="_blank"> Rai...@li...</a><a href="https://lists.sourceforge.net/lists/listinfo/rails-devel" target="_blank"> https://lists.sourceforge.net/lists/listinfo/rails-devel</a> </blockquote> </div> ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today!<a href="http://p.sf.net/sfu/13534_NeoTech_______________________________________________" target="_blank"> http://p.sf.net/sfu/13534_NeoTech_______________________________________________</a> Rails-devel mailing list<a href="mailto:Rai...@li..." target="_blank"> Rai...@li...</a><a href="https://lists.sourceforge.net/lists/listinfo/rails-devel" target="_blank"> https://lists.sourceforge.net/lists/listinfo/rails-devel</a> </blockquote> </div> </div> </div> </div> <br/> ------------------------------------------------------------------------------<br/> Learn Graph Databases - Download FREE O'Reilly Book<br/> "Graph Databases" is the definitive new guide to graph databases and their<br/> applications. Written by three acclaimed leaders in the field,<br/> this first edition is now available. Download your free book today!<br/> <a href="http://p.sf.net/sfu/13534_NeoTech" target="_blank">http://p.sf.net/sfu/13534_NeoTech</a><br/> _______________________________________________<br/> Rails-devel mailing list<br/> <a href="mailto:Rai...@li..." target="_blank">Rai...@li...</a><br/> <a href="https://lists.sourceforge.net/lists/listinfo/rails-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/rails-devel</a><br/> <br/> </blockquote> </div> <br/> </div> ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today!<a href="http://p.sf.net/sfu/13534_NeoTech_______________________________________________" target="_blank"> http://p.sf.net/sfu/13534_NeoTech_______________________________________________</a> Rails-devel mailing list Rai...@li...<a href="https://lists.sourceforge.net/lists/listinfo/rails-devel" target="_blank"> https://lists.sourceforge.net/lists/listinfo/rails-devel</a> </blockquote></div></body> </html> |
From: Michael A. <out...@gm...> - 2014-03-15 19:40:13
|
StartCompany_1880 is used in StockRound_1880. Mike On Sat, Mar 15, 2014 at 3:38 PM, Stefan Frey <ste...@we...> wrote: > I referred to StartCompany_1880, the action subclass of StartCompany. I > thought that Martin meant that StartCompany_1880 was only used by > StartRound_1880 which was later replaced by your new classes. But may be I > am wrong... > > > > Michael Alexander <out...@gm...> wrote: >> >> StartRound or StartCompany? You asked about StartCompany_1880, which I >> believe is used in StockRound_1880... and I don't recall writing that >> myself - you are sure that wasn't you Martin? :) >> >> Mike >> >> >> On Sat, Mar 15, 2014 at 3:10 PM, Stefan Frey <ste...@we...> wrote: >> >>> Ok I believe I understand now, however I wonder how the new classes are >>> backwards compatible with the old actions. Maybe Mike can give me a hint? >>> >>> >>> "Dr. Martin Brumm" <dr....@t-...> wrote: >>>> >>>> The function was replaced by Startround_sequential and >>>> Startround_investor_1880 startround_privates_1880 by Mike >>>> >>>> >>>> Von Samsung Mobile gesendet >>>> >>>> >>>> -------- Ursprüngliche Nachricht -------- >>>> Von: Stefan Frey >>>> Datum:15.03.2014 14:27 (GMT+01:00) >>>> An: "Development list for Rails: an 18xx game" >>>> Betreff: Re: [Rails-devel] Progress of 1880 integration to Rails 2.0 >>>> and question on StartCompany_1880 >>>> >>>> Follow up question: How was the functionality of StartCompany_1880 >>>> replaced in the current version? Are your save files still loadable in >>>> 1.8.7? >>>> Thanks, >>>> Stefan >>>> >>>> >>>> "Dr. Martin Brumm" <dr....@t-...> wrote: >>>>> >>>>> StartComany_1880 is never used. The Use in save Files is an Artefact >>>>> from old versions. >>>>> >>>>> >>>>> >>>>> >>>>> Von Samsung-Tablet gesendet >>>>> >>>>> >>>>> -------- Ursprüngliche Nachricht -------- >>>>> Von: Stefan Frey >>>>> Datum:15.03.2014 11:37 (GMT+01:00) >>>>> An: "Development list for Rails: an 18xx game" >>>>> Betreff: [Rails-devel] Progress of 1880 integration to Rails 2.0 and >>>>> question on StartCompany_1880 >>>>> >>>>> Martin & Mike: >>>>> I have done further steps to integrate 1880 into the rails 2.0 branch. >>>>> The current state is in branch sfy_1880, which was updated today. >>>>> I will write more details what have been changed later this weekend. >>>>> >>>>> However I realized something strange: >>>>> >>>>> How do you use StartCompany_1880: There is no call to one of the >>>>> constructors of that action. And actions are never created dynamically, >>>>> as far as I know. >>>>> >>>>> And in fact the game engine only creates StartCompany actions. However >>>>> in Martins save file examples there are StartCompany_1880 actions >>>>> included. This does not work in Rails 2.0, as the check if the players >>>>> only execute allowed actions is active. And it checks that the actions >>>>> are of the same class. >>>>> >>>>> Could shed some light on this? I had a quick glance on your rails1.8.x >>>>> branch and it seems that there is neither a call to the constructors. >>>>> However in Rails 1.x the test if actions are allowed was never active. >>>>> >>>>> Thanks for your help, >>>>> Stefan >>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Learn Graph Databases - Download FREE O'Reilly Book >>>>> "Graph Databases" is the definitive new guide to graph databases and >>>>> their >>>>> applications. Written by three acclaimed leaders in the field, >>>>> this first edition is now available. Download your free book today! >>>>> http://p.sf.net/sfu/13534_NeoTech >>>>> _______________________________________________ >>>>> Rails-devel mailing list >>>>> Rai...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/rails-devel >>>>> ------------------------------------------------------------------------------ >>>>> Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is >>>>> the definitive new guide to graph databases and their applications. Written >>>>> by three acclaimed leaders in the field, this first edition is now >>>>> available. Download your free book today!http://p.sf.net/sfu/13534_NeoTech_______________________________________________Rails-devel mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/rails-devel >>>> >>>> ------------------------------------------------------------------------------ >>>> Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is >>>> the definitive new guide to graph databases and their applications. Written >>>> by three acclaimed leaders in the field, this first edition is now >>>> available. Download your free book today!http://p.sf.net/sfu/13534_NeoTech_______________________________________________Rails-devel mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/rails-devel >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> Learn Graph Databases - Download FREE O'Reilly Book >>> "Graph Databases" is the definitive new guide to graph databases and >>> their >>> applications. Written by three acclaimed leaders in the field, >>> this first edition is now available. Download your free book today! >>> http://p.sf.net/sfu/13534_NeoTech >>> _______________________________________________ >>> Rails-devel mailing list >>> Rai...@li... >>> https://lists.sourceforge.net/lists/listinfo/rails-devel >>> >>> >> ------------------------------------------------------------------------------ >> Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is >> the definitive new guide to graph databases and their applications. Written >> by three acclaimed leaders in the field, this first edition is now >> available. Download your free book today!http://p.sf.net/sfu/13534_NeoTech_______________________________________________Rails-devel mailing list >> Rai...@li...https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/13534_NeoTech > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > > |
From: Martin B. <dr....@t-...> - 2014-03-15 21:01:43
Attachments:
signature.asc
|
Hi Stefan, sorry your Right, and i am wrong. I was referring to StartRound_1880 not StartCompany_1880. Now why did i introduce StartCompany_1880: To make implement a mechanismn to handly buying rights and the parslot indices. The call to StartCompany_1880 is in StockRound_1880 at line 204 StartCompany_1880 action = new StartCompany_1880(comp, convertedPrices); Kind Regards, Martin Am 15.03.2014 20:38, schrieb Stefan Frey: > I referred to StartCompany_1880, the action subclass of StartCompany. > I thought that Martin meant that StartCompany_1880 was only used by > StartRound_1880 which was later replaced by your new classes. But may > be I am wrong... > > > Michael Alexander <out...@gm...> wrote: > > StartRound or StartCompany? You asked about StartCompany_1880, > which I believe is used in StockRound_1880... and I don't recall > writing that myself - you are sure that wasn't you Martin? :) > > Mike > > > On Sat, Mar 15, 2014 at 3:10 PM, Stefan Frey<ste...@we... > <mailto:ste...@we...>> wrote: > > Ok I believe I understand now, however I wonder how the new > classes are backwards compatible with the old actions. Maybe > Mike can give me a hint? > > > "Dr. Martin Brumm" <dr....@t-... > <mailto:dr....@t-...>> wrote: > > The function was replaced by Startround_sequential and > Startround_investor_1880 startround_privates_1880 by Mike > > > Von Samsung Mobile gesendet > > > -------- Ursprüngliche Nachricht -------- > Von: Stefan Frey > Datum:15.03.2014 14:27 (GMT+01:00) > An: "Development list for Rails: an 18xx game" > Betreff: Re: [Rails-devel] Progress of 1880 integration to > Rails 2.0 and question on StartCompany_1880 > > Follow up question: How was the functionality of > StartCompany_1880 replaced in the current version? Are > your save files still loadable in 1.8.7? > Thanks, > Stefan > > > "Dr. Martin Brumm" <dr....@t-... > <mailto:dr....@t-...>> wrote: > > StartComany_1880 is never used. The Use in save Files > is an Artefact from old versions. > > > > > Von Samsung-Tablet gesendet > > > -------- Ursprüngliche Nachricht -------- > Von: Stefan Frey > Datum:15.03.2014 11:37 (GMT+01:00) > An: "Development list for Rails: an 18xx game" > Betreff: [Rails-devel] Progress of 1880 integration to > Rails 2.0 and question on StartCompany_1880 > > Martin & Mike: > I have done further steps to integrate 1880 into the > rails 2.0 branch. > The current state is in branch sfy_1880, which was > updated today. > I will write more details what have been changed later > this weekend. > > However I realized something strange: > > How do you use StartCompany_1880: There is no call to > one of the > constructors of that action. And actions are never > created dynamically, > as far as I know. > > And in fact the game engine only creates StartCompany > actions. However > in Martins save file examples there are > StartCompany_1880 actions > included. This does not work in Rails 2.0, as the > check if the players > only execute allowed actions is active. And it checks > that the actions > are of the same class. > > Could shed some light on this? I had a quick glance on > your rails1.8.x > branch and it seems that there is neither a call to > the constructors. > However in Rails 1.x the test if actions are allowed > was never active. > > Thanks for your help, > Stefan > |
From: Martin B. <dr....@t-...> - 2014-03-15 21:03:08
Attachments:
signature.asc
|
Am 15.03.2014 22:01, schrieb Martin Brumm: > Hi Stefan, > > sorry your Right, and i am wrong. I was referring to StartRound_1880 > not StartCompany_1880. > Now why did i introduce StartCompany_1880: > > To make implement a mechanismn to handly buying rights and the parslot > indices. > > The call to StartCompany_1880 is in StockRound_1880 at line 204 > > StartCompany_1880 action = new StartCompany_1880(comp, convertedPrices); > > Kind Regards, > Martin > Further Call to StartCompany_1880 from StockRound_1880 is in function process: @Override public boolean process(PossibleAction action) { boolean result; String playerName = action.getPlayerName(); if (action instanceof StartCompany) { StartCompany_1880 startCompanyAction = (StartCompany_1880) action; result = startCompany(playerName, startCompanyAction); return result; } else { return super.process(action); } } |
From: Stefan F. <ste...@we...> - 2014-03-15 21:14:32
|
Ok this narrows things down: However in both branches mbr_rails_2_develop_1880 and sfy_1880 StockRound_1880 consists of only 50 lines of code with no reference to StartCompany_1880. All examples below only exist in branch rails1.8.x. Either that got lost during the integation into Rails 2.0 or the code was added later to rails1.8.x? Does anyone has a good idea, how to fix that and if there are more deviations between rails1.8.x and the integrated code of sfy_1880? Stefan On 03/15/2014 10:01 PM, Martin Brumm wrote: > Hi Stefan, > > sorry your Right, and i am wrong. I was referring to StartRound_1880 not > StartCompany_1880. > Now why did i introduce StartCompany_1880: > > To make implement a mechanismn to handly buying rights and the parslot > indices. > > The call to StartCompany_1880 is in StockRound_1880 at line 204 > > StartCompany_1880 action = new StartCompany_1880(comp, convertedPrices); > > Kind Regards, > Martin > > Am 15.03.2014 20:38, schrieb Stefan Frey: >> I referred to StartCompany_1880, the action subclass of StartCompany. >> I thought that Martin meant that StartCompany_1880 was only used by >> StartRound_1880 which was later replaced by your new classes. But may >> be I am wrong... >> >> >> Michael Alexander <out...@gm...> wrote: >> >> StartRound or StartCompany? You asked about StartCompany_1880, >> which I believe is used in StockRound_1880... and I don't recall >> writing that myself - you are sure that wasn't you Martin? :) >> >> Mike >> >> >> On Sat, Mar 15, 2014 at 3:10 PM, Stefan Frey<ste...@we... >> <mailto:ste...@we...>> wrote: >> >> Ok I believe I understand now, however I wonder how the new >> classes are backwards compatible with the old actions. Maybe >> Mike can give me a hint? >> >> >> "Dr. Martin Brumm" <dr....@t-... >> <mailto:dr....@t-...>> wrote: >> >> The function was replaced by Startround_sequential and >> Startround_investor_1880 startround_privates_1880 by Mike >> >> >> Von Samsung Mobile gesendet >> >> >> -------- Ursprüngliche Nachricht -------- >> Von: Stefan Frey >> Datum:15.03.2014 14:27 (GMT+01:00) >> An: "Development list for Rails: an 18xx game" >> Betreff: Re: [Rails-devel] Progress of 1880 integration to >> Rails 2.0 and question on StartCompany_1880 >> >> Follow up question: How was the functionality of >> StartCompany_1880 replaced in the current version? Are >> your save files still loadable in 1.8.7? >> Thanks, >> Stefan >> >> >> "Dr. Martin Brumm" <dr....@t-... >> <mailto:dr....@t-...>> wrote: >> >> StartComany_1880 is never used. The Use in save Files >> is an Artefact from old versions. >> >> >> >> >> Von Samsung-Tablet gesendet >> >> >> -------- Ursprüngliche Nachricht -------- >> Von: Stefan Frey >> Datum:15.03.2014 11:37 (GMT+01:00) >> An: "Development list for Rails: an 18xx game" >> Betreff: [Rails-devel] Progress of 1880 integration to >> Rails 2.0 and question on StartCompany_1880 >> >> Martin & Mike: >> I have done further steps to integrate 1880 into the >> rails 2.0 branch. >> The current state is in branch sfy_1880, which was >> updated today. >> I will write more details what have been changed later >> this weekend. >> >> However I realized something strange: >> >> How do you use StartCompany_1880: There is no call to >> one of the >> constructors of that action. And actions are never >> created dynamically, >> as far as I know. >> >> And in fact the game engine only creates StartCompany >> actions. However >> in Martins save file examples there are >> StartCompany_1880 actions >> included. This does not work in Rails 2.0, as the >> check if the players >> only execute allowed actions is active. And it checks >> that the actions >> are of the same class. >> >> Could shed some light on this? I had a quick glance on >> your rails1.8.x >> branch and it seems that there is neither a call to >> the constructors. >> However in Rails 1.x the test if actions are allowed >> was never active. >> >> Thanks for your help, >> Stefan >> > > > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/13534_NeoTech > > > > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
From: Martin B. <dr....@t-...> - 2014-03-15 21:34:28
Attachments:
signature.asc
|
Am 15.03.2014 22:14, schrieb Stefan Frey: > Ok this narrows things down: > > However in both branches mbr_rails_2_develop_1880 and sfy_1880 > StockRound_1880 consists of only 50 lines of code with no reference to > StartCompany_1880. All examples below only exist in branch rails1.8.x. > > Either that got lost during the integation into Rails 2.0 or the code > was added later to rails1.8.x? Does anyone has a good idea, how to fix > that and if there are more deviations between rails1.8.x and the > integrated code of sfy_1880? > > Stefan > > Hi Stefan, that got most likely lost during integration, i am afraid. I'll have to redo that part. Sorry about that. I'll try to fix that tomorrow. And do a cross check again :) Regards, Martin |