Menu
▾
▴
rails-devel
|
From: Martin B. <dr....@t-...> - 2014-02-09 19:53:36
Attachments:
signature.asc
|
Hi Stefan, Brett, Erik, Mike & Rest of the crew,
i created a branch of Rails_2_develop called Rails_2_develop_1880 since
i didnt want to mess with Stefans work.
In that branch if i assume right that Stefan started from 1.7.12 with
his work in Rails_2_develop everything but some local side projects by
me (1824, 1837) has been rebased from 1.8.7+ on Rails 2.0. Three bugs
remain that i cant fix with my current understanding of the Network Code :).
public SimpleGraph<NetworkVertex, NetworkEdge>
createConnectionGraph(boolean addHQ) {
in NetworkCompanyGraph_1880 contains 3 bug indications. If anyone so
brave could have a look at the code and fix that, it should be ready for
extensive testing with a number of save files :)
Kind Regards,
Martin
|
|
From: Michael A. <out...@gm...> - 2014-02-09 22:31:22
|
I'll take a look, but it will probably not be until mid-week.
Mike
On Sun, Feb 9, 2014 at 2:53 PM, Martin Brumm <dr....@t-...>wrote:
> Hi Stefan, Brett, Erik, Mike & Rest of the crew,
>
> i created a branch of Rails_2_develop called Rails_2_develop_1880 since
> i didnt want to mess with Stefans work.
> In that branch if i assume right that Stefan started from 1.7.12 with
> his work in Rails_2_develop everything but some local side projects by
> me (1824, 1837) has been rebased from 1.8.7+ on Rails 2.0. Three bugs
> remain that i cant fix with my current understanding of the Network Code
> :).
>
> public SimpleGraph<NetworkVertex, NetworkEdge>
> createConnectionGraph(boolean addHQ) {
>
> in NetworkCompanyGraph_1880 contains 3 bug indications. If anyone so
> brave could have a look at the code and fix that, it should be ready for
> extensive testing with a number of save files :)
>
> Kind Regards,
> Martin
>
>
>
> ------------------------------------------------------------------------------
> Managing the Performance of Cloud-Based Applications
> Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
> Read the Whitepaper.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
|
|
From: Stefan F. <ste...@we...> - 2014-02-10 10:17:35
|
Martin & Mike:
I can do later today, however could someone of you remind me for what
reason you have sub-classed NetworkCompanyGraph? I have done some
changes in Rails 2.0 to those classes to support tile laying and usually
it is better to use the interfaces (here most likely the
NetworkGraphModifier) instead of sub-classes.
Stefan
On 02/09/2014 11:31 PM, Michael Alexander wrote:
> I'll take a look, but it will probably not be until mid-week.
>
> Mike
>
>
> On Sun, Feb 9, 2014 at 2:53 PM, Martin Brumm
> <dr....@t-... <mailto:dr....@t-...>> wrote:
>
> Hi Stefan, Brett, Erik, Mike & Rest of the crew,
>
> i created a branch of Rails_2_develop called Rails_2_develop_1880 since
> i didnt want to mess with Stefans work.
> In that branch if i assume right that Stefan started from 1.7.12 with
> his work in Rails_2_develop everything but some local side projects by
> me (1824, 1837) has been rebased from 1.8.7+ on Rails 2.0. Three bugs
> remain that i cant fix with my current understanding of the Network
> Code :).
>
> public SimpleGraph<NetworkVertex, NetworkEdge>
> createConnectionGraph(boolean addHQ) {
>
> in NetworkCompanyGraph_1880 contains 3 bug indications. If anyone so
> brave could have a look at the code and fix that, it should be ready for
> extensive testing with a number of save files :)
>
> Kind Regards,
> Martin
>
>
> ------------------------------------------------------------------------------
> Managing the Performance of Cloud-Based Applications
> Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
> Read the Whitepaper.
> http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> <mailto:Rai...@li...>
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
|
|
From: Michael A. <out...@gm...> - 2014-02-10 13:58:45
|
The reason I did that originally was to determine when a foreign investor
was connected to it's parent company. I was having trouble with the
existing implementation because it was "connecting" through an off-map
station (going in one side and out the other). I had thought at the time
that there was no other way I could do it.
As it turns out, a handful of weeks after that, I noticed that the off-map
station was defined wrong in the XML. I suspect that once it was defined
correctly (which I did), that the original NetworkCompanyGraph would have
worked - but I wasn't sure it was worth changing it back until 2.0.
The function that has to work is Investor_1880::isConnectedtoLinkedCompany()
Mike
On Mon, Feb 10, 2014 at 5:17 AM, Stefan Frey <ste...@we...> wrote:
> Martin & Mike:
> I can do later today, however could someone of you remind me for what
> reason you have sub-classed NetworkCompanyGraph? I have done some
> changes in Rails 2.0 to those classes to support tile laying and usually
> it is better to use the interfaces (here most likely the
> NetworkGraphModifier) instead of sub-classes.
> Stefan
>
>
> On 02/09/2014 11:31 PM, Michael Alexander wrote:
> > I'll take a look, but it will probably not be until mid-week.
> >
> > Mike
> >
> >
> > On Sun, Feb 9, 2014 at 2:53 PM, Martin Brumm
> > <dr....@t-... <mailto:dr....@t-...>>
> wrote:
> >
> > Hi Stefan, Brett, Erik, Mike & Rest of the crew,
> >
> > i created a branch of Rails_2_develop called Rails_2_develop_1880
> since
> > i didnt want to mess with Stefans work.
> > In that branch if i assume right that Stefan started from 1.7.12 with
> > his work in Rails_2_develop everything but some local side projects
> by
> > me (1824, 1837) has been rebased from 1.8.7+ on Rails 2.0. Three bugs
> > remain that i cant fix with my current understanding of the Network
> > Code :).
> >
> > public SimpleGraph<NetworkVertex, NetworkEdge>
> > createConnectionGraph(boolean addHQ) {
> >
> > in NetworkCompanyGraph_1880 contains 3 bug indications. If anyone so
> > brave could have a look at the code and fix that, it should be ready
> for
> > extensive testing with a number of save files :)
> >
> > Kind Regards,
> > Martin
> >
> >
> >
> ------------------------------------------------------------------------------
> > Managing the Performance of Cloud-Based Applications
> > Take advantage of what the Cloud has to offer - Avoid Common
> Pitfalls.
> > Read the Whitepaper.
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > <mailto:Rai...@li...>
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
> >
>
>
>
> ------------------------------------------------------------------------------
> Managing the Performance of Cloud-Based Applications
> Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
> Read the Whitepaper.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
|
|
From: Stefan F. <ste...@we...> - 2014-02-16 14:52:19
|
Martin & Mike:
I have some troubles with the rails_2_develop_1880 branch: On my system
there are several compile errors (12) in this branch, that do not seem
to be linked to the issue discussed below.
Are you sure you pushed everything to this branch?
Stefan
On 02/10/2014 02:58 PM, Michael Alexander wrote:
> The reason I did that originally was to determine when a foreign
> investor was connected to it's parent company. I was having trouble
> with the existing implementation because it was "connecting" through an
> off-map station (going in one side and out the other). I had thought at
> the time that there was no other way I could do it.
>
> As it turns out, a handful of weeks after that, I noticed that the
> off-map station was defined wrong in the XML. I suspect that once it
> was defined correctly (which I did), that the original
> NetworkCompanyGraph would have worked - but I wasn't sure it was worth
> changing it back until 2.0.
>
> The function that has to work is Investor_1880::isConnectedtoLinkedCompany()
>
> Mike
>
>
>
>
> On Mon, Feb 10, 2014 at 5:17 AM, Stefan Frey <ste...@we...
> <mailto:ste...@we...>> wrote:
>
> Martin & Mike:
> I can do later today, however could someone of you remind me for what
> reason you have sub-classed NetworkCompanyGraph? I have done some
> changes in Rails 2.0 to those classes to support tile laying and usually
> it is better to use the interfaces (here most likely the
> NetworkGraphModifier) instead of sub-classes.
> Stefan
>
>
> On 02/09/2014 11:31 PM, Michael Alexander wrote:
> > I'll take a look, but it will probably not be until mid-week.
> >
> > Mike
> >
> >
> > On Sun, Feb 9, 2014 at 2:53 PM, Martin Brumm
> > <dr....@t-... <mailto:dr....@t-...>
> <mailto:dr....@t-...
> <mailto:dr....@t-...>>> wrote:
> >
> > Hi Stefan, Brett, Erik, Mike & Rest of the crew,
> >
> > i created a branch of Rails_2_develop called
> Rails_2_develop_1880 since
> > i didnt want to mess with Stefans work.
> > In that branch if i assume right that Stefan started from
> 1.7.12 with
> > his work in Rails_2_develop everything but some local side
> projects by
> > me (1824, 1837) has been rebased from 1.8.7+ on Rails 2.0.
> Three bugs
> > remain that i cant fix with my current understanding of the
> Network
> > Code :).
> >
> > public SimpleGraph<NetworkVertex, NetworkEdge>
> > createConnectionGraph(boolean addHQ) {
> >
> > in NetworkCompanyGraph_1880 contains 3 bug indications. If
> anyone so
> > brave could have a look at the code and fix that, it should
> be ready for
> > extensive testing with a number of save files :)
> >
> > Kind Regards,
> > Martin
> >
> >
> >
> ------------------------------------------------------------------------------
> > Managing the Performance of Cloud-Based Applications
> > Take advantage of what the Cloud has to offer - Avoid Common
> Pitfalls.
> > Read the Whitepaper.
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> <mailto:Rai...@li...>
> > <mailto:Rai...@li...
> <mailto:Rai...@li...>>
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
> >
>
>
> ------------------------------------------------------------------------------
> Managing the Performance of Cloud-Based Applications
> Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
> Read the Whitepaper.
> http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> <mailto:Rai...@li...>
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
>
> ------------------------------------------------------------------------------
> Managing the Performance of Cloud-Based Applications
> Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
> Read the Whitepaper.
> http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
|
|
From: Martin B. <dr....@t-...> - 2014-02-16 16:45:19
Attachments:
signature.asc
|
Am 16.02.2014 15:51, schrieb Stefan Frey:
> Martin & Mike:
> I have some troubles with the rails_2_develop_1880 branch: On my system
> there are several compile errors (12) in this branch, that do not seem
> to be linked to the issue discussed below.
> Are you sure you pushed everything to this branch?
> Stefan
>
> On 02/10/2014 02:58 PM, Michael Alexander wrote:
>> The reason I did that originally was to determine when a foreign
>> investor was connected to it's parent company. I was having trouble
>> with the existing implementation because it was "connecting" through an
>> off-map station (going in one side and out the other). I had thought at
>> the time that there was no other way I could do it.
>>
>> As it turns out, a handful of weeks after that, I noticed that the
>> off-map station was defined wrong in the XML. I suspect that once it
>> was defined correctly (which I did), that the original
>> NetworkCompanyGraph would have worked - but I wasn't sure it was worth
>> changing it back until 2.0.
>>
>> The function that has to work is Investor_1880::isConnectedtoLinkedCompany()
>>
>> Mike
>>
>>
>>
>>
>> On Mon, Feb 10, 2014 at 5:17 AM, Stefan Frey <ste...@we...
>> <mailto:ste...@we...>> wrote:
>>
>> Martin & Mike:
>> I can do later today, however could someone of you remind me for what
>> reason you have sub-classed NetworkCompanyGraph? I have done some
>> changes in Rails 2.0 to those classes to support tile laying and usually
>> it is better to use the interfaces (here most likely the
>> NetworkGraphModifier) instead of sub-classes.
>> Stefan
>>
>>
>> On 02/09/2014 11:31 PM, Michael Alexander wrote:
>> > I'll take a look, but it will probably not be until mid-week.
>> >
>> > Mike
>> >
>> >
>> > On Sun, Feb 9, 2014 at 2:53 PM, Martin Brumm
>> > <dr....@t-... <mailto:dr....@t-...>
>> <mailto:dr....@t-...
>> <mailto:dr....@t-...>>> wrote:
>> >
>> > Hi Stefan, Brett, Erik, Mike & Rest of the crew,
>> >
>> > i created a branch of Rails_2_develop called
>> Rails_2_develop_1880 since
>> > i didnt want to mess with Stefans work.
>> > In that branch if i assume right that Stefan started from
>> 1.7.12 with
>> > his work in Rails_2_develop everything but some local side
>> projects by
>> > me (1824, 1837) has been rebased from 1.8.7+ on Rails 2.0.
>> Three bugs
>> > remain that i cant fix with my current understanding of the
>> Network
>> > Code :).
>> >
>> > public SimpleGraph<NetworkVertex, NetworkEdge>
>> > createConnectionGraph(boolean addHQ) {
>> >
>> > in NetworkCompanyGraph_1880 contains 3 bug indications. If
>> anyone so
>> > brave could have a look at the code and fix that, it should
>> be ready for
>> > extensive testing with a number of save files :)
>> >
>> > Kind Regards,
>> > Martin
>> >
>> >
>> >
>>
Good Evening,
@Stefan: I found in my migration effort that certain Fixes/Enhancement
Erik had done to the basis code to enable flexible handling of player
ordering (reordering the seating of players) had not been pushed to the
rails 2 branch, you probably cherry picked the fixes and didnt transport
the 1880 related improvements at that time.
The compile errors come mostly from that parts thats currently in
migration into the 2_develop_1880 branch.
I didnt have enough time this weekend to fix everything there. Hopefully
i'll find some time tonight or on the week.
Reason why i pushed that code is, i use different machines to work
during weekdays or weekends on that branch.
Regards,
Martin
|
|
From: Martin B. <dr....@t-...> - 2014-02-16 17:49:41
Attachments:
signature.asc
0x718625A5.asc
|
On 16.02.2014 17:45, Martin Brumm wrote: > Am 16.02.2014 15:51, schrieb Stefan Frey: >> Martin & Mike: >> I have some troubles with the rails_2_develop_1880 branch: On my system >> there are several compile errors (12) in this branch, that do not seem >> to be linked to the issue discussed below. >> Are you sure you pushed everything to this branch? >> Stefan >> >> On 02/10/2014 02:58 PM, Michael Alexander wrote: >>> The reason I did that originally was to determine when a foreign >>> investor was connected to it's parent company. I was having trouble >>> with the existing implementation because it was "connecting" through an >>> off-map station (going in one side and out the other). I had thought at >>> the time that there was no other way I could do it. >>> >>> As it turns out, a handful of weeks after that, I noticed that the >>> off-map station was defined wrong in the XML. I suspect that once it >>> was defined correctly (which I did), that the original >>> NetworkCompanyGraph would have worked - but I wasn't sure it was worth >>> changing it back until 2.0. >>> >>> The function that has to work is Investor_1880::isConnectedtoLinkedCompany() >>> >>> Mike >>> >>> >>> >>> > > Good Evening, > > @Stefan: I found in my migration effort that certain Fixes/Enhancement > Erik had done to the basis code to enable flexible handling of player > ordering (reordering the seating of players) had not been pushed to the > rails 2 branch, you probably cherry picked the fixes and didnt transport > the 1880 related improvements at that time. > > The compile errors come mostly from that parts thats currently in > migration into the 2_develop_1880 branch. > > I didnt have enough time this weekend to fix everything there. Hopefully > i'll find some time tonight or on the week. > Reason why i pushed that code is, i use different machines to work > during weekdays or weekends on that branch. > > Regards, > Martin > > > > The commit in question is Commit e5581e31305d172a7ff5d68ede5e5fe0207165bc from Erik. Regards, Martin |
|
From: Martin B. <dr....@t-...> - 2014-02-16 18:19:08
Attachments:
signature.asc
|
Am 16.02.2014 18:49, schrieb Martin Brumm: > > On 16.02.2014 17:45, Martin Brumm wrote: >> Am 16.02.2014 15:51, schrieb Stefan Frey: >>> Martin & Mike: >>> I have some troubles with the rails_2_develop_1880 branch: On my system >>> there are several compile errors (12) in this branch, that do not seem >>> to be linked to the issue discussed below. >>> Are you sure you pushed everything to this branch? >>> Stefan >>> >>> On 02/10/2014 02:58 PM, Michael Alexander wrote: >>>> The reason I did that originally was to determine when a foreign >>>> investor was connected to it's parent company. I was having trouble >>>> with the existing implementation because it was "connecting" through an >>>> off-map station (going in one side and out the other). I had thought at >>>> the time that there was no other way I could do it. >>>> >>>> As it turns out, a handful of weeks after that, I noticed that the >>>> off-map station was defined wrong in the XML. I suspect that once it >>>> was defined correctly (which I did), that the original >>>> NetworkCompanyGraph would have worked - but I wasn't sure it was worth >>>> changing it back until 2.0. >>>> >>>> The function that has to work is Investor_1880::isConnectedtoLinkedCompany() >>>> >>>> Mike >>>> >>>> >>>> >>>> >> Good Evening, >> >> @Stefan: I found in my migration effort that certain Fixes/Enhancement >> Erik had done to the basis code to enable flexible handling of player >> ordering (reordering the seating of players) had not been pushed to the >> rails 2 branch, you probably cherry picked the fixes and didnt transport >> the 1880 related improvements at that time. >> >> The compile errors come mostly from that parts thats currently in >> migration into the 2_develop_1880 branch. >> >> I didnt have enough time this weekend to fix everything there. Hopefully >> i'll find some time tonight or on the week. >> Reason why i pushed that code is, i use different machines to work >> during weekdays or weekends on that branch. >> >> Regards, >> Martin >> >> >> >> > The commit in question is > Commit e5581e31305d172a7ff5d68ede5e5fe0207165bc from Erik. > > Regards, > Martin > Upon revisiting the code: Commit b95fd7fd0bf822a8f22a8f275166402ca7c3a9f701ef9 is also not in Rails 2.0. It added the basic feature to be able to reorder players and some mechanismn to display those changes in the UI. Any advice on how to proceed here ? Regards, Martin |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X