From: John D. G. <jd...@di...> - 2012-06-24 22:00:11
Attachments:
diff_1870_CompanyManager.xml
|
1. This patch is to allow the private company tokens to be laid. (I realize that someone else is working on 1870, and if this isn't welcome I'll stop. I'm doing it more to teach myself the code than anything else.) 2. I haven't yet figured out how to let the major companies lay two tiles in their first turn. CompanyManager.xml does have <TileLays> <Number colour="yellow" phase="1,2,3,4,5,6,7,8" number="2"/> </TileLays> which seems to work in 18EU; I haven't figured out why it fails in 1870. 3. How do I go about getting 1837 added to the "prototype" list so I can see how it behaves so far (since I can't seem to get it to build on Windows)? |
From: <Dr....@t-...> - 2012-06-25 08:38:51
|
Hi John, that code in CompanyManager.xml is outdated. The Definition is in Game.xmlfor 18EU <Component name="PhaseManager" class="rails.game.PhaseManager"> <Phase name="2"> <Tiles colour="yellow"> <Lays companyType="Minor" colour="yellow" number="2" occurrences="1"/> <Lays companyType="Minor" colour="green" number="0"/> <Lays companyType="Minor" colour="brown" number="0"/> <Lays companyType="Minor" colour="grey" number="0"/> </Tiles> <OperatingRounds number="2"/> <Trains tradingAllowed="yes"/> </Phase> <Phase name="3"> <Tiles colour="yellow,green"/> <Trains released="P"/> </Phase> <Phase name="4"> <Trains rusted="2" limitStep="2"/> </Phase> <Phase name="5"> <Tiles colour="yellow,green,brown"/> <Trains limitStep="3"/> <OffBoardRevenue step="2"/> </Phase> <Phase name="6"> <Trains rusted="3"/> </Phase> <Phase name="8"> <Tiles colour="yellow,green,brown,grey"/> <Trains rusted="4"/> </Phase> So my current understanding is that you would have to define <Lays companyType="Major" colour="yellow" number="2"/> for each phase where that should be valid. But on a side note to EriK why do we define the other colour lays (green, brown, grey) in Phase 2 ? This seems irrelevant ? Regards, Martin Von: John David Galt <jd...@di...> An: rai...@li... Betreff: [Rails-devel] 1870 patch and questions Datum: Mon, 25 Jun 2012 00:00:00 +0200 1. This patch is to allow the private company tokens to be laid. (I realize that someone else is working on 1870, and if this isn't welcome I'll stop. I'm doing it more to teach myself the code than anything else.) 2. I haven't yet figured out how to let the major companies lay two tiles in their first turn. CompanyManager.xml does have <TileLays> <Number colour="yellow" phase="1,2,3,4,5,6,7,8" number="2"/> </TileLays> which seems to work in 18EU; I haven't figured out why it fails in 1870. 3. How do I go about getting 1837 added to the "prototype" list so I can see how it behaves so far (since I can't seem to get it to build on Windows)? |
From: <Dr....@t-...> - 2012-06-25 08:58:52
|
Hi John, 1837 is in the List as in development (at least under 1.7.x ) ? And i can start it out of the development tree ? Can you give some more specific infos about not being able to build it on windows ? (whats the behaviour, error) Regards Martin P.s. i use Eclipse and Netbeans and have been able to build Rails on Windows on both IDEs ? Von: John David Galt <jd...@di...> An: rai...@li... Betreff: [Rails-devel] 1870 patch and questions Datum: Mon, 25 Jun 2012 00:00:00 +0200 1. This patch is to allow the private company tokens to be laid. (I realize that someone else is working on 1870, and if this isn't welcome I'll stop. I'm doing it more to teach myself the code than anything else.) 2. I haven't yet figured out how to let the major companies lay two tiles in their first turn. CompanyManager.xml does have <TileLays> <Number colour="yellow" phase="1,2,3,4,5,6,7,8" number="2"/> </TileLays> which seems to work in 18EU; I haven't figured out why it fails in 1870. 3. How do I go about getting 1837 added to the "prototype" list so I can see how it behaves so far (since I can't seem to get it to build on Windows)? |
From: Stefan F. <ste...@we...> - 2012-06-25 13:31:34
|
Further comments: 1) Actually there was nobody working on 1870 for quite some time. My initial trigger to start rails2.0 was the intention to have a better foundation for adding the changes required for 1870 (especially for price protection and destination runs). 3) The latest releases were based on the code in the rails1.7.x branch. The 1837 patches were applied to the rails master branch and will be included in the next major release (1.8.0). If you checkout the master branch you will see 1837 listed as "in development". Seems that there are several labels for that (some others are "prototype"s, some are "not playable" and 1880 is already almost playable. If there is the demand, I can make a build of the master branch available on the rails webpage. The build and upload process is fully automated so there is hardly any effort involved from my side. However as Martin pointed out there most other developers have a Windows setup as well, so it should be possible to track down those issues. I wonder how you developed and tested your patches without a working environment? Stefan On 06/25/2012 12:00 AM, John David Galt wrote: > 1. This patch is to allow the private company tokens to be laid. > > (I realize that someone else is working on 1870, and if this isn't welcome I'll > stop. I'm doing it more to teach myself the code than anything else.) > > 2. I haven't yet figured out how to let the major companies lay two tiles in their > first turn. CompanyManager.xml does have > > <TileLays> > <Number colour="yellow" phase="1,2,3,4,5,6,7,8" number="2"/> > </TileLays> > > which seems to work in 18EU; I haven't figured out why it fails in 1870. > > 3. How do I go about getting 1837 added to the "prototype" list so I can see how > it behaves so far (since I can't seem to get it to build on Windows)? > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > > > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
From: Erik V. <eri...@xs...> - 2012-06-25 15:10:34
|
I have applied your patch, and have also applied the new method of configuring two yellow tiles to 1870 (for 18EU, it had already been changed in the 'master' repo branch). Phase 2 is now defined as: <Phase name="2" realName="1"> <Tiles colour="yellow"> <Lays companyType="Public" colour="yellow" number="2"/> </Tiles> <OperatingRounds number="1"/> <Trains tradingAllowed="yes"/> </Phase> But I can't test this, so I must leave that to you. (BTW all phase properties are automatically copied to 'higher' phases, unless changed explicitly). Erik. > -----Original Message----- > From: John David Galt [mailto:jd...@di...] > Sent: Monday, June 25, 2012 12:00 AM > To: rai...@li... > Subject: [Rails-devel] 1870 patch and questions > > 1. This patch is to allow the private company tokens to be laid. > > (I realize that someone else is working on 1870, and if this isn't welcome I'll > stop. I'm doing it more to teach myself the code than anything else.) > > 2. I haven't yet figured out how to let the major companies lay two tiles in > their first turn. CompanyManager.xml does have > > <TileLays> > <Number colour="yellow" phase="1,2,3,4,5,6,7,8" number="2"/> > </TileLays> > > which seems to work in 18EU; I haven't figured out why it fails in 1870. > > 3. How do I go about getting 1837 added to the "prototype" list so I can see > how it behaves so far (since I can't seem to get it to build on Windows)? |