From: <Dr....@t-...> - 2012-03-05 21:42:53
|
Hi, apparently during the tile handling and displaying overhaul some interesting side effects came up. A tile with the number -80001 is shown not to have any upgrades even though they are listed in the Tiles.xml and Tileset.xml of that variant. If i shorten the tile id to -8001 the upgradeinfo is shown ? I suspect that this holds also true for the -89xxx tiles. Furthermore there is a tile -1 with a specific upgrade (8850,8851, 8852) shown in 1880s definition but i cant place a tile on that field, "NoTileAvailable". Frederic can you recheck that you haven mixed up the variant specific definitions there somehow ? I'll try to understand the new code in the next days, but any information would be helpfull. Regards, Martin |
From: Frederick W. <fre...@go...> - 2012-03-07 13:31:58
|
Martin: Some places to set breakpoints would be as follows: - UpgradePanel line 205: really no tile upgrades registered in the or UI manager? - ORUIManager line 764: why are tiles not regarded as valid upgrades? - GUITile line 79: why does tile lay simulation indicate invalidity of tile? Hope that helps. -- Frederick |
From: Schnell, V. <vol...@ar...> - 2012-03-30 20:01:25
Attachments:
1835_20120330_1732_Jupp.rails
|
Hello, I found an issue about the worth-calcualtion in Rails for the 1835-Variant. (Version actual Rails-Master with eclipse) See attached File i.e. Rails calculates 2253$ Worth for Jupp, in real it is 2003. There are also differences for the other player: Klaus-Jürgen Rails: 2514, Real: 2024 Sven: Rails 2559, Real: 1859 Volker: Rails1830, Real 1830, no differenc. Maybe the Pru shares counts double. greetings Volker -- Volker Schnell email: vol...@ar... homepage: home.arcor.de\volker_schnell |
From: Stefan F. <ste...@we...> - 2012-04-01 11:54:39
|
Volker: thanks for your report: Ffrom the numbers I can confirm the suspicion that Prussian shares have double expected worth. However as the behavior of the non-standard share models is intricate and 1835 is Erik's recent implementation it is better to wait for Erik to have a look at that. Erik: I intend to do a release with all recent fixes tonight. If you think that you will be able to do it shortly after that, send me an e-mail and I will wait for your fix. Stefan On 03/30/2012 10:01 PM, Schnell, Volker wrote: > Hello, > > I found an issue about the worth-calcualtion in Rails for the 1835-Variant. > (Version actual Rails-Master with eclipse) > > See attached File > i.e. Rails calculates 2253$ Worth for Jupp, in real it is 2003. > There are also differences for the other player: > Klaus-Jürgen Rails: 2514, Real: 2024 > Sven: Rails 2559, Real: 1859 > Volker: Rails1830, Real 1830, no differenc. > > Maybe the Pru shares counts double. > > greetings > Volker > > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > > > > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel |
From: Erik V. <eri...@xs...> - 2012-04-01 11:59:29
|
> I found an issue about the worth-calcualtion in Rails for the 1835-Variant. > Maybe the Pru shares counts double. Thanks for catching this bug, and for pointing me in exactly the right direction for a solution. The PR is unique in that the market price corresponds to *two* (5%) share units. This fact was overlooked in the worth calculation. I have pushed a fix to the master branch. Erik. |
From: Stefan F. <ste...@we...> - 2012-04-01 12:26:31
|
Erik: thanks. I have picked this and all other fixes from you into Rails1.7.x and updated the reports of those 1835 test cases that were effected, so that all test cases are successful again. Will do the release for 1.7.1 later today. Stefan On 04/01/2012 01:59 PM, Erik Vos wrote: >> I found an issue about the worth-calcualtion in Rails for the > 1835-Variant. >> Maybe the Pru shares counts double. > > Thanks for catching this bug, and for pointing me in exactly the right > direction for a solution. > > The PR is unique in that the market price corresponds to *two* (5%) share > units. This fact was overlooked in the worth calculation. > I have pushed a fix to the master branch. > > Erik. > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel |
From: John D. G. <jd...@di...> - 2012-04-01 18:36:30
|
On 2012-04-01 04:59, Erik Vos wrote: >> I found an issue about the worth-calcualtion in Rails for the >> 1835-Variant. >> Maybe the Pru shares counts double. > Thanks for catching this bug, and for pointing me in exactly the right > direction for a solution. > > The PR is unique in that the market price corresponds to *two* (5%) share > units. This fact was overlooked in the worth calculation. > I have pushed a fix to the master branch. I have another small issue with the net worth calculation for 1835: LD is shown at face value, even though it will quickly disappear for nothing. (This makes that player appear to have a large negative income in the round when SX floats.) I recommend counting it as zero. Likewise the B&O private and those like it in other games. |
From: Chris S. <chr...@gm...> - 2012-04-02 01:03:06
|
This is a more global discussion than just 1835. The question is whether to show net worth for a presumed "reasonable expectation of what will happen and when the game will end" or to show the net worth "if the game ended right now." Any game with disappearing privates that have value during existence will be affected, but other scenarios are also affected. I recommend if you decide to display the former, you give players an option to also calculate and view the figures for the latter. -- Chris Please consider the environment before printing this e-mail. On Sun, Apr 1, 2012 at 11:36 AM, John David Galt < jd...@di...> wrote: > On 2012-04-01 04:59, Erik Vos wrote: > >> I found an issue about the worth-calcualtion in Rails for the > >> 1835-Variant. > >> Maybe the Pru shares counts double. > > > Thanks for catching this bug, and for pointing me in exactly the right > > direction for a solution. > > > > The PR is unique in that the market price corresponds to *two* (5%) share > > units. This fact was overlooked in the worth calculation. > > I have pushed a fix to the master branch. > > I have another small issue with the net worth calculation for 1835: LD is > shown at face value, even though it will quickly disappear for nothing. > (This makes that player appear to have a large negative income in the round > when SX floats.) I recommend counting it as zero. Likewise the B&O > private > and those like it in other games. > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
From: Stefan F. <ste...@we...> - 2012-04-02 07:28:15
|
Last time this discussion came up I wrote down an algorithm that tried to tackle that issue on a general level. However it did not attract much love at that time. So I will wait for better suggestions, but I am still reluctant to implement that on a case-by-case basis. Stefan On 04/02/2012 03:02 AM, Chris Shaffer wrote: > This is a more global discussion than just 1835. The question is > whether to show net worth for a presumed "reasonable expectation of what > will happen and when the game will end" or to show the net worth "if the > game ended right now." Any game with disappearing privates that have > value during existence will be affected, but other scenarios are also > affected. > > I recommend if you decide to display the former, you give players an > option to also calculate and view the figures for the latter. > > -- > Chris > > Please consider the environment before printing this e-mail. > > > On Sun, Apr 1, 2012 at 11:36 AM, John David Galt > <jd...@di... <mailto:jd...@di...>> > wrote: > > On 2012-04-01 04:59, Erik Vos wrote: > >> I found an issue about the worth-calcualtion in Rails for the > >> 1835-Variant. > >> Maybe the Pru shares counts double. > > > Thanks for catching this bug, and for pointing me in exactly the > right > > direction for a solution. > > > > The PR is unique in that the market price corresponds to *two* > (5%) share > > units. This fact was overlooked in the worth calculation. > > I have pushed a fix to the master branch. > > I have another small issue with the net worth calculation for 1835: > LD is > shown at face value, even though it will quickly disappear for nothing. > (This makes that player appear to have a large negative income in > the round > when SX floats.) I recommend counting it as zero. Likewise the B&O > private > and those like it in other games. > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > Rails-devel mailing list > Rai...@li... > <mailto:Rai...@li...> > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > > > > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel |
From: Phil D. <de...@gm...> - 2012-04-02 08:46:44
|
I would always personally favour stating net worth as 'what if the game ended right now' but I appreciate this is a highly subjective area On 2 April 2012 08:28, Stefan Frey <ste...@we...> wrote: > Last time this discussion came up I wrote down an algorithm that tried > to tackle that issue on a general level. However it did not attract much > love at that time. > So I will wait for better suggestions, but I am still reluctant to > implement that on a case-by-case basis. > Stefan > > On 04/02/2012 03:02 AM, Chris Shaffer wrote: >> This is a more global discussion than just 1835. The question is >> whether to show net worth for a presumed "reasonable expectation of what >> will happen and when the game will end" or to show the net worth "if the >> game ended right now." Any game with disappearing privates that have >> value during existence will be affected, but other scenarios are also >> affected. >> >> I recommend if you decide to display the former, you give players an >> option to also calculate and view the figures for the latter. >> >> -- >> Chris >> >> Please consider the environment before printing this e-mail. >> >> >> On Sun, Apr 1, 2012 at 11:36 AM, John David Galt >> <jd...@di... <mailto:jd...@di...>> >> wrote: >> >> On 2012-04-01 04:59, Erik Vos wrote: >> >> I found an issue about the worth-calcualtion in Rails for the >> >> 1835-Variant. >> >> Maybe the Pru shares counts double. >> >> > Thanks for catching this bug, and for pointing me in exactly the >> right >> > direction for a solution. >> > >> > The PR is unique in that the market price corresponds to *two* >> (5%) share >> > units. This fact was overlooked in the worth calculation. >> > I have pushed a fix to the master branch. >> >> I have another small issue with the net worth calculation for 1835: >> LD is >> shown at face value, even though it will quickly disappear for nothing. >> (This makes that player appear to have a large negative income in >> the round >> when SX floats.) I recommend counting it as zero. Likewise the B&O >> private >> and those like it in other games. >> >> ------------------------------------------------------------------------------ >> This SF email is sponsosred by: >> Try Windows Azure free for 90 days Click Here >> http://p.sf.net/sfu/sfd2d-msazure >> _______________________________________________ >> Rails-devel mailing list >> Rai...@li... >> <mailto:Rai...@li...> >> https://lists.sourceforge.net/lists/listinfo/rails-devel >> >> >> >> >> ------------------------------------------------------------------------------ >> This SF email is sponsosred by: >> Try Windows Azure free for 90 days Click Here >> http://p.sf.net/sfu/sfd2d-msazure >> >> >> >> _______________________________________________ >> Rails-devel mailing list >> Rai...@li... >> https://lists.sourceforge.net/lists/listinfo/rails-devel > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel |