rails-devel

[Rails-devel] Rails 1.4 1835 playtest - hangs early

[John D. G. <jd...@di...>]

I tried it with 1835.  Contrary to what I wrote in the 18EU review, the
1835 map doesn't show the Y or XX hexes.  It does very nicely show the
impassable hex side NW of Hamburg.

I got as far as laying tiles with the BY in OR1 (thanks for changing the
company names!)  Then it hangs (no "Buy Train" button, "Done" is grayed
out, and I don't even get the usual dialog saying BY has no train.)

Save file is attached.  If the list filters it, I'll mail it on request.

Re: [Rails-devel] Rails 1.4 1835 playtest - hangs early

[Stefan F. <ste...@we...>]

I have seen this bug before: It seems that the tile lay phase does not end 
correctly, if the special tile lay of the OBB comes after the regular tile 
lays. I had not time yet to follow this up, so I do not know if this comes 
from the fact that there are already multiple lays allowed or that OBB itself 
allows two independent lays.

Fortunately there is a quick workaround: Simply lay the OBB tile first, 
followed by the regular ones. This works on your save file too.

Be aware that there are still several bugs ahead of your party. Some of them 
already fixed in development, but some other still need further investigation. 
(Nearly all of them related to PR merger/creation).

And thanks for your excellent and interesting comments from your 18EU play.
I will try to follow up, but time is a rare good at the moment.

Stefan

On Saturday, September 11, 2010 05:38:57 pm John David Galt wrote:
> I tried it with 1835.  Contrary to what I wrote in the 18EU review, the
> 1835 map doesn't show the Y or XX hexes.  It does very nicely show the
> impassable hex side NW of Hamburg.
> 
> I got as far as laying tiles with the BY in OR1 (thanks for changing the
> company names!)  Then it hangs (no "Buy Train" button, "Done" is grayed
> out, and I don't even get the usual dialog saying BY has no train.)
> 
> Save file is attached.  If the list filters it, I'll mail it on request.

Re: [Rails-devel] Rails 1.4 1835 playtest - hangs early

[John D. G. <jd...@di...>]

John David Galt wrote:
>> I tried it with 1835.  Contrary to what I wrote in the 18EU review, the
>> 1835 map doesn't show the Y or XX hexes.

My mistake.  It does show the XX hexes, just not the Y.

>> I got as far as laying tiles with the BY in OR1 (thanks for changing the
>> company names!)  Then it hangs (no "Buy Train" button, "Done" is grayed
>> out, and I don't even get the usual dialog saying BY has no train.)

Stefan Frey wrote:
> I have seen this bug before: It seems that the tile lay phase does not end 
> correctly, if the special tile lay of the OBB comes after the regular tile 
> lays. I had not time yet to follow this up, so I do not know if this comes 
> from the fact that there are already multiple lays allowed or that OBB itself 
> allows two independent lays.
> 
> Fortunately there is a quick workaround: Simply lay the OBB tile first, 
> followed by the regular ones. This works on your save file too.

Thanks, that works.

> Be aware that there are still several bugs ahead of your party. Some of them 
> already fixed in development, but some other still need further investigation. 
> (Nearly all of them related to PR merger/creation).

I continued this game just to see what other glitches I could find, and did
find several more.  It hung (sort of) partway through a stock round, about
halfway through the game (the next train to be purchased will be the 4 and
trigger PR formation, but I'm not there yet).  Here's a new save file with
commentary in it.

> And thanks for your excellent and interesting comments from your 18EU play.
> I will try to follow up, but time is a rare good at the moment.

I haven't yet managed to get a build to work locally, but I am trying to help
you out & not just complain.

Re: [Rails-devel] Rails 1.4 1835 playtest - hangs early

[Stefan F. <ste...@we...>]

The bug you refer below is the self-nationalisation bug, which has Rails 
create ex-ante nationalisation actions for the own holdings, an action which 
cannot be processed ex-post. You can still continue playing, but it is not 
possible to sell stocks after crossing the threshold for nationalization in 
Rails 1.4. This is fixed in development.

Stefan

For reference I copy the list of fixes in 1835 from a previous mail, but I 
admit most descriptions are more technical than descriptive.

- Tile 213 update was incorrect
- Pr funding money not given, but see TODO 1
- PR formation round acted as a stock round (side effect: price increase, 
wrong round names), removed call to super.finishRound()
- Undo inside PR formation round creates weird states, fixed by changing to 
linked moveSets
- Nationalisation did not check certificate limits before action (post-action 
check was ok)
- Nationalisation prevents selling of stocks (due to self-nationalisation bug)
- Pr 5% shares report only 1/4 of value, 10% shares only 1/2 of value(report 
window, executed correctly fixed currentSellPrice, see TODO 2 and 3, adjusted 
output)
- Added manual closing of OBB

Remaining TODOs:
1) Implement SharePriceUnits everywhere it is appropriate (e.g. Round method 
floating())
2) SellPrices is not a stateful map (=> undo side effects!)
3) Selling PR president is shown as selling two 5 percent shares (which might 
be correct) but selling those creates all kind of crazy effects


On Sunday, September 12, 2010 10:32:05 pm John David Galt wrote:
> John David Galt wrote:
> >> I tried it with 1835.  Contrary to what I wrote in the 18EU review, the
> >> 1835 map doesn't show the Y or XX hexes.
> 
> My mistake.  It does show the XX hexes, just not the Y.
> 
> >> I got as far as laying tiles with the BY in OR1 (thanks for changing the
> >> company names!)  Then it hangs (no "Buy Train" button, "Done" is grayed
> >> out, and I don't even get the usual dialog saying BY has no train.)
> 
> Stefan Frey wrote:
> > I have seen this bug before: It seems that the tile lay phase does not
> > end correctly, if the special tile lay of the OBB comes after the
> > regular tile lays. I had not time yet to follow this up, so I do not
> > know if this comes from the fact that there are already multiple lays
> > allowed or that OBB itself allows two independent lays.
> > 
> > Fortunately there is a quick workaround: Simply lay the OBB tile first,
> > followed by the regular ones. This works on your save file too.
> 
> Thanks, that works.
> 
> > Be aware that there are still several bugs ahead of your party. Some of
> > them already fixed in development, but some other still need further
> > investigation. (Nearly all of them related to PR merger/creation).
> 
> I continued this game just to see what other glitches I could find, and did
> find several more.  It hung (sort of) partway through a stock round, about
> halfway through the game (the next train to be purchased will be the 4 and
> trigger PR formation, but I'm not there yet).  Here's a new save file with
> commentary in it.
> 
> > And thanks for your excellent and interesting comments from your 18EU
> > play. I will try to follow up, but time is a rare good at the moment.
> 
> I haven't yet managed to get a build to work locally, but I am trying to
> help you out & not just complain.

Re: [Rails-devel] Rails 1.4 1835 playtest - hangs early

[Erik V. <eri...@xs...>]

Found this old message waiting to be addressed (finally):

> -----Oorspronkelijk bericht-----
> Van: John David Galt [mailto:jd...@di...]
> 
> I tried it with 1835.  Contrary to what I wrote in the 18EU review, the
> 1835 map doesn't show the Y or XX hexes.  It does very nicely show the
> impassable hex side NW of Hamburg.

The 1835 map did always show the XX tiles, but for the Y hexes the standard
city map tiles #-10 were used so far.  These have now been replaced by the
18EU Y city map tiles #-3007. 
Additional benefit is that the upgrade rules could be simplified.

> I got as far as laying tiles with the BY in OR1 (thanks for changing the
company
> names!)  Then it hangs (no "Buy Train" button, "Done" is grayed out, and I
> don't even get the usual dialog saying BY has no train.)
> 
> Save file is attached.  If the list filters it, I'll mail it on request.

This problem was apparently fixed, or it miraculously went away, I don't
remember.  In any case, it works for me now.

Erik.