From: Chris S. <chr...@gm...> - 2010-01-22 00:04:03
Attachments:
18EU_20100119_2319_Jon.rails
|
We're using version 1.1.0 for compatibility reasons, so perhaps this has been fixed already? Bug report described below, save file attached just prior to the bug. -- Chris Please consider the environment before printing this e-mail. ---------- Forwarded message ---------- From: Jonathan Hays Date: Thu, Jan 21, 2010 at 3:38 PM Subject: Re: [18EU-C] Chris Hi, Looking at the code and messing around with it a bit, I think I'm on the right track to spotting the problem. When loading the save game it dies with a NullPointerException. The loading of a save game basically consists of pulling some information from the top and then loading a sequence of action objects which encode every action taken by all players since the beginning of the game and executing them in turn. It dies when trying to execute my action of buying a T8. Now, for each train in the game there is an object - except when there are an infinite number of trains such as the T8 - this object is created during initialisation and the purchase of a train involves moving a reference to that object around from the previous owner to the new owner. Whatever the bug is, I think its to do with how the infinite trains are handled. It seems to work fine when entering the moves using the UI, but when loading them from a save game its somehow losing the T8's (except for the first one). One workaround is to hack the game.xml to put a finite (but large enough) number of T8s thus ensuring that there are always a fixed number of objects created at initialisation time. I've tested this and it works. Cheers, Jon On Thu, Jan 21, 2010 at 21:48, Jonathan Hays wrote: > nope. it can't load them either. > > Jon > > > On Thu, Jan 21, 2010 at 21:44, Jonathan Hays wrote: >> I can try and get 1.1.2 working with our saved game files. >> >> Jon >> >> >> On Thu, Jan 21, 2010 at 13:53, Chris Shaffer wrote: >>> So maybe there is something broken about the T8 phase change - I seem >>> to recall a mention on the rails-devel list recently about problems >>> with the grey tiles in an older version (i.e. what we're using now). >>> >>> -- >>> Chris >>> >>> Please consider the environment before printing this e-mail. >>> >>> >>> >>> On Thu, Jan 21, 2010 at 5:52 AM, Jonathan Hays wrote: >>>> ok, so if you try to load a file and fail, it doesn't quit but it is >>>> left in such a state that you can't load another file at all - it >>>> always fails with the error Jim posted. >>>> >>>> If I start from the beginning of my turn and just lay the track I can >>>> save the game and reload it. If I reload the game from that point and >>>> continue my turn buying a T8 and then save, I cannot reload that save >>>> game file. >>>> >>>> Jon >>>> >>>> >>>> On Thu, Jan 21, 2010 at 13:36, Jonathan Hays wrote: >>>>> and now its broken again. very strange. >>>>> >>>>> Jon >>>>> >>>>> >>>>> On Thu, Jan 21, 2010 at 12:45, Jonathan Hays wrote: >>>>>> ok, now its working again,. >>>>>> >>>>>> >>>>>> Jon >>>>>> >>>>>> >>>>>> On Thu, Jan 21, 2010 at 12:38, Jonathan Hays wrote: >>>>>>> hmmm, I can't open the files on my linux box anymore. >>>>>>> The file I made last night was on my laptop at home. >>>>>>> >>>>>>> I'll try and read them on the laptop tonight - but its very odd. >>>>>>> >>>>>>> Jon >>>>>>> >>>>>>> >>>>>>> On Thu, Jan 21, 2010 at 08:39, James Romano wrote: >>>>>>>> No, I can't open it either. ("Load failed, reason: null") >>>>>>>> >>>>>>>> I also can't open my save file to Jon ("Game setup from file Game.xml >>>>>>>> failed: Cannot reconfigure the ComponentManager. Load failed, reason: >>>>>>>> Error in settin gup 18EU") >>>>>>>> >>>>>>>> Nor can I open Jon's earlier save to me (same error as above). But I *did* >>>>>>>> open that file a few days ago, and I entered KPEV's turn, and saved for Jon. >>>>>>>> >>>>>>>> So, something has changed, since I can't open a file that I could open >>>>>>>> before. Have we "upgraded" to a newer version of Rails or something? >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Jan 21, 2010 at 12:28 AM, Chris Shaffer >>>>>>>> wrote: >>>>>>>>> >>>>>>>>> Jim, can you open the file? I'm getting the same error as before. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Chris >>>>>>>>> >>>>>>>>> Please consider the environment before printing this e-mail. >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Wed, Jan 20, 2010 at 2:05 PM, Jonathan Hays >>>>>>>>> wrote: >>>>>>>>> > Hi, >>>>>>>>> > >>>>>>>>> > ok, I think the problem was that I'd done a forced undo during my turn >>>>>>>>> > and got the game into a funny state. >>>>>>>>> > Hopefully, this one will work. >>>>>>>>> > >>>>>>>>> > Jon >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > On Wed, Jan 20, 2010 at 17:17, Jonathan Hays >>>>>>>>> > wrote: >>>>>>>>> >> Hi, >>>>>>>>> >> >>>>>>>>> >> I'll deal with it once I get home from work. >>>>>>>>> >> >>>>>>>>> >> Jon >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> On Wed, Jan 20, 2010 at 17:09, James Romano >>>>>>>>> >> wrote: >>>>>>>>> >>> Any progress on this? >>>>>>>>> >>> >>>>>>>>> >>> On Tue, Jan 19, 2010 at 10:20 PM, Chris Shaffer >>>>>>>>> >>> wrote: >>>>>>>>> >>>> >>>>>>>>> >>>> I get a "load failed: reason null" error when I try to open the save >>>>>>>>> >>>> file. I can open the previous one (named >>>>>>>>> >>>> 18EU_20100119_2319_Jon.rails) with >>>>>>>>> >>>> no problem. Maybe you can retake your turn Jon? >>>>>>>>> >>>> >>>>>>>>> >>>> -- >>>>>>>>> >>>> Chris >>>>>>>>> >>>> >>>>>>>>> >>>> Please consider the environment before printing this e-mail. |
From: Phil D. <de...@gm...> - 2010-01-22 09:31:16
|
I've not even looked at the code but at a guess, is it possible that the first train purchase of an unlimited decrements the trains available number, sending it from -1 to -2? That would explain why the first train purchase works okay. I'll have a peek at this when I get home tonight, I am having the same problem with one of my savefiles too Phil 2010/1/22 Chris Shaffer <chr...@gm...>: > We're using version 1.1.0 for compatibility reasons, so perhaps this > has been fixed already? Bug report described below, save file > attached just prior to the bug. > > -- > Chris > > Please consider the environment before printing this e-mail. > > > > > ---------- Forwarded message ---------- > From: Jonathan Hays > Date: Thu, Jan 21, 2010 at 3:38 PM > Subject: Re: [18EU-C] Chris > > Hi, > > Looking at the code and messing around with it a bit, I think I'm on > the right track to spotting the problem. > When loading the save game it dies with a NullPointerException. > > The loading of a save game basically consists of pulling some > information from the top and then loading a sequence of action objects > which encode every action taken by all players since the beginning of > the game and executing them in turn. > > It dies when trying to execute my action of buying a T8. > > Now, for each train in the game there is an object - except when there > are an infinite number of trains such as the T8 - this object is > created during initialisation and the purchase of a train involves > moving a reference to that object around from the previous owner to > the new owner. > > Whatever the bug is, I think its to do with how the infinite trains > are handled. It seems to work fine when entering the moves using the > UI, but when loading them from a save game its somehow losing the T8's > (except for the first one). > > One workaround is to hack the game.xml to put a finite (but large > enough) number of T8s thus ensuring that there are always a fixed > number of objects created at initialisation time. > > I've tested this and it works. > > Cheers, > > Jon > > > On Thu, Jan 21, 2010 at 21:48, Jonathan Hays wrote: >> nope. it can't load them either. >> >> Jon >> >> >> On Thu, Jan 21, 2010 at 21:44, Jonathan Hays wrote: >>> I can try and get 1.1.2 working with our saved game files. >>> >>> Jon >>> >>> >>> On Thu, Jan 21, 2010 at 13:53, Chris Shaffer wrote: >>>> So maybe there is something broken about the T8 phase change - I seem >>>> to recall a mention on the rails-devel list recently about problems >>>> with the grey tiles in an older version (i.e. what we're using now). >>>> >>>> -- >>>> Chris >>>> >>>> Please consider the environment before printing this e-mail. >>>> >>>> >>>> >>>> On Thu, Jan 21, 2010 at 5:52 AM, Jonathan Hays wrote: >>>>> ok, so if you try to load a file and fail, it doesn't quit but it is >>>>> left in such a state that you can't load another file at all - it >>>>> always fails with the error Jim posted. >>>>> >>>>> If I start from the beginning of my turn and just lay the track I can >>>>> save the game and reload it. If I reload the game from that point and >>>>> continue my turn buying a T8 and then save, I cannot reload that save >>>>> game file. >>>>> >>>>> Jon >>>>> >>>>> >>>>> On Thu, Jan 21, 2010 at 13:36, Jonathan Hays wrote: >>>>>> and now its broken again. very strange. >>>>>> >>>>>> Jon >>>>>> >>>>>> >>>>>> On Thu, Jan 21, 2010 at 12:45, Jonathan Hays wrote: >>>>>>> ok, now its working again,. >>>>>>> >>>>>>> >>>>>>> Jon >>>>>>> >>>>>>> >>>>>>> On Thu, Jan 21, 2010 at 12:38, Jonathan Hays wrote: >>>>>>>> hmmm, I can't open the files on my linux box anymore. >>>>>>>> The file I made last night was on my laptop at home. >>>>>>>> >>>>>>>> I'll try and read them on the laptop tonight - but its very odd. >>>>>>>> >>>>>>>> Jon >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Jan 21, 2010 at 08:39, James Romano wrote: >>>>>>>>> No, I can't open it either. ("Load failed, reason: null") >>>>>>>>> >>>>>>>>> I also can't open my save file to Jon ("Game setup from file Game.xml >>>>>>>>> failed: Cannot reconfigure the ComponentManager. Load failed, reason: >>>>>>>>> Error in settin gup 18EU") >>>>>>>>> >>>>>>>>> Nor can I open Jon's earlier save to me (same error as above). But I *did* >>>>>>>>> open that file a few days ago, and I entered KPEV's turn, and saved for Jon. >>>>>>>>> >>>>>>>>> So, something has changed, since I can't open a file that I could open >>>>>>>>> before. Have we "upgraded" to a newer version of Rails or something? >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Thu, Jan 21, 2010 at 12:28 AM, Chris Shaffer >>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> Jim, can you open the file? I'm getting the same error as before. >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Chris >>>>>>>>>> >>>>>>>>>> Please consider the environment before printing this e-mail. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Wed, Jan 20, 2010 at 2:05 PM, Jonathan Hays >>>>>>>>>> wrote: >>>>>>>>>> > Hi, >>>>>>>>>> > >>>>>>>>>> > ok, I think the problem was that I'd done a forced undo during my turn >>>>>>>>>> > and got the game into a funny state. >>>>>>>>>> > Hopefully, this one will work. >>>>>>>>>> > >>>>>>>>>> > Jon >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > On Wed, Jan 20, 2010 at 17:17, Jonathan Hays >>>>>>>>>> > wrote: >>>>>>>>>> >> Hi, >>>>>>>>>> >> >>>>>>>>>> >> I'll deal with it once I get home from work. >>>>>>>>>> >> >>>>>>>>>> >> Jon >>>>>>>>>> >> >>>>>>>>>> >> >>>>>>>>>> >> On Wed, Jan 20, 2010 at 17:09, James Romano >>>>>>>>>> >> wrote: >>>>>>>>>> >>> Any progress on this? >>>>>>>>>> >>> >>>>>>>>>> >>> On Tue, Jan 19, 2010 at 10:20 PM, Chris Shaffer >>>>>>>>>> >>> wrote: >>>>>>>>>> >>>> >>>>>>>>>> >>>> I get a "load failed: reason null" error when I try to open the save >>>>>>>>>> >>>> file. I can open the previous one (named >>>>>>>>>> >>>> 18EU_20100119_2319_Jon.rails) with >>>>>>>>>> >>>> no problem. Maybe you can retake your turn Jon? >>>>>>>>>> >>>> >>>>>>>>>> >>>> -- >>>>>>>>>> >>>> Chris >>>>>>>>>> >>>> >>>>>>>>>> >>>> Please consider the environment before printing this e-mail. > > ------------------------------------------------------------------------------ > Throughout its 18-year history, RSA Conference consistently attracts the > world's best and brightest in the field, creating opportunities for Conference > attendees to learn about information security's most important issues through > interactions with peers, luminaries and emerging and established companies. > http://p.sf.net/sfu/rsaconf-dev2dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > > |
From: Erik V. <eri...@xs...> - 2010-01-22 20:06:10
|
I'm also having a problem with this saved file, and it's the same problem that I have with (only) one of my own saved files. But it's a different problem: loading stops after a 'Done' action in a Stock Round. No 8-trains bought yet. I don't think the quantity is the problem; it's never deducted. All that happens is that the number of remaining trains in the IPO portfolio is counted. If zero, there are no trains left. If the amount is infinite, the one existing train is taken out but a new train is created and inserted. Setting the quantity to a high number doesn't fix my problem. Clearly something is going on differently while reloading. Still investigating. Erik. -----Original Message----- From: Phil Davies [mailto:de...@gm...] Sent: Friday 22 January 2010 10:31 To: Development list for Rails: an 18xx game Subject: Re: [Rails-devel] Problem with infinite trains I've not even looked at the code but at a guess, is it possible that the first train purchase of an unlimited decrements the trains available number, sending it from -1 to -2? That would explain why the first train purchase works okay. I'll have a peek at this when I get home tonight, I am having the same problem with one of my savefiles too Phil 2010/1/22 Chris Shaffer <chr...@gm...>: > We're using version 1.1.0 for compatibility reasons, so perhaps this > has been fixed already? Bug report described below, save file > attached just prior to the bug. > > -- > Chris > > Please consider the environment before printing this e-mail. > > > > > ---------- Forwarded message ---------- > From: Jonathan Hays > Date: Thu, Jan 21, 2010 at 3:38 PM > Subject: Re: [18EU-C] Chris > > Hi, > > Looking at the code and messing around with it a bit, I think I'm on > the right track to spotting the problem. > When loading the save game it dies with a NullPointerException. > > The loading of a save game basically consists of pulling some > information from the top and then loading a sequence of action objects > which encode every action taken by all players since the beginning of > the game and executing them in turn. > > It dies when trying to execute my action of buying a T8. > > Now, for each train in the game there is an object - except when there > are an infinite number of trains such as the T8 - this object is > created during initialisation and the purchase of a train involves > moving a reference to that object around from the previous owner to > the new owner. > > Whatever the bug is, I think its to do with how the infinite trains > are handled. It seems to work fine when entering the moves using the > UI, but when loading them from a save game its somehow losing the T8's > (except for the first one). > > One workaround is to hack the game.xml to put a finite (but large > enough) number of T8s thus ensuring that there are always a fixed > number of objects created at initialisation time. > > I've tested this and it works. > > Cheers, > > Jon > > > On Thu, Jan 21, 2010 at 21:48, Jonathan Hays wrote: >> nope. it can't load them either. >> >> Jon >> >> >> On Thu, Jan 21, 2010 at 21:44, Jonathan Hays wrote: >>> I can try and get 1.1.2 working with our saved game files. >>> >>> Jon >>> >>> >>> On Thu, Jan 21, 2010 at 13:53, Chris Shaffer wrote: >>>> So maybe there is something broken about the T8 phase change - I seem >>>> to recall a mention on the rails-devel list recently about problems >>>> with the grey tiles in an older version (i.e. what we're using now). >>>> >>>> -- >>>> Chris >>>> >>>> Please consider the environment before printing this e-mail. >>>> >>>> >>>> >>>> On Thu, Jan 21, 2010 at 5:52 AM, Jonathan Hays wrote: >>>>> ok, so if you try to load a file and fail, it doesn't quit but it is >>>>> left in such a state that you can't load another file at all - it >>>>> always fails with the error Jim posted. >>>>> >>>>> If I start from the beginning of my turn and just lay the track I can >>>>> save the game and reload it. If I reload the game from that point and >>>>> continue my turn buying a T8 and then save, I cannot reload that save >>>>> game file. >>>>> >>>>> Jon >>>>> >>>>> >>>>> On Thu, Jan 21, 2010 at 13:36, Jonathan Hays wrote: >>>>>> and now its broken again. very strange. >>>>>> >>>>>> Jon >>>>>> >>>>>> >>>>>> On Thu, Jan 21, 2010 at 12:45, Jonathan Hays wrote: >>>>>>> ok, now its working again,. >>>>>>> >>>>>>> >>>>>>> Jon >>>>>>> >>>>>>> >>>>>>> On Thu, Jan 21, 2010 at 12:38, Jonathan Hays wrote: >>>>>>>> hmmm, I can't open the files on my linux box anymore. >>>>>>>> The file I made last night was on my laptop at home. >>>>>>>> >>>>>>>> I'll try and read them on the laptop tonight - but its very odd. >>>>>>>> >>>>>>>> Jon >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Jan 21, 2010 at 08:39, James Romano wrote: >>>>>>>>> No, I can't open it either. ("Load failed, reason: null") >>>>>>>>> >>>>>>>>> I also can't open my save file to Jon ("Game setup from file Game.xml >>>>>>>>> failed: Cannot reconfigure the ComponentManager. Load failed, reason: >>>>>>>>> Error in settin gup 18EU") >>>>>>>>> >>>>>>>>> Nor can I open Jon's earlier save to me (same error as above). But I *did* >>>>>>>>> open that file a few days ago, and I entered KPEV's turn, and saved for Jon. >>>>>>>>> >>>>>>>>> So, something has changed, since I can't open a file that I could open >>>>>>>>> before. Have we "upgraded" to a newer version of Rails or something? >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Thu, Jan 21, 2010 at 12:28 AM, Chris Shaffer >>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> Jim, can you open the file? I'm getting the same error as before. >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Chris >>>>>>>>>> >>>>>>>>>> Please consider the environment before printing this e-mail. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Wed, Jan 20, 2010 at 2:05 PM, Jonathan Hays >>>>>>>>>> wrote: >>>>>>>>>> > Hi, >>>>>>>>>> > >>>>>>>>>> > ok, I think the problem was that I'd done a forced undo during my turn >>>>>>>>>> > and got the game into a funny state. >>>>>>>>>> > Hopefully, this one will work. >>>>>>>>>> > >>>>>>>>>> > Jon >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > On Wed, Jan 20, 2010 at 17:17, Jonathan Hays >>>>>>>>>> > wrote: >>>>>>>>>> >> Hi, >>>>>>>>>> >> >>>>>>>>>> >> I'll deal with it once I get home from work. >>>>>>>>>> >> >>>>>>>>>> >> Jon >>>>>>>>>> >> >>>>>>>>>> >> >>>>>>>>>> >> On Wed, Jan 20, 2010 at 17:09, James Romano >>>>>>>>>> >> wrote: >>>>>>>>>> >>> Any progress on this? >>>>>>>>>> >>> >>>>>>>>>> >>> On Tue, Jan 19, 2010 at 10:20 PM, Chris Shaffer >>>>>>>>>> >>> wrote: >>>>>>>>>> >>>> >>>>>>>>>> >>>> I get a "load failed: reason null" error when I try to open the save >>>>>>>>>> >>>> file. I can open the previous one (named >>>>>>>>>> >>>> 18EU_20100119_2319_Jon.rails) with >>>>>>>>>> >>>> no problem. Maybe you can retake your turn Jon? >>>>>>>>>> >>>> >>>>>>>>>> >>>> -- >>>>>>>>>> >>>> Chris >>>>>>>>>> >>>> >>>>>>>>>> >>>> Please consider the environment before printing this e-mail. > > ---------------------------------------------------------------------------- -- > Throughout its 18-year history, RSA Conference consistently attracts the > world's best and brightest in the field, creating opportunities for Conference > attendees to learn about information security's most important issues through > interactions with peers, luminaries and emerging and established companies. > http://p.sf.net/sfu/rsaconf-dev2dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > > ---------------------------------------------------------------------------- -- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev _______________________________________________ Rails-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rails-devel |