Thread: [Rails-devel] 18EU undo fix

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

In 18EU, Undo did not revert all changes resulting from minor conversion
actions.
That has been fixed now.

Erik Vos

I meant to just try to research the problem and send the patch, but the 
changes below sound close enough I'll ask:

I believe there are some problems with undo and numbering of operating 
rounds - I think that if I am in OR 2 of 2 and I undo back into OR 1/2, 
the program will go to a stock round with the end of the first of 
supposed two operating roudns, as if the Undo action didn't decrease the 
variable holding which operating round is happening.

So my question - does that sound like something close enough to what you 
are doing you most likely will (or just have in this commit) fix, or is 
it something I can work on without crossing your paths too much?

Mike

Erik Vos wrote:
> In 18EU, Undo did not revert all changes resulting from minor conversion
> actions.
> That has been fixed now.
> 
> Erik Vos
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 

Hi Mike,

I was not aware of this bug, but you are absolutely right:
orNumber is still an int whereas it should be an IntegerState.
I'm not really surprised, though; my testing was not exhaustive, 
and it may well be that more items have escaped undoability.

Please go ahead, I'm out of the way!

Erik.

> -----Original Message-----
> From: rai...@li... 
> [mailto:rai...@li...] On Behalf 
> Of Michal Bazynski
> Sent: Thursday 21 February 2008 10:49
> To: Dev...@sc...; 
> li...@sc...; 
> fo...@sc...; 
> "Ra...@sc...":an 18xx game
> Subject: Re: [Rails-devel] 18EU undo fix
> 
> 
> I meant to just try to research the problem and send the 
> patch, but the 
> changes below sound close enough I'll ask:
> 
> I believe there are some problems with undo and numbering of 
> operating 
> rounds - I think that if I am in OR 2 of 2 and I undo back 
> into OR 1/2, 
> the program will go to a stock round with the end of the first of 
> supposed two operating roudns, as if the Undo action didn't 
> decrease the 
> variable holding which operating round is happening.
> 
> So my question - does that sound like something close enough 
> to what you 
> are doing you most likely will (or just have in this commit) 
> fix, or is 
> it something I can work on without crossing your paths too much?
> 
> Mike
> 
> Erik Vos wrote:
> > In 18EU, Undo did not revert all changes resulting from 
> minor conversion
> > actions.
> > That has been fixed now.
> > 
> > Erik Vos
> > 
> > 
> > 
> --------------------------------------------------------------
> -----------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > 
> 
> 
> --------------------------------------------------------------
> -----------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 