From: Erik V. <eri...@hc...> - 2008-10-12 14:58:59
|
Having been made aware of some new (well, 5 months old) entries in the bugs list, I have gone through that list and made some fixes. Some bug reports I cannot reproduce and need further explanation or will be rejected. One or two are actually feature requests. 1945743 Blocked hex sides are not shown on the map. True, but this is a feature request, which I have created: 2161464, closing this bug report. It should be possible to draw thick lines over those hex sides, and IMO this should be done in a way that those lines also show on top of laid tiles (unlike in the real game). 1945754 Can't see where it shows who has the priority deal. Wasn't sure if this is actually a question or a feature request, decided to interpret it as both. - Answer to the question: On the Game status map ("PD" after the priority player name). - Request: it has been asked before to also show the PD player in the map window (FR 1518278). Then I rejected it, but as it was actually easy to implement, I have added it now (also to prevent future requests!). 1994548 1851 allows negative company treasury amounts. I cannot reproduce this problem. Please show how this can be reproduced (if still the case). 1945691 Can't buy trains across from other companies. I cannot reproduce this problem. Please show how this can be reproduced (if still the case). 1945678 1851 Company paying double for shares bought from the pool. I cannot reproduce this problem. Please show how this can be reproduced (if still the case). 1945675 1851 No multiple yellow track lays from phase 3. Confirmed. It has worked in the past, so some recent change must have broken it. As Mark Smith has volunteered to sort out this and other tile laying issues, I'll leave this one to him. Fixed one more functional bug: When a company has a train but no revenue (because no route), the allocation question (pay/split/withold) is still asked. This question is now suppressed if the revenue is $0. A few problems causing the game to abort have also been fixed. All fixes have been committed. Erik Vos |
From: Erik V. <eri...@hc...> - 2008-10-19 19:27:51
|
I have fixed a number of bugs, some of which have been reported my Mark. 1. Wrong home city for L&N in 1851. 2. No 2 yellow tiles allowed in 1851 from phase 3. Also relevant to 1835 (major companies, phase 2) and 1870 (all phases). It was caused by the introduction of a more complex XML structure for this feature with 18EU, which was not retrofitted to these other games. 3. My recent fix for the method calling loop was bad (it caused all privates having all special properties that exist in one game). 4. 1835 had a bug that did not allow this game even to start. On another problem reported by Mark: When attempting to step through the game, I started L&N and GM&O in OR 1, in SR 2 I sold GM&O so that it's stock value was below L&N, then in OR 2, L&N Ran first, after completing that run, GM&O was not given a chance to operate at all. I could not reproduce this behaviour. Mark, what exact sequence of actions led to this situation? (And are you sure you haven't misunderstood the appearance of the Status Window during the share trading step at the end of each company's OR turn, from OR2 on?) I'm also looking at implementing Mark's suggestion to mention the current phase in the UI. I think I'm going to add a new ModelObject subclass (e.g. GameStatusModel) into GameManager, to which the various windows can subscribe for getting info like current phase, current player, current round. That will bring the flow of such status information from engine to UI on the same basis as much of the other displayed items. Hopefully this will ease the future client/server split another bit. Erik Vos |
From: Mark S. <mar...@gm...> - 2008-10-19 21:50:24
|
On Sun, Oct 19, 2008 at 2:27 PM, Erik Vos <eri...@hc...> wrote: > I have fixed a number of bugs, some of which have been reported my Mark. > > 1. Wrong home city for L&N in 1851. > I was attempting to checkin the XML File to fix this issue, and ran across my XCode to CVS Checkin Issues. I have yet to resolve this, but this is fine. > > 2. No 2 yellow tiles allowed in 1851 from phase 3. Also relevant to 1835 > (major companies, phase 2) and 1870 (all phases). It was caused by the > introduction of a more complex XML structure for this feature with 18EU, > which was not retrofitted to these other games. Oh, so this was not an outright code failure, but something else... interesting. > > > 3. My recent fix for the method calling loop was bad (it caused all > privates > having all special properties that exist in one game). Whatever... > > > 4. 1835 had a bug that did not allow this game even to start. > > > On another problem reported by Mark: > > When attempting to step through the game, I started L&N and GM&O in > OR 1, in SR 2 I sold GM&O so that it's stock value was > below L&N, then in OR 2, L&N Ran first, after completing that run, > GM&O was not given a chance to operate at all. > > I could not reproduce this behaviour. Mark, what exact sequence of actions > led to this situation? (And are you sure you haven't misunderstood the > appearance of the Status Window during the share trading step at the end of > each company's OR turn, from OR2 on?) I admit I have not read the rules for 1851 in detail. If there is a special situation that while in the middle of an Operating Round, a Share Round is initiated for some special reason, then I withdraw my "bug". I am used to the "old-school" 18XX games (1829, 1830, 1835, 1853, 1856, 1870, 1837) where you stay in Operating Rounds until every company has operated. > > > > I'm also looking at implementing Mark's suggestion to mention the current > phase in the UI. I think I'm going to add a new ModelObject subclass (e.g. > GameStatusModel) into GameManager, to which the various windows can > subscribe for getting info like current phase, current player, current > round. That will bring the flow of such status information from engine to > UI > on the same basis as much of the other displayed items. Hopefully this will > ease the future client/server split another bit. > To go along with this thought, not only show the Phase, but may next to the new label "Phase X", have 1-4 hexes set with the color of available tiles (Yellow, Green, Brown/Russet, Gray) that are available in the Phase. Don't show any track just a solid hex filled with the color. Maybe for those that don't like to rely just on color include word or initials (Y, Gn, B, Gy) centered in the hex as well. > > Erik Vos > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
From: Erik V. <eri...@hc...> - 2008-10-20 19:54:00
|
When attempting to step through the game, I started L&N and GM&O in OR 1, in SR 2 I sold GM&O so that it's stock value was below L&N, then in OR 2, L&N Ran first, after completing that run, GM&O was not given a chance to operate at all. I could not reproduce this behaviour. Mark, what exact sequence of actions led to this situation? (And are you sure you haven't misunderstood the appearance of the Status Window during the share trading step at the end of each company's OR turn, from OR2 on?) I admit I have not read the rules for 1851 in detail. If there is a special situation that while in the middle of an Operating Round, a Share Round is initiated for some special reason, then I withdraw my "bug". I am used to the "old-school" 18XX games (1829, 1830, 1835, 1853, 1856, 1870, 1837) where you stay in Operating Rounds until every company has operated. It's not a Share Round, but a step at the end of each company's turn in the Operating Round where a company may buy or sell its *own* shares that it holds in its own Treasury. In such games (there are many games nowadays that have this feature) the unsold shares move from the Bank (IPO) to the company treasury when the compamny floats. In our current 18xx GUI share trading is done in the Status Window, so that is the window that pops up in that step. However, the title is changed such that it clearly (I hope) indicates that it is *not* a share round. Erik |
From: Mark S. <mar...@gm...> - 2008-11-09 02:03:48
|
Erik, Your Note: > 2. No 2 yellow tiles allowed in 1851 from phase 3. Also relevant to 1835 > (major companies, phase 2) and 1870 (all phases). It was caused by the > introduction of a more complex XML structure for this feature with 18EU, > which was not retrofitted to these other games. Implies that you fixed the bug report [1945675 1851 no multiple track lays] - If you can confirm this, and update the bug report, I can stop wondering if I should go and try and fix it. Thanks Mark |
From: Erik V. <eri...@hc...> - 2008-11-09 18:44:18
|
OK, I have recorded the fix in the bug report. Erik. > -----Original Message----- > From: Mark Smith [mailto:mar...@gm...] > Sent: Sunday 09 November 2008 03:04 > To: Development list for Rails: an 18xx game > Subject: Re: [Rails-devel] Bugs fixed > > Erik, > > Your Note: > > > 2. No 2 yellow tiles allowed in 1851 from phase 3. Also > relevant to 1835 > > (major companies, phase 2) and 1870 (all phases). It was > caused by the > > introduction of a more complex XML structure for this > feature with 18EU, > > which was not retrofitted to these other games. > > Implies that you fixed the bug report [1945675 1851 > no multiple > track lays] - If you can confirm this, and update the bug report, I > can stop wondering if I should go and try and fix it. > > Thanks > Mark > > -------------------------------------------------------------- > ----------- > This SF.Net email is sponsored by the Moblin Your Move > Developer's challenge > Build the coolest Linux based applications with Moblin SDK & > win great prizes > Grand prize is a trip for two to an Open Source event > anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
From: Mark S. <mar...@gm...> - 2008-11-09 20:35:54
|
Thanks Erik. On Sun, Nov 9, 2008 at 1:44 PM, Erik Vos <eri...@hc...> wrote: > OK, I have recorded the fix in the bug report. > Erik. > >> -----Original Message----- >> From: Mark Smith [mailto:mar...@gm...] >> Sent: Sunday 09 November 2008 03:04 >> To: Development list for Rails: an 18xx game >> Subject: Re: [Rails-devel] Bugs fixed >> >> Erik, >> >> Your Note: >> >> > 2. No 2 yellow tiles allowed in 1851 from phase 3. Also >> relevant to 1835 >> > (major companies, phase 2) and 1870 (all phases). It was >> caused by the >> > introduction of a more complex XML structure for this >> feature with 18EU, >> > which was not retrofitted to these other games. >> >> Implies that you fixed the bug report [1945675 1851 >> no multiple >> track lays] - If you can confirm this, and update the bug report, I >> can stop wondering if I should go and try and fix it. >> >> Thanks >> Mark >> >> -------------------------------------------------------------- >> ----------- >> This SF.Net email is sponsored by the Moblin Your Move >> Developer's challenge >> Build the coolest Linux based applications with Moblin SDK & >> win great prizes >> Grand prize is a trip for two to an Open Source event >> anywhere in the world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> _______________________________________________ >> Rails-devel mailing list >> Rai...@li... >> https://lists.sourceforge.net/lists/listinfo/rails-devel >> > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
From: Mark S. <mar...@gm...> - 2008-10-12 16:45:06
|
Erik, I just went in to replicate the Tile Laying bug in Phase 3 of 1851, and stumbled across a few other issues: 1. In the Map Display, Cincinati at the top of the board is cut off. I think the whole position for 1851 is set too high in the Map Frame 2. The L&N Starting Home Location in B16 should be the Northern City, not the Southern City (based upon the board photo at: http://boardgamegeek.com/image/126915?size=large.This can be fixed by updating the CompanyManager.xml File under data/1851, line 38 (for the L&N Public Company) to be <Home hex=B16", city="1"> 3. When attempting to step through the game, I started L&N and GM&O in OR 1, in SR 2 I sold GM&O so that it's stock value was below L&N, then in OR 2, L&N Ran first, after completing that run, GM&O was not given a chance to operate at all. On Sun, Oct 12, 2008 at 9:58 AM, Erik Vos <eri...@hc...> wrote: > Having been made aware of some new (well, 5 months old) entries in the bugs > list, I have gone through that list and made some fixes. Some bug reports I > cannot reproduce and need further explanation or will be rejected. One or > two are actually feature requests. > > 1945743 Blocked hex sides are not shown on the map. > True, but this is a feature request, which I have created: 2161464, closing > this bug report. > It should be possible to draw thick lines over those hex sides, and IMO > this > should be done in a way that those lines also show on top of laid tiles > (unlike in the real game). > > 1945754 Can't see where it shows who has the priority deal. > Wasn't sure if this is actually a question or a feature request, decided to > interpret it as both. > - Answer to the question: On the Game status map ("PD" after the priority > player name). > - Request: it has been asked before to also show the PD player in the map > window (FR 1518278). Then I rejected it, but as it was actually easy to > implement, I have added it now (also to prevent future requests!). > > 1994548 1851 allows negative company treasury amounts. > I cannot reproduce this problem. Please show how this can be reproduced (if > still the case). > > 1945691 Can't buy trains across from other companies. > I cannot reproduce this problem. Please show how this can be reproduced (if > still the case). > > 1945678 1851 Company paying double for shares bought from the pool. > I cannot reproduce this problem. Please show how this can be reproduced (if > still the case). > > 1945675 1851 No multiple yellow track lays from phase 3. > Confirmed. It has worked in the past, so some recent change must have > broken > it. > As Mark Smith has volunteered to sort out this and other tile laying > issues, > I'll leave this one to him. > > Fixed one more functional bug: > > When a company has a train but no revenue (because no route), the > allocation > question (pay/split/withold) is still asked. This question is now > suppressed > if the revenue is $0. > > A few problems causing the game to abort have also been fixed. > All fixes have been committed. > > Erik Vos > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
From: Erik V. <eri...@hc...> - 2008-10-12 19:17:21
|
Comments see below. 1. In the Map Display, Cincinati at the top of the board is cut off. I think the whole position for 1851 is set too high in the Map Frame Correct. The problem is, that in the game as published the "A" row is the row below Cincinnati. So I have given the Cincinnati hex the name "@18" as @ is the ASCII character below A. This works well, except that the map placement code is not aware of this exception. The best solution is, perhaps, to have the code create the map position and window size based on the actual lowest and highest row and column values. This is done in EWHexMap (and NSHexMap for the other hex orientation). The map placement in its panel needs be refined anyway. 2. The L&N Starting Home Location in B16 should be the Northern City, not the Southern City (based upon the board photo at: http://boardgamegeek.com/image/126915?size=large.This can be fixed by updating the CompanyManager.xml File under data/1851, line 38 (for the L&N Public Company) to be <Home hex=B16", city="1"> Correct. 3. When attempting to step through the game, I started L&N and GM&O in OR 1, in SR 2 I sold GM&O so that it's stock value was below L&N, then in OR 2, L&N Ran first, after completing that run, GM&O was not given a chance to operate at all. Hmm, that is serious. I'll look at it later this week (if you haven't fixed it before, of course...). Erik. |
From: Mark S. <mar...@gm...> - 2008-10-12 19:45:05
|
Erik, If you haven't seen what I sent to Brett, and posted, it might be worth you taking a look. I had started building up and 18XX Engine with the primary (initial) focus on the map and tiles. The application is not a complete implementation, but I feel it shows a much better Map and Tiles. It does allow the map to be scaled up or down via a slider. All of the information on the Map is drawn by the code, the cities, towns, track segments, blocked hexsides, river graphics, mountain graphics, port symbols, etc. I do have the desire to see about incorporating my code base in with the Rails Code Base over time. But I need to work out a plan to do so. Mark On Sun, Oct 12, 2008 at 2:17 PM, Erik Vos <eri...@hc...> wrote: > Comments see below. > > 1. In the Map Display, Cincinati at the top of the board is cut off. I > think the whole position for 1851 is set too high in the Map Frame > > Correct. The problem is, that in the game as published the "A" row is the > row *below* Cincinnati. So I have given the Cincinnati hex the name "@18" > as @ is the ASCII character below A. This works well, except that the map > placement code is not aware of this exception. > The best solution is, perhaps, to have the code create the map position and > window size based on the actual lowest and highest row and column values. > This is done in EWHexMap (and NSHexMap for the other hex orientation). The > map placement in its panel needs be refined anyway. > > 2. The L&N Starting Home Location in B16 should be the Northern City, not > the Southern City (based upon the board photo at: > http://boardgamegeek.com/image/126915?size=large.This can be fixed by > updating the CompanyManager.xml File under data/1851, line 38 (for the L&N > Public Company) to be <Home hex=B16", city="1"> > > Correct. > > 3. When attempting to step through the game, I started L&N and GM&O in OR > 1, in SR 2 I sold GM&O so that it's stock value was below L&N, then in OR 2, > L&N Ran first, after completing that run, GM&O was not given a chance to > operate at all. > > Hmm, that is serious. I'll look at it later this week (if you haven't fixed > it before, of course...). > Erik. > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > > |
From: brett l. <wak...@gm...> - 2008-10-12 20:05:59
|
> On Sun, Oct 12, 2008 at 2:17 PM, Erik Vos <eri...@hc...> wrote: >> >> Comments see below. >> >> 1. In the Map Display, Cincinati at the top of the board is cut off. I >> think the whole position for 1851 is set too high in the Map Frame >> >> Correct. The problem is, that in the game as published the "A" row is the >> row below Cincinnati. So I have given the Cincinnati hex the name "@18" as @ >> is the ASCII character below A. This works well, except that the map >> placement code is not aware of this exception. >> The best solution is, perhaps, to have the code create the map position >> and window size based on the actual lowest and highest row and column >> values. This is done in EWHexMap (and NSHexMap for the other hex >> orientation). The map placement in its panel needs be refined anyway. >> >> 2. The L&N Starting Home Location in B16 should be the Northern City, not >> the Southern City (based upon the board photo at: >> http://boardgamegeek.com/image/126915?size=large.This can be fixed by >> updating the CompanyManager.xml File under data/1851, line 38 (for the L&N >> Public Company) to be <Home hex=B16", city="1"> >> >> Correct. >> >> 3. When attempting to step through the game, I started L&N and GM&O in OR >> 1, in SR 2 I sold GM&O so that it's stock value was below L&N, then in OR 2, >> L&N Ran first, after completing that run, GM&O was not given a chance to >> operate at all. >> >> Hmm, that is serious. I'll look at it later this week (if you haven't >> fixed it before, of course...). >> Erik. > > > Erik, > > If you haven't seen what I sent to Brett, and posted, it might be worth you > taking a look. I had started building up and 18XX Engine with the primary > (initial) focus on the map and tiles. The application is not a complete > implementation, but I feel it shows a much better Map and Tiles. It does > allow the map to be scaled up or down via a slider. All of the information > on the Map is drawn by the code, the cities, towns, track segments, blocked > hexsides, river graphics, mountain graphics, port symbols, etc. I do have > the desire to see about incorporating my code base in with the Rails Code > Base over time. But I need to work out a plan to do so. > > Mark > Just to repost the link, here's Mark's engine: http://rails.sourceforge.net/18XX_Engine.Sept_2008.zip ---Brett |
From: Mark S. <mar...@gm...> - 2008-10-12 20:08:17
|
OH, and I have at least replicated the Phase 3+ problem of only one tile lay allowed. Which brings up another point about the UI... The Map Display should indicate, maybe in the Title Bar, what is the current Phase. This helps to players familiar with the board games who know about Phases, and are reading the rule-books, know which Phase the game think's it is within. Looking at the the mutli-tile lay per turn, but only from Phase 3 forward, it might make sense to include in the Phase Description a count of the number of tiles that can be placed. 1851, Phase 3 and later 2. 1870 can always lay 2 yellow tiles, or upgrade one already placed. Etc. Mark On Sun, Oct 12, 2008 at 2:44 PM, Mark Smith <mar...@gm...> wrote: > Erik, > > If you haven't seen what I sent to Brett, and posted, it might be worth you > taking a look. I had started building up and 18XX Engine with the primary > (initial) focus on the map and tiles. The application is not a complete > implementation, but I feel it shows a much better Map and Tiles. It does > allow the map to be scaled up or down via a slider. All of the information > on the Map is drawn by the code, the cities, towns, track segments, blocked > hexsides, river graphics, mountain graphics, port symbols, etc. I do have > the desire to see about incorporating my code base in with the Rails Code > Base over time. But I need to work out a plan to do so. > > Mark > > On Sun, Oct 12, 2008 at 2:17 PM, Erik Vos <eri...@hc...> wrote: > >> Comments see below. >> >> 1. In the Map Display, Cincinati at the top of the board is cut off. I >> think the whole position for 1851 is set too high in the Map Frame >> >> Correct. The problem is, that in the game as published the "A" row is the >> row *below* Cincinnati. So I have given the Cincinnati hex the name "@18" >> as @ is the ASCII character below A. This works well, except that the map >> placement code is not aware of this exception. >> The best solution is, perhaps, to have the code create the map position >> and window size based on the actual lowest and highest row and column >> values. This is done in EWHexMap (and NSHexMap for the other hex >> orientation). The map placement in its panel needs be refined anyway. >> >> 2. The L&N Starting Home Location in B16 should be the Northern City, not >> the Southern City (based upon the board photo at: >> http://boardgamegeek.com/image/126915?size=large.This can be fixed by >> updating the CompanyManager.xml File under data/1851, line 38 (for the L&N >> Public Company) to be <Home hex=B16", city="1"> >> >> Correct. >> >> 3. When attempting to step through the game, I started L&N and GM&O in OR >> 1, in SR 2 I sold GM&O so that it's stock value was below L&N, then in OR 2, >> L&N Ran first, after completing that run, GM&O was not given a chance to >> operate at all. >> >> Hmm, that is serious. I'll look at it later this week (if you haven't >> fixed it before, of course...). >> Erik. >> >> ------------------------------------------------------------------------- >> This SF.Net email is sponsored by the Moblin Your Move Developer's >> challenge >> Build the coolest Linux based applications with Moblin SDK & win great >> prizes >> Grand prize is a trip for two to an Open Source event anywhere in the >> world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> _______________________________________________ >> Rails-devel mailing list >> Rai...@li... >> https://lists.sourceforge.net/lists/listinfo/rails-devel >> >> > |
From: Erik V. <eri...@hc...> - 2008-10-12 20:37:39
|
OH, and I have at least replicated the Phase 3+ problem of only one tile lay allowed. Which brings up another point about the UI... The Map Display should indicate, maybe in the Title Bar, what is the current Phase. This helps to players familiar with the board games who know about Phases, and are reading the rule-books, know which Phase the game think's it is within. Good point. Looking at the the mutli-tile lay per turn, but only from Phase 3 forward, it might make sense to include in the Phase Description a count of the number of tiles that can be placed. 1851, Phase 3 and later 2. 1870 can always lay 2 yellow tiles, or upgrade one already placed. Etc. It's configured in CompanyManager.xml, because in games with minor and major companies the number of tile lays may be different between these types. For instance, in 18EU only minor companies may lay two yellow tiles, and only in their first turn. It's already defined for 1851, is just has stopped working... If you haven't seen what I sent to Brett, and posted, it might be worth you taking a look. I had started building up and 18XX Engine with the primary (initial) focus on the map and tiles. The application is not a complete implementation, but I feel it shows a much better Map and Tiles. It does allow the map to be scaled up or down via a slider. All of the information on the Map is drawn by the code, the cities, towns, track segments, blocked hexsides, river graphics, mountain graphics, port symbols, etc. I do have the desire to see about incorporating my code base in with the Rails Code Base over time. But I need to work out a plan to do so. Yes. I have seen it. It looks good, although I would prefer the usual pale green background over a yellowish one, and I would have a few more quibbles. As map and tile drawing is done in the few classes of rails.ui.swing.hexmap, replacement shouldn't be too hard (personally I would prefer a choice of styles, but that no doubt would make it harder). For the additional info that you display, some extensions would be needed to Map.xml and the MapHex model objects. Erik. |