rails-devel

[Rails-devel] Bug report in 1835 (Clemens) - Game incorrectly identifying a company director.

[Mike B. <com...@ip...>]

Hi Guys,

Here's another bug to be investigated:

The game is 1835, Clemens option. During stock round 10, player m3 attempted
to sell shares in He (player m4 is the president). The option offered when
attempting to sell shares was "Sell 1 10% certificates(s) (10%) of HE for
100M, swapping president for 2 10% certificates." In other words, the game
is misidentifying the 20% He certificate owned by player 3 as the
President's share.

Save Game: 1835_20120508_1321_m3.rails

Bug initially discovered in version 1.7.2, confirmed as persisting in
version 1.7.3.

Mike Bourke
Campaign Mastery http://www.campaignmastery.com
Co-author, Assassin's Amulet http://www.legaciescampaignsetting.com




---
avast! Antivirus: Outbound message clean.
Virus Database (VPS): 120507-1, 08/05/2012
Tested on: 8/05/2012 11:26:45 PM
avast! - copyright (c) 1988-2012 AVAST Software.
http://www.avast.com

Re: [Rails-devel] Bug report in 1835 (Clemens) - Game incorrectly identifying a company director.

[Erik V. <eri...@xs...>]

Mike, the attachment is missing.
Erik.

> -----Original Message-----
> From: Mike Bourke [mailto:com...@ip...]
> Sent: Tuesday, May 08, 2012 3:27 PM
> To: Development list for Rails: an 18xx game
> Subject: [Rails-devel] Bug report in 1835 (Clemens) - Game incorrectly
> identifying a company director.
> 
> Hi Guys,
> 
> Here's another bug to be investigated:
> 
> The game is 1835, Clemens option. During stock round 10, player m3
> attempted to sell shares in He (player m4 is the president). The option
> offered when attempting to sell shares was "Sell 1 10% certificates(s)
(10%)
> of HE for 100M, swapping president for 2 10% certificates." In other
words,
> the game is misidentifying the 20% He certificate owned by player 3 as the
> President's share.
> 
> Save Game: 1835_20120508_1321_m3.rails
> 
> Bug initially discovered in version 1.7.2, confirmed as persisting in
version
> 1.7.3.
> 
> Mike Bourke
> Campaign Mastery http://www.campaignmastery.com Co-author, Assassin's
> Amulet http://www.legaciescampaignsetting.com
> 
> 
> 
> 
> ---
> avast! Antivirus: Outbound message clean.
> Virus Database (VPS): 120507-1, 08/05/2012 Tested on: 8/05/2012 11:26:45
> PM avast! - copyright (c) 1988-2012 AVAST Software.
> http://www.avast.com
> 
> 
> 
> 
>
----------------------------------------------------------------------------
--
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and threat
> landscape has changed and how IT managers can respond. Discussions will
> include endpoint security, mobile security and the latest in malware
threats.
> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Bug report in 1835 (Clemens) - Gameincorrectly identifying a company director.

[Mike B. <com...@ip...>]

Sorry - here it is!

Mike Bourke
Campaign Mastery http://www.campaignmastery.com
Co-author, Assassin's Amulet http://www.legaciescampaignsetting.com

-----Original Message-----
From: Erik Vos [mailto:eri...@xs...] 
Sent: Tuesday, 8 May 2012 11:46 PM
To: 'Development list for Rails: an 18xx game'
Subject: Re: [Rails-devel] Bug report in 1835 (Clemens) - Gameincorrectly
identifying a company director.

Mike, the attachment is missing.
Erik.

> -----Original Message-----
> From: Mike Bourke [mailto:com...@ip...]
> Sent: Tuesday, May 08, 2012 3:27 PM
> To: Development list for Rails: an 18xx game
> Subject: [Rails-devel] Bug report in 1835 (Clemens) - Game incorrectly
> identifying a company director.
> 
> Hi Guys,
> 
> Here's another bug to be investigated:
> 
> The game is 1835, Clemens option. During stock round 10, player m3
> attempted to sell shares in He (player m4 is the president). The option
> offered when attempting to sell shares was "Sell 1 10% certificates(s)
(10%)
> of HE for 100M, swapping president for 2 10% certificates." In other
words,
> the game is misidentifying the 20% He certificate owned by player 3 as the
> President's share.
> 
> Save Game: 1835_20120508_1321_m3.rails
> 
> Bug initially discovered in version 1.7.2, confirmed as persisting in
version
> 1.7.3.
> 
> Mike Bourke
> Campaign Mastery http://www.campaignmastery.com Co-author, Assassin's
> Amulet http://www.legaciescampaignsetting.com
> 
> 
> 
> 
> ---
> avast! Antivirus: Outbound message clean.
> Virus Database (VPS): 120507-1, 08/05/2012 Tested on: 8/05/2012 11:26:45
> PM avast! - copyright (c) 1988-2012 AVAST Software.
> http://www.avast.com
> 
> 
> 
> 
>
----------------------------------------------------------------------------
--
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and threat
> landscape has changed and how IT managers can respond. Discussions will
> include endpoint security, mobile security and the latest in malware
threats.
> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel


----------------------------------------------------------------------------
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Bug report in 1835 (Clemens) - Gameincorrectly identifying a company director.

[Erik V. <eri...@xs...>]

This was a classical programmer's error: a variable controlling this aspect
was reset in the wrong place in the loop over companies:  it was set for BA
and not reset for HE.
I have pushed a fix to master.

I suppose this is a pretty rare case.  Saved games where such wrong actions
have been chosen will not reload after this fix.

Erik.



> -----Original Message-----
> From: Mike Bourke [mailto:com...@ip...]
> Sent: Tuesday, May 08, 2012 5:46 PM
> To: 'Development list for Rails: an 18xx game'
> Subject: Re: [Rails-devel] Bug report in 1835 (Clemens) - Gameincorrectly
> identifying a company director.
> 
> Sorry - here it is!
> 
> Mike Bourke
> Campaign Mastery http://www.campaignmastery.com Co-author, Assassin's
> Amulet http://www.legaciescampaignsetting.com
> 
> -----Original Message-----
> From: Erik Vos [mailto:eri...@xs...]
> Sent: Tuesday, 8 May 2012 11:46 PM
> To: 'Development list for Rails: an 18xx game'
> Subject: Re: [Rails-devel] Bug report in 1835 (Clemens) - Gameincorrectly
> identifying a company director.
> 
> Mike, the attachment is missing.
> Erik.
> 
> > -----Original Message-----
> > From: Mike Bourke [mailto:com...@ip...]
> > Sent: Tuesday, May 08, 2012 3:27 PM
> > To: Development list for Rails: an 18xx game
> > Subject: [Rails-devel] Bug report in 1835 (Clemens) - Game incorrectly
> > identifying a company director.
> >
> > Hi Guys,
> >
> > Here's another bug to be investigated:
> >
> > The game is 1835, Clemens option. During stock round 10, player m3
> > attempted to sell shares in He (player m4 is the president). The
> > option offered when attempting to sell shares was "Sell 1 10%
> > certificates(s)
> (10%)
> > of HE for 100M, swapping president for 2 10% certificates." In other
> words,
> > the game is misidentifying the 20% He certificate owned by player 3 as
> > the President's share.
> >
> > Save Game: 1835_20120508_1321_m3.rails
> >
> > Bug initially discovered in version 1.7.2, confirmed as persisting in
> version
> > 1.7.3.
> >
> > Mike Bourke
> > Campaign Mastery http://www.campaignmastery.com Co-author,
> Assassin's
> > Amulet http://www.legaciescampaignsetting.com
> >
> >
> >
> >
> > ---
> > avast! Antivirus: Outbound message clean.
> > Virus Database (VPS): 120507-1, 08/05/2012 Tested on: 8/05/2012
> > 11:26:45 PM avast! - copyright (c) 1988-2012 AVAST Software.
> > http://www.avast.com
> >
> >
> >
> >
> >
>
----------------------------------------------------------------------------
> --
> > Live Security Virtual Conference
> > Exclusive live event will cover all the ways today's security and
> > threat landscape has changed and how IT managers can respond.
> > Discussions will include endpoint security, mobile security and the
> > latest in malware
> threats.
> > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> 
>
----------------------------------------------------------------------------
> --
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and threat
> landscape has changed and how IT managers can respond. Discussions will
> include endpoint security, mobile security and the latest in malware
threats.
> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Bug report in 1835 (Clemens)- Gameincorrectly identifying a company director.

[Mike B. <com...@ip...>]

Given the number of variables required to reach the point where this takes
place, I would expect it to be a very rare event (otherwise it would have
been noticed and fixed before now!). Nevertheless, a warning to people that
old 1835 saved games might not load properly might be worth noting with the
release which has the code corrected - people might want to hold off on
updating until their game is finished, just in case. I'm not sure whether
this would impact 1835 games that have an option other than Clemens selected
or not.

Mike Bourke
Campaign Mastery http://www.campaignmastery.com
Co-author, Assassin's Amulet http://www.legaciescampaignsetting.com

-----Original Message-----
From: Erik Vos [mailto:eri...@xs...] 
Sent: Wednesday, 9 May 2012 5:30 AM
To: 'Development list for Rails: an 18xx game'
Subject: Re: [Rails-devel] Bug report in 1835 (Clemens)- Gameincorrectly
identifying a company director.

This was a classical programmer's error: a variable controlling this aspect
was reset in the wrong place in the loop over companies:  it was set for BA
and not reset for HE.
I have pushed a fix to master.

I suppose this is a pretty rare case.  Saved games where such wrong actions
have been chosen will not reload after this fix.

Erik.



---
avast! Antivirus: Outbound message clean.
Virus Database (VPS): 120507-1, 08/05/2012
Tested on: 9/05/2012 5:38:15 AM
avast! - copyright (c) 1988-2012 AVAST Software.
http://www.avast.com

Re: [Rails-devel] Bug report in 1835 (Clemens)- Gameincorrectly identifying a company director.

[Erik V. <eri...@xs...>]

This problem is not related to the chosen variant.

> -----Original Message-----
> From: Mike Bourke [mailto:com...@ip...]
> Sent: Tuesday, May 08, 2012 9:38 PM
> To: 'Development list for Rails: an 18xx game'
> Subject: Re: [Rails-devel] Bug report in 1835 (Clemens)- Gameincorrectly
> identifying a company director.
> 
> Given the number of variables required to reach the point where this takes
> place, I would expect it to be a very rare event (otherwise it would have
> been noticed and fixed before now!). Nevertheless, a warning to people
> that old 1835 saved games might not load properly might be worth noting
> with the release which has the code corrected - people might want to hold
> off on updating until their game is finished, just in case. I'm not sure
whether
> this would impact 1835 games that have an option other than Clemens
> selected or not.
> 
> Mike Bourke
> Campaign Mastery http://www.campaignmastery.com Co-author, Assassin's
> Amulet http://www.legaciescampaignsetting.com
> 
> -----Original Message-----
> From: Erik Vos [mailto:eri...@xs...]
> Sent: Wednesday, 9 May 2012 5:30 AM
> To: 'Development list for Rails: an 18xx game'
> Subject: Re: [Rails-devel] Bug report in 1835 (Clemens)- Gameincorrectly
> identifying a company director.
> 
> This was a classical programmer's error: a variable controlling this
aspect was
> reset in the wrong place in the loop over companies:  it was set for BA
and
> not reset for HE.
> I have pushed a fix to master.
> 
> I suppose this is a pretty rare case.  Saved games where such wrong
actions
> have been chosen will not reload after this fix.
> 
> Erik.
> 
> 
> 
> ---
> avast! Antivirus: Outbound message clean.
> Virus Database (VPS): 120507-1, 08/05/2012 Tested on: 9/05/2012 5:38:15 AM
> avast! - copyright (c) 1988-2012 AVAST Software.
> http://www.avast.com
> 
> 
> 
> 
>
----------------------------------------------------------------------------
--
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and threat
> landscape has changed and how IT managers can respond. Discussions will
> include endpoint security, mobile security and the latest in malware
threats.
> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel