rails-devel

[Rails-devel] Nonmodal popups

[Erik V. <eri...@xs...>]

I have pushed a change to disable all buttons (in the current window) as
long as a non-modal popup request has not been answered.
Two questions remain, on which I'm in doubt:
1. Should (most) menu items also be disabled?
2. Should we make an exception to message-only popups?  I currently do.

Erik.

Re: [Rails-devel] Nonmodal popups

[Chris S. <chr...@gm...>]

Are there times when the respondent might want to view other windows before
answering?  I can imagine being frustrated if the popup says "do you want
to convert this share?" and my answer is dependent on needing to use the
menu to see the stock market, for example.

--
Chris

Please consider the environment before printing this e-mail.


On Thu, Jan 12, 2012 at 7:39 AM, Erik Vos <eri...@xs...> wrote:

> I have pushed a change to disable all buttons (in the current window) as
> long as a non-modal popup request has not been answered.
> Two questions remain, on which I'm in doubt:
> 1. Should (most) menu items also be disabled?
> 2. Should we make an exception to message-only popups?  I currently do.
>
> Erik.
>
>
>
> ------------------------------------------------------------------------------
> RSA(R) Conference 2012
> Mar 27 - Feb 2
> Save $400 by Jan. 27
> Register now!
> http://p.sf.net/sfu/rsa-sfdev2dev2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Nonmodal popups

[Erik V. <eri...@xs...>]

Yes, that's the whole point of making popups non-modal.  Several ones
already are.

Erik.

 

From: Chris Shaffer [mailto:chr...@gm...] 
Sent: Thursday, January 12, 2012 4:54 PM
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] Nonmodal popups

 

Are there times when the respondent might want to view other windows before
answering?  I can imagine being frustrated if the popup says "do you want to
convert this share?" and my answer is dependent on needing to use the menu
to see the stock market, for example.


 

--
Chris

Please consider the environment before printing this e-mail.



On Thu, Jan 12, 2012 at 7:39 AM, Erik Vos <eri...@xs...> wrote:

I have pushed a change to disable all buttons (in the current window) as
long as a non-modal popup request has not been answered.
Two questions remain, on which I'm in doubt:
1. Should (most) menu items also be disabled?
2. Should we make an exception to message-only popups?  I currently do.

Erik.


----------------------------------------------------------------------------
--
RSA(R) Conference 2012
Mar 27 - Feb 2
Save $400 by Jan. 27
Register now!
http://p.sf.net/sfu/rsa-sfdev2dev2
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

 

Re: [Rails-devel] Nonmodal popups

[Chris S. <chr...@gm...>]

Right, but you asked if the menu items should be disabled, and one of them
is "let me see that other window" which should not be disabled.

Does that make sense?

--
Chris

Please consider the environment before printing this e-mail.


On Thu, Jan 12, 2012 at 9:52 AM, Erik Vos <eri...@xs...> wrote:

> Yes, that’s the whole point of making popups non-modal.  Several ones
> already are.****
>
> Erik.****
>
> ** **
>
> *From:* Chris Shaffer [mailto:chr...@gm...]
> *Sent:* Thursday, January 12, 2012 4:54 PM
> *To:* Development list for Rails: an 18xx game
> *Subject:* Re: [Rails-devel] Nonmodal popups****
>
> ** **
>
> Are there times when the respondent might want to view other windows
> before answering?  I can imagine being frustrated if the popup says "do you
> want to convert this share?" and my answer is dependent on needing to use
> the menu to see the stock market, for example.
> ****
>
> ** **
>
> --
> Chris
>
> Please consider the environment before printing this e-mail.
>
> ****
>
> On Thu, Jan 12, 2012 at 7:39 AM, Erik Vos <eri...@xs...> wrote:****
>
> I have pushed a change to disable all buttons (in the current window) as
> long as a non-modal popup request has not been answered.
> Two questions remain, on which I'm in doubt:
> 1. Should (most) menu items also be disabled?
> 2. Should we make an exception to message-only popups?  I currently do.
>
> Erik.
>
>
>
> ------------------------------------------------------------------------------
> RSA(R) Conference 2012
> Mar 27 - Feb 2
> Save $400 by Jan. 27
> Register now!
> http://p.sf.net/sfu/rsa-sfdev2dev2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel****
>
> ** **
>
>
> ------------------------------------------------------------------------------
> RSA(R) Conference 2012
> Mar 27 - Feb 2
> Save $400 by Jan. 27
> Register now!
> http://p.sf.net/sfu/rsa-sfdev2dev2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>

Re: [Rails-devel] Nonmodal popups

[Stefan F. <ste...@we...>]

Erik:

To answer your questions:
1. would only de-activate those menu-items which are corresponds to Rails 
actions. All others should be still active. 

2. message pop-ups should never be modal (or quasi-modal, as you are currently 
implementing), most likely they could be replaced by displaying it in the 
info/status panel (adding an info panel in the stock window would allow that).

Some other remarks:

* Most likely it makes sense to merge your commit  
with the code that deactivates the windows when the game history is used, 
which tries to achieve a similar effect.

* More general:
I think there in principle there is no general difference between the non-
model popup requests and any other situation: Only those buttons and menu-
items should be active that are either available generally (like save/load, 
zoom, show/hide windows) or are allowed actions at that time.

Currently there are some other cases when buttons are still active, which do 
not contain active commands, that generate error messages if pressed.

The ideal solution would be if the UI would be able to figure out what to 
activate and deactivate given the current set of actions 
and maybe a few flags. 

I know that the current UI already tries to achieve that already, but there
are some bits still missing.

Stefan


On Thursday, January 12, 2012 04:39:58 pm Erik Vos wrote:
> I have pushed a change to disable all buttons (in the current window) as
> long as a non-modal popup request has not been answered.
> Two questions remain, on which I'm in doubt:
> 1. Should (most) menu items also be disabled?
> 2. Should we make an exception to message-only popups?  I currently do.
> 
> Erik.
> 
> 
> ---------------------------------------------------------------------------
> --- RSA(R) Conference 2012
> Mar 27 - Feb 2
> Save $400 by Jan. 27
> Register now!
> http://p.sf.net/sfu/rsa-sfdev2dev2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Nonmodal popups

[Erik V. <eri...@xs...>]

> To answer your questions:
> 1. would only de-activate those menu-items which are corresponds to Rails
> actions. All others should be still active.

Agreed.

> 2. message pop-ups should never be modal (or quasi-modal, as you are
> currently implementing), most likely they could be replaced by displaying
it in
> the info/status panel (adding an info panel in the stock window would
allow
> that).

That doesn't work in all cases: some messages are pretty long, such as those
that report the CGR formation details.
Another idea could be a permanent message window.

> Some other remarks:
> 
> * Most likely it makes sense to merge your commit with the code that
> deactivates the windows when the game history is used, which tries to
> achieve a similar effect.

I'll look at that.  I'll probably first refactor dialog handling itself,
which is now spread over various UI classes in a not very logical way.  In
any case we need a dialog type enum.