rails-devel

[Rails-devel] Refactored loading code

[Stefan F. <ste...@we...>]

Brett & Erik,
some time ago I started to refactor the game loading code in one class to get 
the ListAndFixSavedFiles utility adjusted to the new comments.

To avoid more incompatibilities from the started refactoring from Brett now I 
thought to adjust the code to include the new reload functionality of Erik to 
be able to commit those changes.

Nearly all loading functionality has been moved to a new GameLoader class in 
rails.util package. The load function in Game, GameManager and 
ListAndFixSavedFiles now all make use of a a GameLoader object.

I have also added a line to the reload error message that asks the user to 
submit the corrupt save file to the Rails user list for bug tracking. If you 
think that is not a good idea, simply remove that text from 
LocalisedProperties.

Stefan

Re: [Rails-devel] Refactored loading code

[brett l. <bre...@gm...>]

That looks good to me.

My overall goal with my refactoring is to remove the need for the
rails.game package to know about lower-level details, such as XML
parsing.

Moving the classes that need to know about how to load/save game files
outside of rails.game.* aligns very well with this goal. :-)

---Brett.



On Tue, Jul 5, 2011 at 10:11 AM, Stefan Frey <ste...@we...> wrote:
> Brett & Erik,
> some time ago I started to refactor the game loading code in one class to get
> the ListAndFixSavedFiles utility adjusted to the new comments.
>
> To avoid more incompatibilities from the started refactoring from Brett now I
> thought to adjust the code to include the new reload functionality of Erik to
> be able to commit those changes.
>
> Nearly all loading functionality has been moved to a new GameLoader class in
> rails.util package. The load function in Game, GameManager and
> ListAndFixSavedFiles now all make use of a a GameLoader object.
>
> I have also added a line to the reload error message that asks the user to
> submit the corrupt save file to the Rails user list for bug tracking. If you
> think that is not a good idea, simply remove that text from
> LocalisedProperties.
>
> Stefan
>

Re: [Rails-devel] Refactored loading code

[Erik V. <eri...@xs...>]

Ah, good stuff.  I was already occasionally running into problems with
loading files into ListAndFixSavedFiles.

As you may or may not have noticed, since some time I'm pretty meticulously
creating entries in the Wiki Change Log for all my commits (except very
trivial ones).  I don't know if I can expect the same from Brett and you (as
we have seen earlier today, I'm not really the right person to request
discipline). In any case, I have just created simple entries for the recent
commits 1602-1604 by the two of you.  Feel free to  correct or expand.

As for packaging, I would prefer to reserve rails.util for Rails classes
only, and put all external main programs into tools.  That would mean that
ListAndFixSavedFiles should move from rails.util to tools. Any objections?  

I just noticed that we have TWO Util classes, one in rails.util and one in
tools.  Does anyone know a good reason for that duplication?  Otherwise I
would propose to merge the two into rails.util.Util.

Erik.

> -----Oorspronkelijk bericht-----
> Van: Stefan Frey [mailto:ste...@we...]
> Verzonden: dinsdag 5 juli 2011 19:11
> Aan: 'Development list for Rails: an 18xx game'
> Onderwerp: [Rails-devel] Refactored loading code
> 
> Brett & Erik,
> some time ago I started to refactor the game loading code in one class to
get
> the ListAndFixSavedFiles utility adjusted to the new comments.
> 
> To avoid more incompatibilities from the started refactoring from Brett
now I
> thought to adjust the code to include the new reload functionality of Erik
to
> be able to commit those changes.
> 
> Nearly all loading functionality has been moved to a new GameLoader class
in
> rails.util package. The load function in Game, GameManager and
> ListAndFixSavedFiles now all make use of a a GameLoader object.
> 
> I have also added a line to the reload error message that asks the user to
> submit the corrupt save file to the Rails user list for bug tracking. If
you think
> that is not a good idea, simply remove that text from LocalisedProperties.
> 
> Stefan
> 
>
----------------------------------------------------------------------------
--
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security
> threats, fraudulent activity, and more. Splunk takes this data and makes
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Refactored loading code

[brett l. <bre...@gm...>]

I was actually thinking something similar this weekend...

No objections here. :-)

---Brett.


On Tue, Jul 5, 2011 at 10:49 AM, Erik Vos <eri...@xs...> wrote:
> Ah, good stuff.  I was already occasionally running into problems with
> loading files into ListAndFixSavedFiles.
>
> As you may or may not have noticed, since some time I'm pretty meticulously
> creating entries in the Wiki Change Log for all my commits (except very
> trivial ones).  I don't know if I can expect the same from Brett and you (as
> we have seen earlier today, I'm not really the right person to request
> discipline). In any case, I have just created simple entries for the recent
> commits 1602-1604 by the two of you.  Feel free to  correct or expand.
>
> As for packaging, I would prefer to reserve rails.util for Rails classes
> only, and put all external main programs into tools.  That would mean that
> ListAndFixSavedFiles should move from rails.util to tools. Any objections?
>
> I just noticed that we have TWO Util classes, one in rails.util and one in
> tools.  Does anyone know a good reason for that duplication?  Otherwise I
> would propose to merge the two into rails.util.Util.
>
> Erik.
>
>> -----Oorspronkelijk bericht-----
>> Van: Stefan Frey [mailto:ste...@we...]
>> Verzonden: dinsdag 5 juli 2011 19:11
>> Aan: 'Development list for Rails: an 18xx game'
>> Onderwerp: [Rails-devel] Refactored loading code
>>
>> Brett & Erik,
>> some time ago I started to refactor the game loading code in one class to
> get
>> the ListAndFixSavedFiles utility adjusted to the new comments.
>>
>> To avoid more incompatibilities from the started refactoring from Brett
> now I
>> thought to adjust the code to include the new reload functionality of Erik
> to
>> be able to commit those changes.
>>
>> Nearly all loading functionality has been moved to a new GameLoader class
> in
>> rails.util package. The load function in Game, GameManager and
>> ListAndFixSavedFiles now all make use of a a GameLoader object.
>>
>> I have also added a line to the reload error message that asks the user to
>> submit the corrupt save file to the Rails user list for bug tracking. If
> you think
>> that is not a good idea, simply remove that text from LocalisedProperties.
>>
>> Stefan
>>
>>
> ----------------------------------------------------------------------------
> --
>> All of the data generated in your IT infrastructure is seriously valuable.
>> Why? It contains a definitive record of application performance, security
>> threats, fraudulent activity, and more. Splunk takes this data and makes
>> sense of it. IT sense. And common sense.
>> http://p.sf.net/sfu/splunk-d2d-c2
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ------------------------------------------------------------------------------
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security
> threats, fraudulent activity, and more. Splunk takes this data and makes
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Refactored loading code

[Stefan F. <ste...@we...>]

This seems like duplication of work: The repository already keeps a history of 
the change-logs. I believe it will be the same for git. Thus I am reluctant to 
copy the logs into the wiki manually.

What I think would be helpful (and I did that once already) to attach the 
revision number after the e-mail accompanying the commit (if there is any).
In combination with blame this would really help to find out, what was the 
idea behind the change. I quite often search the Rails archive for more info 
of a change.

I have not checked if there is a revision number of the sf-git repository and 
potentially it might be better to copy the main parts of the e-mail into  
(additional) javadoc document(s).

Instead of adding the history of development to the wiki I suggest to add a 
development roadmap/todo-list to the wiki.
Especially with local repositories it gets more likely that several people are 
working on the same stuff, which is both a waste of resources and makes code 
merging difficult. And it might even attract new people, if they know where to 
start and what is needed.

Stefan



> 
> As you may or may not have noticed, since some time I'm pretty meticulously
> creating entries in the Wiki Change Log for all my commits (except very
> trivial ones).  I don't know if I can expect the same from Brett and you
> (as we have seen earlier today, I'm not really the right person to request
> discipline). In any case, I have just created simple entries for the
> recent commits 1602-1604 by the two of you.  Feel free to  correct or
> expand.
> 
> 
> > -----Oorspronkelijk bericht-----
> > Van: Stefan Frey [mailto:ste...@we...]
> > Verzonden: dinsdag 5 juli 2011 19:11
> > Aan: 'Development list for Rails: an 18xx game'
> > Onderwerp: [Rails-devel] Refactored loading code
> > 
> > Brett & Erik,
> > some time ago I started to refactor the game loading code in one class to
> 
> get
> 
> > the ListAndFixSavedFiles utility adjusted to the new comments.
> > 
> > To avoid more incompatibilities from the started refactoring from Brett
> 
> now I
> 
> > thought to adjust the code to include the new reload functionality of
> > Erik
> 
> to
> 
> > be able to commit those changes.
> > 
> > Nearly all loading functionality has been moved to a new GameLoader class
> 
> in
> 
> > rails.util package. The load function in Game, GameManager and
> > ListAndFixSavedFiles now all make use of a a GameLoader object.
> > 
> > I have also added a line to the reload error message that asks the user
> > to submit the corrupt save file to the Rails user list for bug tracking.
> > If
> 
> you think
> 
> > that is not a good idea, simply remove that text from
> > LocalisedProperties.
> > 
> > Stefan
> 
> ---------------------------------------------------------------------------
> - --
> 
> > All of the data generated in your IT infrastructure is seriously
> > valuable. Why? It contains a definitive record of application
> > performance, security threats, fraudulent activity, and more. Splunk
> > takes this data and makes sense of it. IT sense. And common sense.
> > http://p.sf.net/sfu/splunk-d2d-c2
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> ---------------------------------------------------------------------------
> --- All of the data generated in your IT infrastructure is seriously
> valuable. Why? It contains a definitive record of application performance,
> security threats, fraudulent activity, and more. Splunk takes this data
> and makes sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Refactored loading code

[Stefan F. <ste...@we...>]

Further steps on refactoring:

There is a new class that combines all fields required for gameIO into 
rails.util.gameData and renamed the gameLoader into gameFileIO as it now 
combines load and save functions.

Please do some further checks on your own that load and save still works as 
intended in all situations.

One little bit is still missing: ListAndFixSavedFile is not able to save games 
currently, only loading.

Stefan

On Tuesday, July 05, 2011 07:59:49 pm brett lentz wrote:
> I was actually thinking something similar this weekend...
> 
> No objections here. :-)
> 
> ---Brett.
> 
> On Tue, Jul 5, 2011 at 10:49 AM, Erik Vos <eri...@xs...> wrote:
> > Ah, good stuff.  I was already occasionally running into problems with
> > loading files into ListAndFixSavedFiles.
> > 
> > As you may or may not have noticed, since some time I'm pretty
> > meticulously creating entries in the Wiki Change Log for all my commits
> > (except very trivial ones).  I don't know if I can expect the same from
> > Brett and you (as we have seen earlier today, I'm not really the right
> > person to request discipline). In any case, I have just created simple
> > entries for the recent commits 1602-1604 by the two of you.  Feel free
> > to  correct or expand.
> > 
> > As for packaging, I would prefer to reserve rails.util for Rails classes
> > only, and put all external main programs into tools.  That would mean
> > that ListAndFixSavedFiles should move from rails.util to tools. Any
> > objections?
> > 
> > I just noticed that we have TWO Util classes, one in rails.util and one
> > in tools.  Does anyone know a good reason for that duplication?
> >  Otherwise I would propose to merge the two into rails.util.Util.
> > 
> > Erik.
> > 
> >> -----Oorspronkelijk bericht-----
> >> Van: Stefan Frey [mailto:ste...@we...]
> >> Verzonden: dinsdag 5 juli 2011 19:11
> >> Aan: 'Development list for Rails: an 18xx game'
> >> Onderwerp: [Rails-devel] Refactored loading code
> >> 
> >> Brett & Erik,
> >> some time ago I started to refactor the game loading code in one class
> >> to
> > 
> > get
> > 
> >> the ListAndFixSavedFiles utility adjusted to the new comments.
> >> 
> >> To avoid more incompatibilities from the started refactoring from Brett
> > 
> > now I
> > 
> >> thought to adjust the code to include the new reload functionality of
> >> Erik
> > 
> > to
> > 
> >> be able to commit those changes.
> >> 
> >> Nearly all loading functionality has been moved to a new GameLoader
> >> class
> > 
> > in
> > 
> >> rails.util package. The load function in Game, GameManager and
> >> ListAndFixSavedFiles now all make use of a a GameLoader object.
> >> 
> >> I have also added a line to the reload error message that asks the user
> >> to submit the corrupt save file to the Rails user list for bug
> >> tracking. If
> > 
> > you think
> > 
> >> that is not a good idea, simply remove that text from
> >> LocalisedProperties.
> >> 
> >> Stefan
> > 
> > -------------------------------------------------------------------------
> > --- --
> > 
> >> All of the data generated in your IT infrastructure is seriously
> >> valuable. Why? It contains a definitive record of application
> >> performance, security threats, fraudulent activity, and more. Splunk
> >> takes this data and makes sense of it. IT sense. And common sense.
> >> http://p.sf.net/sfu/splunk-d2d-c2
> >> _______________________________________________
> >> Rails-devel mailing list
> >> Rai...@li...
> >> https://lists.sourceforge.net/lists/listinfo/rails-devel
> > 
> > -------------------------------------------------------------------------
> > ----- All of the data generated in your IT infrastructure is seriously
> > valuable. Why? It contains a definitive record of application
> > performance, security threats, fraudulent activity, and more. Splunk
> > takes this data and makes sense of it. IT sense. And common sense.
> > http://p.sf.net/sfu/splunk-d2d-c2
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> ---------------------------------------------------------------------------
> --- All of the data generated in your IT infrastructure is seriously
> valuable. Why? It contains a definitive record of application performance,
> security threats, fraudulent activity, and more. Splunk takes this data
> and makes sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Refactored loading code (r1613)

[Stefan F. <ste...@we...>]

And the final step, refactoring of game load and save is finished for now.

ListAndFixSavedFile now uses GameFileIO for saving.
It fully supports loading and saving the user comments and those are shown in 
the report window.

Stefan

On Wednesday, July 06, 2011 07:44:35 am Stefan Frey wrote:
> Further steps on refactoring:
> 
> There is a new class that combines all fields required for gameIO into
> rails.util.gameData and renamed the gameLoader into gameFileIO as it now
> combines load and save functions.
> 
> Please do some further checks on your own that load and save still works as
> intended in all situations.
> 
> One little bit is still missing: ListAndFixSavedFile is not able to save
> games currently, only loading.
> 
> Stefan
> 
> On Tuesday, July 05, 2011 07:59:49 pm brett lentz wrote:
> > I was actually thinking something similar this weekend...
> > 
> > No objections here. :-)
> > 
> > ---Brett.
> > 
> > On Tue, Jul 5, 2011 at 10:49 AM, Erik Vos <eri...@xs...> wrote:
> > > Ah, good stuff.  I was already occasionally running into problems with
> > > loading files into ListAndFixSavedFiles.
> > > 
> > > As you may or may not have noticed, since some time I'm pretty
> > > meticulously creating entries in the Wiki Change Log for all my commits
> > > (except very trivial ones).  I don't know if I can expect the same from
> > > Brett and you (as we have seen earlier today, I'm not really the right
> > > person to request discipline). In any case, I have just created simple
> > > entries for the recent commits 1602-1604 by the two of you.  Feel free
> > > to  correct or expand.
> > > 
> > > As for packaging, I would prefer to reserve rails.util for Rails
> > > classes only, and put all external main programs into tools.  That
> > > would mean that ListAndFixSavedFiles should move from rails.util to
> > > tools. Any objections?
> > > 
> > > I just noticed that we have TWO Util classes, one in rails.util and one
> > > in tools.  Does anyone know a good reason for that duplication?
> > > 
> > >  Otherwise I would propose to merge the two into rails.util.Util.
> > > 
> > > Erik.
> > > 
> > >> -----Oorspronkelijk bericht-----
> > >> Van: Stefan Frey [mailto:ste...@we...]
> > >> Verzonden: dinsdag 5 juli 2011 19:11
> > >> Aan: 'Development list for Rails: an 18xx game'
> > >> Onderwerp: [Rails-devel] Refactored loading code
> > >> 
> > >> Brett & Erik,
> > >> some time ago I started to refactor the game loading code in one class
> > >> to
> > > 
> > > get
> > > 
> > >> the ListAndFixSavedFiles utility adjusted to the new comments.
> > >> 
> > >> To avoid more incompatibilities from the started refactoring from
> > >> Brett
> > > 
> > > now I
> > > 
> > >> thought to adjust the code to include the new reload functionality of
> > >> Erik
> > > 
> > > to
> > > 
> > >> be able to commit those changes.
> > >> 
> > >> Nearly all loading functionality has been moved to a new GameLoader
> > >> class
> > > 
> > > in
> > > 
> > >> rails.util package. The load function in Game, GameManager and
> > >> ListAndFixSavedFiles now all make use of a a GameLoader object.
> > >> 
> > >> I have also added a line to the reload error message that asks the
> > >> user to submit the corrupt save file to the Rails user list for bug
> > >> tracking. If
> > > 
> > > you think
> > > 
> > >> that is not a good idea, simply remove that text from
> > >> LocalisedProperties.
> > >> 
> > >> Stefan
> > > 
> > > -----------------------------------------------------------------------
> > > -- --- --
> > > 
> > >> All of the data generated in your IT infrastructure is seriously
> > >> valuable. Why? It contains a definitive record of application
> > >> performance, security threats, fraudulent activity, and more. Splunk
> > >> takes this data and makes sense of it. IT sense. And common sense.
> > >> http://p.sf.net/sfu/splunk-d2d-c2
> > >> _______________________________________________
> > >> Rails-devel mailing list
> > >> Rai...@li...
> > >> https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > 
> > > -----------------------------------------------------------------------
> > > -- ----- All of the data generated in your IT infrastructure is
> > > seriously valuable. Why? It contains a definitive record of
> > > application
> > > performance, security threats, fraudulent activity, and more. Splunk
> > > takes this data and makes sense of it. IT sense. And common sense.
> > > http://p.sf.net/sfu/splunk-d2d-c2
> > > _______________________________________________
> > > Rails-devel mailing list
> > > Rai...@li...
> > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > 
> > -------------------------------------------------------------------------
> > -- --- All of the data generated in your IT infrastructure is seriously
> > valuable. Why? It contains a definitive record of application
> > performance, security threats, fraudulent activity, and more. Splunk
> > takes this data and makes sense of it. IT sense. And common sense.
> > http://p.sf.net/sfu/splunk-d2d-c2
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> ---------------------------------------------------------------------------
> --- All of the data generated in your IT infrastructure is seriously
> valuable. Why? It contains a definitive record of application performance,
> security threats, fraudulent activity, and more. Splunk takes this data
> and makes sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Refactored loading code

[Erik V. <eri...@xs...>]

I can report that even Autosave/load still works (as far as it ever did).  
But, as I have not got any feedback yet on this new feature, its further
development doesn't have a high priority for me right now.

Erik.

> -----Oorspronkelijk bericht-----
> Van: Stefan Frey [mailto:ste...@we...]
> Verzonden: woensdag 6 juli 2011 7:45
> Aan: Development list for Rails: an 18xx game
> Onderwerp: Re: [Rails-devel] Refactored loading code
> 
> Further steps on refactoring:
> 
> There is a new class that combines all fields required for gameIO into
> rails.util.gameData and renamed the gameLoader into gameFileIO as it now
> combines load and save functions.
> 
> Please do some further checks on your own that load and save still works
as
> intended in all situations.
> 
> One little bit is still missing: ListAndFixSavedFile is not able to save
games
> currently, only loading.
> 
> Stefan
> 
> On Tuesday, July 05, 2011 07:59:49 pm brett lentz wrote:
> > I was actually thinking something similar this weekend...
> >
> > No objections here. :-)
> >
> > ---Brett.
> >
> > On Tue, Jul 5, 2011 at 10:49 AM, Erik Vos <eri...@xs...> wrote:
> > > Ah, good stuff.  I was already occasionally running into problems
> > > with loading files into ListAndFixSavedFiles.
> > >
> > > As you may or may not have noticed, since some time I'm pretty
> > > meticulously creating entries in the Wiki Change Log for all my
> > > commits (except very trivial ones).  I don't know if I can expect
> > > the same from Brett and you (as we have seen earlier today, I'm not
> > > really the right person to request discipline). In any case, I have
> > > just created simple entries for the recent commits 1602-1604 by the
> > > two of you.  Feel free to  correct or expand.
> > >
> > > As for packaging, I would prefer to reserve rails.util for Rails
> > > classes only, and put all external main programs into tools.  That
> > > would mean that ListAndFixSavedFiles should move from rails.util to
> > > tools. Any objections?
> > >
> > > I just noticed that we have TWO Util classes, one in rails.util and
> > > one in tools.  Does anyone know a good reason for that duplication?
> > >  Otherwise I would propose to merge the two into rails.util.Util.
> > >
> > > Erik.
> > >
> > >> -----Oorspronkelijk bericht-----
> > >> Van: Stefan Frey [mailto:ste...@we...]
> > >> Verzonden: dinsdag 5 juli 2011 19:11
> > >> Aan: 'Development list for Rails: an 18xx game'
> > >> Onderwerp: [Rails-devel] Refactored loading code
> > >>
> > >> Brett & Erik,
> > >> some time ago I started to refactor the game loading code in one
> > >> class to
> > >
> > > get
> > >
> > >> the ListAndFixSavedFiles utility adjusted to the new comments.
> > >>
> > >> To avoid more incompatibilities from the started refactoring from
> > >> Brett
> > >
> > > now I
> > >
> > >> thought to adjust the code to include the new reload functionality
> > >> of Erik
> > >
> > > to
> > >
> > >> be able to commit those changes.
> > >>
> > >> Nearly all loading functionality has been moved to a new GameLoader
> > >> class
> > >
> > > in
> > >
> > >> rails.util package. The load function in Game, GameManager and
> > >> ListAndFixSavedFiles now all make use of a a GameLoader object.
> > >>
> > >> I have also added a line to the reload error message that asks the
> > >> user to submit the corrupt save file to the Rails user list for bug
> > >> tracking. If
> > >
> > > you think
> > >
> > >> that is not a good idea, simply remove that text from
> > >> LocalisedProperties.
> > >>
> > >> Stefan
> > >
> > > --------------------------------------------------------------------
> > > -----
> > > --- --
> > >
> > >> All of the data generated in your IT infrastructure is seriously
> > >> valuable. Why? It contains a definitive record of application
> > >> performance, security threats, fraudulent activity, and more.
> > >> Splunk takes this data and makes sense of it. IT sense. And common
> sense.
> > >> http://p.sf.net/sfu/splunk-d2d-c2
> > >> _______________________________________________
> > >> Rails-devel mailing list
> > >> Rai...@li...
> > >> https://lists.sourceforge.net/lists/listinfo/rails-devel
> > >
> > > --------------------------------------------------------------------
> > > -----
> > > ----- All of the data generated in your IT infrastructure is
> > > seriously valuable. Why? It contains a definitive record of
> > > application performance, security threats, fraudulent activity, and
> > > more. Splunk takes this data and makes sense of it. IT sense. And
> common sense.
> > > http://p.sf.net/sfu/splunk-d2d-c2
> > > _______________________________________________
> > > Rails-devel mailing list
> > > Rai...@li...
> > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
> > ----------------------------------------------------------------------
> > -----
> > --- All of the data generated in your IT infrastructure is seriously
> > valuable. Why? It contains a definitive record of application
> > performance, security threats, fraudulent activity, and more. Splunk
> > takes this data and makes sense of it. IT sense. And common sense.
> > http://p.sf.net/sfu/splunk-d2d-c2
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
>
----------------------------------------------------------------------------
--
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security
> threats, fraudulent activity, and more. Splunk takes this data and makes
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Refactored loading code

[Phil D. <de...@gm...>]

I've been using it successfully, it seems to work fairly well, the
only difficulty I've had has been a social one unfortunately, in that
it's difficult to persuade other people I play with to keep the game
window open and use the autoplay system.  Certainly for pbem games,
most seem to prefer to use the reload feature manually rather than the
autoreload, so I've not had a chance to test it in anger.

On 6 July 2011 10:04, Erik Vos <eri...@xs...> wrote:
> I can report that even Autosave/load still works (as far as it ever did).
> But, as I have not got any feedback yet on this new feature, its further
> development doesn't have a high priority for me right now.
>
> Erik.
>
>> -----Oorspronkelijk bericht-----
>> Van: Stefan Frey [mailto:ste...@we...]
>> Verzonden: woensdag 6 juli 2011 7:45
>> Aan: Development list for Rails: an 18xx game
>> Onderwerp: Re: [Rails-devel] Refactored loading code
>>
>> Further steps on refactoring:
>>
>> There is a new class that combines all fields required for gameIO into
>> rails.util.gameData and renamed the gameLoader into gameFileIO as it now
>> combines load and save functions.
>>
>> Please do some further checks on your own that load and save still works
> as
>> intended in all situations.
>>
>> One little bit is still missing: ListAndFixSavedFile is not able to save
> games
>> currently, only loading.
>>
>> Stefan
>>
>> On Tuesday, July 05, 2011 07:59:49 pm brett lentz wrote:
>> > I was actually thinking something similar this weekend...
>> >
>> > No objections here. :-)
>> >
>> > ---Brett.
>> >
>> > On Tue, Jul 5, 2011 at 10:49 AM, Erik Vos <eri...@xs...> wrote:
>> > > Ah, good stuff.  I was already occasionally running into problems
>> > > with loading files into ListAndFixSavedFiles.
>> > >
>> > > As you may or may not have noticed, since some time I'm pretty
>> > > meticulously creating entries in the Wiki Change Log for all my
>> > > commits (except very trivial ones).  I don't know if I can expect
>> > > the same from Brett and you (as we have seen earlier today, I'm not
>> > > really the right person to request discipline). In any case, I have
>> > > just created simple entries for the recent commits 1602-1604 by the
>> > > two of you.  Feel free to  correct or expand.
>> > >
>> > > As for packaging, I would prefer to reserve rails.util for Rails
>> > > classes only, and put all external main programs into tools.  That
>> > > would mean that ListAndFixSavedFiles should move from rails.util to
>> > > tools. Any objections?
>> > >
>> > > I just noticed that we have TWO Util classes, one in rails.util and
>> > > one in tools.  Does anyone know a good reason for that duplication?
>> > >  Otherwise I would propose to merge the two into rails.util.Util.
>> > >
>> > > Erik.
>> > >
>> > >> -----Oorspronkelijk bericht-----
>> > >> Van: Stefan Frey [mailto:ste...@we...]
>> > >> Verzonden: dinsdag 5 juli 2011 19:11
>> > >> Aan: 'Development list for Rails: an 18xx game'
>> > >> Onderwerp: [Rails-devel] Refactored loading code
>> > >>
>> > >> Brett & Erik,
>> > >> some time ago I started to refactor the game loading code in one
>> > >> class to
>> > >
>> > > get
>> > >
>> > >> the ListAndFixSavedFiles utility adjusted to the new comments.
>> > >>
>> > >> To avoid more incompatibilities from the started refactoring from
>> > >> Brett
>> > >
>> > > now I
>> > >
>> > >> thought to adjust the code to include the new reload functionality
>> > >> of Erik
>> > >
>> > > to
>> > >
>> > >> be able to commit those changes.
>> > >>
>> > >> Nearly all loading functionality has been moved to a new GameLoader
>> > >> class
>> > >
>> > > in
>> > >
>> > >> rails.util package. The load function in Game, GameManager and
>> > >> ListAndFixSavedFiles now all make use of a a GameLoader object.
>> > >>
>> > >> I have also added a line to the reload error message that asks the
>> > >> user to submit the corrupt save file to the Rails user list for bug
>> > >> tracking. If
>> > >
>> > > you think
>> > >
>> > >> that is not a good idea, simply remove that text from
>> > >> LocalisedProperties.
>> > >>
>> > >> Stefan
>> > >
>> > > --------------------------------------------------------------------
>> > > -----
>> > > --- --
>> > >
>> > >> All of the data generated in your IT infrastructure is seriously
>> > >> valuable. Why? It contains a definitive record of application
>> > >> performance, security threats, fraudulent activity, and more.
>> > >> Splunk takes this data and makes sense of it. IT sense. And common
>> sense.
>> > >> http://p.sf.net/sfu/splunk-d2d-c2
>> > >> _______________________________________________
>> > >> Rails-devel mailing list
>> > >> Rai...@li...
>> > >> https://lists.sourceforge.net/lists/listinfo/rails-devel
>> > >
>> > > --------------------------------------------------------------------
>> > > -----
>> > > ----- All of the data generated in your IT infrastructure is
>> > > seriously valuable. Why? It contains a definitive record of
>> > > application performance, security threats, fraudulent activity, and
>> > > more. Splunk takes this data and makes sense of it. IT sense. And
>> common sense.
>> > > http://p.sf.net/sfu/splunk-d2d-c2
>> > > _______________________________________________
>> > > Rails-devel mailing list
>> > > Rai...@li...
>> > > https://lists.sourceforge.net/lists/listinfo/rails-devel
>> >
>> > ----------------------------------------------------------------------
>> > -----
>> > --- All of the data generated in your IT infrastructure is seriously
>> > valuable. Why? It contains a definitive record of application
>> > performance, security threats, fraudulent activity, and more. Splunk
>> > takes this data and makes sense of it. IT sense. And common sense.
>> > http://p.sf.net/sfu/splunk-d2d-c2
>> > _______________________________________________
>> > Rails-devel mailing list
>> > Rai...@li...
>> > https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>>
> ----------------------------------------------------------------------------
> --
>> All of the data generated in your IT infrastructure is seriously valuable.
>> Why? It contains a definitive record of application performance, security
>> threats, fraudulent activity, and more. Splunk takes this data and makes
>> sense of it. IT sense. And common sense.
>> http://p.sf.net/sfu/splunk-d2d-c2
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ------------------------------------------------------------------------------
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security
> threats, fraudulent activity, and more. Splunk takes this data and makes
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Refactored loading code

[Scott P. <sc...@re...>]

On Wed, Jul 6, 2011 at 4:04 AM, Erik Vos <eri...@xs...> wrote:

> But, as I have not got any feedback yet on this new feature, its further
> development doesn't have a high priority for me right now.


Erik, I never figured out how Autosave/load is supposed to work.  What steps
would I do to test it?

I assume I could have two instances of Rails running on the same machine to
try it.

[Rails-devel] autosave/load testing, was: Refactored loading code

[Rick W. <wes...@pu...>]

----- Original Message -----
> On Wed, Jul 6, 2011 at 4:04 AM, Erik Vos < eri...@xs... > wrote:
> 
> 
> But, as I have not got any feedback yet on this new feature, its
> further
> development doesn't have a high priority for me right now.
> 
> 
> Erik, I never figured out how Autosave/load is supposed to work. What
> steps would I do to test it?
> 
> 
> I assume I could have two instances of Rails running on the same
> machine to try it.

   Even better would be to have two machines.  I tried this early on but have since run out of time to do more testing.   On the other hand I do appreciate Erik keeping this code around.  I suspect that it will be useful.

-- Rick

Re: [Rails-devel] Refactored loading code

[Erik V. <eri...@xs...>]

This makes me raise another question that has been on my mind for a long
time: should we partially refactor the rails.game package into smaller
subpackages?
Examples: rails.game.round for all Round (sub)classes, rails.game.train,
rails.game.map (hexes and tiles), perhaps others.  

I don't have strong feelings about it, it's just that rails.game is growing
a bit largish.

Erik.

> -----Oorspronkelijk bericht-----
> Van: brett lentz [mailto:bre...@gm...]
> Verzonden: dinsdag 5 juli 2011 19:39
> Aan: Development list for Rails: an 18xx game
> Onderwerp: Re: [Rails-devel] Refactored loading code
> 
> That looks good to me.
> 
> My overall goal with my refactoring is to remove the need for the
rails.game
> package to know about lower-level details, such as XML parsing.
> 
> Moving the classes that need to know about how to load/save game files
> outside of rails.game.* aligns very well with this goal. :-)
> 
> ---Brett.
> 
> 
> 
> On Tue, Jul 5, 2011 at 10:11 AM, Stefan Frey <ste...@we...> wrote:
> > Brett & Erik,
> > some time ago I started to refactor the game loading code in one class
> > to get the ListAndFixSavedFiles utility adjusted to the new comments.
> >
> > To avoid more incompatibilities from the started refactoring from
> > Brett now I thought to adjust the code to include the new reload
> > functionality of Erik to be able to commit those changes.
> >
> > Nearly all loading functionality has been moved to a new GameLoader
> > class in rails.util package. The load function in Game, GameManager
> > and ListAndFixSavedFiles now all make use of a a GameLoader object.
> >
> > I have also added a line to the reload error message that asks the
> > user to submit the corrupt save file to the Rails user list for bug
> > tracking. If you think that is not a good idea, simply remove that
> > text from LocalisedProperties.
> >
> > Stefan
> >
> 
>
----------------------------------------------------------------------------
--
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security
> threats, fraudulent activity, and more. Splunk takes this data and makes
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Refactored loading code

[brett l. <bre...@gm...>]

I've been pulling the XML-related bits over into rails.common.parser.

I think that if there are more than 3-5 classes for a common purpose,
they can probably be organized into a sub-package.

---Brett.



On Wed, Jul 6, 2011 at 2:53 AM, Erik Vos <eri...@xs...> wrote:
> This makes me raise another question that has been on my mind for a long
> time: should we partially refactor the rails.game package into smaller
> subpackages?
> Examples: rails.game.round for all Round (sub)classes, rails.game.train,
> rails.game.map (hexes and tiles), perhaps others.
>
> I don't have strong feelings about it, it's just that rails.game is growing
> a bit largish.
>
> Erik.
>
>> -----Oorspronkelijk bericht-----
>> Van: brett lentz [mailto:bre...@gm...]
>> Verzonden: dinsdag 5 juli 2011 19:39
>> Aan: Development list for Rails: an 18xx game
>> Onderwerp: Re: [Rails-devel] Refactored loading code
>>
>> That looks good to me.
>>
>> My overall goal with my refactoring is to remove the need for the
> rails.game
>> package to know about lower-level details, such as XML parsing.
>>
>> Moving the classes that need to know about how to load/save game files
>> outside of rails.game.* aligns very well with this goal. :-)
>>
>> ---Brett.
>>
>>
>>
>> On Tue, Jul 5, 2011 at 10:11 AM, Stefan Frey <ste...@we...> wrote:
>> > Brett & Erik,
>> > some time ago I started to refactor the game loading code in one class
>> > to get the ListAndFixSavedFiles utility adjusted to the new comments.
>> >
>> > To avoid more incompatibilities from the started refactoring from
>> > Brett now I thought to adjust the code to include the new reload
>> > functionality of Erik to be able to commit those changes.
>> >
>> > Nearly all loading functionality has been moved to a new GameLoader
>> > class in rails.util package. The load function in Game, GameManager
>> > and ListAndFixSavedFiles now all make use of a a GameLoader object.
>> >
>> > I have also added a line to the reload error message that asks the
>> > user to submit the corrupt save file to the Rails user list for bug
>> > tracking. If you think that is not a good idea, simply remove that
>> > text from LocalisedProperties.
>> >
>> > Stefan
>> >
>>
>>
> ----------------------------------------------------------------------------
> --
>> All of the data generated in your IT infrastructure is seriously valuable.
>> Why? It contains a definitive record of application performance, security
>> threats, fraudulent activity, and more. Splunk takes this data and makes
>> sense of it. IT sense. And common sense.
>> http://p.sf.net/sfu/splunk-d2d-c2
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ------------------------------------------------------------------------------
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security
> threats, fraudulent activity, and more. Splunk takes this data and makes
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>