rails-devel

[Rails-devel] 1835 bug fixes

[Stefan F. <ste...@we...>]

In a test game on 1835 I found several bugs:
As most of them were pretty basic/standard, it was easier to fix them directly 
instead of forwarding bug reports to Erik.
Nearly all of the bugs are either related to PR formation or nationalisation, 
thus playing until that stage works ok.

Stefan

List of my changes:
- Tile 213 update was incorrect
- Pr funding money not given, but see TODO 1
- PR formation round acted as a stock round (side effect: price increase, 
wrong round names), removed call to super.finishRound()
- Undo inside PR formation round creates weird states, fixed by changing to 
linked moveSets
- Nationalisation did not check certificate limits before action (post-action 
check was ok)
- Nationalisation prevents selling of stocks (due to self-nationalisation bug)
- Pr 5% shares report only 1/4 of value, 10% shares only 1/2 of value(report 
window, executed correctly fixed currentSellPrice, see TODO 2 and 3, adjusted 
output)
- Added manual closing of OBB

Remaining TODOs:
1) Implement SharePriceUnits everywhere it is appropriate (e.g. Round method 
floating())
2) SellPrices is not a stateful map (=> undo side effects!)
3) Selling PR president is shown as selling two 5 percent shares (which might 
be correct) but selling those creates all kind of crazy effects

Re: [Rails-devel] 1835 bug fixes

[Erik V. <eri...@xs...>]

Thanks, Stefan.

I had kind of lost track where we are with 1835, great that you can pick it
up. 
I believe there are still some issues with the blue private properties, as
reported by JDG a while ago, and I was intending to give these a better look
whenever I could spend a good bit of time. But no problem if you want to
take these too.

Erik.

-----Original Message-----
From: Stefan Frey [mailto:ste...@we...] 
Sent: Monday 06 September 2010 23:28
To: 'Development list for Rails: an 18xx game'
Subject: [Rails-devel] 1835 bug fixes

In a test game on 1835 I found several bugs:
As most of them were pretty basic/standard, it was easier to fix them
directly 
instead of forwarding bug reports to Erik.
Nearly all of the bugs are either related to PR formation or
nationalisation, 
thus playing until that stage works ok.

Stefan

List of my changes:
- Tile 213 update was incorrect
- Pr funding money not given, but see TODO 1
- PR formation round acted as a stock round (side effect: price increase, 
wrong round names), removed call to super.finishRound()
- Undo inside PR formation round creates weird states, fixed by changing to 
linked moveSets
- Nationalisation did not check certificate limits before action
(post-action 
check was ok)
- Nationalisation prevents selling of stocks (due to self-nationalisation
bug)
- Pr 5% shares report only 1/4 of value, 10% shares only 1/2 of value(report

window, executed correctly fixed currentSellPrice, see TODO 2 and 3,
adjusted 
output)
- Added manual closing of OBB

Remaining TODOs:
1) Implement SharePriceUnits everywhere it is appropriate (e.g. Round method

floating())
2) SellPrices is not a stateful map (=> undo side effects!)
3) Selling PR president is shown as selling two 5 percent shares (which
might 
be correct) but selling those creates all kind of crazy effects

----------------------------------------------------------------------------
--
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel