Menu
▾
▴
rails-devel
|
From: brett l. <bre...@gm...> - 2010-03-19 15:11:15
|
---------- Forwarded message ---------- From: Arne Östlund <arn...@gl...> Date: Thu, Mar 18, 2010 at 11:27 PM Subject: Problem with Rails 1.2 To: rai...@li... Hi Brett/Erik We are playing an 1856 PBeM campaigne. Due to an error with Rails 1.1.3 I tried to recreate our moves in Rail 1.2 to current status by redo some turns. But when I repayed the Loans for LPS after an withhold, one OR before the CGR formation, the game stalled. The only option I got was to Undo. So we can not pass this state and continue the game! /Arne Östlund |
|
From: Erik V. <eri...@xs...> - 2010-03-19 20:53:24
|
This problem was indeed caused by the Stefan's fix. That fix was basically correct, as my way to allow done in this case was a shortcut that broke the (unwritten) rules. But the purpose of that shortcut (enabling Done) was not reinstated in any other way. I have now done it in the regular way. Done will now be enabled after repaying loans. Erik. -----Original Message----- From: Stefan Frey [mailto:ste...@we...] Sent: Friday 19 March 2010 17:05 To: rai...@li... Subject: Re: [Rails-devel] Fwd: Problem with Rails 1.2 Erik: from the description alone I guess that this is caused by a bug fix of mine on the undo mechanism. Do you remember our discussion about the change from the postcondition check (which requires the use of state variables) for the done button to a precondition check (which avoids that). It seems that there is a case not covered in the 1856 repay loan action step yet, that does not set the doneAllowed variable. Thus it might be a good guess to check the preconditions there. I look forward to checking in my automated testing procedures which hopefully reduce those side-effects of refactoring. STefan On Friday 19 March 2010 16:10:49 brett lentz wrote: > ---------- Forwarded message ---------- > From: Arne Östlund <arn...@gl...> > Date: Thu, Mar 18, 2010 at 11:27 PM > Subject: Problem with Rails 1.2 > To: rai...@li... > > > Hi Brett/Erik > > We are playing an 1856 PBeM campaigne. Due to an error with Rails > 1.1.3 I tried to recreate our moves in Rail 1.2 to current status by > redo some turns. But when I repayed the Loans for LPS after an > withhold, one OR before the CGR formation, the game stalled. The only > option I got was to Undo. So we can not pass this state and continue > the game! > > /Arne Östlund ---------------------------------------------------------------------------- -- Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Rails-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rails-devel |
|
From: brett l. <bre...@gm...> - 2010-03-19 21:02:27
|
Should we do a 1.2.2 release for this? ---Brett. On Fri, Mar 19, 2010 at 1:53 PM, Erik Vos <eri...@xs...> wrote: > This problem was indeed caused by the Stefan's fix. That fix was basically > correct, as my way to allow done in this case was a shortcut that broke the > (unwritten) rules. But the purpose of that shortcut (enabling Done) was not > reinstated in any other way. > > I have now done it in the regular way. Done will now be enabled after > repaying loans. > > Erik. > > > -----Original Message----- > From: Stefan Frey [mailto:ste...@we...] > Sent: Friday 19 March 2010 17:05 > To: rai...@li... > Subject: Re: [Rails-devel] Fwd: Problem with Rails 1.2 > > Erik: > from the description alone I guess that this is caused by a bug fix of mine > on the undo mechanism. Do you remember our discussion about the change from > the postcondition check (which requires the use of state variables) for the > done button to a precondition check (which avoids that). > > It seems that there is a case not covered in the 1856 repay loan action step > > yet, that does not set the doneAllowed variable. Thus it might be a good > guess to check the preconditions there. > > I look forward to checking in my automated testing procedures which > hopefully > reduce those side-effects of refactoring. > > STefan > > > On Friday 19 March 2010 16:10:49 brett lentz wrote: >> ---------- Forwarded message ---------- >> From: Arne Östlund <arn...@gl...> >> Date: Thu, Mar 18, 2010 at 11:27 PM >> Subject: Problem with Rails 1.2 >> To: rai...@li... >> >> >> Hi Brett/Erik >> >> We are playing an 1856 PBeM campaigne. Due to an error with Rails >> 1.1.3 I tried to recreate our moves in Rail 1.2 to current status by >> redo some turns. But when I repayed the Loans for LPS after an >> withhold, one OR before the CGR formation, the game stalled. The only >> option I got was to Undo. So we can not pass this state and continue >> the game! >> >> /Arne Östlund > > > > ---------------------------------------------------------------------------- > -- > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
|
From: Stefan F. <ste...@we...> - 2010-03-20 08:59:24
|
the bug I fixed is still fixed with Erik's fix. I would recommend another release is possible, after that I would check in my changes to enable automated regression testing, which requires some minor changes on two utility Rails classes. STefan On Friday 19 March 2010 22:02:01 brett lentz wrote: > Should we do a 1.2.2 release for this? > > > ---Brett. > > On Fri, Mar 19, 2010 at 1:53 PM, Erik Vos <eri...@xs...> wrote: > > This problem was indeed caused by the Stefan's fix. That fix was > > basically correct, as my way to allow done in this case was a shortcut > > that broke the (unwritten) rules. But the purpose of that shortcut > > (enabling Done) was not reinstated in any other way. > > > > I have now done it in the regular way. Done will now be enabled after > > repaying loans. > > > > Erik. > > > > > > -----Original Message----- > > From: Stefan Frey [mailto:ste...@we...] > > Sent: Friday 19 March 2010 17:05 > > To: rai...@li... > > Subject: Re: [Rails-devel] Fwd: Problem with Rails 1.2 > > > > Erik: > > from the description alone I guess that this is caused by a bug fix of > > mine on the undo mechanism. Do you remember our discussion about the > > change from the postcondition check (which requires the use of state > > variables) for the done button to a precondition check (which avoids > > that). > > > > It seems that there is a case not covered in the 1856 repay loan action > > step > > > > yet, that does not set the doneAllowed variable. Thus it might be a good > > guess to check the preconditions there. > > > > I look forward to checking in my automated testing procedures which > > hopefully > > reduce those side-effects of refactoring. > > > > STefan > > > > On Friday 19 March 2010 16:10:49 brett lentz wrote: > >> ---------- Forwarded message ---------- > >> From: Arne Östlund <arn...@gl...> > >> Date: Thu, Mar 18, 2010 at 11:27 PM > >> Subject: Problem with Rails 1.2 > >> To: rai...@li... > >> > >> > >> Hi Brett/Erik > >> > >> We are playing an 1856 PBeM campaigne. Due to an error with Rails > >> 1.1.3 I tried to recreate our moves in Rail 1.2 to current status by > >> redo some turns. But when I repayed the Loans for LPS after an > >> withhold, one OR before the CGR formation, the game stalled. The only > >> option I got was to Undo. So we can not pass this state and continue > >> the game! > >> > >> /Arne Östlund > > > > ------------------------------------------------------------------------- > >--- -- > > Download Intel® Parallel Studio Eval > > Try the new software tools for yourself. Speed compiling, find bugs > > proactively, and fine-tune applications for parallel performance. > > See why Intel Parallel Studio got high marks during beta. > > http://p.sf.net/sfu/intel-sw-dev > > _______________________________________________ > > Rails-devel mailing list > > Rai...@li... > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > > > ------------------------------------------------------------------------- > >----- Download Intel® Parallel Studio Eval > > Try the new software tools for yourself. Speed compiling, find bugs > > proactively, and fine-tune applications for parallel performance. > > See why Intel Parallel Studio got high marks during beta. > > http://p.sf.net/sfu/intel-sw-dev > > _______________________________________________ > > Rails-devel mailing list > > Rai...@li... > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > --------------------------------------------------------------------------- >--- Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel |
|
From: Stefan F. <ste...@we...> - 2010-03-21 10:59:28
|
Brett: I would like to commit my changes that allow regression testing for Rails. Could we have the bug fix release out of the door before that? The changes include a few changes to some of the base classes to allow Rails to process several different 18xx games in sequence and to the ReportBuffer class, as the comparison is based on the game report. I would prefer to have the bug fix release out without those changes, which might include some side effects. The other possibility would be to branch, but I do not know exactly how to branch and merge with cvs. Do we have a decision already about the future system? I would be glad about svn as I use that for work as well and it seems to be well integrated to eclipse. Stefan On Friday 19 March 2010 22:02:01 brett lentz wrote: > Should we do a 1.2.2 release for this? > > > ---Brett. > > On Fri, Mar 19, 2010 at 1:53 PM, Erik Vos <eri...@xs...> wrote: > > This problem was indeed caused by the Stefan's fix. That fix was > > basically correct, as my way to allow done in this case was a shortcut > > that broke the (unwritten) rules. But the purpose of that shortcut > > (enabling Done) was not reinstated in any other way. > > > > I have now done it in the regular way. Done will now be enabled after > > repaying loans. > > > > Erik. > > > > > > -----Original Message----- > > From: Stefan Frey [mailto:ste...@we...] > > Sent: Friday 19 March 2010 17:05 > > To: rai...@li... > > Subject: Re: [Rails-devel] Fwd: Problem with Rails 1.2 > > > > Erik: > > from the description alone I guess that this is caused by a bug fix of > > mine on the undo mechanism. Do you remember our discussion about the > > change from the postcondition check (which requires the use of state > > variables) for the done button to a precondition check (which avoids > > that). > > > > It seems that there is a case not covered in the 1856 repay loan action > > step > > > > yet, that does not set the doneAllowed variable. Thus it might be a good > > guess to check the preconditions there. > > > > I look forward to checking in my automated testing procedures which > > hopefully > > reduce those side-effects of refactoring. > > > > STefan > > > > On Friday 19 March 2010 16:10:49 brett lentz wrote: > >> ---------- Forwarded message ---------- > >> From: Arne Östlund <arn...@gl...> > >> Date: Thu, Mar 18, 2010 at 11:27 PM > >> Subject: Problem with Rails 1.2 > >> To: rai...@li... > >> > >> > >> Hi Brett/Erik > >> > >> We are playing an 1856 PBeM campaigne. Due to an error with Rails > >> 1.1.3 I tried to recreate our moves in Rail 1.2 to current status by > >> redo some turns. But when I repayed the Loans for LPS after an > >> withhold, one OR before the CGR formation, the game stalled. The only > >> option I got was to Undo. So we can not pass this state and continue > >> the game! > >> > >> /Arne Östlund > > > > ------------------------------------------------------------------------- > >--- -- > > Download Intel® Parallel Studio Eval > > Try the new software tools for yourself. Speed compiling, find bugs > > proactively, and fine-tune applications for parallel performance. > > See why Intel Parallel Studio got high marks during beta. > > http://p.sf.net/sfu/intel-sw-dev > > _______________________________________________ > > Rails-devel mailing list > > Rai...@li... > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > > > ------------------------------------------------------------------------- > >----- Download Intel® Parallel Studio Eval > > Try the new software tools for yourself. Speed compiling, find bugs > > proactively, and fine-tune applications for parallel performance. > > See why Intel Parallel Studio got high marks during beta. > > http://p.sf.net/sfu/intel-sw-dev > > _______________________________________________ > > Rails-devel mailing list > > Rai...@li... > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > --------------------------------------------------------------------------- >--- Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel |
|
From: brett l. <bre...@gm...> - 2010-03-21 17:25:32
|
Yup. I was planning on doing the release today. ---Brett. On Sun, Mar 21, 2010 at 3:55 AM, Stefan Frey <ste...@we...> wrote: > Brett: > I would like to commit my changes that allow regression testing for Rails. > Could we have the bug fix release out of the door before that? > > The changes include a few changes to some of the base classes to allow Rails > to process several different 18xx games in sequence and to the ReportBuffer > class, as the comparison is based on the game report. > > I would prefer to have the bug fix release out without those changes, which > might include some side effects. > > The other possibility would be to branch, but I do not know exactly how to > branch and merge with cvs. Do we have a decision already about the future > system? I would be glad about svn as I use that for work as well and it seems > to be well integrated to eclipse. > > Stefan > > > On Friday 19 March 2010 22:02:01 brett lentz wrote: >> Should we do a 1.2.2 release for this? >> >> >> ---Brett. >> >> On Fri, Mar 19, 2010 at 1:53 PM, Erik Vos <eri...@xs...> wrote: >> > This problem was indeed caused by the Stefan's fix. That fix was >> > basically correct, as my way to allow done in this case was a shortcut >> > that broke the (unwritten) rules. But the purpose of that shortcut >> > (enabling Done) was not reinstated in any other way. >> > >> > I have now done it in the regular way. Done will now be enabled after >> > repaying loans. >> > >> > Erik. >> > >> > >> > -----Original Message----- >> > From: Stefan Frey [mailto:ste...@we...] >> > Sent: Friday 19 March 2010 17:05 >> > To: rai...@li... >> > Subject: Re: [Rails-devel] Fwd: Problem with Rails 1.2 >> > >> > Erik: >> > from the description alone I guess that this is caused by a bug fix of >> > mine on the undo mechanism. Do you remember our discussion about the >> > change from the postcondition check (which requires the use of state >> > variables) for the done button to a precondition check (which avoids >> > that). >> > >> > It seems that there is a case not covered in the 1856 repay loan action >> > step >> > >> > yet, that does not set the doneAllowed variable. Thus it might be a good >> > guess to check the preconditions there. >> > >> > I look forward to checking in my automated testing procedures which >> > hopefully >> > reduce those side-effects of refactoring. >> > >> > STefan >> > >> > On Friday 19 March 2010 16:10:49 brett lentz wrote: >> >> ---------- Forwarded message ---------- >> >> From: Arne Östlund <arn...@gl...> >> >> Date: Thu, Mar 18, 2010 at 11:27 PM >> >> Subject: Problem with Rails 1.2 >> >> To: rai...@li... >> >> >> >> >> >> Hi Brett/Erik >> >> >> >> We are playing an 1856 PBeM campaigne. Due to an error with Rails >> >> 1.1.3 I tried to recreate our moves in Rail 1.2 to current status by >> >> redo some turns. But when I repayed the Loans for LPS after an >> >> withhold, one OR before the CGR formation, the game stalled. The only >> >> option I got was to Undo. So we can not pass this state and continue >> >> the game! >> >> >> >> /Arne Östlund >> > >> > ------------------------------------------------------------------------- >> >--- -- >> > Download Intel® Parallel Studio Eval >> > Try the new software tools for yourself. Speed compiling, find bugs >> > proactively, and fine-tune applications for parallel performance. >> > See why Intel Parallel Studio got high marks during beta. >> > http://p.sf.net/sfu/intel-sw-dev >> > _______________________________________________ >> > Rails-devel mailing list >> > Rai...@li... >> > https://lists.sourceforge.net/lists/listinfo/rails-devel >> > >> > >> > ------------------------------------------------------------------------- >> >----- Download Intel® Parallel Studio Eval >> > Try the new software tools for yourself. Speed compiling, find bugs >> > proactively, and fine-tune applications for parallel performance. >> > See why Intel Parallel Studio got high marks during beta. >> > http://p.sf.net/sfu/intel-sw-dev >> > _______________________________________________ >> > Rails-devel mailing list >> > Rai...@li... >> > https://lists.sourceforge.net/lists/listinfo/rails-devel >> >> --------------------------------------------------------------------------- >>--- Download Intel® Parallel Studio Eval >> Try the new software tools for yourself. Speed compiling, find bugs >> proactively, and fine-tune applications for parallel performance. >> See why Intel Parallel Studio got high marks during beta. >> http://p.sf.net/sfu/intel-sw-dev >> _______________________________________________ >> Rails-devel mailing list >> Rai...@li... >> https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
|
From: Stefan F. <ste...@we...> - 2010-03-19 16:07:23
|
Erik: from the description alone I guess that this is caused by a bug fix of mine on the undo mechanism. Do you remember our discussion about the change from the postcondition check (which requires the use of state variables) for the done button to a precondition check (which avoids that). It seems that there is a case not covered in the 1856 repay loan action step yet, that does not set the doneAllowed variable. Thus it might be a good guess to check the preconditions there. I look forward to checking in my automated testing procedures which hopefully reduce those side-effects of refactoring. STefan On Friday 19 March 2010 16:10:49 brett lentz wrote: > ---------- Forwarded message ---------- > From: Arne Östlund <arn...@gl...> > Date: Thu, Mar 18, 2010 at 11:27 PM > Subject: Problem with Rails 1.2 > To: rai...@li... > > > Hi Brett/Erik > > We are playing an 1856 PBeM campaigne. Due to an error with Rails > 1.1.3 I tried to recreate our moves in Rail 1.2 to current status by > redo some turns. But when I repayed the Loans for LPS after an > withhold, one OR before the CGR formation, the game stalled. The only > option I got was to Undo. So we can not pass this state and continue > the game! > > /Arne Östlund |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X