Menu
▾
▴
rails-devel
|
From: Brett L. <wak...@gm...> - 2007-10-09 21:59:24
|
I've reworked a few things in the game setup UI. Firstly, I've renamed the Options class to GameSetupWindow. Options was just a bit too generic and didn't really represent what the class actually did. Second, I've reworked the New and Options button logic to better use Swing conventions and have removed the ActionStep state tracking mechanism. Lastly, I also committed a few other cleanups elsewhere. Mostly related to removing old commented-out code. ---Brett. Questions are never indiscreet, answers sometimes are. -- Oscar Wilde |
|
From: Brett L. <wak...@gm...> - 2007-10-10 00:19:29
|
On Tue, 2007-10-09 at 14:59 -0700, Brett Lentz wrote: > I've reworked a few things in the game setup UI. > > Firstly, I've renamed the Options class to GameSetupWindow. Options was > just a bit too generic and didn't really represent what the class > actually did. > > Second, I've reworked the New and Options button logic to better use > Swing conventions and have removed the ActionStep state tracking > mechanism. > > Lastly, I also committed a few other cleanups elsewhere. Mostly related > to removing old commented-out code. > > > ---Brett. > > > Questions are never indiscreet, answers sometimes are. > -- Oscar Wilde One more addition to the GameSetupWindow UI: The number of text boxes drawn is now dynamically adjusted based on the currently selected game's maximum number of players. There's still some issues with the sizing of individual UI elements, but that will get worked out in the near future. ---Brett. Real Time, adj.: Here and now, as opposed to fake time, which only occurs there and then. |
|
From: Brett L. <wak...@gm...> - 2007-10-10 18:45:24
|
On Tue, 2007-10-09 at 17:19 -0700, Brett Lentz wrote: > On Tue, 2007-10-09 at 14:59 -0700, Brett Lentz wrote: > > I've reworked a few things in the game setup UI. > > > > Firstly, I've renamed the Options class to GameSetupWindow. Options was > > just a bit too generic and didn't really represent what the class > > actually did. > > > > Second, I've reworked the New and Options button logic to better use > > Swing conventions and have removed the ActionStep state tracking > > mechanism. > > > > Lastly, I also committed a few other cleanups elsewhere. Mostly related > > to removing old commented-out code. > > > > > > ---Brett. > > > > > > Questions are never indiscreet, answers sometimes are. > > -- Oscar Wilde > > > > One more addition to the GameSetupWindow UI: The number of text boxes > drawn is now dynamically adjusted based on the currently selected game's > maximum number of players. > > There's still some issues with the sizing of individual UI elements, but > that will get worked out in the near future. > > > ---Brett. > > > Real Time, adj.: > Here and now, as opposed to fake time, which only occurs there and then. I believe I've fixed all of the sizing issues in GameSetupWindow. It's looking pretty good, if I do say so myself. :) ---Brett. Things equal to nothing else are equal to each other. |
|
From: Erik V. <eri...@hc...> - 2007-10-10 19:04:50
|
> I believe I've fixed all of the sizing issues in GameSetupWindow. > > It's looking pretty good, if I do say so myself. :) Yes, it does. But something seems wrong. If I press New Game, I get an error: java.lang.NullPointerException at rails.ui.swing.GameSetupWindow.startNewGame(GameSetupWindow.java:246) Not sure why. I had not changed my pre-filled default players Alice, Bob and Charlie. May I suggest to add a button (e.g. "Info") or some other device to show the current game's additional info, as included in the <Description> tag in GamesList.xml? I have just added some info (about a limitation) for 1830. Other games already had some text (1835 has the longest story right now). Erik. |
|
From: Brett L. <wak...@gm...> - 2007-10-10 19:41:09
|
On Wed, 2007-10-10 at 21:04 +0200, Erik Vos wrote: > > I believe I've fixed all of the sizing issues in GameSetupWindow. > > > > It's looking pretty good, if I do say so myself. :) > > Yes, it does. > > But something seems wrong. > If I press New Game, I get an error: > > java.lang.NullPointerException > at > rails.ui.swing.GameSetupWindow.startNewGame(GameSetupWindow.java:246) > Hmmm... Which game is selected at the time you hit New Game? Also, are the options visible, or not? > > May I suggest to add a button (e.g. "Info") or some other > device to show the current game's additional info, > as included in the <Description> tag in GamesList.xml? Yep, that's the next item on the to-do list. ---Brett. I always wake up at the crack of ice. -- Joe E. Lewis |
|
From: Erik V. <eri...@hc...> - 2007-10-10 21:57:51
|
> > But something seems wrong. > > If I press New Game, I get an error: > > > > java.lang.NullPointerException > > at > > > rails.ui.swing.GameSetupWindow.startNewGame(GameSetupWindow.java:246) > > > > Hmmm... Which game is selected at the time you hit New Game? Any game. > Also, are the options visible, or not? Does not matter. I suppose the main thing is, that I have not touched the player area. Just the three default names are there. Erik. |
|
From: Brett L. <wak...@gm...> - 2007-10-10 22:09:15
|
On Wed, 2007-10-10 at 23:58 +0200, Erik Vos wrote: > > > But something seems wrong. > > > If I press New Game, I get an error: > > > > > > java.lang.NullPointerException > > > at > > > > > rails.ui.swing.GameSetupWindow.startNewGame(GameSetupWindow.java:246) > > > > > > > Hmmm... Which game is selected at the time you hit New Game? > > Any game. > > > Also, are the options visible, or not? > > Does not matter. > > I suppose the main thing is, that I have not touched the player area. > Just the three default names are there. Ok, looking at the line that is in the error... it's the check that looks for if you've selected "Human" and have something in the name textbox. Can you make sure your drop-downs are set to Human and not None? ---Brett. I am the wandering glitch -- catch me if you can. |
|
From: Erik V. <eri...@hc...> - 2007-10-10 22:41:49
|
> Ok, looking at the line that is in the error... it's the check that > looks for if you've selected "Human" and have something in the name > textbox. > > Can you make sure your drop-downs are set to Human and not None? As it starts, the first 3 boxes (with default names) are "Human", and the rest is "None". No difference if I change all to "Human". Frankly, I don't see the point of these selection boxes. Why not remove them? AI players are way behind our horizon. Erik. |
|
From: Brett L. <wak...@gm...> - 2007-10-10 22:58:19
|
On Thu, 2007-10-11 at 00:42 +0200, Erik Vos wrote: > > Ok, looking at the line that is in the error... it's the check that > > looks for if you've selected "Human" and have something in the name > > textbox. > > > > Can you make sure your drop-downs are set to Human and not None? > > As it starts, the first 3 boxes (with default names) are "Human", > and the rest is "None". No difference if I change all to "Human". > > Frankly, I don't see the point of these selection boxes. > Why not remove them? AI players are way behind our horizon. AI is only a long way off because nobody has expressed interest in working on it. My hope is that by reserving some space in the UI for it, someone that is interested can see the desire for such a feature and fill it. I found the problem. I forgot to check for a null. The fix has been committed. ---Brett. A failure will not appear until a unit has passed final inspection. |
|
From: Erik V. <eri...@hc...> - 2007-10-11 18:37:38
|
> I found the problem. I forgot to check for a null. The fix has been > committed. Works fine now. Thanks, also for the Game Info. Erik. |
|
From: Brett L. <wak...@gm...> - 2007-10-11 00:06:04
|
On Wed, 2007-10-10 at 21:04 +0200, Erik Vos wrote: > May I suggest to add a button (e.g. "Info") or some other > device to show the current game's additional info, > as included in the <Description> tag in GamesList.xml? > > I have just added some info (about a limitation) for 1830. > Other games already had some text (1835 has the longest story right now). Game Notes button added. Also added dynamic toggling of the name textboxes. ---Brett. The trouble with being punctual is that people think you have nothing more important to do. |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X