rails-devel

[Rails-devel] Pullmanns etc.

[Erik V. <eri...@xs...>]

I think (or at least hope) that the reported 18EU Pullmann-related problems
have been fixed.

If a train is bought at the train limit and a Pullmann was owned since the
turn started, then a message "(discard Pullmann)" will be added to each
train buying option. (I'd liked to give that message once, at the top of the
dialog, but that turned out to be less easy to do).

I have checked that Save and Load now work correctly afterwards. I cannot
guarantee that this will work for "existing cases", i.e. old saved files
where such an action had already occurred, but it does work fine now for
"new cases".

---

I have also fixed two minor issues raised as Bugs in Sourceforge:

1. The 1851 map had for Birmingham an ordinary off-board tile as a stop-gap.
I have now created a new grey tile -1143 for that purpose.

2. All spaces and most other funny characters in NEXT_PLAYER saved file name
suffixes (i.e. player Names) are now replaced by underscores. Dashes and
periods are retained.

---

I do not plan any new work for the next release. We could wait a few more
days for new or updated bug reports, but from my POV release 1.1.3 can be
issued soon now.

Erik.

Re: [Rails-devel] Pullmanns etc.

[Phil D. <de...@gm...>]

Erik,

Thanks for the excellent work the last few weeks, I've just been
replaying my EU game from the game log in the current source build,
the following issues are definitely fixed from my testing perspective:

Discarding pullmans on phase transition
Pullmans reappearing after loading a saved game
Corporations buying stock from the pool in multiples
Incorrect player starting the minor exchange round

So that's all really great, the infinite trains issues when loading a
saved game is still present although at least this one is easy to get
round.  I'll have a hunt of this myself when I get more spare time as
well as finally getting started on things like the minor company info
etc.

Phil


2010/1/24 Erik Vos <eri...@xs...>:
> I think (or at least hope) that the reported 18EU Pullmann-related problems
> have been fixed.
>
> If a train is bought at the train limit and a Pullmann was owned since the
> turn started, then a message "(discard Pullmann)" will be added to each
> train buying option. (I'd liked to give that message once, at the top of the
> dialog, but that turned out to be less easy to do).
>
> I have checked that Save and Load now work correctly afterwards. I cannot
> guarantee that this will work for "existing cases", i.e. old saved files
> where such an action had already occurred, but it does work fine now for
> "new cases".
>
> ---
>
> I have also fixed two minor issues raised as Bugs in Sourceforge:
>
> 1. The 1851 map had for Birmingham an ordinary off-board tile as a stop-gap.
> I have now created a new grey tile -1143 for that purpose.
>
> 2. All spaces and most other funny characters in NEXT_PLAYER saved file name
> suffixes (i.e. player Names) are now replaced by underscores. Dashes and
> periods are retained.
>
> ---
>
> I do not plan any new work for the next release. We could wait a few more
> days for new or updated bug reports, but from my POV release 1.1.3 can be
> issued soon now.
>
> Erik.
>
>
> ------------------------------------------------------------------------------
> Throughout its 18-year history, RSA Conference consistently attracts the
> world's best and brightest in the field, creating opportunities for Conference
> attendees to learn about information security's most important issues through
> interactions with peers, luminaries and emerging and established companies.
> http://p.sf.net/sfu/rsaconf-dev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Pullmanns etc.

[Erik V. <eri...@xs...>]

OK, I can reproduce it and will have another look.
Erik.

-----Original Message-----
From: Phil Davies [mailto:de...@gm...] 
Sent: Monday 25 January 2010 16:39
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] Pullmanns etc.
(...)
So that's all really great, the infinite trains issues when loading a
saved game is still present although at least this one is easy to get
round.  I'll have a hunt of this myself when I get more spare time as
well as finally getting started on things like the minor company info
etc.

Re: [Rails-devel] Pullmanns etc.

[Phil D. <de...@gm...>]

Ahh, slight issue I've just noticed.  Pullmans that are discarded
appear to vanish into thin air and are discarded form the game, rather
than back to the pool where they should go.

Phil

2010/1/25 Erik Vos <eri...@xs...>:
> OK, I can reproduce it and will have another look.
> Erik.
>
> -----Original Message-----
> From: Phil Davies [mailto:de...@gm...]
> Sent: Monday 25 January 2010 16:39
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] Pullmanns etc.
> (...)
> So that's all really great, the infinite trains issues when loading a
> saved game is still present although at least this one is easy to get
> round.  I'll have a hunt of this myself when I get more spare time as
> well as finally getting started on things like the minor company info
> etc.
>
>
>
> ------------------------------------------------------------------------------
> The Planet: dedicated and managed hosting, cloud storage, colocation
> Stay online with enterprise data centers and the best network in the business
> Choose flexible plans and management services without long-term contracts
> Personal 24x7 support from experience hosting pros just a phone call away.
> http://p.sf.net/sfu/theplanet-com
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Pullmanns etc.

[Erik V. <eri...@xs...>]

Both train issues have been fixed.

The Pullmanns being discarded to to the scrapheap instead of the Pool was a
stupid mistake by me.

The problem with the second and subsequent copies of unlimited quantity
trains was a sequence problem.
I have been so stupid (again) to write the list of executed actions to the
save file as one large ArrayList object, in stead of as a series of single
action objects. 
The result is, that the whole list is deserialized and instances of all
their referenced objects are sought for in one fell swoop, before any action
has been executed. Each such train, however, is only created once its
predecessor is bought. As a result, these train objects stay null, which
causes the error.
The fix is to check the train reference in BuyTrain objects on each access,
and if null, instantiate it as yet.

It would have been much better to read/deserialize *and* execute the action
objects one by one.
But I cannot change that without making all old saved files (i.e. my entire
test set) unusable.

(and apologies to non-technical readers for the above gibberish)

Erik.


-----Original Message-----
From: Phil Davies [mailto:de...@gm...] 
Sent: Tuesday 26 January 2010 11:14
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] Pullmanns etc.

Ahh, slight issue I've just noticed.  Pullmans that are discarded
appear to vanish into thin air and are discarded form the game, rather
than back to the pool where they should go.

Phil

2010/1/25 Erik Vos <eri...@xs...>:
> OK, I can reproduce it and will have another look.
> Erik.
>
> -----Original Message-----
> From: Phil Davies [mailto:de...@gm...]
> Sent: Monday 25 January 2010 16:39
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] Pullmanns etc.
> (...)
> So that's all really great, the infinite trains issues when loading a
> saved game is still present although at least this one is easy to get
> round.  I'll have a hunt of this myself when I get more spare time as
> well as finally getting started on things like the minor company info
> etc.
>
>
>
>
----------------------------------------------------------------------------
--
> The Planet: dedicated and managed hosting, cloud storage, colocation
> Stay online with enterprise data centers and the best network in the
business
> Choose flexible plans and management services without long-term contracts
> Personal 24x7 support from experience hosting pros just a phone call away.
> http://p.sf.net/sfu/theplanet-com
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

----------------------------------------------------------------------------
--
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the
business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Pullmanns etc.

[Freek D. <sf_...@ma...>]

Erik Vos wrote:

> (and apologies to non-technical readers for the above gibberish)

Yummies. Technical Gibberish.

Regards,
Freek

Re: [Rails-devel] Pullmanns etc.

[Phil D. <de...@gm...>]

Presumably though, dealing with them sequentially might be a
performance hit on opening?

and I agree with Freek, technical gibberish is always fun to read :)

Thanks for all the fix work, sounds like 1.1.3 is shaping up to be pretty solid

Phil

2010/1/26 Erik Vos <eri...@xs...>:
> Both train issues have been fixed.
>
> The Pullmanns being discarded to to the scrapheap instead of the Pool was a
> stupid mistake by me.
>
> The problem with the second and subsequent copies of unlimited quantity
> trains was a sequence problem.
> I have been so stupid (again) to write the list of executed actions to the
> save file as one large ArrayList object, in stead of as a series of single
> action objects.
> The result is, that the whole list is deserialized and instances of all
> their referenced objects are sought for in one fell swoop, before any action
> has been executed. Each such train, however, is only created once its
> predecessor is bought. As a result, these train objects stay null, which
> causes the error.
> The fix is to check the train reference in BuyTrain objects on each access,
> and if null, instantiate it as yet.
>
> It would have been much better to read/deserialize *and* execute the action
> objects one by one.
> But I cannot change that without making all old saved files (i.e. my entire
> test set) unusable.
>
> (and apologies to non-technical readers for the above gibberish)
>
> Erik.
>
>
> -----Original Message-----
> From: Phil Davies [mailto:de...@gm...]
> Sent: Tuesday 26 January 2010 11:14
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] Pullmanns etc.
>
> Ahh, slight issue I've just noticed.  Pullmans that are discarded
> appear to vanish into thin air and are discarded form the game, rather
> than back to the pool where they should go.
>
> Phil
>
> 2010/1/25 Erik Vos <eri...@xs...>:
>> OK, I can reproduce it and will have another look.
>> Erik.
>>
>> -----Original Message-----
>> From: Phil Davies [mailto:de...@gm...]
>> Sent: Monday 25 January 2010 16:39
>> To: Development list for Rails: an 18xx game
>> Subject: Re: [Rails-devel] Pullmanns etc.
>> (...)
>> So that's all really great, the infinite trains issues when loading a
>> saved game is still present although at least this one is easy to get
>> round.  I'll have a hunt of this myself when I get more spare time as
>> well as finally getting started on things like the minor company info
>> etc.
>>
>>
>>
>>
> ----------------------------------------------------------------------------
> --
>> The Planet: dedicated and managed hosting, cloud storage, colocation
>> Stay online with enterprise data centers and the best network in the
> business
>> Choose flexible plans and management services without long-term contracts
>> Personal 24x7 support from experience hosting pros just a phone call away.
>> http://p.sf.net/sfu/theplanet-com
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>
>
> ----------------------------------------------------------------------------
> --
> The Planet: dedicated and managed hosting, cloud storage, colocation
> Stay online with enterprise data centers and the best network in the
> business
> Choose flexible plans and management services without long-term contracts
> Personal 24x7 support from experience hosting pros just a phone call away.
> http://p.sf.net/sfu/theplanet-com
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ------------------------------------------------------------------------------
> The Planet: dedicated and managed hosting, cloud storage, colocation
> Stay online with enterprise data centers and the best network in the business
> Choose flexible plans and management services without long-term contracts
> Personal 24x7 support from experience hosting pros just a phone call away.
> http://p.sf.net/sfu/theplanet-com
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>