From: Erik V. <eri...@xs...> - 2010-02-04 21:29:55
|
I have generalized Info/Privates to Info/Companies, now covering all types. The info displayed has also been extended. 1830 and 1835 are mostly done, other games remain to be done (volunteers?) Erik. |
From: Phil D. <de...@gm...> - 2010-02-05 01:18:52
|
I can do data for 1870, will be off the grid for about a week or so from tomorrow but I'll update before I go offline and will no doubt have time to plug stuff in whilst I'm away On 4 February 2010 21:29, Erik Vos <eri...@xs...> wrote: > I have generalized Info/Privates to Info/Companies, now covering all types. > The info displayed has also been extended. > 1830 and 1835 are mostly done, other games remain to be done (volunteers?) > > Erik. > > > ------------------------------------------------------------------------------ > The Planet: dedicated and managed hosting, cloud storage, colocation > Stay online with enterprise data centers and the best network in the business > Choose flexible plans and management services without long-term contracts > Personal 24x7 support from experience hosting pros just a phone call away. > http://p.sf.net/sfu/theplanet-com > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
From: Phil D. <de...@gm...> - 2010-02-15 12:53:13
Attachments:
patch.txt
|
Patch for 1870 longnames as well as adding/correcting some of the longnames in 18EU to match those given in the rulebook A lot of the private company bonus features from 1870 aren't implemented yet so I haven't bothered adding help text until we know how the implementation is going to work. Phil On 5 February 2010 01:18, Phil Davies <de...@gm...> wrote: > I can do data for 1870, will be off the grid for about a week or so > from tomorrow but I'll update before I go offline and will no doubt > have time to plug stuff in whilst I'm away > > On 4 February 2010 21:29, Erik Vos <eri...@xs...> wrote: >> I have generalized Info/Privates to Info/Companies, now covering all types. >> The info displayed has also been extended. >> 1830 and 1835 are mostly done, other games remain to be done (volunteers?) >> >> Erik. >> >> >> ------------------------------------------------------------------------------ >> The Planet: dedicated and managed hosting, cloud storage, colocation >> Stay online with enterprise data centers and the best network in the business >> Choose flexible plans and management services without long-term contracts >> Personal 24x7 support from experience hosting pros just a phone call away. >> http://p.sf.net/sfu/theplanet-com >> _______________________________________________ >> Rails-devel mailing list >> Rai...@li... >> https://lists.sourceforge.net/lists/listinfo/rails-devel >> > |
From: brett l. <bre...@gm...> - 2010-02-15 22:40:23
|
Applied. ---Brett. On Mon, Feb 15, 2010 at 4:46 AM, Phil Davies <de...@gm...> wrote: > Patch for 1870 longnames as well as adding/correcting some of the > longnames in 18EU to match those given in the rulebook > > A lot of the private company bonus features from 1870 aren't > implemented yet so I haven't bothered adding help text until we know > how the implementation is going to work. > > Phil > > On 5 February 2010 01:18, Phil Davies <de...@gm...> wrote: >> I can do data for 1870, will be off the grid for about a week or so >> from tomorrow but I'll update before I go offline and will no doubt >> have time to plug stuff in whilst I'm away >> >> On 4 February 2010 21:29, Erik Vos <eri...@xs...> wrote: >>> I have generalized Info/Privates to Info/Companies, now covering all types. >>> The info displayed has also been extended. >>> 1830 and 1835 are mostly done, other games remain to be done (volunteers?) >>> >>> Erik. >>> >>> >>> ------------------------------------------------------------------------------ >>> The Planet: dedicated and managed hosting, cloud storage, colocation >>> Stay online with enterprise data centers and the best network in the business >>> Choose flexible plans and management services without long-term contracts >>> Personal 24x7 support from experience hosting pros just a phone call away. >>> http://p.sf.net/sfu/theplanet-com >>> _______________________________________________ >>> Rails-devel mailing list >>> Rai...@li... >>> https://lists.sourceforge.net/lists/listinfo/rails-devel >>> >> > > ------------------------------------------------------------------------------ > SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, > Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW > http://p.sf.net/sfu/solaris-dev2dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > > |
From: Phil D. <de...@gm...> - 2010-02-22 16:48:11
Attachments:
patch.txt
|
Patch for 18AL longnames for companies The 'powers' for the M&C and NDY aren't in particularly clear English but I'm unsure exactly how the info menu is populated here. I'm assuming it's somewhere in LocalisedText.properties but couldn't totally work out where the existing companies are picking up their info from. Any pointers on where to put this information and I'll add it. Phil On 15 February 2010 22:40, brett lentz <bre...@gm...> wrote: > Applied. > > ---Brett. > > > > On Mon, Feb 15, 2010 at 4:46 AM, Phil Davies <de...@gm...> wrote: >> Patch for 1870 longnames as well as adding/correcting some of the >> longnames in 18EU to match those given in the rulebook >> >> A lot of the private company bonus features from 1870 aren't >> implemented yet so I haven't bothered adding help text until we know >> how the implementation is going to work. >> >> Phil >> >> On 5 February 2010 01:18, Phil Davies <de...@gm...> wrote: >>> I can do data for 1870, will be off the grid for about a week or so >>> from tomorrow but I'll update before I go offline and will no doubt >>> have time to plug stuff in whilst I'm away >>> >>> On 4 February 2010 21:29, Erik Vos <eri...@xs...> wrote: >>>> I have generalized Info/Privates to Info/Companies, now covering all types. >>>> The info displayed has also been extended. >>>> 1830 and 1835 are mostly done, other games remain to be done (volunteers?) >>>> >>>> Erik. >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> The Planet: dedicated and managed hosting, cloud storage, colocation >>>> Stay online with enterprise data centers and the best network in the business >>>> Choose flexible plans and management services without long-term contracts >>>> Personal 24x7 support from experience hosting pros just a phone call away. >>>> http://p.sf.net/sfu/theplanet-com >>>> _______________________________________________ >>>> Rails-devel mailing list >>>> Rai...@li... >>>> https://lists.sourceforge.net/lists/listinfo/rails-devel >>>> >>> >> >> ------------------------------------------------------------------------------ >> SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, >> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW >> http://p.sf.net/sfu/solaris-dev2dev >> _______________________________________________ >> Rails-devel mailing list >> Rai...@li... >> https://lists.sourceforge.net/lists/listinfo/rails-devel >> >> > > ------------------------------------------------------------------------------ > SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, > Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW > http://p.sf.net/sfu/solaris-dev2dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
From: Erik V. <eri...@xs...> - 2010-02-22 23:34:44
|
Patch for 18AL longnames for companies [EV] Applied. The 'powers' for the M&C and NDY aren't in particularly clear English but I'm unsure exactly how the info menu is populated here. I'm assuming it's somewhere in LocalisedText.properties but couldn't totally work out where the existing companies are picking up their info from. Any pointers on where to put this information and I'll add it. [EV] These are the return values of the getInfo() methods of NameTrains and SpecialTrainBuy. By default, these values are equal to the (by design not localized) toString() results (which are mainly meant for logging). So you might want to compose new localized return values of these getInfo() methods. |
From: Phil D. <de...@gm...> - 2010-02-23 15:04:29
Attachments:
patch.txt
|
Gave this one a shot, in several cases I found the local getInfo() was just pointing straight at the toMenu() method so I've done the same here. I also extended the description to include the value for the routes on the named trains and the full name for the destinations. One thing that might be an issue is the text for SpecialTrainBuy which states 'Close {private} to purchase...' This would be incorrect if there is an 18XX game out there that had train discounts that didn't close the private. I am unaware whether or not such a game exists so this might need further clarification if this is the case. Phil On 22 February 2010 23:34, Erik Vos <eri...@xs...> wrote: > > Patch for 18AL longnames for companies > > [EV] Applied. > > The 'powers' for the M&C and NDY aren't in particularly clear English > but I'm unsure exactly how the info menu is populated here. I'm > assuming it's somewhere in LocalisedText.properties but couldn't > totally work out where the existing companies are picking up their > info from. > > Any pointers on where to put this information and I'll add it. > > [EV] These are the return values of the getInfo() methods of NameTrains and > SpecialTrainBuy. > By default, these values are equal to the (by design not localized) > toString() results (which are mainly meant for logging). > So you might want to compose new localized return values of these getInfo() > methods. > > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
From: Erik V. <eri...@xs...> - 2010-02-23 20:23:59
|
Gave this one a shot, in several cases I found the local getInfo() was just pointing straight at the toMenu() method so I've done the same here. I also extended the description to include the value for the routes on the named trains and the full name for the destinations. [EV] Equalizing toMenu() and getInfo() can be an easy shortcut, and it reduces the number of LocalizedText entries (which is a Good Thing). But it does not work if the info gets long (3 lines in this case). And to make it worse, this special property now shows up *twice* in the Special menu for the company owning M&C (not sure why). In any case, toMenu() should produce a sensible and not overly long one-liner. One thing that might be an issue is the text for SpecialTrainBuy which states 'Close {private} to purchase...' This would be incorrect if there is an 18XX game out there that had train discounts that didn't close the private. I am unaware whether or not such a game exists so this might need further clarification if this is the case. [EV] The worst thing about this text is, that you put the side effect (closing the private) at the front, where the main purpose (buying a cheap train) should be. So I would suggest something like "Purchase.... (closing <private>)". Also, you haven't localized "any". I'm also unaware of any other cases (which proves nothing). We can always refine if such a case would show up later. [EV] Want to try another shot? Erik. |
From: Erik V. <eri...@xs...> - 2010-02-23 21:06:44
|
"And to make it worse, this special property now shows up *twice* in the Special menu for the company owning M&C (not sure why)." Apologies, that wasn't your fault, but an existing bug (which I have now fixed). Erik. |
From: Phil D. <de...@gm...> - 2010-02-28 22:06:06
|
On 23 February 2010 20:23, Erik Vos <eri...@xs...> wrote: > Gave this one a shot, in several cases I found the local getInfo() was > just pointing straight at the toMenu() method so I've done the same > here. I also extended the description to include the value for the > routes on the named trains and the full name for the destinations. > > [EV] Equalizing toMenu() and getInfo() can be an easy shortcut, and it > reduces the number of LocalizedText entries (which is a Good Thing). But it > does not work if the info gets long (3 lines in this case). And to make it > worse, this special property now shows up *twice* in the Special menu for > the company owning M&C (not sure why). > In any case, toMenu() should produce a sensible and not overly long > one-liner. Where does the toMenu() get called? the info menu is a menu in and of itself, so I wsn't entirely sure on the difference. I'll certainly clear that back to one line and in this case produce different versions for the train naming I think. > One thing that might be an issue is the text for SpecialTrainBuy which > states 'Close {private} to purchase...' This would be incorrect if > there is an 18XX game out there that had train discounts that didn't > close the private. I am unaware whether or not such a game exists so > this might need further clarification if this is the case. > > [EV] The worst thing about this text is, that you put the side effect > (closing the private) at the front, where the main purpose (buying a cheap > train) should be. So I would suggest something like "Purchase.... (closing > <private>)". Hmm, Interesting, I think it depends whether you view closing the private as a cost or a consequence. In some games (not talking 18XX here, just generic boardgames) you would often see powers listed as: Cost: benefit So I immediately think of things in these terms (I close the private, that allows me to buy a train cheaply) rather than closing the private being a consequence of choosing to buy a cheap train. I think this comes down to a personal choice but I can appreciate your thinking on this. We should be emphasising the benefit instead of the detriment so this should get switched round. > Also, you haven't localized "any". Very valid point...was trying to think of a cute way of doing this and obviously failed :p > I'm also unaware of any other cases (which proves nothing). We can always > refine if such a case would show up later. > [EV] Want to try another shot? As long as you don't mind me bothering you for feedback, I'll get a chance to play with this during the week hopefully. Phil |
From: Erik V. <eri...@xs...> - 2010-02-28 23:35:50
|
Where does the toMenu() get called? [EV] When building an entry for the 'Special' menu. See StatusWindow line 400. This should be a localized text, but in many cases it isn't yet. Erik. |
From: Phil D. <de...@gm...> - 2010-03-02 14:51:12
Attachments:
patch.txt
|
Hows this, dropped to toMenu back to one line (and updated ORUIManager which was using the getInfo not the toMenu to populate the special menu, leading it to still use the longer description) Altered the LocalisedText to place closing the private as a consequence and added a second entry to handle the 'any' discount over a specific discount (there is probably a neater way to do that :p) It occurred to me looking at this that putting the privates income on the info menu would be a good idea, but I'll do that separately. Phil On 28 February 2010 23:35, Erik Vos <eri...@xs...> wrote: > Where does the toMenu() get called? > > [EV] When building an entry for the 'Special' menu. See StatusWindow line > 400. > This should be a localized text, but in many cases it isn't yet. > > Erik. > > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
From: Erik V. <eri...@xs...> - 2010-03-02 22:30:38
|
OK, I have applied and committed this patch. Thanks! Erik. -----Original Message----- From: Phil Davies [mailto:de...@gm...] Sent: Tuesday 02 March 2010 15:51 To: Development list for Rails: an 18xx game Subject: Re: [Rails-devel] Info Hows this, dropped to toMenu back to one line (and updated ORUIManager which was using the getInfo not the toMenu to populate the special menu, leading it to still use the longer description) Altered the LocalisedText to place closing the private as a consequence and added a second entry to handle the 'any' discount over a specific discount (there is probably a neater way to do that :p) It occurred to me looking at this that putting the privates income on the info menu would be a good idea, but I'll do that separately. Phil On 28 February 2010 23:35, Erik Vos <eri...@xs...> wrote: > Where does the toMenu() get called? > > [EV] When building an entry for the 'Special' menu. See StatusWindow line > 400. > This should be a localized text, but in many cases it isn't yet. > > Erik. > > > ---------------------------------------------------------------------------- -- > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |