rails-devel

[Rails-devel] Getting started

[Jeff B. <jef...@gm...>]

Greetings all.  I downloaded Rails today to take a look at it and I can see
that you've put in a lot of work.  I'm interested in contributing, and while
I am an experienced programmer, I haven't used Java before and I haven't
worked on an open source project.

Anyway, I installed Eclipse, downloaded the rails source, looked around a
bit, found a bug and fixed it.  Now what?

The change is very minor.  On the 1870 map, hex H3 should be a small city
hex.

Re: [Rails-devel] Getting started

[Brett L. <wak...@gm...>]

On Tue, 2008-02-12 at 16:51 -0700, Jeff Bowers wrote:
> Greetings all.  I downloaded Rails today to take a look at it and I
> can see that you've put in a lot of work.  I'm interested in
> contributing, and while I am an experienced programmer, I haven't used
> Java before and I haven't worked on an open source project.
> 
> Anyway, I installed Eclipse, downloaded the rails source, looked
> around a bit, found a bug and fixed it.  Now what?
> 
> The change is very minor.  On the 1870 map, hex H3 should be a small
> city hex.


Welcome aboard Jeff!

You're definitely on the right track. While you're getting familiar with
the codebase, please try to focus on fixing small-ish issues. 

For the first few changes, please send patches to the list. Unified diff
is the preferred format. Breaking up changes into logical chunks is also
recommended.

As soon as we've seen a few sets of patches from you, we can talk about
giving you direct commit access and letting you drive a bigger segment
of the changes. To give a tangible goal, I personally like to see at
least 3-5 patches.


 ---Brett.


Machines certainly can solve problems, store information, correlate,
and play games -- but not with pleasure.
		-- Leo Rosten

Re: [Rails-devel] Getting started

[Erik V. <eri...@hc...>]

Welcome Jeff!

I have just committed a bunch of changes, mostly related to the 18EU start
round.
As usual, this has had some consequences in various places,
so please refresh your sources before you start updating
(but I haven't touched the 1870 map).

A general warning for Jeff and others: the main goal behind
all I'm doing is still trying to get the basic program design right.
That is why I'm currently mostly working on implementing new games
that have different mechanics than the ones we've already done.
Fitting in new features often enforces rethinking various design
aspects, to make it ever more generic.

Although we have already gone a long way, the above still means that
the code base is not yet as stable as we would like it to be.
So be warned: often check for updates (I'm saying this to myself as well!).

Erik.


> -----Original Message-----
> From: rai...@li... 
> [mailto:rai...@li...] On Behalf 
> Of Brett Lentz
> Sent: Wednesday 13 February 2008 01:54
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] Getting started
> 
> 
> On Tue, 2008-02-12 at 16:51 -0700, Jeff Bowers wrote:
> > Greetings all.  I downloaded Rails today to take a look at it and I
> > can see that you've put in a lot of work.  I'm interested in
> > contributing, and while I am an experienced programmer, I 
> haven't used
> > Java before and I haven't worked on an open source project.
> > 
> > Anyway, I installed Eclipse, downloaded the rails source, looked
> > around a bit, found a bug and fixed it.  Now what?
> > 
> > The change is very minor.  On the 1870 map, hex H3 should be a small
> > city hex.
> 
> 
> Welcome aboard Jeff!
> 
> You're definitely on the right track. While you're getting 
> familiar with
> the codebase, please try to focus on fixing small-ish issues. 
> 
> For the first few changes, please send patches to the list. 
> Unified diff
> is the preferred format. Breaking up changes into logical 
> chunks is also
> recommended.
> 
> As soon as we've seen a few sets of patches from you, we can 
> talk about
> giving you direct commit access and letting you drive a bigger segment
> of the changes. To give a tangible goal, I personally like to see at
> least 3-5 patches.
> 
> 
>  ---Brett.
> 
> 
> Machines certainly can solve problems, store information, correlate,
> and play games -- but not with pleasure.
> 		-- Leo Rosten
> 
> 
> --------------------------------------------------------------
> -----------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 

Re: [Rails-devel] Getting started

[Jeff B. <jef...@gm...>]

My question is then, what would you like people to work on?  I'd like to get
1870 up and running.  Is that compatible with your current efforts, or is it
something better left for later

On Feb 13, 2008 1:19 PM, Erik Vos <eri...@hc...> wrote:

> Welcome Jeff!
>
> I have just committed a bunch of changes, mostly related to the 18EU start
> round.
> As usual, this has had some consequences in various places,
> so please refresh your sources before you start updating
> (but I haven't touched the 1870 map).
>
> A general warning for Jeff and others: the main goal behind
> all I'm doing is still trying to get the basic program design right.
> That is why I'm currently mostly working on implementing new games
> that have different mechanics than the ones we've already done.
> Fitting in new features often enforces rethinking various design
> aspects, to make it ever more generic.
>
> Although we have already gone a long way, the above still means that
> the code base is not yet as stable as we would like it to be.
> So be warned: often check for updates (I'm saying this to myself as
> well!).
>
> Erik.
>
>
> > -----Original Message-----
> > From: rai...@li...
> > [mailto:rai...@li...] On Behalf
> > Of Brett Lentz
> > Sent: Wednesday 13 February 2008 01:54
> > To: Development list for Rails: an 18xx game
> > Subject: Re: [Rails-devel] Getting started
> >
> >
> > On Tue, 2008-02-12 at 16:51 -0700, Jeff Bowers wrote:
> > > Greetings all.  I downloaded Rails today to take a look at it and I
> > > can see that you've put in a lot of work.  I'm interested in
> > > contributing, and while I am an experienced programmer, I
> > haven't used
> > > Java before and I haven't worked on an open source project.
> > >
> > > Anyway, I installed Eclipse, downloaded the rails source, looked
> > > around a bit, found a bug and fixed it.  Now what?
> > >
> > > The change is very minor.  On the 1870 map, hex H3 should be a small
> > > city hex.
> >
> >
> > Welcome aboard Jeff!
> >
> > You're definitely on the right track. While you're getting
> > familiar with
> > the codebase, please try to focus on fixing small-ish issues.
> >
> > For the first few changes, please send patches to the list.
> > Unified diff
> > is the preferred format. Breaking up changes into logical
> > chunks is also
> > recommended.
> >
> > As soon as we've seen a few sets of patches from you, we can
> > talk about
> > giving you direct commit access and letting you drive a bigger segment
> > of the changes. To give a tangible goal, I personally like to see at
> > least 3-5 patches.
> >
> >
> >  ---Brett.
> >
> >
> > Machines certainly can solve problems, store information, correlate,
> > and play games -- but not with pleasure.
> >               -- Leo Rosten
> >
> >
> > --------------------------------------------------------------
> > -----------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Getting started

[Brett L. <wak...@gm...>]

On Wed, 2008-02-13 at 13:30 -0700, Jeff Bowers wrote:
> My question is then, what would you like people to work on?  I'd like
> to get 1870 up and running.  Is that compatible with your current
> efforts, or is it something better left for later


I have no objection to having you work on 1870. Adding new games is a
great place to start. Just remember to keep as much of the game's
mechanics as generic and reusable as possible. Things like price
protection are needed for many games beyond 1870.

Also, here's some other bits that need love, in no particular order:

* Token placement (especially wrt OO cities).
* Map drawing. Resizing the map is currently broken.
* Route calculation (BIG PROJECT) 



 ---Brett.


No one regards what is before his feet; we all gaze at the stars.
		-- Quintus Ennius

Re: [Rails-devel] Getting started

[Erik V. <eri...@hc...>]

> On Wed, 2008-02-13 at 13:30 -0700, Jeff Bowers wrote:
> > My question is then, what would you like people to work on? 
>  I'd like
> > to get 1870 up and running.  Is that compatible with your current
> > efforts, or is it something better left for later
> 
> 
> I have no objection to having you work on 1870. Adding new games is a
> great place to start. Just remember to keep as much of the game's
> mechanics as generic and reusable as possible. Things like price
> protection are needed for many games beyond 1870.

You might want to start with configuring the private special properties
in data/1870/CompanyManager.xml.

I suppose that all special properties (except the Bridgeone ) can be 
implemented by just adding XML. Look at the 18AL S&NA private for how 
to configure the bonus tokens (cattle and shipping).
(N.B. The existing "tokens" and "tokenValue" attributes in the XML 
of these privates should be removed and replaced by the SpecialProperty
tags).

The Bridge will require new Java code, as well as all the restrictions
around the Mississippi.

Erik.