rails-devel

Re: [Rails-devel] Corrections to Loading Game from Command Line

[Erik V. <eri...@xs...>]

Hi Adam,

 

Thanks for your fix. I haved applied it, except:

- the removed space in GameSetupWindow: cosmetic only.

- the qualifier in java.lang.String, which is completely redundant (I have left in your two other qualifiers, though, which at least save an import.  But we normally don’t use any qualifiers).

- the unused import of InvocationTargetException.

 

For now sending patches is the way to go.  Once you have gained a reputation of sending good patches, you will get commit access.

 

Erik.

 

Van: Adam Badura [mailto:ab...@o2...] 
Verzonden: zaterdag 22 januari 2011 2:07
Aan: rai...@li...
Onderwerp: [Rails-devel] Corrections to Loading Game from Command Line

 

    The attachement contains an SVN Patch (done on trunk/18xx) correcting two errors associated with loading game from command line argument passed to the application:

 

1) After such load File | Save command (and possibly others as well) crushed with NullPointerException due to log4j NDC not containing game key. This was caused by NDC being initialized in main thread during application startup rather then in AWT-EventsQueue thread as it happend during normal application opening and loading game through Load Game button.

 

2) A save path is associated with the game just as if the game was loaded using Load Game button.

 

 

    Do you accept those corrections? Should I commit them? What do I require to commit them? (On SourceForge my user name is "adambadura” just in case...)

 

    Adam Badura

Re: [Rails-devel] Corrections to Loading Game from Command Line

[Adam B. <ab...@o2...>]

    The imports are result of mishandling Eclipse. I am not used to it yet (and on the search how to switch short-cuts to Windows-style...) Sorry for that.
    I personaly do cosmetic changes if they make code styl consistent but its your call.

    Now I was thinking of a redesign of initial window. So that the application lists recently opened games for example. What do you think of it?

    Adam Badura

From: Erik Vos 
Sent: Saturday, January 22, 2011 4:36 PM
To: 'Development list for Rails: an 18xx game' 
Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

Hi Adam,

 

Thanks for your fix. I haved applied it, except:

- the removed space in GameSetupWindow: cosmetic only.

- the qualifier in java.lang.String, which is completely redundant (I have left in your two other qualifiers, though, which at least save an import.  But we normally don’t use any qualifiers).

- the unused import of InvocationTargetException.

 

For now sending patches is the way to go.  Once you have gained a reputation of sending good patches, you will get commit access.

 

Erik.

 

Van: Adam Badura [mailto:ab...@o2...] 
Verzonden: zaterdag 22 januari 2011 2:07
Aan: rai...@li...
Onderwerp: [Rails-devel] Corrections to Loading Game from Command Line

 

    The attachement contains an SVN Patch (done on trunk/18xx) correcting two errors associated with loading game from command line argument passed to the application:

 

1) After such load File | Save command (and possibly others as well) crushed with NullPointerException due to log4j NDC not containing game key. This was caused by NDC being initialized in main thread during application startup rather then in AWT-EventsQueue thread as it happend during normal application opening and loading game through Load Game button.

 

2) A save path is associated with the game just as if the game was loaded using Load Game button.

 

 

    Do you accept those corrections? Should I commit them? What do I require to commit them? (On SourceForge my user name is "adambadura” just in case...)

 

    Adam Badura



--------------------------------------------------------------------------------
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 


--------------------------------------------------------------------------------
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Corrections to Loading Game from Command Line

[Chris S. <chr...@gm...>]

What do you mean by "recently opened games"?  In play by email, the program
appends a player name and timestamp to the filename.  Would you be able to
set it up to search the directories where games were previously saved, find
the most recent timestamped file with the appropriate base filename, and
list that?

--
Chris

Please consider the environment before printing this e-mail.


On Sat, Jan 22, 2011 at 7:40 AM, Adam Badura <ab...@o2...> wrote:

>       The imports are result of mishandling Eclipse. I am not used to it
> yet (and on the search how to switch short-cuts to Windows-style...) Sorry
> for that.
>     I personaly do cosmetic changes if they make code styl consistent but
> its your call.
>
>     Now I was thinking of a redesign of initial window. So that the
> application lists recently opened games for example. What do you think of
> it?
>
>     Adam Badura
>
>  *From:* Erik Vos <eri...@xs...>
> *Sent:* Saturday, January 22, 2011 4:36 PM
> *To:* 'Development list for Rails: an 18xx game'<rai...@li...>
> *Subject:* Re: [Rails-devel] Corrections to Loading Game from Command Line
>
>
> Hi Adam,
>
>
>
> Thanks for your fix. I haved applied it, except:
>
> - the removed space in GameSetupWindow: cosmetic only.
>
> - the qualifier in *java.lang.*String, which is completely redundant (I
> have left in your two other qualifiers, though, which at least save an
> import.  But we normally don’t use any qualifiers).
>
> - the unused import of InvocationTargetException.
>
>
>
> For now sending patches is the way to go.  Once you have gained a
> reputation of sending good patches, you will get commit access.
>
>
>
> Erik.
>
>
>
> *Van:* Adam Badura [mailto:ab...@o2...]
> *Verzonden:* zaterdag 22 januari 2011 2:07
> *Aan:* rai...@li...
> *Onderwerp:* [Rails-devel] Corrections to Loading Game from Command Line
>
>
>
>     The attachement contains an SVN Patch (done on trunk/18xx) correcting
> two errors associated with loading game from command line argument passed to
> the application:
>
>
>
> 1) After such load File | Save command (and possibly others as well)
> crushed with NullPointerException due to log4j NDC not containing game key.
> This was caused by NDC being initialized in main thread during application
> startup rather then in AWT-EventsQueue thread as it happend during normal
> application opening and loading game through Load Game button.
>
>
>
> 2) A save path is associated with the game just as if the game was loaded
> using Load Game button.
>
>
>
>
>
>     Do you accept those corrections? Should I commit them? What do I
> require to commit them? (On SourceForge my user name is "adambadura” just in
> case...)
>
>
>
>     Adam Badura
>
> ------------------------------
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
>
> ------------------------------
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>

Re: [Rails-devel] Corrections to Loading Game from Command Line

[Erik V. <eri...@xs...>]

A "recent files" item would be very useful, at least for me for the purpose
of testing. But IMO it should not use filenames, but the file system
last-changed timestamps.  The filenames can be changed on saving, and that
is what I usually do; example '18EU_OR1.rails' for a saved 18EU game at the
start of OR 1.

 

But the most important question perhaps is whether or not we can stand the
slowdown caused by creating such a "recent files" list.

 

Erik.

 

Van: Chris Shaffer [mailto:chr...@gm...] 
Verzonden: zaterdag 22 januari 2011 19:28
Aan: Development list for Rails: an 18xx game
Onderwerp: Re: [Rails-devel] Corrections to Loading Game from Command Line

 

What do you mean by "recently opened games"?  In play by email, the program
appends a player name and timestamp to the filename.  Would you be able to
set it up to search the directories where games were previously saved, find
the most recent timestamped file with the appropriate base filename, and
list that?


--
Chris

Please consider the environment before printing this e-mail.



On Sat, Jan 22, 2011 at 7:40 AM, Adam Badura <ab...@o2...> wrote:

    The imports are result of mishandling Eclipse. I am not used to it yet
(and on the search how to switch short-cuts to Windows-style...) Sorry for
that.

    I personaly do cosmetic changes if they make code styl consistent but
its your call.

 

    Now I was thinking of a redesign of initial window. So that the
application lists recently opened games for example. What do you think of
it?

 

    Adam Badura

 

From: Erik Vos <mailto:eri...@xs...>  

Sent: Saturday, January 22, 2011 4:36 PM

To: 'Development list for Rails: an 18xx game'
<mailto:rai...@li...>  

Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

 

Hi Adam,

 

Thanks for your fix. I haved applied it, except:

- the removed space in GameSetupWindow: cosmetic only.

- the qualifier in java.lang.String, which is completely redundant (I have
left in your two other qualifiers, though, which at least save an import.
But we normally don't use any qualifiers).

- the unused import of InvocationTargetException.

 

For now sending patches is the way to go.  Once you have gained a reputation
of sending good patches, you will get commit access.

 

Erik.

 

Van: Adam Badura [mailto:ab...@o2...] 
Verzonden: zaterdag 22 januari 2011 2:07
Aan: rai...@li...
Onderwerp: [Rails-devel] Corrections to Loading Game from Command Line

 

    The attachement contains an SVN Patch (done on trunk/18xx) correcting
two errors associated with loading game from command line argument passed to
the application:

 

1) After such load File | Save command (and possibly others as well) crushed
with NullPointerException due to log4j NDC not containing game key. This was
caused by NDC being initialized in main thread during application startup
rather then in AWT-EventsQueue thread as it happend during normal
application opening and loading game through Load Game button.

 

2) A save path is associated with the game just as if the game was loaded
using Load Game button.

 

 

    Do you accept those corrections? Should I commit them? What do I require
to commit them? (On SourceForge my user name is "adambadura" just in
case...)

 

    Adam Badura

  _____  

----------------------------------------------------------------------------
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 

  _____  

_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel


----------------------------------------------------------------------------
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

 

Re: [Rails-devel] Corrections to Loading Game from Command Line

[Adam B. <ab...@o2...>]

    I thought that maybe if user opens a game from a file and then save it under a different name then the original name is removed from MRU and the new one is added. This could be even enhanced that all the saved names are added in case user saves the game several times (this supports my way of saving: we play in one file and do a snapshot after each full round).
    Other solutions which I thought of were:
    Save some info with the game file, at beast at the start of the file and then use it to fine most “recent” file among series (it is all files from a single game would share a common id, GUID or something like that).
    Or base on smae naming patterns.
    But both seemed complex and fregile.
    How do you see that with time-stamps?
    Adam Badura
From: Erik Vos 
Sent: Sunday, January 23, 2011 8:51 PM
To: 'Development list for Rails: an 18xx game' 
Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

A “recent files” item would be very useful, at least for me for the purpose of testing. But IMO it should not use filenames, but the file system last-changed timestamps.  The filenames can be changed on saving, and that is what I usually do; example ‘18EU_OR1.rails’ for a saved 18EU game at the start of OR 1.

 

But the most important question perhaps is whether or not we can stand the slowdown caused by creating such a “recent files” list.

 

Erik.

 

Van: Chris Shaffer [mailto:chr...@gm...] 
Verzonden: zaterdag 22 januari 2011 19:28
Aan: Development list for Rails: an 18xx game
Onderwerp: Re: [Rails-devel] Corrections to Loading Game from Command Line

 

What do you mean by "recently opened games"?  In play by email, the program appends a player name and timestamp to the filename.  Would you be able to set it up to search the directories where games were previously saved, find the most recent timestamped file with the appropriate base filename, and list that?


--
Chris

Please consider the environment before printing this e-mail.



On Sat, Jan 22, 2011 at 7:40 AM, Adam Badura <ab...@o2...> wrote:

    The imports are result of mishandling Eclipse. I am not used to it yet (and on the search how to switch short-cuts to Windows-style...) Sorry for that.

    I personaly do cosmetic changes if they make code styl consistent but its your call.

 

    Now I was thinking of a redesign of initial window. So that the application lists recently opened games for example. What do you think of it?

 

    Adam Badura

 

From: Erik Vos 

Sent: Saturday, January 22, 2011 4:36 PM

To: 'Development list for Rails: an 18xx game' 

Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

 

Hi Adam,

 

Thanks for your fix. I haved applied it, except:

- the removed space in GameSetupWindow: cosmetic only.

- the qualifier in java.lang.String, which is completely redundant (I have left in your two other qualifiers, though, which at least save an import.  But we normally don’t use any qualifiers).

- the unused import of InvocationTargetException.

 

For now sending patches is the way to go.  Once you have gained a reputation of sending good patches, you will get commit access.

 

Erik.

 

Van: Adam Badura [mailto:ab...@o2...] 
Verzonden: zaterdag 22 januari 2011 2:07
Aan: rai...@li...
Onderwerp: [Rails-devel] Corrections to Loading Game from Command Line

 

    The attachement contains an SVN Patch (done on trunk/18xx) correcting two errors associated with loading game from command line argument passed to the application:

 

1) After such load File | Save command (and possibly others as well) crushed with NullPointerException due to log4j NDC not containing game key. This was caused by NDC being initialized in main thread during application startup rather then in AWT-EventsQueue thread as it happend during normal application opening and loading game through Load Game button.

 

2) A save path is associated with the game just as if the game was loaded using Load Game button.

 

 

    Do you accept those corrections? Should I commit them? What do I require to commit them? (On SourceForge my user name is "adambadura” just in case...)

 

    Adam Badura


--------------------------------------------------------------------------------

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 


--------------------------------------------------------------------------------

_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel


------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

 



--------------------------------------------------------------------------------
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 


--------------------------------------------------------------------------------
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Corrections to Loading Game from Command Line

[Erik V. <eri...@xs...>]

I can’t quite follow you.

 

I guess that “MRU” means “most recently used”. Are you proposing to save and maintain an “MRU” list in some special file?

That would be a possibility.

 

I was thinking to scan the contents of the save directory tree, and sort the lastModified() results of the  leafs.

Of course, keeping the results of such a search in a special file would speed up a lot, but I’m not convinced that such a file will remain in sync eternally, so we’ll have to rebuild it every now and then.

 

Erik.

 

Van: Adam Badura [mailto:ab...@o2...] 
Verzonden: zondag 23 januari 2011 22:19
Aan: Development list for Rails: an 18xx game
Onderwerp: Re: [Rails-devel] Corrections to Loading Game from Command Line

 

    I thought that maybe if user opens a game from a file and then save it under a different name then the original name is removed from MRU and the new one is added. This could be even enhanced that all the saved names are added in case user saves the game several times (this supports my way of saving: we play in one file and do a snapshot after each full round).

    Other solutions which I thought of were:

    Save some info with the game file, at beast at the start of the file and then use it to fine most “recent” file among series (it is all files from a single game would share a common id, GUID or something like that).

    Or base on smae naming patterns.

    But both seemed complex and fregile.

 

    How do you see that with time-stamps?

 

    Adam Badura

From: Erik Vos <mailto:eri...@xs...>  

Sent: Sunday, January 23, 2011 8:51 PM

To: 'Development list for Rails: an 18xx game' <mailto:rai...@li...>  

Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

 

A “recent files” item would be very useful, at least for me for the purpose of testing. But IMO it should not use filenames, but the file system last-changed timestamps.  The filenames can be changed on saving, and that is what I usually do; example ‘18EU_OR1.rails’ for a saved 18EU game at the start of OR 1.

 

But the most important question perhaps is whether or not we can stand the slowdown caused by creating such a “recent files” list.

 

Erik.

 

Van: Chris Shaffer [mailto:chr...@gm...] 
Verzonden: zaterdag 22 januari 2011 19:28
Aan: Development list for Rails: an 18xx game
Onderwerp: Re: [Rails-devel] Corrections to Loading Game from Command Line

 

What do you mean by "recently opened games"?  In play by email, the program appends a player name and timestamp to the filename.  Would you be able to set it up to search the directories where games were previously saved, find the most recent timestamped file with the appropriate base filename, and list that?


--
Chris

Please consider the environment before printing this e-mail.

On Sat, Jan 22, 2011 at 7:40 AM, Adam Badura <ab...@o2...> wrote:

    The imports are result of mishandling Eclipse. I am not used to it yet (and on the search how to switch short-cuts to Windows-style...) Sorry for that.

    I personaly do cosmetic changes if they make code styl consistent but its your call.

 

    Now I was thinking of a redesign of initial window. So that the application lists recently opened games for example. What do you think of it?

 

    Adam Badura

 

From: Erik Vos <mailto:eri...@xs...>  

Sent: Saturday, January 22, 2011 4:36 PM

To: 'Development list for Rails: an 18xx game' <mailto:rai...@li...>  

Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

 

Hi Adam,

 

Thanks for your fix. I haved applied it, except:

- the removed space in GameSetupWindow: cosmetic only.

- the qualifier in java.lang.String, which is completely redundant (I have left in your two other qualifiers, though, which at least save an import.  But we normally don’t use any qualifiers).

- the unused import of InvocationTargetException.

 

For now sending patches is the way to go.  Once you have gained a reputation of sending good patches, you will get commit access.

 

Erik.

 

Van: Adam Badura [mailto:ab...@o2...] 
Verzonden: zaterdag 22 januari 2011 2:07
Aan: rai...@li...
Onderwerp: [Rails-devel] Corrections to Loading Game from Command Line

 

    The attachement contains an SVN Patch (done on trunk/18xx) correcting two errors associated with loading game from command line argument passed to the application:

 

1) After such load File | Save command (and possibly others as well) crushed with NullPointerException due to log4j NDC not containing game key. This was caused by NDC being initialized in main thread during application startup rather then in AWT-EventsQueue thread as it happend during normal application opening and loading game through Load Game button.

 

2) A save path is associated with the game just as if the game was loaded using Load Game button.

 

 

    Do you accept those corrections? Should I commit them? What do I require to commit them? (On SourceForge my user name is "adambadura” just in case...)

 

    Adam Badura

  _____  

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 

  _____  

_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel


------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

 

  _____  

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 

  _____  

_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Corrections to Loading Game from Command Line

[<ab...@o2...>]

    Yes. MRU means Most Recently Used, a common short-cut on Windows platform (or at least I think so... ;)).

    And yes I wanted to store it in a config file, or something similar.

    Looking at the modification dates only could be very tricky if user stores different games in the same folder (and distinguishes them by a name prefix for example). But would possibly go well with receiving a differently named file from someone else (like you and Phile already mentioned).

    Adam Badura

From: Erik Vos 
Sent: Monday, January 24, 2011 12:27 AM
To: 'Development list for Rails: an 18xx game' 
Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

I can’t quite follow you.

 

I guess that “MRU” means “most recently used”. Are you proposing to save and maintain an “MRU” list in some special file?

That would be a possibility.

 

I was thinking to scan the contents of the save directory tree, and sort the lastModified() results of the  leafs.

Of course, keeping the results of such a search in a special file would speed up a lot, but I’m not convinced that such a file will remain in sync eternally, so we’ll have to rebuild it every now and then.

 

Erik.

 

Van: Adam Badura [mailto:ab...@o2...] 
Verzonden: zondag 23 januari 2011 22:19
Aan: Development list for Rails: an 18xx game
Onderwerp: Re: [Rails-devel] Corrections to Loading Game from Command Line

 

    I thought that maybe if user opens a game from a file and then save it under a different name then the original name is removed from MRU and the new one is added. This could be even enhanced that all the saved names are added in case user saves the game several times (this supports my way of saving: we play in one file and do a snapshot after each full round).

    Other solutions which I thought of were:

    Save some info with the game file, at beast at the start of the file and then use it to fine most “recent” file among series (it is all files from a single game would share a common id, GUID or something like that).

    Or base on smae naming patterns.

    But both seemed complex and fregile.

 

    How do you see that with time-stamps?

 

    Adam Badura

From: Erik Vos 

Sent: Sunday, January 23, 2011 8:51 PM

To: 'Development list for Rails: an 18xx game' 

Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

 

A “recent files” item would be very useful, at least for me for the purpose of testing. But IMO it should not use filenames, but the file system last-changed timestamps.  The filenames can be changed on saving, and that is what I usually do; example ‘18EU_OR1.rails’ for a saved 18EU game at the start of OR 1.

 

But the most important question perhaps is whether or not we can stand the slowdown caused by creating such a “recent files” list.

 

Erik.

 

Van: Chris Shaffer [mailto:chr...@gm...] 
Verzonden: zaterdag 22 januari 2011 19:28
Aan: Development list for Rails: an 18xx game
Onderwerp: Re: [Rails-devel] Corrections to Loading Game from Command Line

 

What do you mean by "recently opened games"?  In play by email, the program appends a player name and timestamp to the filename.  Would you be able to set it up to search the directories where games were previously saved, find the most recent timestamped file with the appropriate base filename, and list that?


--
Chris

Please consider the environment before printing this e-mail.

On Sat, Jan 22, 2011 at 7:40 AM, Adam Badura <ab...@o2...> wrote:

    The imports are result of mishandling Eclipse. I am not used to it yet (and on the search how to switch short-cuts to Windows-style...) Sorry for that.

    I personaly do cosmetic changes if they make code styl consistent but its your call.

 

    Now I was thinking of a redesign of initial window. So that the application lists recently opened games for example. What do you think of it?

 

    Adam Badura

 

From: Erik Vos 

Sent: Saturday, January 22, 2011 4:36 PM

To: 'Development list for Rails: an 18xx game' 

Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

 

Hi Adam,

 

Thanks for your fix. I haved applied it, except:

- the removed space in GameSetupWindow: cosmetic only.

- the qualifier in java.lang.String, which is completely redundant (I have left in your two other qualifiers, though, which at least save an import.  But we normally don’t use any qualifiers).

- the unused import of InvocationTargetException.

 

For now sending patches is the way to go.  Once you have gained a reputation of sending good patches, you will get commit access.

 

Erik.

 

Van: Adam Badura [mailto:ab...@o2...] 
Verzonden: zaterdag 22 januari 2011 2:07
Aan: rai...@li...
Onderwerp: [Rails-devel] Corrections to Loading Game from Command Line

 

    The attachement contains an SVN Patch (done on trunk/18xx) correcting two errors associated with loading game from command line argument passed to the application:

 

1) After such load File | Save command (and possibly others as well) crushed with NullPointerException due to log4j NDC not containing game key. This was caused by NDC being initialized in main thread during application startup rather then in AWT-EventsQueue thread as it happend during normal application opening and loading game through Load Game button.

 

2) A save path is associated with the game just as if the game was loaded using Load Game button.

 

 

    Do you accept those corrections? Should I commit them? What do I require to commit them? (On SourceForge my user name is "adambadura” just in case...)

 

    Adam Badura


--------------------------------------------------------------------------------

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 


--------------------------------------------------------------------------------

_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel


------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

 


--------------------------------------------------------------------------------

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 


--------------------------------------------------------------------------------

_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel



--------------------------------------------------------------------------------
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 


--------------------------------------------------------------------------------
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Corrections to Loading Game from Command Line

[Gmail <de...@gm...>]

For testing purposes I can see the addition of a recent files list being useful.

For general use, when playing a game I very, very rarely load the same saved game twice.  With the auto naming of saved games by game-date-user I wouldn't personally think many people would find this useful outside testing where we quite often reload the same game multiple timez.

I actually have my .rails files assigned to Java with parameters to launch rails directly so I very rarely even use the 'load game' function

Phil





On 23 Jan 2011, at 21:19, "Adam Badura" <ab...@o2...> wrote:

>     I thought that maybe if user opens a game from a file and then save it under a different name then the original name is removed from MRU and the new one is added. This could be even enhanced that all the saved names are added in case user saves the game several times (this supports my way of saving: we play in one file and do a snapshot after each full round).
>     Other solutions which I thought of were:
>     Save some info with the game file, at beast at the start of the file and then use it to fine most “recent” file among series (it is all files from a single game would share a common id, GUID or something like that).
>     Or base on smae naming patterns.
>     But both seemed complex and fregile.
>  
>     How do you see that with time-stamps?
>  
>     Adam Badura
> From: Erik Vos
> Sent: Sunday, January 23, 2011 8:51 PM
> To: 'Development list for Rails: an 18xx game'
> Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line
>  
> A “recent files” item would be very useful, at least for me for the purpose of testing. But IMO it should not use filenames, but the file system last-changed timestamps.  The filenames can be changed on saving, and that is what I usually do; example ‘18EU_OR1.rails’ for a saved 18EU game at the start of OR 1.
> 
>  
> 
> But the most important question perhaps is whether or not we can stand the slowdown caused by creating such a “recent files” list.
> 
>  
> 
> Erik.
> 
>  
> 
> Van: Chris Shaffer [mailto:chr...@gm...] 
> Verzonden: zaterdag 22 januari 2011 19:28
> Aan: Development list for Rails: an 18xx game
> Onderwerp: Re: [Rails-devel] Corrections to Loading Game from Command Line
> 
>  
> 
> What do you mean by "recently opened games"?  In play by email, the program appends a player name and timestamp to the filename.  Would you be able to set it up to search the directories where games were  previously saved, find the most recent timestamped file with the appropriate base filename, and list that?
> 
> 
> --
> Chris
> 
> Please consider the environment before printing this e-mail.
> 
> 
> On Sat, Jan 22, 2011 at 7:40 AM, Adam Badura <ab...@o2...> wrote:
> 
>     The imports are result of mishandling Eclipse. I am not used to it yet (and on the search how to switch short-cuts to Windows-style...) Sorry for that.
> 
>     I personaly do cosmetic changes if they make code styl consistent but its your call.
> 
>  
> 
>     Now I was thinking of a redesign of initial window. So that the application lists recently opened games for example. What do you think of it?
> 
>  
> 
>     Adam Badura
> 
>  
> 
> From: Erik Vos
> 
> Sent: Saturday, January 22, 2011 4:36 PM
> 
> To: 'Development list for Rails: an 18xx game'
> 
> Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line
> 
>  
> 
> Hi Adam,
> 
>  
> 
> Thanks for your fix. I haved applied it, except:
> 
> - the removed space in GameSetupWindow: cosmetic only.
> 
> - the qualifier in java.lang.String, which is completely redundant (I have left in your two other qualifiers, though, which at least save an import.  But we normally don’t use any qualifiers).
> 
> - the unused import of InvocationTargetException.
> 
>  
> 
> For now sending patches is the way to go.  Once you have gained a reputation of sending good patches, you will get commit access.
> 
>  
> 
> Erik.
> 
>  
> 
> Van: Adam Badura [mailto:ab...@o2...] 
> Verzonden: zaterdag 22 januari 2011 2:07
> Aan: rai...@li...
> Onderwerp: [Rails-devel] Corrections to Loading Game from Command Line
> 
>  
> 
>     The attachement contains an SVN Patch (done on trunk/18xx) correcting two errors associated with loading game from command line argument passed to the application:
> 
>  
> 
> 1) After such load File | Save command (and possibly others as well) crushed with NullPointerException due to log4j NDC not containing game key. This was caused by NDC being initialized in main thread during application startup rather then in AWT-EventsQueue thread as it happend during normal application opening and loading game through Load Game button.
> 
>  
> 
> 2) A save path is associated with the game just as if the game was loaded using Load Game button.
> 
>  
> 
>  
> 
>     Do you accept those corrections? Should I commit them? What do I require to commit them? (On SourceForge my user name is "adambadura” just in case...)
> 
>  
> 
>     Adam Badura
> 
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
> February 28th, so secure your free ArcSight Logger TODAY! 
> http://p.sf.net/sfu/arcsight-sfd2d
> 
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> 
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
>  
> 
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
> February 28th, so secure your free ArcSight Logger TODAY! 
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
> February 28th, so secure your free ArcSight Logger TODAY! 
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Corrections to Loading Game from Command Line

[<ab...@o2...>]

    Yes. Indeed. I forgot that its not only that you yourself save under different name but also you get differently named file also. So my simple solution will not help here. But I think it will not do any harm either. And we could add config option to not show such list for players which use the app in way which makes the list useless...

    Adam Badura

From: Gmail 
Sent: Monday, January 24, 2011 12:36 AM
To: Development list for Rails: an 18xx game 
Cc: Development list for Rails: an 18xx game 
Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

For testing purposes I can see the addition of a recent files list being useful.

For general use, when playing a game I very, very rarely load the same saved game twice.  With the auto naming of saved games by game-date-user I wouldn't personally think many people would find this useful outside testing where we quite often reload the same game multiple timez.

I actually have my .rails files assigned to Java with parameters to launch rails directly so I very rarely even use the 'load game' function

Phil






On 23 Jan 2011, at 21:19, "Adam Badura" <ab...@o2...> wrote:


      I thought that maybe if user opens a game from a file and then save it under a different name then the original name is removed from MRU and the new one is added. This could be even enhanced that all the saved names are added in case user saves the game several times (this supports my way of saving: we play in one file and do a snapshot after each full round).
      Other solutions which I thought of were:
      Save some info with the game file, at beast at the start of the file and then use it to fine most “recent” file among series (it is all files from a single game would share a common id, GUID or something like that).
      Or base on smae naming patterns.
      But both seemed complex and fregile.
      How do you see that with time-stamps?
      Adam Badura
  From: Erik Vos 
  Sent: Sunday, January 23, 2011 8:51 PM
  To: 'Development list for Rails: an 18xx game' 
  Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

  A “recent files” item would be very useful, at least for me for the purpose of testing. But IMO it should not use filenames, but the file system last-changed timestamps.  The filenames can be changed on saving, and that is what I usually do; example ‘18EU_OR1.rails’ for a saved 18EU game at the start of OR 1.

   

  But the most important question perhaps is whether or not we can stand the slowdown caused by creating such a “recent files” list.

   

  Erik.

   

  Van: Chris Shaffer [mailto:chr...@gm...] 
  Verzonden: zaterdag 22 januari 2011 19:28
  Aan: Development list for Rails: an 18xx game
  Onderwerp: Re: [Rails-devel] Corrections to Loading Game from Command Line

   

  What do you mean by "recently opened games"?  In play by email, the program appends a player name and timestamp to the filename.  Would you be able to set it up to search the directories where games were previously saved, find the most recent timestamped file with the appropriate base filename, and list that?


  --
  Chris

  Please consider the environment before printing this e-mail.



  On Sat, Jan 22, 2011 at 7:40 AM, Adam Badura <ab...@o2...> wrote:

      The imports are result of mishandling Eclipse. I am not used to it yet (and on the search how to switch short-cuts to Windows-style...) Sorry for that.

      I personaly do cosmetic changes if they make code styl consistent but its your call.

   

      Now I was thinking of a redesign of initial window. So that the application lists recently opened games for example. What do you think of it?

   

      Adam Badura

   

  From: Erik Vos 

  Sent: Saturday, January 22, 2011 4:36 PM

  To: 'Development list for Rails: an 18xx game' 

  Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

   

  Hi Adam,

   

  Thanks for your fix. I haved applied it, except:

  - the removed space in GameSetupWindow: cosmetic only.

  - the qualifier in java.lang.String, which is completely redundant (I have left in your two other qualifiers, though, which at least save an import.  But we normally don’t use any qualifiers).

  - the unused import of InvocationTargetException.

   

  For now sending patches is the way to go.  Once you have gained a reputation of sending good patches, you will get commit access.

   

  Erik.

   

  Van: Adam Badura [mailto:ab...@o2...] 
  Verzonden: zaterdag 22 januari 2011 2:07
  Aan: rai...@li...
  Onderwerp: [Rails-devel] Corrections to Loading Game from Command Line

   

      The attachement contains an SVN Patch (done on trunk/18xx) correcting two errors associated with loading game from command line argument passed to the application:

   

  1) After such load File | Save command (and possibly others as well) crushed with NullPointerException due to log4j NDC not containing game key. This was caused by NDC being initialized in main thread during application startup rather then in AWT-EventsQueue thread as it happend during normal application opening and loading game through Load Game button.

   

  2) A save path is associated with the game just as if the game was loaded using Load Game button.

   

   

      Do you accept those corrections? Should I commit them? What do I require to commit them? (On SourceForge my user name is "adambadura” just in case...)

   

      Adam Badura


------------------------------------------------------------------------------

  ------------------------------------------------------------------------------
  Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
  Finally, a world-class log management solution at an even better price-free!
  Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
  February 28th, so secure your free ArcSight Logger TODAY! 
  http://p.sf.net/sfu/arcsight-sfd2d 


------------------------------------------------------------------------------

  _______________________________________________
  Rails-devel mailing list
  Rai...@li...
  https://lists.sourceforge.net/lists/listinfo/rails-devel


  ------------------------------------------------------------------------------
  Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
  Finally, a world-class log management solution at an even better price-free!
  Download using promo code Free_Logger_4_Dev2Dev. Offer expires
  February 28th, so secure your free ArcSight Logger TODAY!
  http://p.sf.net/sfu/arcsight-sfd2d
  _______________________________________________
  Rails-devel mailing list
  Rai...@li...
  https://lists.sourceforge.net/lists/listinfo/rails-devel

   


------------------------------------------------------------------------------
  ------------------------------------------------------------------------------
  Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
  Finally, a world-class log management solution at an even better price-free!
  Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
  February 28th, so secure your free ArcSight Logger TODAY! 
  http://p.sf.net/sfu/arcsight-sfd2d 
------------------------------------------------------------------------------
  _______________________________________________
  Rails-devel mailing list
  Rai...@li...
  https://lists.sourceforge.net/lists/listinfo/rails-devel

  ------------------------------------------------------------------------------
  Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
  Finally, a world-class log management solution at an even better price-free!
  Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
  February 28th, so secure your free ArcSight Logger TODAY! 
  http://p.sf.net/sfu/arcsight-sfd2d
  _______________________________________________
  Rails-devel mailing list
  Rai...@li...
  https://lists.sourceforge.net/lists/listinfo/rails-devel



--------------------------------------------------------------------------------
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 


--------------------------------------------------------------------------------
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Corrections to Loading Game from Command Line

[Chris S. <chr...@gm...>]

Right, but if you can figure out how to make it list the most recent
timestamped file in a directory, that would be great!  So I'm excited about
your idea and hope you can make it work for the most common play-by-email
use case.

--
Chris

Please consider the environment before printing this e-mail.


On Sun, Jan 23, 2011 at 10:58 PM, <ab...@o2...> wrote:

>       Yes. Indeed. I forgot that its not only that you yourself save under
> different name but also you get differently named file also. So my simple
> solution will not help here. But I think it will not do any harm either. And
> we could add config option to not show such list for players which use the
> app in way which makes the list useless...
>
>     Adam Badura
>
>  *From:* Gmail <de...@gm...>
> *Sent:* Monday, January 24, 2011 12:36 AM
> *To:* Development list for Rails: an 18xx game<rai...@li...>
> *Cc:* Development list for Rails: an 18xx game<rai...@li...>
> *Subject:* Re: [Rails-devel] Corrections to Loading Game from Command Line
>
>  For testing purposes I can see the addition of a recent files list being
> useful.
>
> For general use, when playing a game I very, very rarely load the same
> saved game twice.  With the auto naming of saved games by game-date-user I
> wouldn't personally think many people would find this useful outside testing
> where we quite often reload the same game multiple timez.
>
> I actually have my .rails files assigned to Java with parameters to launch
> rails directly so I very rarely even use the 'load game' function
>
> Phil
>
>
>
>
>
> On 23 Jan 2011, at 21:19, "Adam Badura" <ab...@o2...> wrote:
>
>        I thought that maybe if user opens a game from a file and then save
> it under a different name then the original name is removed from MRU and the
> new one is added. This could be even enhanced that all the saved names are
> added in case user saves the game several times (this supports my way of
> saving: we play in one file and do a snapshot after each full round).
>      Other solutions which I thought of were:
>      Save some info with the game file, at beast at the start of the file
> and then use it to fine most “recent” file among series (it is all files
> from a single game would share a common id, GUID or something like that).
>      Or base on smae naming patterns.
>      But both seemed complex and fregile.
>
>      How do you see that with time-stamps?
>
>      Adam Badura
>   *From:* Erik Vos <eri...@xs...>
> *Sent:* Sunday, January 23, 2011 8:51 PM
> *To:* 'Development list for Rails: an 18xx game'<rai...@li...>
> *Subject:* Re: [Rails-devel] Corrections to Loading Game from Command Line
>
>
> A “recent files” item would be very useful, at least for me for the purpose
> of testing. But IMO it should not use filenames, but the file system
> last-changed timestamps.  The filenames can be changed on saving, and that
> is what I usually do; example ‘18EU_OR1.rails’ for a saved 18EU game at the
> start of OR 1.
>
>
>
> But the most important question perhaps is whether or not we can stand the
> slowdown caused by creating such a “recent files” list.
>
>
>
> Erik.
>
>
>
> *Van:* Chris Shaffer [mailto:chr...@gm...]
> *Verzonden:* zaterdag 22 januari 2011 19:28
> *Aan:* Development list for Rails: an 18xx game
> *Onderwerp:* Re: [Rails-devel] Corrections to Loading Game from Command
> Line
>
>
>
> What do you mean by "recently opened games"?  In play by email, the program
> appends a player name and timestamp to the filename.  Would you be able to
> set it up to search the directories where games were previously saved, find
> the most recent timestamped file with the appropriate base filename, and
> list that?
>
>
> --
> Chris
>
> Please consider the environment before printing this e-mail.
>
>  On Sat, Jan 22, 2011 at 7:40 AM, Adam Badura < <ab...@o2...>
> ab...@o2...> wrote:
>
>     The imports are result of mishandling Eclipse. I am not used to it yet
> (and on the search how to switch short-cuts to Windows-style...) Sorry for
> that.
>
>     I personaly do cosmetic changes if they make code styl consistent but
> its your call.
>
>
>
>     Now I was thinking of a redesign of initial window. So that the
> application lists recently opened games for example. What do you think of
> it?
>
>
>
>     Adam Badura
>
>
>
> *From:* Erik Vos <eri...@xs...>
>
> *Sent:* Saturday, January 22, 2011 4:36 PM
>
> *To:* 'Development list for Rails: an 18xx game'<rai...@li...>
>
> *Subject:* Re: [Rails-devel] Corrections to Loading Game from Command Line
>
>
>
> Hi Adam,
>
>
>
> Thanks for your fix. I haved applied it, except:
>
> - the removed space in GameSetupWindow: cosmetic only.
>
> - the qualifier in *java.lang.*String, which is completely redundant (I
> have left in your two other qualifiers, though, which at least save an
> import.  But we normally don’t use any qualifiers).
>
> - the unused import of InvocationTargetException.
>
>
>
> For now sending patches is the way to go.  Once you have gained a
> reputation of sending good patches, you will get commit access.
>
>
>
> Erik.
>
>
>
> *Van:* Adam Badura [mailto: <ab...@o2...>ab...@o2...]
> *Verzonden:* zaterdag 22 januari 2011 2:07
> *Aan:* <rai...@li...>
> rai...@li...
> *Onderwerp:* [Rails-devel] Corrections to Loading Game from Command Line
>
>
>
>     The attachement contains an SVN Patch (done on trunk/18xx) correcting
> two errors associated with loading game from command line argument passed to
> the application:
>
>
>
> 1) After such load File | Save command (and possibly others as well)
> crushed with NullPointerException due to log4j NDC not containing game key.
> This was caused by NDC being initialized in main thread during application
> startup rather then in AWT-EventsQueue thread as it happend during normal
> application opening and loading game through Load Game button.
>
>
>
> 2) A save path is associated with the game just as if the game was loaded
> using Load Game button.
>
>
>
>
>
>     Do you accept those corrections? Should I commit them? What do I
> require to commit them? (On SourceForge my user name is "adambadura” just in
> case...)
>
>
>
>     Adam Badura
>  ------------------------------
>
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> <http://p.sf.net/sfu/arcsight-sfd2d>http://p.sf.net/sfu/arcsight-sfd2d
>  ------------------------------
>
> _______________________________________________
> Rails-devel mailing list
> <Rai...@li...>Rai...@li...
> <https://lists.sourceforge.net/lists/listinfo/rails-devel>
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> <http://p.sf.net/sfu/arcsight-sfd2d>http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> Rails-devel mailing list
> <Rai...@li...>Rai...@li...
> <https://lists.sourceforge.net/lists/listinfo/rails-devel>
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ------------------------------
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> ------------------------------
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
>
>  _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>  ------------------------------
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
>
> ------------------------------
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>

Re: [Rails-devel] Corrections to Loading Game from Command Line

[<ab...@o2...>]

    OK. I will rethink this issue once more.

    Adam Badura

From: Chris Shaffer 
Sent: Monday, January 24, 2011 8:00 AM
To: Development list for Rails: an 18xx game 
Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

Right, but if you can figure out how to make it list the most recent timestamped file in a directory, that would be great!  So I'm excited about your idea and hope you can make it work for the most common play-by-email use case. 

--
Chris

Please consider the environment before printing this e-mail.



On Sun, Jan 23, 2011 at 10:58 PM, <ab...@o2...> wrote:

      Yes. Indeed. I forgot that its not only that you yourself save under different name but also you get differently named file also. So my simple solution will not help here. But I think it will not do any harm either. And we could add config option to not show such list for players which use the app in way which makes the list useless...

      Adam Badura

  From: Gmail 
  Sent: Monday, January 24, 2011 12:36 AM
  To: Development list for Rails: an 18xx game 
  Cc: Development list for Rails: an 18xx game 
  Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

  For testing purposes I can see the addition of a recent files list being useful.

  For general use, when playing a game I very, very rarely load the same saved game twice.  With the auto naming of saved games by game-date-user I wouldn't personally think many people would find this useful outside testing where we quite often reload the same game multiple timez.

  I actually have my .rails files assigned to Java with parameters to launch rails directly so I very rarely even use the 'load game' function

  Phil






  On 23 Jan 2011, at 21:19, "Adam Badura" <ab...@o2...> wrote:


        I thought that maybe if user opens a game from a file and then save it under a different name then the original name is removed from MRU and the new one is added. This could be even enhanced that all the saved names are added in case user saves the game several times (this supports my way of saving: we play in one file and do a snapshot after each full round).
        Other solutions which I thought of were:
        Save some info with the game file, at beast at the start of the file and then use it to fine most “recent” file among series (it is all files from a single game would share a common id, GUID or something like that).
        Or base on smae naming patterns.
        But both seemed complex and fregile.
        How do you see that with time-stamps?
        Adam Badura
    From: Erik Vos 
    Sent: Sunday, January 23, 2011 8:51 PM
    To: 'Development list for Rails: an 18xx game' 
    Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

    A “recent files” item would be very useful, at least for me for the purpose of testing. But IMO it should not use filenames, but the file system last-changed timestamps.  The filenames can be changed on saving, and that is what I usually do; example ‘18EU_OR1.rails’ for a saved 18EU game at the start of OR 1.



    But the most important question perhaps is whether or not we can stand the slowdown caused by creating such a “recent files” list.



    Erik.



    Van: Chris Shaffer [mailto:chr...@gm...] 
    Verzonden: zaterdag 22 januari 2011 19:28
    Aan: Development list for Rails: an 18xx game
    Onderwerp: Re: [Rails-devel] Corrections to Loading Game from Command Line



    What do you mean by "recently opened games"?  In play by email, the program appends a player name and timestamp to the filename.  Would you be able to set it up to search the directories where games were previously saved, find the most recent timestamped file with the appropriate base filename, and list that?


    --
    Chris

    Please consider the environment before printing this e-mail.



    On Sat, Jan 22, 2011 at 7:40 AM, Adam Badura <ab...@o2...> wrote:

        The imports are result of mishandling Eclipse. I am not used to it yet (and on the search how to switch short-cuts to Windows-style...) Sorry for that.

        I personaly do cosmetic changes if they make code styl consistent but its your call.



        Now I was thinking of a redesign of initial window. So that the application lists recently opened games for example. What do you think of it?



        Adam Badura



    From: Erik Vos 

    Sent: Saturday, January 22, 2011 4:36 PM

    To: 'Development list for Rails: an 18xx game' 

    Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line



    Hi Adam,



    Thanks for your fix. I haved applied it, except:

    - the removed space in GameSetupWindow: cosmetic only.

    - the qualifier in java.lang.String, which is completely redundant (I have left in your two other qualifiers, though, which at least save an import.  But we normally don’t use any qualifiers).

    - the unused import of InvocationTargetException.



    For now sending patches is the way to go.  Once you have gained a reputation of sending good patches, you will get commit access.



    Erik.



    Van: Adam Badura [mailto:ab...@o2...] 
    Verzonden: zaterdag 22 januari 2011 2:07
    Aan: rai...@li...
    Onderwerp: [Rails-devel] Corrections to Loading Game from Command Line



        The attachement contains an SVN Patch (done on trunk/18xx) correcting two errors associated with loading game from command line argument passed to the application:



    1) After such load File | Save command (and possibly others as well) crushed with NullPointerException due to log4j NDC not containing game key. This was caused by NDC being initialized in main thread during application startup rather then in AWT-EventsQueue thread as it happend during normal application opening and loading game through Load Game button.



    2) A save path is associated with the game just as if the game was loaded using Load Game button.





        Do you accept those corrections? Should I commit them? What do I require to commit them? (On SourceForge my user name is "adambadura” just in case...)



        Adam Badura


----------------------------------------------------------------------------

    ------------------------------------------------------------------------------
    Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
    Finally, a world-class log management solution at an even better price-free!
    Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
    February 28th, so secure your free ArcSight Logger TODAY! 
    http://p.sf.net/sfu/arcsight-sfd2d 


----------------------------------------------------------------------------

    _______________________________________________
    Rails-devel mailing list
    Rai...@li...
    https://lists.sourceforge.net/lists/listinfo/rails-devel


    ------------------------------------------------------------------------------
    Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
    Finally, a world-class log management solution at an even better price-free!
    Download using promo code Free_Logger_4_Dev2Dev. Offer expires
    February 28th, so secure your free ArcSight Logger TODAY!
    http://p.sf.net/sfu/arcsight-sfd2d
    _______________________________________________
    Rails-devel mailing list
    Rai...@li...
    https://lists.sourceforge.net/lists/listinfo/rails-devel




----------------------------------------------------------------------------
    ------------------------------------------------------------------------------
    Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
    Finally, a world-class log management solution at an even better price-free!
    Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
    February 28th, so secure your free ArcSight Logger TODAY! 
    http://p.sf.net/sfu/arcsight-sfd2d 
----------------------------------------------------------------------------
    _______________________________________________
    Rails-devel mailing list
    Rai...@li...
    https://lists.sourceforge.net/lists/listinfo/rails-devel

    ------------------------------------------------------------------------------
    Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
    Finally, a world-class log management solution at an even better price-free!
    Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
    February 28th, so secure your free ArcSight Logger TODAY! 
    http://p.sf.net/sfu/arcsight-sfd2d
    _______________________________________________
    Rails-devel mailing list
    Rai...@li...
    https://lists.sourceforge.net/lists/listinfo/rails-devel


------------------------------------------------------------------------------
  ------------------------------------------------------------------------------
  Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
  Finally, a world-class log management solution at an even better price-free!
  Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
  February 28th, so secure your free ArcSight Logger TODAY! 
  http://p.sf.net/sfu/arcsight-sfd2d 
------------------------------------------------------------------------------
  _______________________________________________
  Rails-devel mailing list
  Rai...@li...
  https://lists.sourceforge.net/lists/listinfo/rails-devel


  ------------------------------------------------------------------------------
  Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
  Finally, a world-class log management solution at an even better price-free!
  Download using promo code Free_Logger_4_Dev2Dev. Offer expires
  February 28th, so secure your free ArcSight Logger TODAY!
  http://p.sf.net/sfu/arcsight-sfd2d
  _______________________________________________
  Rails-devel mailing list
  Rai...@li...
  https://lists.sourceforge.net/lists/listinfo/rails-devel





--------------------------------------------------------------------------------
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 


--------------------------------------------------------------------------------
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Corrections to Loading Game from Command Line

[Adam B. <ab...@o2...>]

    I’m pausing my works on Most Recently Used Games for undefined time.
    Version 1.4.1 solves (I suspect due to the correction I posted before) issues with opening game from command line which is what I needed. And making this feature is difficult in cases of naming suggested by Rails especially in all the reasonable use cases.
    Maybe I will find something else to correct/improve.

    Adam Badura

From: ab...@o2... 
Sent: Monday, January 24, 2011 8:02 AM
To: Development list for Rails: an 18xx game 
Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

    OK. I will rethink this issue once more.

    Adam Badura

From: Chris Shaffer 
Sent: Monday, January 24, 2011 8:00 AM
To: Development list for Rails: an 18xx game 
Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

Right, but if you can figure out how to make it list the most recent timestamped file in a directory, that would be great!  So I'm excited about your idea and hope you can make it work for the most common play-by-email use case. 

--
Chris

Please consider the environment before printing this e-mail.



On Sun, Jan 23, 2011 at 10:58 PM, <ab...@o2...> wrote:

      Yes. Indeed. I forgot that its not only that you yourself save under different name but also you get differently named file also. So my simple solution will not help here. But I think it will not do any harm either. And we could add config option to not show such list for players which use the app in way which makes the list useless...

      Adam Badura

  From: Gmail 
  Sent: Monday, January 24, 2011 12:36 AM
  To: Development list for Rails: an 18xx game 
  Cc: Development list for Rails: an 18xx game 
  Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

  For testing purposes I can see the addition of a recent files list being useful.

  For general use, when playing a game I very, very rarely load the same saved game twice.  With the auto naming of saved games by game-date-user I wouldn't personally think many people would find this useful outside testing where we quite often reload the same game multiple timez.

  I actually have my .rails files assigned to Java with parameters to launch rails directly so I very rarely even use the 'load game' function

  Phil






  On 23 Jan 2011, at 21:19, "Adam Badura" <ab...@o2...> wrote:


        I thought that maybe if user opens a game from a file and then save it under a different name then the original name is removed from MRU and the new one is added. This could be even enhanced that all the saved names are added in case user saves the game several times (this supports my way of saving: we play in one file and do a snapshot after each full round).
        Other solutions which I thought of were:
        Save some info with the game file, at beast at the start of the file and then use it to fine most “recent” file among series (it is all files from a single game would share a common id, GUID or something like that).
        Or base on smae naming patterns.
        But both seemed complex and fregile.
        How do you see that with time-stamps?
        Adam Badura
    From: Erik Vos 
    Sent: Sunday, January 23, 2011 8:51 PM
    To: 'Development list for Rails: an 18xx game' 
    Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line

    A “recent files” item would be very useful, at least for me for the purpose of testing. But IMO it should not use filenames, but the file system last-changed timestamps.  The filenames can be changed on saving, and that is what I usually do; example ‘18EU_OR1.rails’ for a saved 18EU game at the start of OR 1.



    But the most important question perhaps is whether or not we can stand the slowdown caused by creating such a “recent files” list.



    Erik.



    Van: Chris Shaffer [mailto:chr...@gm...] 
    Verzonden: zaterdag 22 januari 2011 19:28
    Aan: Development list for Rails: an 18xx game
    Onderwerp: Re: [Rails-devel] Corrections to Loading Game from Command Line



    What do you mean by "recently opened games"?  In play by email, the program appends a player name and timestamp to the filename.  Would you be able to set it up to search the directories where games were previously saved, find the most recent timestamped file with the appropriate base filename, and list that?


    --
    Chris

    Please consider the environment before printing this e-mail.



    On Sat, Jan 22, 2011 at 7:40 AM, Adam Badura <ab...@o2...> wrote:

        The imports are result of mishandling Eclipse. I am not used to it yet (and on the search how to switch short-cuts to Windows-style...) Sorry for that.

        I personaly do cosmetic changes if they make code styl consistent but its your call.



        Now I was thinking of a redesign of initial window. So that the application lists recently opened games for example. What do you think of it?



        Adam Badura



    From: Erik Vos 

    Sent: Saturday, January 22, 2011 4:36 PM

    To: 'Development list for Rails: an 18xx game' 

    Subject: Re: [Rails-devel] Corrections to Loading Game from Command Line



    Hi Adam,



    Thanks for your fix. I haved applied it, except:

    - the removed space in GameSetupWindow: cosmetic only.

    - the qualifier in java.lang.String, which is completely redundant (I have left in your two other qualifiers, though, which at least save an import.  But we normally don’t use any qualifiers).

    - the unused import of InvocationTargetException.



    For now sending patches is the way to go.  Once you have gained a reputation of sending good patches, you will get commit access.



    Erik.



    Van: Adam Badura [mailto:ab...@o2...] 
    Verzonden: zaterdag 22 januari 2011 2:07
    Aan: rai...@li...
    Onderwerp: [Rails-devel] Corrections to Loading Game from Command Line



        The attachement contains an SVN Patch (done on trunk/18xx) correcting two errors associated with loading game from command line argument passed to the application:



    1) After such load File | Save command (and possibly others as well) crushed with NullPointerException due to log4j NDC not containing game key. This was caused by NDC being initialized in main thread during application startup rather then in AWT-EventsQueue thread as it happend during normal application opening and loading game through Load Game button.



    2) A save path is associated with the game just as if the game was loaded using Load Game button.





        Do you accept those corrections? Should I commit them? What do I require to commit them? (On SourceForge my user name is "adambadura” just in case...)



        Adam Badura


----------------------------------------------------------------------------

    ------------------------------------------------------------------------------
    Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
    Finally, a world-class log management solution at an even better price-free!
    Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
    February 28th, so secure your free ArcSight Logger TODAY! 
    http://p.sf.net/sfu/arcsight-sfd2d 


----------------------------------------------------------------------------

    _______________________________________________
    Rails-devel mailing list
    Rai...@li...
    https://lists.sourceforge.net/lists/listinfo/rails-devel


    ------------------------------------------------------------------------------
    Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
    Finally, a world-class log management solution at an even better price-free!
    Download using promo code Free_Logger_4_Dev2Dev. Offer expires
    February 28th, so secure your free ArcSight Logger TODAY!
    http://p.sf.net/sfu/arcsight-sfd2d
    _______________________________________________
    Rails-devel mailing list
    Rai...@li...
    https://lists.sourceforge.net/lists/listinfo/rails-devel




----------------------------------------------------------------------------
    ------------------------------------------------------------------------------
    Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
    Finally, a world-class log management solution at an even better price-free!
    Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
    February 28th, so secure your free ArcSight Logger TODAY! 
    http://p.sf.net/sfu/arcsight-sfd2d 
----------------------------------------------------------------------------
    _______________________________________________
    Rails-devel mailing list
    Rai...@li...
    https://lists.sourceforge.net/lists/listinfo/rails-devel

    ------------------------------------------------------------------------------
    Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
    Finally, a world-class log management solution at an even better price-free!
    Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
    February 28th, so secure your free ArcSight Logger TODAY! 
    http://p.sf.net/sfu/arcsight-sfd2d
    _______________________________________________
    Rails-devel mailing list
    Rai...@li...
    https://lists.sourceforge.net/lists/listinfo/rails-devel


------------------------------------------------------------------------------
  ------------------------------------------------------------------------------
  Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
  Finally, a world-class log management solution at an even better price-free!
  Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
  February 28th, so secure your free ArcSight Logger TODAY! 
  http://p.sf.net/sfu/arcsight-sfd2d 
------------------------------------------------------------------------------
  _______________________________________________
  Rails-devel mailing list
  Rai...@li...
  https://lists.sourceforge.net/lists/listinfo/rails-devel


  ------------------------------------------------------------------------------
  Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
  Finally, a world-class log management solution at an even better price-free!
  Download using promo code Free_Logger_4_Dev2Dev. Offer expires
  February 28th, so secure your free ArcSight Logger TODAY!
  http://p.sf.net/sfu/arcsight-sfd2d
  _______________________________________________
  Rails-devel mailing list
  Rai...@li...
  https://lists.sourceforge.net/lists/listinfo/rails-devel





--------------------------------------------------------------------------------
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 


--------------------------------------------------------------------------------
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel



--------------------------------------------------------------------------------
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d 


--------------------------------------------------------------------------------
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Corrections to Loading Game from Command Line

[John A. T. <ja...@ja...>]

On Sat, Jan 22, 2011 at 10:40 AM, Adam Badura <ab...@o2...> wrote:

>       The imports are result of mishandling Eclipse. I am not used to it
> yet (and on the search how to switch short-cuts to Windows-style...) Sorry
> for that.
>

Ctrl-Shift-O is your friend in Eclipse.


>      I personaly do cosmetic changes if they make code styl consistent but
> its your call.
>

It is nice to separate out formatting/comment-only changes from substantive
changes - otherwise, they clutter up code that needs to be more carefully
reviewed.

-- 
John A. Tamplin