rails-devel

Re: [Rails-devel] Patch against previous 1880 patch

[Erik V. <eri...@xs...>]

Martin,

 

Thanks for sorting it out, you are absolutely right.

 

I may also have screwed up on the ‘pic’ attribute: it should be in TileSet.xml, not in Map.xml – but in TileSet.xml it would affect all -902/-903 tiles.

In Map.xml it doesn’t work (yet), so the 1800 harbours will still show up red.

 

I don’t see a simple solution right now, even though it would be highly desirable if there were one. 

I’ll sleep a good night over how we can get this right, but we may have to revert to your initial approach.  

 

Erik.

 

From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Tuesday, March 13, 2012 8:37 PM
To: Rails Development; Erik Vos; Stefan Frey
Subject: Patch against previous 1880 patch

 

 

Hi Stefan, Erik et al.

 

i fixed the Map, Tiles etc. for 1880.

 

Erik: the actual definition has to be: <Access type="town" score="minor"/>.

 

Kind Regards,

Martin

 

Re: [Rails-devel] Patch against previous 1880 patch

[Erik V. <eri...@xs...>]

	I may also have screwed up on the ‘pic’ attribute: it should be in TileSet.xml, not in Map.xml – but in TileSet.xml it would affect all -902/-903 tiles.
	In Map.xml it doesn’t work (yet), so the 1880 harbours will still show up red.

	I don’t see a simple solution right now, even though it would be highly desirable if there were one. 
	I’ll sleep a good night over how we can get this right, but we may have to revert to your initial approach.  

After all, it wasn't that difficult. 'pic' is now allowed in Map.xml, and used in 1880.
I have also cleaned up its (ineffective) usage in 1830/Map.xml, where TileSet.xml already had it.

It turned out that Martin's new 1880-specific classes had not been included in my previous commit.  That has been fixed now as well.

Erik.