From: brett l. <wak...@gm...> - 2007-07-17 20:36:34
|
I've committed the first batch of cleanups for the SVG tiles. The last time I touched these files, it looks like there was some slight variation in the hex size and positioning within the image canvas. This was causing some unpredictable positioning when these images were laid out on the map as well as some strange skewing when applying an affine transform. So, I'm going back and adjusting all of the tiles to better fit within the canvas dimensions. I'm fairly happy with the results. The 1830 map looks significantly more uniform. The other thing I'm working on, but haven't committed yet is a solution for the horrible dithering on the map. In large part, this is due to AffineTransform's scale() method. We use HexIcons for the tile lay preview, which does an excellent smooth rescaling. I'd love to use HexIcons for the map, but there's no way to rotate a HexIcon. So, I'm exploring a few different ways of removing the need to use AffineTransform's scale() method. ---Brett. |
From: Erik V. <eri...@hc...> - 2007-07-17 21:37:28
|
> I've committed the first batch of cleanups for the SVG tiles. > > The last time I touched these files, it looks like there was some > slight variation in the hex size and positioning within the image > canvas. This was causing some unpredictable positioning when these > images were laid out on the map as well as some strange skewing when > applying an affine transform. > > So, I'm going back and adjusting all of the tiles to better fit within > the canvas dimensions. > > I'm fairly happy with the results. The 1830 map looks significantly > more uniform. Yes, it looks a lot better now, though still slightly less good than the .gif tiles that I had reverted to in the meantime. I hope your further efforts will clean it all up! Erik. |
From: brett l. <wak...@gm...> - 2007-07-21 18:05:08
|
On 7/17/07, Erik Vos <eri...@hc...> wrote: > > I've committed the first batch of cleanups for the SVG tiles. > > > > The last time I touched these files, it looks like there was some > > slight variation in the hex size and positioning within the image > > canvas. This was causing some unpredictable positioning when these > > images were laid out on the map as well as some strange skewing when > > applying an affine transform. > > > > So, I'm going back and adjusting all of the tiles to better fit within > > the canvas dimensions. > > > > I'm fairly happy with the results. The 1830 map looks significantly > > more uniform. > > Yes, it looks a lot better now, though still slightly less good than > the .gif tiles that I had reverted to in the meantime. > > I hope your further efforts will clean it all up! > I've completed the tile adjustments and committed them. Also, I've committed some adjustments to the tile scaling constants. Now, when we load a tile, it's a significantly smaller image that doesn't need much rescaling. This simplifies the drawing calculations so that we don't lose as much information when we rescale the image during a paint(). This improves the look of the SVG tiles immensely. I'm really happy with the results. With this tile work and the undo/redo work complete, if there are no objections, I'll do another release in the next day or so. ---Brett. |
From: Erik V. <eri...@hc...> - 2007-07-22 11:51:33
|
> I've completed the tile adjustments and committed them. Also, I've > committed some adjustments to the tile scaling constants. >=20 > Now, when we load a tile, it's a significantly smaller image that > doesn't need much rescaling. This simplifies the drawing calculations > so that we don't lose as much information when we rescale the image > during a paint(). >=20 > This improves the look of the SVG tiles immensely. I'm really happy > with the results. Well, the tiles are a lot smaller, but the map isn't, so the result does not look good on my PC. I'll send you a screenshot per personal = mail. Do I need some property setting? =20 > With this tile work and the undo/redo work complete, if there are no > objections, I'll do another release in the next day or so. No objections. Just two remarks: - I'm well on my way with Save/Load. Save is done, but, of course,=20 Load is the difficult part. I can't guarantee completion in the 2=BD weeks before I'm going on vacation (Aug. 10th), but the prospect isn't bad, so it might be worth the wait. - Not sure, but I may have fixed one or two remaining bugs while working = on Save/Load. If you want, I could upload the current code (with = Save/Load still disabled). It should all work, but that would need extra testing. Erik. |
From: brett l. <wak...@gm...> - 2007-07-22 17:58:23
|
On 7/22/07, Erik Vos <eri...@hc...> wrote: > > I've completed the tile adjustments and committed them. Also, I've > > committed some adjustments to the tile scaling constants. > > > > Now, when we load a tile, it's a significantly smaller image that > > doesn't need much rescaling. This simplifies the drawing calculations > > so that we don't lose as much information when we rescale the image > > during a paint(). > > > > This improves the look of the SVG tiles immensely. I'm really happy > > with the results. > > Well, the tiles are a lot smaller, but the map isn't, so the result > does not look good on my PC. I'll send you a screenshot per personal mail= . > Do I need some property setting? > None that I know of. I'm using the my.properties that's in CVS. I assume you've merged all changes into your local code? > > With this tile work and the undo/redo work complete, if there are no > > objections, I'll do another release in the next day or so. > > No objections. Just two remarks: > > - I'm well on my way with Save/Load. Save is done, but, of course, > Load is the difficult part. I can't guarantee completion in the > 2=BD weeks before I'm going on vacation (Aug. 10th), but the prospect > isn't bad, so it might be worth the wait. > We can do that in a separate release. > - Not sure, but I may have fixed one or two remaining bugs while working > on Save/Load. If you want, I could upload the current code (with Save/Loa= d > still disabled). It should all work, but that would need extra testing. > Let's wait until the rest of Save/Load is finished. ----Brett. |
From: Erik V. <eri...@hc...> - 2007-07-22 21:52:10
|
> I assume you've merged all changes into your local code? Just found I had overlooked the GUIHex classes. Sorry for the confusion, it looks very good now. > > - I'm well on my way with Save/Load. Save is done, but, of course, > > Load is the difficult part. I can't guarantee completion in the > > 2=BD weeks before I'm going on vacation (Aug. 10th), but the = prospect > > isn't bad, so it might be worth the wait. >=20 > We can do that in a separate release. OK. Erik. |