Menu
▾
▴
rails-devel
|
From: Brett L. <wak...@ea...> - 2006-01-10 00:00:04
|
Well, the nice thing about using the ORWindow as the main container is that the changes are really minimal. Basically, there's little more than changing MapWindow to be a JPanel instead of a JFrame, changing the calls from using contentPane to using the JPanel's add() methods, and adding the mapWindow to ORWindow's constructor. The tricky part is, as you mentioned, this changes how the map is made visible, and there's some resizing issues. I think I'm going to explore these issues a little further before I commit anything. ---Brett. -----Original Message----- >From: Erik Vos <eri...@hc...> >Sent: Jan 9, 2006 6:14 PM >To: rai...@li... >Subject: RE: [Rails-devel] Combining ORWindow and MapWindow > >I suppose the OR Window will now become a JPanel, >that is alternatingly visible and invisible? > >There are two reasons why I have some doubts on this move: >1. The window (panel) sizes will often not match very well, >2. The OR window currently only exists during an OR, >whereas the map always exists (though not always visible), >so that we should be careful about re-initialisation. > >On the other hand: I was considering to move, or duplicate, >the current buttons in the upgrade panel to the OR window. >Such integration might become easier. > >None of my doubts are really prohibitive, so I don't mind trying this, >but I would prefer to keep the way back open for a while. > >Erik. > > >> -----Original Message----- >> From: rai...@li... >> [mailto:rai...@li...] On Behalf Of >> Brett Lentz >> Sent: 09 January 2006 23:59 >> To: rails-devel >> Subject: [Rails-devel] Combining ORWindow and MapWindow >> >> I've been looking at how to combine these two windows over >> the weekend. >> >> The easiest method is to add MapWindow to ORWindow rather >> than the other way around. >> >> Currently, I've got a working unified window. There's some >> resizing issues I'm working out, but overall it works fairly well. >> >> However, before I commit the changes... are there any >> reasons why I should not commit this, just yet? >> >> >> >> ---Brett. >> >> >> ------------------------------------------------------- >> This SF.net email is sponsored by: Splunk Inc. Do you grep >> through log files >> for problems? Stop! Download the new AJAX search engine that makes >> searching your log files as easy as surfing the web. >> DOWNLOAD SPLUNK! >> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click >> _______________________________________________ >> Rails-devel mailing list >> Rai...@li... >> https://lists.sourceforge.net/lists/listinfo/rails-devel >> >> > > > > >------------------------------------------------------- >This SF.net email is sponsored by: Splunk Inc. Do you grep through log files >for problems? Stop! Download the new AJAX search engine that makes >searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! >http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click >_______________________________________________ >Rails-devel mailing list >Rai...@li... >https://lists.sourceforge.net/lists/listinfo/rails-devel |
|
From: Brett L. <wak...@ea...> - 2006-01-10 20:16:44
|
Ok... I've gotten the merged ORWindow working and comitted. It can still use some tweaking to get the sizing correct. Here's an overview of the changes: ORWindow is now just the container class ORPanel is all of the status panel code. MapPanel is MapWindow retooled as a JPanel. UpgradesPanel has been moved out of MapPanel and into ORWindow as one of three main JPanels contained within ORWindow. One lingering issue: Is there a way to find whether there has been an Operating Round or not? ---Brett. -----Original Message----- >From: Brett Lentz <wak...@ea...> >Sent: Jan 9, 2006 6:59 PM >To: rai...@li... >Subject: RE: [Rails-devel] Combining ORWindow and MapWindow > >Well, the nice thing about using the ORWindow as the main container is that the changes are really minimal. Basically, there's little more than changing MapWindow to be a JPanel instead of a JFrame, changing the calls from using contentPane to using the JPanel's add() methods, and adding the mapWindow to ORWindow's constructor. > >The tricky part is, as you mentioned, this changes how the map is made visible, and there's some resizing issues. > >I think I'm going to explore these issues a little further before I commit anything. > > >---Brett. > >-----Original Message----- >>From: Erik Vos <eri...@hc...> >>Sent: Jan 9, 2006 6:14 PM >>To: rai...@li... >>Subject: RE: [Rails-devel] Combining ORWindow and MapWindow >> >>I suppose the OR Window will now become a JPanel, >>that is alternatingly visible and invisible? >> >>There are two reasons why I have some doubts on this move: >>1. The window (panel) sizes will often not match very well, >>2. The OR window currently only exists during an OR, >>whereas the map always exists (though not always visible), >>so that we should be careful about re-initialisation. >> >>On the other hand: I was considering to move, or duplicate, >>the current buttons in the upgrade panel to the OR window. >>Such integration might become easier. >> >>None of my doubts are really prohibitive, so I don't mind trying this, >>but I would prefer to keep the way back open for a while. >> >>Erik. >> >> >>> -----Original Message----- >>> From: rai...@li... >>> [mailto:rai...@li...] On Behalf Of >>> Brett Lentz >>> Sent: 09 January 2006 23:59 >>> To: rails-devel >>> Subject: [Rails-devel] Combining ORWindow and MapWindow >>> >>> I've been looking at how to combine these two windows over >>> the weekend. >>> >>> The easiest method is to add MapWindow to ORWindow rather >>> than the other way around. >>> >>> Currently, I've got a working unified window. There's some >>> resizing issues I'm working out, but overall it works fairly well. >>> >>> However, before I commit the changes... are there any >>> reasons why I should not commit this, just yet? >>> >>> >>> >>> ---Brett. >>> >>> >>> ------------------------------------------------------- >>> This SF.net email is sponsored by: Splunk Inc. Do you grep >>> through log files >>> for problems? Stop! Download the new AJAX search engine that makes >>> searching your log files as easy as surfing the web. >>> DOWNLOAD SPLUNK! >>> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click >>> _______________________________________________ >>> Rails-devel mailing list >>> Rai...@li... >>> https://lists.sourceforge.net/lists/listinfo/rails-devel >>> >>> >> >> >> >> >>------------------------------------------------------- >>This SF.net email is sponsored by: Splunk Inc. Do you grep through log files >>for problems? Stop! Download the new AJAX search engine that makes >>searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! >>http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click >>_______________________________________________ >>Rails-devel mailing list >>Rai...@li... >>https://lists.sourceforge.net/lists/listinfo/rails-devel > > > >------------------------------------------------------- >This SF.net email is sponsored by: Splunk Inc. Do you grep through log files >for problems? Stop! Download the new AJAX search engine that makes >searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! >http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click >_______________________________________________ >Rails-devel mailing list >Rai...@li... >https://lists.sourceforge.net/lists/listinfo/rails-devel |
|
From: Erik V. <eri...@hc...> - 2006-01-10 21:54:49
|
> Ok... I've gotten the merged ORWindow working and comitted. > It can still use some tweaking to get the sizing correct. I was a bit skeptical, but it looks pretty good. One small annoyance: if I make the map visible at the start of the game, and then click it away, it does not become automatically visible again at the start of the first OR. I must click it on again in StatusWindow. > One lingering issue: Is there a way to find whether there > has been an Operating Round or not? There wasn't, but now there is: OperatingRound.getLastORNumber() returns the last (cumulative) OR number - zero if there wasn't any. Erik. |
|
From: Brett L. <wak...@ea...> - 2006-01-10 21:05:50
|
>Please also take into account, that the number of operating >companies can be substantial. >18EU starts with 15 minor companies and 1837 with 21 (plus some >early major companies after a few SRs), >all laying tiles and running trains etc. >I can imagine that these all will not fit in one window with a map. > >Ideal would be a facility to dock frames in a window, >or drag them out to create a separate window. >But that is for some distant future, I guess.... > Yeah, I'm not certain how friendly Java is to things like docking. I'll play around with a JScrollPane and see how it looks when there's a large amount of companies running. ---Brett. |
|
From: Brett L. <wak...@ea...> - 2006-01-10 22:39:08
|
>> Ok... I've gotten the merged ORWindow working and comitted. >> It can still use some tweaking to get the sizing correct. > >I was a bit skeptical, but it looks pretty good. > Thanks. I didn't want to change how any of our components looked. I like the way the status info is presented. I just wanted everything to be contained within a single window. >One small annoyance: if I make the map visible at the start of the game, >and then click it away, it does not become automatically visible again >at the start of the first OR. I must click it on again in StatusWindow. > Yeah, I've noticed this too. I'm working on tracking down the cause. >> One lingering issue: Is there a way to find whether there >> has been an Operating Round or not? > >There wasn't, but now there is: OperatingRound.getLastORNumber() >returns the last (cumulative) OR number - zero if there wasn't any. > Perfect. This fixes a bug you hadn't seen yet. ;-) ---Brett. |
|
From: Brett L. <wak...@ea...> - 2006-01-10 22:50:41
|
>>One small annoyance: if I make the map visible at the start of the game, >>and then click it away, it does not become automatically visible again >>at the start of the first OR. I must click it on again in StatusWindow. >> > >Yeah, I've noticed this too. I'm working on tracking down the cause. I've found this bug and fixed it. ---Brett. |
|
From: Brett L. <wak...@ea...> - 2006-01-11 02:05:35
|
>Please also take into account, that the number of operating >companies can be substantial. >18EU starts with 15 minor companies and 1837 with 21 (plus some >early major companies after a few SRs), >all laying tiles and running trains etc. >I can imagine that these all will not fit in one window with a map. I think perhaps we should simply offer a button in the window (Menu and MenuItems is probably best) to allow toggling of the StatusPanel (the Button Panel should always be visible). ---Brett. |
|
From: Erik V. <eri...@hc...> - 2006-01-10 20:49:25
|
> Well, the nice thing about using the ORWindow as the main > container is that the changes are really minimal. Basically, > there's little more than changing MapWindow to be a JPanel > instead of a JFrame, changing the calls from using > contentPane to using the JPanel's add() methods, and adding > the mapWindow to ORWindow's constructor. > > The tricky part is, as you mentioned, this changes how the > map is made visible, and there's some resizing issues. > > I think I'm going to explore these issues a little further > before I commit anything. Please also take into account, that the number of operating companies can be substantial. 18EU starts with 15 minor companies and 1837 with 21 (plus some early major companies after a few SRs), all laying tiles and running trains etc. I can imagine that these all will not fit in one window with a map. Ideal would be a facility to dock frames in a window, or drag them out to create a separate window. But that is for some distant future, I guess.... Erik. |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X